Public report of home-assistant/android, published 26 October 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 26 October 2026, 21:03 UTC · Survey ID cd_4c7bc4145b1c45f9bc152ac2ab19164a
home-assistant/android
Measured 26 October 2026, 21:00 UTC, at code version 8e094f1
Regression: 1 dimension fell since the last survey
A regression is a drop of 0.5 points or more in the score, or of 2.5 or more out of 10 in a dimension, since the last survey.
CAI scoreAt riskNo change since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A large codebase: 107,395 lines of product code in 10 projects, tests not counted · Estimated rebuild effort: about 1.3 person-years · Weakest lens: Security and Compliance, 51
Findings by how serious they are
44 critical351 serious70 minor
17 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
26 October 2026, 21:00 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that
implements it, and today Watchdog is the only one that does.
A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.
The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
66of 66 dimensions measured by tools.
449of 465 findings point to an exact file and line, so you can open each one in the code. The other 16 concern the repository as a whole, such as missing documentation.
66dimensions across 7 lenses, read from 107,395 lines of product code in 10 projects.
home-assistant/android is rated At risk because critical security findings are open, most of them in the build pipeline. Its score is held back in part because it has pipeline tools referenced by a changeable name. It scores 55 out of 100, which the At risk rating leaves unchanged.
Security and Compliance, at 51, is the weakest lens, level with Domain Modelling, and counts most in the score. The best first step for the work it takes is improving the documentation, worth about 1 point. Fixing the 39 pipeline tools referenced by a changeable name would lift Security and Compliance itself, worth about 2 points. Raising Security and Compliance to 70 would lift the score to about 58.
Thirty-nine pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. One known security hole in a package the code depends on can be used by attackers, and two sets of files in separate parts keep changing together, which points to hidden dependencies. Pinning each tool to an exact version, updating the vulnerable packages and making the hidden dependencies explicit would close these risks. Fixing the weaknesses the scanner points to would fix the security weakness in the code, and correcting the flagged pipeline settings would deal with the weakness in the build pipeline's configuration.
The product code is 107,395 lines, about €190,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
€62,000 to €310,000, for 1,035 to 3,282 hours of work, about 1.3 person-years for 1 to 3 engineers
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.8 at a score of 55. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Large: 107,395 lines of product code
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md.
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €190,000 to build again, about 1.3 person-years of work. Its weakest lens is Security and Compliance, at 51 (Adequate). Security and Compliance is about how well the product is protected, and how it handles personal data. Because the weakest lens counts most in the score, work on Security and Compliance also moves the score most.
Based on: the rebuild estimate · the Security and Compliance grade · how much each lens counts
What to do: Start with the Security and Compliance actions in Top priorities.
One cause behind 25 Domain Modelling findings · Common cause
25 findings in the Domain Modelling lens come from the same cause. The code models the business as objects, such as an order or a customer, and each object should guard its own rules: an order, for example, should refuse to be shipped before it has been paid. Here the objects don't do that. Some objects only hold data, while the rules that should keep that data valid sit elsewhere in the code. Identifiers, such as order numbers and customer numbers, are passed around as plain numbers or text, so nothing stops the code from using one kind where another belongs. Because all of these findings have the same cause, fixing it once, in the business objects themselves, deals with them together.
Based on: Rich vs anemic model (14 findings) · Strongly-typed ids (11 findings)
What to do: Give each business object the methods that enforce its rules, such as a method for shipping an order that first checks it has been paid, and let only those methods change its data. Give each kind of identifier a type of its own, so an order number can't be used where a customer number belongs.
If you do one thing first · First action
Resolve the 1 Documentation finding(s) in Documentation Quality. Of all the actions in this report, it raises the score most for the work it takes: about 1 point for low effort, because it clears the 1 Documentation Quality findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
582 modules, with 905 dependencies between them. 12 loops run through 60 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 542 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
common.data.network uses common.data.servers, so a change to common.data.servers can break common.data.network, while a change to common.data.network can't break common.data.servers.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
10→16 common.data.websocket.impl.entities uses common.data.integrationpart of a loop✕
Connections
4 pairs of types, where a type in common.data.websocket.impl.entities uses a type in common.data.integration.
common.data.websocket.impl.entities uses common.data.integration, so a change to common.data.integration can break common.data.websocket.impl.entities, while a change to common.data.websocket.impl.entities can't break common.data.integration.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
10→24 common.data.websocket.impl.entities uses common.utilpart of a loop✕
Connections
1 pair of types, where a type in common.data.websocket.impl.entities uses a type in common.util.
common.data.websocket.impl.entities uses common.util, so a change to common.util can break common.data.websocket.impl.entities, while a change to common.data.websocket.impl.entities can't break common.util.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
frontend.externalbus uses frontend, so a change to frontend can break frontend.externalbus, while a change to frontend.externalbus can't break frontend.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
common.data.authentication uses common.data, so a change to common.data can break common.data.authentication, while a change to common.data.authentication can't break common.data.
Position
Below the diagonal: common.data.authentication uses a module listed above it, which is the healthy direction.
common.data.authentication uses common.util.di, so a change to common.util.di can break common.data.authentication, while a change to common.data.authentication can't break common.util.di.
Position
Below the diagonal: common.data.authentication uses a module listed above it, which is the healthy direction.
common.data.authentication uses database.server, so a change to database.server can break common.data.authentication, while a change to common.data.authentication can't break database.server.
Position
Below the diagonal: common.data.authentication uses a module listed above it, which is the healthy direction.
13→21 common.data.authentication uses common.data.serverspart of a loop✕
Connections
1 pair of types, where a type in common.data.authentication uses a type in common.data.servers.
common.data.authentication uses common.data.servers, so a change to common.data.servers can break common.data.authentication, while a change to common.data.authentication can't break common.data.servers.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
common.data.websocket uses common.util.di, so a change to common.util.di can break common.data.websocket, while a change to common.data.websocket can't break common.util.di.
Position
Below the diagonal: common.data.websocket uses a module listed above it, which is the healthy direction.
common.data.websocket uses common.data.websocket.impl.entities, so a change to common.data.websocket.impl.entities can break common.data.websocket, while a change to common.data.websocket can't break common.data.websocket.impl.entities.
Position
Below the diagonal: common.data.websocket uses a module listed above it, which is the healthy direction.
common.data.websocket uses database.server, so a change to database.server can break common.data.websocket, while a change to common.data.websocket can't break database.server.
Position
Below the diagonal: common.data.websocket uses a module listed above it, which is the healthy direction.
14→16 common.data.websocket uses common.data.integrationpart of a loop✕
Connections
1 pair of types, where a type in common.data.websocket uses a type in common.data.integration.
common.data.websocket uses common.data.integration, so a change to common.data.integration can break common.data.websocket, while a change to common.data.websocket can't break common.data.integration.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
14→21 common.data.websocket uses common.data.serverspart of a loop✕
Connections
2 pairs of types, where a type in common.data.websocket uses a type in common.data.servers.
common.data.websocket uses common.data.servers, so a change to common.data.servers can break common.data.websocket, while a change to common.data.websocket can't break common.data.servers.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
common.data.integration.impl uses common.data, so a change to common.data can break common.data.integration.impl, while a change to common.data.integration.impl can't break common.data.
Position
Below the diagonal: common.data.integration.impl uses a module listed above it, which is the healthy direction.
common.data.integration.impl uses common.data.websocket.impl.entities, so a change to common.data.websocket.impl.entities can break common.data.integration.impl, while a change to common.data.integration.impl can't break common.data.websocket.impl.entities.
Position
Below the diagonal: common.data.integration.impl uses a module listed above it, which is the healthy direction.
common.data.integration.impl uses database.server, so a change to database.server can break common.data.integration.impl, while a change to common.data.integration.impl can't break database.server.
Position
Below the diagonal: common.data.integration.impl uses a module listed above it, which is the healthy direction.
common.data.integration.impl uses common.data.websocket, so a change to common.data.websocket can break common.data.integration.impl, while a change to common.data.integration.impl can't break common.data.websocket.
Position
Below the diagonal: common.data.integration.impl uses a module listed above it, which is the healthy direction.
15→16 common.data.integration.impl uses common.data.integrationpart of a loop✕
Connections
7 pairs of types, where a type in common.data.integration.impl uses a type in common.data.integration.
common.data.integration.impl uses common.data.integration, so a change to common.data.integration can break common.data.integration.impl, while a change to common.data.integration.impl can't break common.data.integration.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
15→21 common.data.integration.impl uses common.data.serverspart of a loop✕
Connections
2 pairs of types, where a type in common.data.integration.impl uses a type in common.data.servers.
common.data.integration.impl uses common.data.servers, so a change to common.data.servers can break common.data.integration.impl, while a change to common.data.integration.impl can't break common.data.servers.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
common.data.integration uses common.data, so a change to common.data can break common.data.integration, while a change to common.data.integration can't break common.data.
Position
Below the diagonal: common.data.integration uses a module listed above it, which is the healthy direction.
common.data.integration uses common.util.di, so a change to common.util.di can break common.data.integration, while a change to common.data.integration can't break common.util.di.
Position
Below the diagonal: common.data.integration uses a module listed above it, which is the healthy direction.
common.data.integration uses common.data.websocket.impl.entities, so a change to common.data.websocket.impl.entities can break common.data.integration, while a change to common.data.integration can't break common.data.websocket.impl.entities.
Position
Below the diagonal: common.data.integration uses a module listed above it, which is the healthy direction.
common.data.integration uses common.data.integration.impl, so a change to common.data.integration.impl can break common.data.integration, while a change to common.data.integration can't break common.data.integration.impl.
Position
Below the diagonal: common.data.integration uses a module listed above it, which is the healthy direction.
16→21 common.data.integration uses common.data.serverspart of a loop✕
Connections
1 pair of types, where a type in common.data.integration uses a type in common.data.servers.
common.data.integration uses common.data.servers, so a change to common.data.servers can break common.data.integration, while a change to common.data.integration can't break common.data.servers.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
16→24 common.data.integration uses common.utilpart of a loop✕
Connections
2 pairs of types, where a type in common.data.integration uses a type in common.util.
common.data.integration uses common.util, so a change to common.util can break common.data.integration, while a change to common.data.integration can't break common.util.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
common.data.prefs uses common.data, so a change to common.data can break common.data.prefs, while a change to common.data.prefs can't break common.data.
Position
Below the diagonal: common.data.prefs uses a module listed above it, which is the healthy direction.
common.data.prefs uses common.util.di, so a change to common.util.di can break common.data.prefs, while a change to common.data.prefs can't break common.util.di.
Position
Below the diagonal: common.data.prefs uses a module listed above it, which is the healthy direction.
common.data.prefs uses common.data.integration, so a change to common.data.integration can break common.data.prefs, while a change to common.data.prefs can't break common.data.integration.
Position
Below the diagonal: common.data.prefs uses a module listed above it, which is the healthy direction.
17→24 common.data.prefs uses common.utilpart of a loop✕
Connections
4 pairs of types, where a type in common.data.prefs uses a type in common.util.
common.data.prefs uses common.util, so a change to common.util can break common.data.prefs, while a change to common.data.prefs can't break common.util.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
database.sensor uses common.sensors.SensorManager, so a change to common.sensors.SensorManager can break database.sensor, while a change to database.sensor can't break common.sensors.SensorManager.
Position
Below the diagonal: database.sensor uses a module listed above it, which is the healthy direction.
database.sensor uses common.data.integration, so a change to common.data.integration can break database.sensor, while a change to database.sensor can't break common.data.integration.
Position
Below the diagonal: database.sensor uses a module listed above it, which is the healthy direction.
26 pairs of types, where a type in common.sensors uses a type in common.sensors.SensorManager. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
common.sensors uses common.sensors.SensorManager, so a change to common.sensors.SensorManager can break common.sensors, while a change to common.sensors can't break common.sensors.SensorManager.
Position
Below the diagonal: common.sensors uses a module listed above it, which is the healthy direction.
common.sensors uses database.settings, so a change to database.settings can break common.sensors, while a change to common.sensors can't break database.settings.
Position
Below the diagonal: common.sensors uses a module listed above it, which is the healthy direction.
common.sensors uses database.server, so a change to database.server can break common.sensors, while a change to common.sensors can't break database.server.
Position
Below the diagonal: common.sensors uses a module listed above it, which is the healthy direction.
common.sensors uses database.sensor, so a change to database.sensor can break common.sensors, while a change to common.sensors can't break database.sensor.
Position
Below the diagonal: common.sensors uses a module listed above it, which is the healthy direction.
19→21 common.sensors uses common.data.serverspart of a loop✕
Connections
26 pairs of types, where a type in common.sensors uses a type in common.data.servers. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
common.sensors uses common.data.servers, so a change to common.data.servers can break common.sensors, while a change to common.sensors can't break common.data.servers.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
19→24 common.sensors uses common.utilpart of a loop✕
Connections
1 pair of types, where a type in common.sensors uses a type in common.util.
common.data.servers uses common.data, so a change to common.data can break common.data.servers, while a change to common.data.servers can't break common.data.
Position
Below the diagonal: common.data.servers uses a module listed above it, which is the healthy direction.
common.data.servers uses database.settings, so a change to database.settings can break common.data.servers, while a change to common.data.servers can't break database.settings.
Position
Below the diagonal: common.data.servers uses a module listed above it, which is the healthy direction.
common.data.servers uses common.data.network, so a change to common.data.network can break common.data.servers, while a change to common.data.servers can't break common.data.network.
Position
Below the diagonal: common.data.servers uses a module listed above it, which is the healthy direction.
common.data.servers uses database.server, so a change to database.server can break common.data.servers, while a change to common.data.servers can't break database.server.
Position
Below the diagonal: common.data.servers uses a module listed above it, which is the healthy direction.
common.data.servers uses common.data.authentication, so a change to common.data.authentication can break common.data.servers, while a change to common.data.servers can't break common.data.authentication.
Position
Below the diagonal: common.data.servers uses a module listed above it, which is the healthy direction.
common.data.servers uses common.data.websocket, so a change to common.data.websocket can break common.data.servers, while a change to common.data.servers can't break common.data.websocket.
Position
Below the diagonal: common.data.servers uses a module listed above it, which is the healthy direction.
common.data.servers uses common.data.integration, so a change to common.data.integration can break common.data.servers, while a change to common.data.servers can't break common.data.integration.
Position
Below the diagonal: common.data.servers uses a module listed above it, which is the healthy direction.
common.data.servers uses common.data.prefs, so a change to common.data.prefs can break common.data.servers, while a change to common.data.servers can't break common.data.prefs.
Position
Below the diagonal: common.data.servers uses a module listed above it, which is the healthy direction.
common.data.servers uses common.sensors, so a change to common.sensors can break common.data.servers, while a change to common.data.servers can't break common.sensors.
Position
Below the diagonal: common.data.servers uses a module listed above it, which is the healthy direction.
common.data.integration.display uses common.data.websocket.impl.entities, so a change to common.data.websocket.impl.entities can break common.data.integration.display, while a change to common.data.integration.display can't break common.data.websocket.impl.entities.
Position
Below the diagonal: common.data.integration.display uses a module listed above it, which is the healthy direction.
common.data.integration.display uses common.data.websocket, so a change to common.data.websocket can break common.data.integration.display, while a change to common.data.integration.display can't break common.data.websocket.
Position
Below the diagonal: common.data.integration.display uses a module listed above it, which is the healthy direction.
27 pairs of types, where a type in common.data.integration.display uses a type in common.data.integration. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
common.data.integration.display uses common.data.integration, so a change to common.data.integration can break common.data.integration.display, while a change to common.data.integration.display can't break common.data.integration.
Position
Below the diagonal: common.data.integration.display uses a module listed above it, which is the healthy direction.
common.data.integration.display uses common.data.servers, so a change to common.data.servers can break common.data.integration.display, while a change to common.data.integration.display can't break common.data.servers.
Position
Below the diagonal: common.data.integration.display uses a module listed above it, which is the healthy direction.
common.data.websocket.impl uses common.data, so a change to common.data can break common.data.websocket.impl, while a change to common.data.websocket.impl can't break common.data.
Position
Below the diagonal: common.data.websocket.impl uses a module listed above it, which is the healthy direction.
27 pairs of types, where a type in common.data.websocket.impl uses a type in common.data.websocket.impl.entities. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
common.data.websocket.impl uses common.data.websocket.impl.entities, so a change to common.data.websocket.impl.entities can break common.data.websocket.impl, while a change to common.data.websocket.impl can't break common.data.websocket.impl.entities.
Position
Below the diagonal: common.data.websocket.impl uses a module listed above it, which is the healthy direction.
common.data.websocket.impl uses database.server, so a change to database.server can break common.data.websocket.impl, while a change to common.data.websocket.impl can't break database.server.
Position
Below the diagonal: common.data.websocket.impl uses a module listed above it, which is the healthy direction.
common.data.websocket.impl uses common.data.websocket, so a change to common.data.websocket can break common.data.websocket.impl, while a change to common.data.websocket.impl can't break common.data.websocket.
Position
Below the diagonal: common.data.websocket.impl uses a module listed above it, which is the healthy direction.
common.data.websocket.impl uses common.data.integration, so a change to common.data.integration can break common.data.websocket.impl, while a change to common.data.websocket.impl can't break common.data.integration.
Position
Below the diagonal: common.data.websocket.impl uses a module listed above it, which is the healthy direction.
common.data.websocket.impl uses common.data.servers, so a change to common.data.servers can break common.data.websocket.impl, while a change to common.data.websocket.impl can't break common.data.servers.
Position
Below the diagonal: common.data.websocket.impl uses a module listed above it, which is the healthy direction.
common.util uses common.data.servers, so a change to common.data.servers can break common.util, while a change to common.util can't break common.data.servers.
Position
Below the diagonal: common.util uses a module listed above it, which is the healthy direction.
sensors uses common.sensors.SensorManager, so a change to common.sensors.SensorManager can break sensors, while a change to sensors can't break common.sensors.SensorManager.
Position
Below the diagonal: sensors uses a module listed above it, which is the healthy direction.
sensors uses common.data.integration, so a change to common.data.integration can break sensors, while a change to sensors can't break common.data.integration.
Position
Below the diagonal: sensors uses a module listed above it, which is the healthy direction.
39 pairs of types, where a type in sensors uses a type in common.sensors. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
frontend.permissions uses database.settings, so a change to database.settings can break frontend.permissions, while a change to frontend.permissions can't break database.settings.
Position
Below the diagonal: frontend.permissions uses a module listed above it, which is the healthy direction.
frontend.permissions uses common.data.prefs, so a change to common.data.prefs can break frontend.permissions, while a change to frontend.permissions can't break common.data.prefs.
Position
Below the diagonal: frontend.permissions uses a module listed above it, which is the healthy direction.
frontend.permissions uses common.data.servers, so a change to common.data.servers can break frontend.permissions, while a change to frontend.permissions can't break common.data.servers.
Position
Below the diagonal: frontend.permissions uses a module listed above it, which is the healthy direction.
frontend.permissions uses common.util, so a change to common.util can break frontend.permissions, while a change to frontend.permissions can't break common.util.
Position
Below the diagonal: frontend.permissions uses a module listed above it, which is the healthy direction.
home uses common.sensors.SensorManager, so a change to common.sensors.SensorManager can break home, while a change to home can't break common.sensors.SensorManager.
Position
Below the diagonal: home uses a module listed above it, which is the healthy direction.
home uses common.data.websocket.impl.entities, so a change to common.data.websocket.impl.entities can break home, while a change to home can't break common.data.websocket.impl.entities.
Position
Below the diagonal: home uses a module listed above it, which is the healthy direction.
home uses common.data.integration.display, so a change to common.data.integration.display can break home, while a change to home can't break common.data.integration.display.
Position
Below the diagonal: home uses a module listed above it, which is the healthy direction.
settings.qs uses common.compose.composable, so a change to common.compose.composable can break settings.qs, while a change to settings.qs can't break common.compose.composable.
Position
Below the diagonal: settings.qs uses a module listed above it, which is the healthy direction.
settings.qs uses common.data.servers, so a change to common.data.servers can break settings.qs, while a change to settings.qs can't break common.data.servers.
Position
Below the diagonal: settings.qs uses a module listed above it, which is the healthy direction.
settings.qs uses common.data.integration.display, so a change to common.data.integration.display can break settings.qs, while a change to settings.qs can't break common.data.integration.display.
Position
Below the diagonal: settings.qs uses a module listed above it, which is the healthy direction.
util uses common.sensors.SensorManager, so a change to common.sensors.SensorManager can break util, while a change to util can't break common.sensors.SensorManager.
Position
Below the diagonal: util uses a module listed above it, which is the healthy direction.
util uses common.data.authentication, so a change to common.data.authentication can break util, while a change to util can't break common.data.authentication.
Position
Below the diagonal: util uses a module listed above it, which is the healthy direction.
util uses common.data.integration.display, so a change to common.data.integration.display can break util, while a change to util can't break common.data.integration.display.
Position
Below the diagonal: util uses a module listed above it, which is the healthy direction.
io.homeassistant.companion.android uses common.util, so a change to common.util can break io.homeassistant.companion.android, while a change to io.homeassistant.companion.android can't break common.util.
Position
Below the diagonal: io.homeassistant.companion.android uses a module listed above it, which is the healthy direction.
io.homeassistant.companion.android uses util, so a change to util can break io.homeassistant.companion.android, while a change to io.homeassistant.companion.android can't break util.
Position
Below the diagonal: io.homeassistant.companion.android uses a module listed above it, which is the healthy direction.
frontend.improv uses common.data.network, so a change to common.data.network can break frontend.improv, while a change to frontend.improv can't break common.data.network.
Position
Below the diagonal: frontend.improv uses a module listed above it, which is the healthy direction.
frontend.improv uses frontend.externalbus, so a change to frontend.externalbus can break frontend.improv, while a change to frontend.improv can't break frontend.externalbus.
Position
Below the diagonal: frontend.improv uses a module listed above it, which is the healthy direction.
frontend.improv uses common.data.servers, so a change to common.data.servers can break frontend.improv, while a change to frontend.improv can't break common.data.servers.
Position
Below the diagonal: frontend.improv uses a module listed above it, which is the healthy direction.
frontend.improv uses frontend.permissions, so a change to frontend.permissions can break frontend.improv, while a change to frontend.improv can't break frontend.permissions.
Position
Below the diagonal: frontend.improv uses a module listed above it, which is the healthy direction.
home.views uses common.sensors.SensorManager, so a change to common.sensors.SensorManager can break home.views, while a change to home.views can't break common.sensors.SensorManager.
Position
Below the diagonal: home.views uses a module listed above it, which is the healthy direction.
home.views uses common.data.integration, so a change to common.data.integration can break home.views, while a change to home.views can't break common.data.integration.
Position
Below the diagonal: home.views uses a module listed above it, which is the healthy direction.
home.views uses common.data.integration.display, so a change to common.data.integration.display can break home.views, while a change to home.views can't break common.data.integration.display.
Position
Below the diagonal: home.views uses a module listed above it, which is the healthy direction.
assist uses common.data.websocket.impl.entities, so a change to common.data.websocket.impl.entities can break assist, while a change to assist can't break common.data.websocket.impl.entities.
Position
Below the diagonal: assist uses a module listed above it, which is the healthy direction.
assist uses io.homeassistant.companion.android, so a change to io.homeassistant.companion.android can break assist, while a change to assist can't break io.homeassistant.companion.android.
Position
Below the diagonal: assist uses a module listed above it, which is the healthy direction.
frontend.handler uses frontend.externalbus, so a change to frontend.externalbus can break frontend.handler, while a change to frontend.handler can't break frontend.externalbus.
Position
Below the diagonal: frontend.handler uses a module listed above it, which is the healthy direction.
frontend.handler uses frontend.improv, so a change to frontend.improv can break frontend.handler, while a change to frontend.handler can't break frontend.improv.
Position
Below the diagonal: frontend.handler uses a module listed above it, which is the healthy direction.
35→39 frontend.handler uses frontendpart of a loop✕
Connections
2 pairs of types, where a type in frontend.handler uses a type in frontend.
settings uses io.homeassistant.companion.android, so a change to io.homeassistant.companion.android can break settings, while a change to settings can't break io.homeassistant.companion.android.
Position
Below the diagonal: settings uses a module listed above it, which is the healthy direction.
widgets.todo uses common.compose.composable, so a change to common.compose.composable can break widgets.todo, while a change to widgets.todo can't break common.compose.composable.
Position
Below the diagonal: widgets.todo uses a module listed above it, which is the healthy direction.
widgets.todo uses common.data.servers, so a change to common.data.servers can break widgets.todo, while a change to widgets.todo can't break common.data.servers.
Position
Below the diagonal: widgets.todo uses a module listed above it, which is the healthy direction.
widgets.todo uses common.data.integration.display, so a change to common.data.integration.display can break widgets.todo, while a change to widgets.todo can't break common.data.integration.display.
Position
Below the diagonal: widgets.todo uses a module listed above it, which is the healthy direction.
widgets.todo uses io.homeassistant.companion.android, so a change to io.homeassistant.companion.android can break widgets.todo, while a change to widgets.todo can't break io.homeassistant.companion.android.
Position
Below the diagonal: widgets.todo uses a module listed above it, which is the healthy direction.
frontend uses frontend.externalbus, so a change to frontend.externalbus can break frontend, while a change to frontend can't break frontend.externalbus.
Position
Below the diagonal: frontend uses a module listed above it, which is the healthy direction.
frontend uses frontend.permissions, so a change to frontend.permissions can break frontend, while a change to frontend can't break frontend.permissions.
Position
Below the diagonal: frontend uses a module listed above it, which is the healthy direction.
settings.sensor uses common.sensors.SensorManager, so a change to common.sensors.SensorManager can break settings.sensor, while a change to settings.sensor can't break common.sensors.SensorManager.
Position
Below the diagonal: settings.sensor uses a module listed above it, which is the healthy direction.
settings.sensor uses database.settings, so a change to database.settings can break settings.sensor, while a change to settings.sensor can't break database.settings.
Position
Below the diagonal: settings.sensor uses a module listed above it, which is the healthy direction.
settings.sensor uses common.data.prefs, so a change to common.data.prefs can break settings.sensor, while a change to settings.sensor can't break common.data.prefs.
Position
Below the diagonal: settings.sensor uses a module listed above it, which is the healthy direction.
settings.sensor uses database.sensor, so a change to database.sensor can break settings.sensor, while a change to settings.sensor can't break database.sensor.
Position
Below the diagonal: settings.sensor uses a module listed above it, which is the healthy direction.
settings.sensor uses common.sensors, so a change to common.sensors can break settings.sensor, while a change to settings.sensor can't break common.sensors.
Position
Below the diagonal: settings.sensor uses a module listed above it, which is the healthy direction.
settings.sensor uses common.data.servers, so a change to common.data.servers can break settings.sensor, while a change to settings.sensor can't break common.data.servers.
Position
Below the diagonal: settings.sensor uses a module listed above it, which is the healthy direction.
settings.sensor uses io.homeassistant.companion.android, so a change to io.homeassistant.companion.android can break settings.sensor, while a change to settings.sensor can't break io.homeassistant.companion.android.
Position
Below the diagonal: settings.sensor uses a module listed above it, which is the healthy direction.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
80
High / Critical
A03:2025 — Software Supply Chain Failures
9
High / Critical
Roadmap
Begin by adopting strongly-typed identifiers across the domain to eliminate transposed-argument bugs and defining clear boundaries for any remaining primitive IDs. Shift business rules into aggregates and entities to enforce invariants at the source, ensuring each aggregate has a single, guarded entry point that prevents the construction of invalid states. Finally, resolve the static analysis findings in the GitHub Actions workflows and address the documentation gap in the README to complete the health improvements.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md.
Give each aggregate one way in that can refuse — a guarded constructor, value-object parameters that validate themselves, or a private constructor behind a factory that returns a failure.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 44
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 351
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 70
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 17
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 66 of 66 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); none rely on LLM judgement. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 66 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 449 of 465 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.kt) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures. You can widen what we reach: optional: produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then the real number is read on the next scan.
D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.kt) and this repository declares a JVM test suite (repository root, Gradle), but it was not re-run: no test result was produced. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D14 License Compliance — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares a Gradle build (build.gradle/build.gradle.kts), but the licence verdict published here was taken over its gem dependencies. Nothing was read about its Gradle dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
D19 Documentation Quality — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
D21 Naming Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D21's deterministic naming rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. Until then its declarations carry no naming verdict this run — this says nothing about whether its names are consistent.
D22 Internal API Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is a COLLECTOR gap, not an environment fault: it declares a published package (testing-unit/build.gradle.kts), but no published-package marker D22 reads admitted any project here, so this ecosystem's public API has no collector, and the remedy is to write one — no change to the scan image can close it.
D24 Comment Value — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
D27 Navigability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Navigability is taken over call sites whose callee resolved. For C# that population includes calls into referenced assemblies; for this language only calls declared inside the repository count, so the abstention threshold reads the repository's use of its standard library as a resolution failure. That is a limit of this analyzer, not a build problem in this repository.
D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt`, `app/src/main/kotlin/io/homeassistant/companion/android/assist/wakeword/WakeWordListener.kt`, `app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt`, `app/src/main/kotlin/io/homeassistant/companion/android/frontend/error/ErrorAction.kt`, `app/src/main/kotlin/io/homeassistant/companion/android/frontend/improv/BluetoothCapabilities.kt`, … (+33 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
AXB1 Runtime evidence locked — no reproducible boot — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: a native UI project (wear/src/test/AndroidManifest.xml). The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. Watchdog then boots it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
C2 Access Controls — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
DM8 Value-object opportunities — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check finds primitive parameters that travel together through several signatures of the domain (a missing value object). Its deterministic rule has not yet shown 95 % precision on adjudicated rows, so the clumps it finds are counted here and not published as findings, and the card carries no score. That is a limit of the analyzer, not a finding about your code.
DM9 Scattered domain decisions — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The frontend declares that it computes whether a construction is produced or passed, yet 864 of 864 constructions arrived without the answer. Arm two skipped them; it did not clear them.
GD1 Unfinished & placeholder code — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and no C#, F#, JavaScript/TypeScript, Dart, Ruby or Scala was found, and this repository's Kotlin, c, cpp is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
IC1 Incompleteness & stubs — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and no C#, JavaScript/TypeScript, Java, Dart, Ruby or Scala was found, and this repository's Kotlin, c, cpp is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
S1 Web-Security Posture — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
X24 Document value interpolated into markup unescaped — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Java, Scala, Ruby and Python source only, and no C# was loaded and no JavaScript/TypeScript, Java, Scala, Ruby or Python was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
Repo exclusion declarations: 1 pattern(s) declared (.gitattributes linguist-generated/vendored, .editorconfig generated_code) excluded 0 source file(s) from code-quality scoring. Declarations are the repo's own visible statement that a tree is machine-written or vendored — auditable in any diff, honored by GitHub the same way.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
DM4 Rich vs anemic model: Behaviour is detected as state mutation inside a method body — a method that enforces an invariant by validating-and-throwing without mutating reads as a query, and mutation delegated through an interface the scan can't resolve isn't credited; entities with zero public properties still drop out of the population. It detects that state changes, not whether the rule is correct.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
41 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was EntityKt.getIcon at 169. A further 9 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being HealthServicesSensorManager.getActivityIcon at 49 — they are counted neither in the figure above nor in this dimension's score. 7 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendViewModel.kt (FrontendViewModel.handleMessageResult at 24), common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/SensorWithAttributes.kt (SensorWithAttributes.toSensorRegistration at 20), app/src/main/kotlin/io/homeassistant/companion/android/frontend/navigation/FrontendNavigation.kt (FrontendNavigationKt.FrontendEventHandler at 19), app/src/main/kotlin/io/homeassistant/companion/android/frontend/barcode/FrontendBarcodeScannerHandler.kt (FrontendBarcodeScannerHandlerKt.toFrontendWireFormat at 18), app/src/main/kotlin/io/homeassistant/companion/android/frontend/gesture/FrontendGestureManager.kt (FrontendGestureManager.handleGesture at 18), and 2 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 36 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 1 body over 120 down to 120 or less in Cyclomatic Complexity — start with EntityKt.getIcon (cyclomatic 169). — Refactoring it lifts Cyclomatic Complexity from 5.5 to about 5.8/10.
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 63 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 8 bodies over 60 down to 60 or less in Cognitive Complexity — start with EntityKt.getIcon (cognitive 116), MessagingManager.handleMessage (cognitive 101), FriendlyStateKt.stateResource (cognitive 84). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 8 together lifts Cognitive Complexity from 5.9 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes8.8 / 10Strong✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 12 TooManyMethods finding(s) in God Classes — start with FakePlayer.kt, PrefsRepositoryImpl.kt, MessagingManager.kt. — One of this dimension's main actionable groups (12 warning-level).
Resolve the 12 FileTooLong finding(s) in God Classes — start with MessagingManager.kt, Entity.kt, HealthConnectSensorManager.kt. — One of this dimension's main actionable groups (12 warning-level).
Resolve the 11 MethodTooLong finding(s) in God Classes — start with DatabaseMigration.kt (2), MediaPlayerControlsWidget.kt, MainView.kt. — One of this dimension's main actionable groups (11 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
42 duplicated block group(s) detected. A further 4 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.
+ 26 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 4 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with FirebaseCloudMessagingService.kt, ManualServerScreen.kt, DetailsPanelView.kt. — One of this dimension's main actionable groups (4 warning-level).
Resolve the 3 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with MessagingManager.kt, BaseWidgetProvider.kt, EntityWidget.kt. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 3 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with AssistViewModel.kt, MediaPlayerControlsWidgetConfigureViewModel.kt, CameraTile.kt. — One of this dimension's main actionable groups (3 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
10 production modules (Gradle), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 1 module(s) off the main sequence, with abstractness counted on 8 of the 10 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).
Off the main sequence: home-assistant-android:common
✓ On the Gold path — maintain.
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 2 Low cohesion finding(s) in Cohesion (LCOM4) — start with MainViewModel.kt, DeveloperSettingsFragment.kt. — One of this dimension's main actionable groups (2 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether dependencies are current, secure, and not bloated.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.
1 outdated direct gem(s), 0 pinning defect(s). 2 declaration(s) graded against rubygems.org, 2 of them against a version resolved in a committed Gemfile.lock. Whether any of these gems is DEPRECATED or YANKED is not graded — rubygems.org publishes no deprecation marker, and a yank removes a version rather than flagging it. Whether any is UNMAINTAINED is not graded either: no registry publishes a maintenance status, and release age does not stand in for one. Whether any is UNUSED is a source question, not a registry one. Known CVEs in this dependency graph are D30's question, read from the manifest there.
Outdated: fastlane
✓ On the Gold path — maintain.
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 106 shipped gem(s) use a banned license. Licences were resolved from rubygems.org over the 106 gem(s) a consumer installs — this repository's runtime declarations closed transitively over its committed Gemfile.lock. Development-group and `add_development_dependency` gems are excluded: they are not distributed with this repository. 1 of them publish no licence on rubygems.org; that is missing data, not a violation, and none of them is charged. ★ COVERAGE OF THIS VERDICT: it grades this repository's gem dependencies and nothing else. The repository also declares a Gradle build (build.gradle/build.gradle.kts), and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Resolve the 10 Hotspot finding(s) in Churn × Complexity Hotspots — start with MessagingManager.kt, FrontendViewModel.kt, SensorDetailView.kt. — One of this dimension's main actionable groups (10 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor7.8 / 10Strong✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
110 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendViewModel.kt. Counted over 503 of the 957 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Off-boarding risk: anonymized user #1
Further sole-owners (lower concentration)
What to do
Resolve the 1 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 Further sole-owners (lower concentration) finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
31 deducted task-comment markers across 107395 LoC (0.0/KLoC) → score 9.9. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
Resolve the 31 TodoComment finding(s) in Explicit Debt — start with HATextField.kt (6), LocationSensorManager.kt (3), AssistPipelineEvent.kt (2). — One of this dimension's main actionable groups (31 warning-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
0 of 1 documentation facets pass in full; short on: F2 example. 1 document(s) read across 1 unit(s).
Documentation: no build, run or usage exampleREADME.md:1
What to do
Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.
3 of 9 build units (Gradle) flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesion
What to do
Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
80 finding(s): 0 critical, 41 high, 39 medium, 0 low. semgrep hit a parse error in 4 file(s) — `app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt` (line 464), `app/src/main/kotlin/io/homeassistant/companion/android/widgets/todo/TodoWidgetConfigureViewModel.kt`, `gradlew` (line 74, line 178), `wear/src/main/kotlin/io/homeassistant/companion/android/splash/SplashActivity.kt` (line 8, line 12, line 15, …) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 3 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
What to do
Resolve the 39 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (22), REDACTED (12), REDACTED. — One of this dimension's main actionable groups (39 issue-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.
Resolve the 1 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 3 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (3). — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
25 of 503 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SettingsView.kt. Counted over 503 of the 957 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 2 Boundary-crossing change coupling finding(s) in Change Coupling — start with MessagingManager.kt, NotificationFunctions.kt. — One of this dimension's main actionable groups (2 issue-level).
Resolve the 10 Change coupling finding(s) in Change Coupling — start with HomeView.kt (2), EntityGridVehicleScreen.kt, LaunchActivity.kt. — One of this dimension's main actionable groups (10 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 4 platform declaration(s) and 133 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
What to do
The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`HealthServicesSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (healthClient, passiveMonitoringClient, passiveMonitoringCapabilities, passiveListenerConfig, activityStateRegistered, dataTypesRegistered; e.g. `healthClient` in `getAvailableSensors` at line 178). — wear/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthServicesSensorManager.kt:83
`HeartRateSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager; e.g. `mySensorManager` in `updateHeartRate` at line 99). — wear/src/main/kotlin/io/homeassistant/companion/android/sensors/HeartRateSensorManager.kt:38
`OnBodySensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager; e.g. `mySensorManager` in `hasSensor` at line 68). — wear/src/main/kotlin/io/homeassistant/companion/android/sensors/OnBodySensorManager.kt:28
`WetModeSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (wetModeEnabled; e.g. `wetModeEnabled` in `requestSensorUpdate` at line 55). — wear/src/main/kotlin/io/homeassistant/companion/android/sensors/WetModeSensorManager.kt:18
`AudioSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (sensorIdsWithMatchingAttributes; e.g. `sensorIdsWithMatchingAttributes` in `areAttributesOfSensorAlreadyForcedAtRuntimeOrMatching` at line 512). — common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/AudioSensorManager.kt:40
`LightSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager; e.g. `mySensorManager` in `updateLightSensor` at line 75). — common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/LightSensorManager.kt:25
`PressureSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager; e.g. `mySensorManager` in `updatePressureSensor` at line 76). — common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/PressureSensorManager.kt:25
`ProximitySensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager, maxRange; e.g. `mySensorManager` in `updateProximitySensor` at line 75). — common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/ProximitySensorManager.kt:25
`StepsSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager; e.g. `mySensorManager` in `updateStepsSensor` at line 82). — common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/StepsSensorManager.kt:28
`AndroidAutoSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (carConnection; e.g. `carConnection` in `requestSensorUpdate` at line 64). — app/src/full/kotlin/io/homeassistant/companion/android/sensors/AndroidAutoSensorManager.kt:23
`DevicePolicyManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (isManagedProfileAvailable; e.g. `isManagedProfileAvailable` in `requestSensorUpdate` at line 55). — app/src/main/kotlin/io/homeassistant/companion/android/sensors/DevicePolicyManager.kt:17
What to do
Java/Kotlin: keep container singletons stateless — move per-request data into locals or a request-scoped bean — or back the state with java.util.concurrent types (ConcurrentHashMap, AtomicInteger/AtomicReference), guard it with synchronized / a Lock (Kotlin: withLock), or mark a flag that is only ever overwritten volatile (@Volatile).
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Do you agree with this assessment?
C1 · Data Protection3.5 / 10Weak✓ Tool-verified
Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.
Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.
What to do
Strengthen data-at-rest protection: vault your keys (AWS KMS / Secrets Manager, GCP KMS / Secret Manager, Azure Key Vault, HashiCorp Vault — not a key compiled into the app) and encrypt the store that holds the personal data (SQLCipher, a Realm encryptionKey, field-level AEAD) — partial coverage still leaves gaps.
Enforce HTTPS on the server that receives this data: terminate TLS in it (Ktor's sslConnector, Spring's server.ssl and requiresSecure, Netty's SslContextBuilder.forServer) and send Strict-Transport-Security (Ktor's HttpsRedirect), or run it behind a TLS-terminating proxy, so data in transit is always encrypted.
Do you agree with this assessment?
DM10 · One transaction, one aggregate10.0 / 10Exemplary○ Nothing flagged
Other · Domain Modelling — Whether a single operation mutates more than one aggregate root. An aggregate is a consistency boundary, so saving two together fuses them into one — the second's invariants come to depend on the first's transaction, and the pair can no longer be separated. Reads of other aggregates are not counted.
Method: Neutral body surface (DDD-gated): every method body scanned for repository WRITE calls (Add/Update/Save/Remove/Delete/Insert/Store and their async forms), keyed on the ARGUMENT type rather than the repository type — three `IRepository<T>` writes collapse to one repository but are three distinct aggregates. Reads (Get/Find/Load/Query) are excluded, so loading another aggregate for context never counts. Score is offending methods over methods that write at all. Deterministic.
Other · Domain Modelling — Whether an aggregate can be constructed in a state its own rules forbid — a public constructor that takes a raw primitive, stores it, and validates nothing, with no factory beside it. A constructor taking only value objects is not counted: each parameter has already validated itself.
Method: Neutral surface (DDD-gated): each non-abstract entity/aggregate checked for a PUBLIC constructor taking at least one RAW PRIMITIVE parameter whose body contains no guard token (throw / Guard. / Ensure. / ArgumentException / CheckRule), on a type that also offers no static Create/Of/From/New factory. A constructor taking only value objects is never charged -- measured: 64 of 87 unguarded public constructors on the C# corpus take value objects only, so ignoring parameter types would be 73% false positives. One finding per entity. Deterministic.
`Authentication`'s public constructor takes `host`, `username`, `password` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Authentication` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/authentication/Authentication.kt:8
`LocationHistoryItem`'s public constructor takes `latitude`, `longitude`, `locationName`, `data` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `LocationHistoryItem` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/location/LocationHistoryItem.kt:14
`MediaControlsConfig`'s public constructor takes `entityId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `MediaControlsConfig` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/mediacontrol/MediaControlsConfig.kt:8
`NotificationItem`'s public constructor takes `message`, `data`, `source` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `NotificationItem` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/notification/NotificationItem.kt:8
`TileEntity`'s public constructor takes `tileId`, `iconName`, `entityId`, `label`, … as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `TileEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/qs/TileEntity.kt:8
`Attribute`'s public constructor takes `sensorId`, `name`, `value`, `valueType` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Attribute` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Attribute.kt:7
`Sensor`'s public constructor takes `id`, `state`, `lastSentState`, `lastSentIcon`, … as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Sensor` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Sensor.kt:7
`SensorSetting`'s public constructor takes `sensorId`, `name`, `value` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `SensorSetting` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/SensorSetting.kt:23
`Server`'s public constructor takes `_name`, `nameOverride`, `_version`, `deviceRegistryId`, … as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Server` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/server/Server.kt:14
`CameraTile`'s public constructor takes `entityId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `CameraTile` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/CameraTile.kt:12
`EntityStateComplications`'s public constructor takes `entityId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `EntityStateComplications` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/EntityStateComplications.kt:11
`FavoriteCaches`'s public constructor takes `id`, `name`, `icon` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `FavoriteCaches` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/FavoriteCaches.kt:11
`Favorites`'s public constructor takes `id` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Favorites` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/Favorites.kt:11
`ThermostatTile`'s public constructor takes `entityId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `ThermostatTile` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/ThermostatTile.kt:12
`ButtonWidgetEntity`'s public constructor takes `iconName`, `domain`, `service`, `serviceData`, … as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `ButtonWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/widget/ButtonWidgetEntity.kt:8
`CameraWidgetEntity`'s public constructor takes `entityId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `CameraWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/widget/CameraWidgetEntity.kt:8
`MediaPlayerControlsWidgetEntity`'s public constructor takes `entityId`, `label`, `textColor` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `MediaPlayerControlsWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/widget/MediaPlayerControlsWidgetEntity.kt:8
`StaticWidgetEntity`'s public constructor takes `entityId`, `attributeIds`, `label`, `stateSeparator`, … as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `StaticWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/widget/StaticWidgetEntity.kt:8
`TemplateWidgetEntity`'s public constructor takes `template`, `lastUpdate`, `textColor` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `TemplateWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/widget/TemplateWidgetEntity.kt:8
`TodoWidgetEntity`'s public constructor takes `entityId`, `textColor` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `TodoWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — common/src/main/kotlin/io/homeassistant/companion/android/database/widget/TodoWidgetEntity.kt:11
What to do
Give each aggregate one way in that can refuse — a guarded constructor, value-object parameters that validate themselves, or a private constructor behind a factory that returns a failure.
Other · Domain Modelling — How much of the domain uses strongly-typed ids vs raw Guid/string/int — adoption curve, not all-or-nothing.
Method: Roslyn (DDD-gated): strongly-typed id adoption on domain entities/events; raw Guid/int/string ids counted versus wrapped types. An id wrapper is recognised by VALUE SEMANTICS, not by being a struct — a record struct, a record class (`record ApartmentId(Guid Value)`) or a class declared by a typed-id base (`class MemberId : TypedIdValueBase`) all count, while a plain mutable class (reference equality) and a verb-phrase query record (`GetCustomerById`) do not. Deterministic, adoption percentage.
Coverage: Population: id-like members by *Id/*Key NAME suffix; strongly-typed-ID shape then checked semantically — non-suffixed identifiers are not seen.
`LocationHistoryItem.serverId` is a raw `Int` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int`, in whatever form your language spells that. — common/src/main/kotlin/io/homeassistant/companion/android/database/location/LocationHistoryItem.kt:34
`MediaControlsConfig.serverId` is a raw `Int` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int`, in whatever form your language spells that. — common/src/main/kotlin/io/homeassistant/companion/android/database/mediacontrol/MediaControlsConfig.kt:10
`MediaControlsConfig.entityId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — common/src/main/kotlin/io/homeassistant/companion/android/database/mediacontrol/MediaControlsConfig.kt:12
`NotificationItem.serverId` is a raw `Int` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int`, in whatever form your language spells that. — common/src/main/kotlin/io/homeassistant/companion/android/database/notification/NotificationItem.kt:20
`Attribute.sensorId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Attribute.kt:9
`Sensor.serverId` is a raw `Int` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int`, in whatever form your language spells that. — common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Sensor.kt:11
`SensorSetting.sensorId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/SensorSetting.kt:25
`Server.deviceRegistryId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — common/src/main/kotlin/io/homeassistant/companion/android/database/server/Server.kt:24
`CameraTile.entityId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/CameraTile.kt:19
`EntityStateComplications.entityId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/EntityStateComplications.kt:16
`ThermostatTile.entityId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/ThermostatTile.kt:19
What to do
Adopt strongly-typed ids across the domain — finish the migration or document the boundary; primitive ids invite transposed-argument bugs.
Do you agree with this assessment?
DM4 · Rich vs anemic model3.0 / 10Weak✓ Tool-verified
Other · Domain Modelling — Whether aggregates/entities carry the behaviour that protects their invariants, rather than being data bags driven by external services.
Method: Roslyn (DDD-gated): entity method BODIES classified mutator-vs-query — only methods that mutate the entity's own declared state count as invariant-protecting behaviour, so a getter/passthrough doesn't rescue an anemic class. Deterministic, exhaustive over domain-layer entities.
Coverage: Population: entities by name/base convention; rich-vs-anemic judged by classifying each method body mutator-vs-query — logic-bearing domain types outside the convention are invisible.
`Authentication` is an aggregate/entity with 3 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/authentication/Authentication.kt:8
`LocationHistoryItem` is an aggregate/entity with 11 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/location/LocationHistoryItem.kt:14
`MediaControlsConfig` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/mediacontrol/MediaControlsConfig.kt:8
`NotificationItem` is an aggregate/entity with 6 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/notification/NotificationItem.kt:8
`Attribute` is an aggregate/entity with 4 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Attribute.kt:7
`Sensor` is an aggregate/entity with 17 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Sensor.kt:7
`SensorSetting` is an aggregate/entity with 6 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/SensorSetting.kt:23
`Server` is an aggregate/entity with 12 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/server/Server.kt:14
`Setting` is an aggregate/entity with 3 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/settings/Setting.kt:8
`CameraTile` is an aggregate/entity with 3 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/CameraTile.kt:12
`EntityStateComplications` is an aggregate/entity with 4 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/EntityStateComplications.kt:11
`FavoriteCaches` is an aggregate/entity with 3 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/FavoriteCaches.kt:11
`Favorites` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/Favorites.kt:11
`ThermostatTile` is an aggregate/entity with 5 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — common/src/main/kotlin/io/homeassistant/companion/android/database/wear/ThermostatTile.kt:12
What to do
Move business rules onto the aggregates/entities they govern so invariants are enforced at the source, not in anemic services.
Other · Domain Modelling — Whether entities protect their state — private/init-only setters, and collections handed out as read-only views rather than the mutable backing collection — instead of exposing writable state that bypasses invariants. Softened when a rehydration framework (Marten/EF) is present.
Method: Roslyn (DDD-gated): entities scanned for publicly writable state — public setters, and (C#/VB) own mutable collections handed out through an auto-property, a public field or a bare-field expression getter, where a computed/copying getter is never charged. One finding per entity; score softened when Marten/EF rehydration frameworks present. Deterministic, framework-aware.
Coverage: Population: entities by convention; encapsulation (setter shape) checked exhaustively within the set.
Other · Domain Modelling — Whether repositories are per aggregate root (not per child entity) and keep the persistence query handle behind the contract, so the root's invariants can't be bypassed.
Method: Roslyn (DDD-gated): repository abstraction detection; repositories over non-aggregate-root entities flagged, and (C#/VB) repository INTERFACES whose members return a live persistence query handle (IQueryable/DbSet/IMongoQueryable) — implementations and specification evaluators are out of population by design, since composing a query internally is what an implementation is for. Deterministic, DDD-native.
Coverage: Population: repositories + aggregate roots by NAME convention; per-root repository rule checked within the set.
Other · Domain Modelling — Whether one domain rule is decided — or one measurement produced — in more than one place, rather than living on the type that owns it.
Method: Neutral body surface plus Roslyn (DDD-gated), two arms. DECISION (Roslyn only): a predicate over a domain type's members judged in two or more types, where none of those decisions live on the owning type — operands of comparisons and relational property patterns only, so a member merely passed as an argument is not judged. DERIVATION: a plain all-numeric carrier of ≥2 members, with no base type and exactly one constructor, CONSTRUCTED as the result of a method (returned or assigned, never inline as an argument) in two or more types other than its own — the same measurement produced twice, which centralising the judgement does not fix. DERIVATION runs on every language whose frontend declares the produced-or-passed fact per construction (Roslyn and the Java sidecar today); a target with only the derivation arm carries an engine gap naming the decision arm as not assessed, and a frontend that declares nothing keeps the dimension not measured rather than clean. Single-member rules, test code and generated code are out of population for both. Advisory.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Add a README to the 9 of 9 project(s) that lack one — worth up to 2 pts.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
`REDACTED` run(s) a static-analysis scan, but no workflow that runs one is triggered by a pull request (or a merge queue, or an unfiltered push) — the scan fires on a schedule or a manual dispatch only. A vulnerable change therefore merges clean and is reported on the next scheduled run, by which time it is on the default branch and the only remedy is a follow-up fix. Add the pull-request trigger to the workflow that runs the scan so the finding arrives before the merge rather than after it.
What to do
Trigger your SAST workflow on pull requests — a scan that only runs on a cron reports history, it does not gate.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.
Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.
What to do
Raise allocation-aware density on the hot paths — currently 52 use(s) across 118,868 production line(s) (~0.4/1k). More of the idioms below on the allocation-heavy paths climbs this toward 10.
Kotlin: on hot paths, use primitive arrays (IntArray, LongArray …) and @JvmInline value classes instead of boxed values, primitive collections (androidx.collection, fastutil) instead of boxed ones, and presize collections and StringBuilders.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
`updateHealthServices` is async and calls runBlocking — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs. — wear/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthServicesSensorManager.kt:231
What to do
Kotlin: call the suspend function directly instead of wrapping it in runBlocking, use delay() instead of Thread.sleep, and move unavoidable blocking I/O into withContext(Dispatchers.IO).
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether suspend functions that make a cancellable request accept or pass on the coroutine's cancellation (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 0/5 suspend functions that make a cancellable request (Ktor, OkHttp newCall, URL streams) accept the coroutine's cancellation or pass one on, so a request keeps running after whatever wanted it has given up — a screen navigated away from, a disposed widget, a superseded search. In a suspend function, make the request with a call that suspends — Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` that cancels the `Call` — not a blocking `execute()`: `withContext(Dispatchers.IO)` moves the call off the caller's thread but does not make it cancellable; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
`tls` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`. — common/src/main/kotlin/io/homeassistant/companion/android/common/data/connectivity/DefaultConnectivityChecker.kt:119
`homeAssistant` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`. — common/src/main/kotlin/io/homeassistant/companion/android/common/data/connectivity/DefaultConnectivityChecker.kt:146
`getImageBitmap` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`. — app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1400
`saveTempAnimatedImage` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`. — app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1426
`getVideoFrames` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`. — app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1511
What to do
Thread the coroutine's cancellation through suspend functions that make requests, so the work stops when its caller gives up.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. — common/src/main/kotlin/io/homeassistant/companion/android/common/data/HomeAssistantApis.kt:100
`catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×3) — app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:514, app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:612, app/src/main/kotlin/io/homeassistant/companion/android/settings/notification/views/NotificationDetailView.kt:72
`catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — app/src/main/kotlin/io/homeassistant/companion/android/frontend/session/ServerSessionManager.kt:66
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 2 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
X10 Duplicated predicate — 18 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 2 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 4 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C3 Audit Trail — Repo shows no audit-logging mechanism (an audit-log table or model — an Exposed table, a data class, a Room entity or a SQL migration's table named for it — Hibernate Envers' @Audited, a JPA entity listener, Hibernate event listener or jOOQ RecordListener that records each change) for sensitive changes — absence of evidence is not evidence of a working control. Record an audit trail in code (or document where it lives) so this dimension can be scored.
C4 Data Retention — Repo shows no data-retention / TTL / cleanup mechanism for personal data — absence of evidence is not evidence of a working control. Define retention periods and a purge/cleanup job (or TTL) in code, or document where retention is enforced, so this dimension can be scored.
C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 58 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
AX1 Captive dependencies — Not applicable: Dagger rejects, at compile time, a component that holds a binding with a narrower scope than its own.
AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX6 Interface segregation — no public interfaces
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
D10 Test Quality — ~56075 lines of test source are present (.kt) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
D11 Test Reliability — Test reliability not included — the .kt suite was found but not re-run
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D21 Naming Consistency — Naming consistency is measured on C# only; Java, Kotlin, Python not measured.
D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ projects each declaring an entity of their own. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D24 Comment Value — D24 reads C# and Visual Basic comments only — this repository's production source is .kt, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D25 ADR Conformance — no ADRs to check
D27 Navigability — D27 counts a call into the standard library or a dependency as unresolved for this repository's language (.kt), so too few call sites counted as resolved to assess navigability. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 38 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage not included — suite not readable by the collector
D9 Test Distribution — Test source is present (.kt) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so its unit/integration/BDD/E2E split couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
DM1 Aggregate boundaries — no aggregates detected — aggregate-boundary check not applicable
DM12 Ambient inputs in the domain — no domain-layer types detected — ambient-input check not applicable
DM3 Integration-event coupling — no integration events detected — coupling check not applicable
DM6 Domain ↔ infrastructure boundary — no domain-layer types detected — domain↔infrastructure boundary check not applicable
DM8 Value-object opportunities — not scored — the deterministic rule found 0 candidate clump(s); its rows are withheld until it has a measured precision of 95 % (a sample of fewer than 10 rows cannot show one)
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
M4 Documentation accuracy — Not applicable: the 1 current-state document(s) make no claim of a kind M4 checks.
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P2 Observability — This repository's JVM source (7 module(s), 934 file(s) read) declares no entry point and bootstraps no server, and nothing here deploys a service — it is a library, run inside whatever hosts it, so production observability (structured logging, tracing/metrics, health checks) is N/A. If it grows a binary or a service, the dimension reactivates.
P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM source, so there is no service whose uptime a failing dependency could take down
P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
X24 Document value interpolated into markup unescaped — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Kotlin was read, and it logs through none that an assembled message defeats: Android's `Log` and Timber, java.util.logging and log4j-api-kotlin take one finished message (as log4net does in C#), or it makes no call through a named logger at all. Calls made through SLF4J, log4j 2 or kotlin-logging (`LoggerFactory.getLogger`, `KotlinLogging.logger {}`) would be judged.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
Boundary-crossing change coupling: MessagingManager.kt ↔ NotificationFunctions.kt app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1— `app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt` (context main) and `common/src/main/kotlin/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt` (context common) sit in DIFFERENT parts of the tree yet change together 73% of the time (8 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `25eb107c` Move Emoji.parseToUnicode to Dispatcher.IO (#7108); `d21e938c` Allow assistant volume control (#7068); `6b56bc57` mobile_app_notification_cleared for wearos (#4035) (at that commit the files were still `app/src/main/java/io/homeassistant/companion/android/notifications/MessagingManager.kt` and `common/src/main/java/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt`) — run `git show` on any of them.
Boundary-crossing change coupling: NotificationFunctions.kt ↔ MessagingManager.kt common/src/main/kotlin/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt:1— `common/src/main/kotlin/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt` (context common) and `wear/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt` (context wear) sit in DIFFERENT parts of the tree yet change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `25eb107c` Move Emoji.parseToUnicode to Dispatcher.IO (#7108); `6b56bc57` mobile_app_notification_cleared for wearos (#4035) (at that commit the files were still `common/src/main/java/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt` and `wear/src/main/java/io/homeassistant/companion/android/notifications/MessagingManager.kt`); `cda25479` Add clear_notification support to Wear OS (#3956) (at that commit the files were still `common/src/main/java/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt` and `wear/src/main/java/io/homeassistant/companion/android/notifications/MessagingManager.kt`) — run `git show` on any of them.
TodoComment wear/src/main/kotlin/io/homeassistant/companion/android/home/MainViewModel.kt:129— // TODO: This is bad, do this instead: https://stackoverflow.com/questions/46283981/android-viewmodel-additional-arguments
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorManager.kt:38— // TODO any reason to use mainScope here and not iO? https://github.com/home-assistant/android/issues/5585
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/impl/WebSocketCoreImpl.kt:916— // TODO https://github.com/home-assistant/android/issues/5271
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/impl/WebSocketRepositoryImpl.kt:221— // TODO: Send default locale of device with request. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/impl/entities/AssistPipelineEvent.kt:28— // TODO replace the map https://github.com/home-assistant/android/issues/5341
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/impl/entities/AssistPipelineEvent.kt:39— // TODO Replace the map https://github.com/home-assistant/android/issues/5341
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/data/servers/ServerConnectionStateProviderImpl.kt:147— // TODO this could be cache too, the idea would be to have better logging experience regarding — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/ZoneAttributes.kt:10— // TODO Introduce back ZoneAttribute class https://github.com/home-assistant/android/issues/5340
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/compose/theme/HAColors.kt:190— // TODO validate with design team if this color are immutable or not (not changeable by the users and also stay the same — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/compose/composable/HATextField.kt:72— // TODO probably replace the text composable by strings to control the applied style — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/compose/composable/HATextField.kt:114— // TODO Change colors with design team (current value are picked approximatively) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/compose/composable/HATextField.kt:140— // TODO Verify colors with design team — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/compose/composable/HATextField.kt:146— // TODO Verify colors with design team — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/compose/composable/HATextField.kt:152— // TODO Verify colors with design team — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment common/src/main/kotlin/io/homeassistant/companion/android/common/compose/composable/HATextField.kt:158— // TODO Verify colors with design team — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app/src/test/kotlin/io/homeassistant/companion/android/widgets/todo/TodoGlanceAppWidgetTest.kt:290— // TODO I don't know how to assert the imageProvider or event if it possible — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app/src/main/kotlin/io/homeassistant/companion/android/widgets/todo/TodoWidgetActions.kt:133— // TODO we could modify the entry in DB to add the error message — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app/src/main/kotlin/io/homeassistant/companion/android/widgets/todo/TodoWidgetStateUpdater.kt:88— // TODO send error to the widget??? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app/src/main/kotlin/io/homeassistant/companion/android/widgets/camera/CameraWidgetConfigureActivity.kt:33— // TODO Migrate to compose https://github.com/home-assistant/android/issues/6306
TodoComment app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidgetConfigureActivity.kt:55— // TODO Migrate to compose https://github.com/home-assistant/android/issues/6305
TodoComment app/src/main/kotlin/io/homeassistant/companion/android/util/vehicle/TemplateComponents.kt:157— // TODO most probably this is always false since the launch will update the boolean after we actually test — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment app/src/main/kotlin/io/homeassistant/companion/android/util/compose/LocationPermissionState.kt:15— // TODO drop this requirement https://github.com/home-assistant/android/issues/5931
TodoComment app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:1318— // TODO drop this requirement https://github.com/home-assistant/android/issues/5931
TodoComment app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:1328— // TODO drop this requirement https://github.com/home-assistant/android/issues/5931
TodoComment app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:1337— // TODO drop this requirement https://github.com/home-assistant/android/issues/5931
+ 6 more in this group — see findings.md.
DM11 · Constructible invalid state· Constructible in an invalid state · ×20
Constructible in an invalid state: Authentication common/src/main/kotlin/io/homeassistant/companion/android/database/authentication/Authentication.kt:8— `Authentication`'s public constructor takes `host`, `username`, `password` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Authentication` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: LocationHistoryItem common/src/main/kotlin/io/homeassistant/companion/android/database/location/LocationHistoryItem.kt:14— `LocationHistoryItem`'s public constructor takes `latitude`, `longitude`, `locationName`, `data` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `LocationHistoryItem` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: MediaControlsConfig common/src/main/kotlin/io/homeassistant/companion/android/database/mediacontrol/MediaControlsConfig.kt:8— `MediaControlsConfig`'s public constructor takes `entityId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `MediaControlsConfig` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: NotificationItem common/src/main/kotlin/io/homeassistant/companion/android/database/notification/NotificationItem.kt:8— `NotificationItem`'s public constructor takes `message`, `data`, `source` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `NotificationItem` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: TileEntity common/src/main/kotlin/io/homeassistant/companion/android/database/qs/TileEntity.kt:8— `TileEntity`'s public constructor takes `tileId`, `iconName`, `entityId`, `label`, … as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `TileEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: Attribute common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Attribute.kt:7— `Attribute`'s public constructor takes `sensorId`, `name`, `value`, `valueType` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Attribute` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: Sensor common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Sensor.kt:7— `Sensor`'s public constructor takes `id`, `state`, `lastSentState`, `lastSentIcon`, … as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Sensor` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: SensorSetting common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/SensorSetting.kt:23— `SensorSetting`'s public constructor takes `sensorId`, `name`, `value` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `SensorSetting` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: Server common/src/main/kotlin/io/homeassistant/companion/android/database/server/Server.kt:14— `Server`'s public constructor takes `_name`, `nameOverride`, `_version`, `deviceRegistryId`, … as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Server` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: CameraTile common/src/main/kotlin/io/homeassistant/companion/android/database/wear/CameraTile.kt:12— `CameraTile`'s public constructor takes `entityId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `CameraTile` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: EntityStateComplications common/src/main/kotlin/io/homeassistant/companion/android/database/wear/EntityStateComplications.kt:11— `EntityStateComplications`'s public constructor takes `entityId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `EntityStateComplications` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: FavoriteCaches common/src/main/kotlin/io/homeassistant/companion/android/database/wear/FavoriteCaches.kt:11— `FavoriteCaches`'s public constructor takes `id`, `name`, `icon` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `FavoriteCaches` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: Favorites common/src/main/kotlin/io/homeassistant/companion/android/database/wear/Favorites.kt:11— `Favorites`'s public constructor takes `id` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Favorites` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: ThermostatTile common/src/main/kotlin/io/homeassistant/companion/android/database/wear/ThermostatTile.kt:12— `ThermostatTile`'s public constructor takes `entityId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `ThermostatTile` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: ButtonWidgetEntity common/src/main/kotlin/io/homeassistant/companion/android/database/widget/ButtonWidgetEntity.kt:8— `ButtonWidgetEntity`'s public constructor takes `iconName`, `domain`, `service`, `serviceData`, … as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `ButtonWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: CameraWidgetEntity common/src/main/kotlin/io/homeassistant/companion/android/database/widget/CameraWidgetEntity.kt:8— `CameraWidgetEntity`'s public constructor takes `entityId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `CameraWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: MediaPlayerControlsWidgetEntity common/src/main/kotlin/io/homeassistant/companion/android/database/widget/MediaPlayerControlsWidgetEntity.kt:8— `MediaPlayerControlsWidgetEntity`'s public constructor takes `entityId`, `label`, `textColor` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `MediaPlayerControlsWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: StaticWidgetEntity common/src/main/kotlin/io/homeassistant/companion/android/database/widget/StaticWidgetEntity.kt:8— `StaticWidgetEntity`'s public constructor takes `entityId`, `attributeIds`, `label`, `stateSeparator`, … as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `StaticWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: TemplateWidgetEntity common/src/main/kotlin/io/homeassistant/companion/android/database/widget/TemplateWidgetEntity.kt:8— `TemplateWidgetEntity`'s public constructor takes `template`, `lastUpdate`, `textColor` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `TemplateWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: TodoWidgetEntity common/src/main/kotlin/io/homeassistant/companion/android/database/widget/TodoWidgetEntity.kt:11— `TodoWidgetEntity`'s public constructor takes `entityId`, `textColor` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `TodoWidgetEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Anemic entity: Authentication common/src/main/kotlin/io/homeassistant/companion/android/database/authentication/Authentication.kt:8— `Authentication` is an aggregate/entity with 3 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: LocationHistoryItem common/src/main/kotlin/io/homeassistant/companion/android/database/location/LocationHistoryItem.kt:14— `LocationHistoryItem` is an aggregate/entity with 11 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: MediaControlsConfig common/src/main/kotlin/io/homeassistant/companion/android/database/mediacontrol/MediaControlsConfig.kt:8— `MediaControlsConfig` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: NotificationItem common/src/main/kotlin/io/homeassistant/companion/android/database/notification/NotificationItem.kt:8— `NotificationItem` is an aggregate/entity with 6 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Attribute common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Attribute.kt:7— `Attribute` is an aggregate/entity with 4 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Sensor common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Sensor.kt:7— `Sensor` is an aggregate/entity with 17 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: SensorSetting common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/SensorSetting.kt:23— `SensorSetting` is an aggregate/entity with 6 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Server common/src/main/kotlin/io/homeassistant/companion/android/database/server/Server.kt:14— `Server` is an aggregate/entity with 12 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Setting common/src/main/kotlin/io/homeassistant/companion/android/database/settings/Setting.kt:8— `Setting` is an aggregate/entity with 3 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: CameraTile common/src/main/kotlin/io/homeassistant/companion/android/database/wear/CameraTile.kt:12— `CameraTile` is an aggregate/entity with 3 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: EntityStateComplications common/src/main/kotlin/io/homeassistant/companion/android/database/wear/EntityStateComplications.kt:11— `EntityStateComplications` is an aggregate/entity with 4 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: FavoriteCaches common/src/main/kotlin/io/homeassistant/companion/android/database/wear/FavoriteCaches.kt:11— `FavoriteCaches` is an aggregate/entity with 3 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Favorites common/src/main/kotlin/io/homeassistant/companion/android/database/wear/Favorites.kt:11— `Favorites` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: ThermostatTile common/src/main/kotlin/io/homeassistant/companion/android/database/wear/ThermostatTile.kt:12— `ThermostatTile` is an aggregate/entity with 5 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
TooManyMethods: FakePlayer app/src/main/kotlin/io/homeassistant/companion/android/util/compose/media/player/FakePlayer.kt:26— TooManyMethods — 123 methods. The bar is 30 methods; this is 93 over it, 4.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PrefsRepositoryImpl common/src/main/kotlin/io/homeassistant/companion/android/common/data/prefs/PrefsRepositoryImpl.kt:106— TooManyMethods — 69 methods. The bar is 30 methods; this is 39 over it, 2.30× the bar. Most of these members implement prefs.PrefsRepository (68 of 69 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: MessagingManager app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:128— TooManyMethods — 57 methods. The bar is 30 methods; this is 27 over it, 1.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: IntegrationRepositoryImpl common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/impl/IntegrationRepositoryImpl.kt:72— TooManyMethods — 55 methods. The bar is 30 methods; this is 25 over it, 1.83× the bar. Most of these members implement integration.IntegrationRepository (39 of 54 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: FrontendViewModel app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendViewModel.kt:115— TooManyMethods — 53 methods. The bar is 30 methods; this is 23 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: HealthConnectSensorManager app/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthConnectSensorManager.kt:85— TooManyMethods — 51 methods. The bar is 30 methods; this is 21 over it, 1.70× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MainViewModel wear/src/main/kotlin/io/homeassistant/companion/android/home/MainViewModel.kt:49— TooManyMethods — 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: WebSocketRepositoryImpl common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/impl/WebSocketRepositoryImpl.kt:60— TooManyMethods — 42 methods. The bar is 30 methods; this is 12 over it, 1.40× the bar. Most of these members implement websocket.WebSocketRepository (34 of 40 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: WebSocketCoreImpl common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/impl/WebSocketCoreImpl.kt:142— TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LocationSensorManager app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:66— TooManyMethods — 37 methods. The bar is 30 methods; this is 7 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: HomePresenterImpl wear/src/main/kotlin/io/homeassistant/companion/android/home/HomePresenterImpl.kt:33— TooManyMethods — 35 methods. The bar is 30 methods; this is 5 over it, 1.17× the bar. Most of these members implement home.HomePresenter (33 of 35 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: SensorRepositoryImpl common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorRepositoryImpl.kt:19— TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
FileTooLong: notifications/MessagingManager.kt app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt— FileTooLong — 1516 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1016 over it, 3.03× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: integration/Entity.kt common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt— FileTooLong — 1187 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 687 over it, 2.37× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: sensors/HealthConnectSensorManager.kt app/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthConnectSensorManager.kt— FileTooLong — 1144 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: HealthConnectSensorManager (85-1457). The bar is 500 significant lines; this is 644 over it, 2.29× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: sensors/LocationSensorManager.kt app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt— FileTooLong — 990 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 490 over it, 1.98× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: impl/WebSocketCoreImpl.kt common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/impl/WebSocketCoreImpl.kt— FileTooLong — 755 significant lines (blank, comment-only and punctuation-only lines excluded), about 81% of them inside a single declaration: WebSocketCoreImpl (142-1265). The bar is 500 significant lines; this is 255 over it, 1.51× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: frontend/FrontendScreen.kt app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt— FileTooLong — 742 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 242 over it, 1.48× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: frontend/FrontendViewModel.kt app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendViewModel.kt— FileTooLong — 680 significant lines (blank, comment-only and punctuation-only lines excluded), about 86% of them inside a single declaration: FrontendViewModel (115-1353). The bar is 500 significant lines; this is 180 over it, 1.36× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: migration/DatabaseMigration.kt common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt— FileTooLong — 571 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 71 over it, 1.14× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: views/SensorDetailView.kt app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt— FileTooLong — 567 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 67 over it, 1.13× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: mediaplayer/MediaPlayerControlsWidget.kt app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt— FileTooLong — 565 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: MediaPlayerControlsWidget (42-768). The bar is 500 significant lines; this is 65 over it, 1.13× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: ui/AssistSheet.kt app/src/main/kotlin/io/homeassistant/companion/android/assist/ui/AssistSheet.kt— FileTooLong — 525 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 25 over it, 1.05× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: impl/IntegrationRepositoryImpl.kt common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/impl/IntegrationRepositoryImpl.kt— FileTooLong — 507 significant lines (blank, comment-only and punctuation-only lines excluded), about 87% of them inside a single declaration: IntegrationRepositoryImpl (72-751). The bar is 500 significant lines; this is 7 over it, 1.01× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
Stateful singleton: HealthServicesSensorManager wear/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthServicesSensorManager.kt:83— `HealthServicesSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (healthClient, passiveMonitoringClient, passiveMonitoringCapabilities, passiveListenerConfig, activityStateRegistered, dataTypesRegistered; e.g. `healthClient` in `getAvailableSensors` at line 178).
Stateful singleton: HeartRateSensorManager wear/src/main/kotlin/io/homeassistant/companion/android/sensors/HeartRateSensorManager.kt:38— `HeartRateSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager; e.g. `mySensorManager` in `updateHeartRate` at line 99).
Stateful singleton: OnBodySensorManager wear/src/main/kotlin/io/homeassistant/companion/android/sensors/OnBodySensorManager.kt:28— `OnBodySensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager; e.g. `mySensorManager` in `hasSensor` at line 68).
Stateful singleton: WetModeSensorManager wear/src/main/kotlin/io/homeassistant/companion/android/sensors/WetModeSensorManager.kt:18— `WetModeSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (wetModeEnabled; e.g. `wetModeEnabled` in `requestSensorUpdate` at line 55).
Stateful singleton: AudioSensorManager common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/AudioSensorManager.kt:40— `AudioSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (sensorIdsWithMatchingAttributes; e.g. `sensorIdsWithMatchingAttributes` in `areAttributesOfSensorAlreadyForcedAtRuntimeOrMatching` at line 512).
Stateful singleton: LightSensorManager common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/LightSensorManager.kt:25— `LightSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager; e.g. `mySensorManager` in `updateLightSensor` at line 75).
Stateful singleton: PressureSensorManager common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/PressureSensorManager.kt:25— `PressureSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager; e.g. `mySensorManager` in `updatePressureSensor` at line 76).
Stateful singleton: ProximitySensorManager common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/ProximitySensorManager.kt:25— `ProximitySensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager, maxRange; e.g. `mySensorManager` in `updateProximitySensor` at line 75).
Stateful singleton: StepsSensorManager common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/StepsSensorManager.kt:28— `StepsSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (mySensorManager; e.g. `mySensorManager` in `updateStepsSensor` at line 82).
Stateful singleton: AndroidAutoSensorManager app/src/full/kotlin/io/homeassistant/companion/android/sensors/AndroidAutoSensorManager.kt:23— `AndroidAutoSensorManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (carConnection; e.g. `carConnection` in `requestSensorUpdate` at line 64).
Stateful singleton: DevicePolicyManager app/src/main/kotlin/io/homeassistant/companion/android/sensors/DevicePolicyManager.kt:17— `DevicePolicyManager` is a singleton (@Singleton: the container shares one instance across every request thread) but mutates instance state outside any lock (isManagedProfileAvailable; e.g. `isManagedProfileAvailable` in `requestSensorUpdate` at line 55).
MethodTooLong: MediaPlayerControlsWidget.getWidgetRemoteViews app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:66— MethodTooLong — getWidgetRemoteViews runs 240 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 140 over it, 2.40× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: MainViewKt.MainView wear/src/main/kotlin/io/homeassistant/companion/android/home/views/MainView.kt:52— MethodTooLong — MainView runs 206 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 106 over it, 2.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: EntityKt.getIcon common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:981— MethodTooLong — getIcon runs 203 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 103 over it, 2.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ManageShortcutsViewKt.CreateShortcutView app/src/main/kotlin/io/homeassistant/companion/android/settings/shortcuts/legacy/views/ManageShortcutsView.kt:94— MethodTooLong — CreateShortcutView runs 197 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 97 over it, 1.97× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: HomeAssistantApplication.onCreate app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:89— MethodTooLong — onCreate runs 184 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 84 over it, 1.84× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: SettingsViewKt.SettingsView wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SettingsView.kt:75— MethodTooLong — SettingsView runs 153 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 53 over it, 1.53× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: SensorUpdater.syncSensorsWithServer common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorUpdater.kt:177— MethodTooLong — syncSensorsWithServer runs 148 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 48 over it, 1.48× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: SsidViewKt.SsidView app/src/main/kotlin/io/homeassistant/companion/android/settings/ssid/views/SsidView.kt:68— MethodTooLong — SsidView runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Migration37to38.onPostMigrate common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt:561— MethodTooLong — onPostMigrate runs 118 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 18 over it, 1.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ButtonWidgetConfigureActivity.onCreate app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidgetConfigureActivity.kt:212— MethodTooLong — onCreate runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Migration16to17.migrate common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt:243— MethodTooLong — migrate runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Hotspot: app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:304— app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 72 in MessagingManager.handleMessage at line 304. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-28..2026-10-26, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-28 20:10:21 +00:00' --until='2026-10-26 20:10:21 +00:00' --full-history --no-merges -- app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendViewModel.kt app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendViewModel.kt:887— app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendViewModel.kt changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in FrontendViewModel.handleMessageResult at line 887. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-28..2026-10-26, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-28 20:10:21 +00:00' --until='2026-10-26 20:10:21 +00:00' --full-history --no-merges -- app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendViewModel.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt:100— app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 37 in SensorDetailViewKt.SensorDetailView at line 100. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-28..2026-10-26, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-28 20:10:21 +00:00' --until='2026-10-26 20:10:21 +00:00' --full-history --no-merges -- app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: app/src/main/kotlin/io/homeassistant/companion/android/settings/shortcuts/legacy/views/ManageShortcutsView.kt app/src/main/kotlin/io/homeassistant/companion/android/settings/shortcuts/legacy/views/ManageShortcutsView.kt:94— app/src/main/kotlin/io/homeassistant/companion/android/settings/shortcuts/legacy/views/ManageShortcutsView.kt changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 32 in ManageShortcutsViewKt.CreateShortcutView at line 94. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-28..2026-10-26, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-28 20:10:21 +00:00' --until='2026-10-26 20:10:21 +00:00' --full-history --no-merges -- app/src/main/kotlin/io/homeassistant/companion/android/settings/shortcuts/legacy/views/ManageShortcutsView.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:883— app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in LocationSensorManager.sendLocationUpdate at line 883. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-28..2026-10-26, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-28 20:10:21 +00:00' --until='2026-10-26 20:10:21 +00:00' --full-history --no-merges -- app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsActivity.kt app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsActivity.kt:85— app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsActivity.kt changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in SettingsActivity.onCreate at line 85. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-28..2026-10-26, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-28 20:10:21 +00:00' --until='2026-10-26 20:10:21 +00:00' --full-history --no-merges -- app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsActivity.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:89— app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in HomeAssistantApplication.onCreate at line 89. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-28..2026-10-26, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-28 20:10:21 +00:00' --until='2026-10-26 20:10:21 +00:00' --full-history --no-merges -- app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt:92— app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in SettingsFragment.onCreatePreferences at line 92. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-28..2026-10-26, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-28 20:10:21 +00:00' --until='2026-10-26 20:10:21 +00:00' --full-history --no-merges -- app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: wear/src/main/kotlin/io/homeassistant/companion/android/home/views/MainView.kt wear/src/main/kotlin/io/homeassistant/companion/android/home/views/MainView.kt:52— wear/src/main/kotlin/io/homeassistant/companion/android/home/views/MainView.kt changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in MainViewKt.MainView at line 52. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-28..2026-10-26, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-28 20:10:21 +00:00' --until='2026-10-26 20:10:21 +00:00' --full-history --no-merges -- wear/src/main/kotlin/io/homeassistant/companion/android/home/views/MainView.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: wear/src/main/kotlin/io/homeassistant/companion/android/tiles/ThermostatTile.kt wear/src/main/kotlin/io/homeassistant/companion/android/tiles/ThermostatTile.kt:68— wear/src/main/kotlin/io/homeassistant/companion/android/tiles/ThermostatTile.kt changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in ThermostatTile.onTileRequest at line 68. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-28..2026-10-26, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-28 20:10:21 +00:00' --until='2026-10-26 20:10:21 +00:00' --full-history --no-merges -- wear/src/main/kotlin/io/homeassistant/companion/android/tiles/ThermostatTile.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Change coupling: EntityGridVehicleScreen.kt ↔ MapVehicleScreen.kt app/src/main/kotlin/io/homeassistant/companion/android/vehicle/EntityGridVehicleScreen.kt:1— `app/src/main/kotlin/io/homeassistant/companion/android/vehicle/EntityGridVehicleScreen.kt` and `app/src/main/kotlin/io/homeassistant/companion/android/vehicle/MapVehicleScreen.kt` change together 73% of the time (8 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `2bdcbfd6` Mutualize Android Auto navigation_started event firing (#7468); `62b81a18` Remove runBlocking from ServerManager.activeServerId (#5722); `90bf7369` Clean up some left over code after update to getIcon (#3827) (at that commit the files were still `app/src/main/java/io/homeassistant/companion/android/vehicle/EntityGridVehicleScreen.kt` and `app/src/main/java/io/homeassistant/companion/android/vehicle/MapVehicleScreen.kt`) — run `git show` on any of them.
Change coupling: LaunchActivity.kt ↔ HANavHost.kt app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchActivity.kt:1— `app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchActivity.kt` and `app/src/main/kotlin/io/homeassistant/companion/android/util/compose/HANavHost.kt` change together 65% of the time (11 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `26154d92` Add dedicated screen for invitation flow instead of WelcomeScreen (#6…; `99655c59` Add support for PiP for FrontendScreen (#6812); `c84d7f44` Add ExoPlayer support for FrontendScreen from frontend request (#6771) — run `git show` on any of them.
Change coupling: EntityWidget.kt ↔ TemplateWidget.kt app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidget.kt:1— `app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidget.kt` and `app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidget.kt` change together 64% of the time (14 of the 22 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 14 shared commits counted here, the most recent 3 are `514d6c10` Move away from Main in Widgets (#6415); `e838330d` Code quality: use compat functions for Android 13 type extras (#4501) (at that commit the files were still `app/src/main/java/io/homeassistant/companion/android/widgets/entity/EntityWidget.kt` and `app/src/main/java/io/homeassistant/companion/android/widgets/template/TemplateWidget.kt`); `7953f81b` Fix websocket stays subscribed after widget edit due to multiple inst… (at that commit the files were still `app/src/main/java/io/homeassistant/companion/android/widgets/entity/EntityWidget.kt` and `app/src/main/java/io/homeassistant/companion/android/widgets/template/TemplateWidget.kt`) — run `git show` on any of them.
Change coupling: HomeView.kt ↔ SetFavoriteView.kt wear/src/main/kotlin/io/homeassistant/companion/android/home/views/HomeView.kt:1— `wear/src/main/kotlin/io/homeassistant/companion/android/home/views/HomeView.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SetFavoriteView.kt` change together 58% of the time (7 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `64a425ac` Use ViewState in some views of the watch to avoid concurrent issues (…; `dbb1e8bf` Use suspend and transactions for Favorites dao (#2398) (at that commit the files were still `wear/src/main/java/io/homeassistant/companion/android/home/views/HomeView.kt` and `wear/src/main/java/io/homeassistant/companion/android/home/views/SetFavoriteView.kt`); `47962841` Add areas to entity list on Wear (#2118) (at that commit the files were still `wear/src/main/java/io/homeassistant/companion/android/home/views/HomeView.kt` and `wear/src/main/java/io/homeassistant/companion/android/home/views/SetFavoriteView.kt`) — run `git show` on any of them.
Change coupling: ServerSettingsFragment.kt ↔ WebViewActivity.kt app/src/main/kotlin/io/homeassistant/companion/android/settings/server/ServerSettingsFragment.kt:1— `app/src/main/kotlin/io/homeassistant/companion/android/settings/server/ServerSettingsFragment.kt` and `app/src/main/kotlin/io/homeassistant/companion/android/webview/WebViewActivity.kt` change together 58% of the time (7 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `2717a340` Introduce FrontendTarget and use it instead of WebViewActivity (#7087); `17e03ca3` Add app lock feature to FrontendScreen (#6756); `793bf01d` Add set security level when not set while opening a server (#6097) — run `git show` on any of them.
Change coupling: ConversationActivity.kt ↔ ConversationView.kt wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationActivity.kt:1— `wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationActivity.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/conversation/views/ConversationView.kt` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `f3071e79` Wear Assist: show login when logged out, scroll first item into view … (at that commit the files were still `wear/src/main/java/io/homeassistant/companion/android/conversation/ConversationActivity.kt` and `wear/src/main/java/io/homeassistant/companion/android/conversation/views/ConversationView.kt`); `edf6ba5b` Use Assist pipeline STT/TTS on Wear OS (#3611) (at that commit the files were still `wear/src/main/java/io/homeassistant/companion/android/conversation/ConversationActivity.kt` and `wear/src/main/java/io/homeassistant/companion/android/conversation/views/ConversationView.kt`); `3c706bb7` Update Wear Assist with continued conversations, pipelines (#3604) (at that commit the files were still `wear/src/main/java/io/homeassistant/companion/android/conversation/ConversationActivity.kt` and `wear/src/main/java/io/homeassistant/companion/android/conversation/views/ConversationView.kt`) — run `git show` on any of them.
Change coupling: SensorReceiverBase.kt ↔ SensorWorker.kt common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorReceiverBase.kt:1— `common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorReceiverBase.kt` and `common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorWorker.kt` change together 54% of the time (7 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `2c3406fe` Extract SensorReceiverBase update logic into SensorUpdater (#7107); `7d93d38b` Remove DatabaseEntryPoint (#7106) (at that commit the file was still `common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorWorkerBase.kt`); `2b2ece82` Remove appdatabase get instance (#6234) (at that commit the file was still `common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorWorkerBase.kt`) — run `git show` on any of them.
Change coupling: HomeView.kt ↔ ChooseEntityView.kt wear/src/main/kotlin/io/homeassistant/companion/android/home/views/HomeView.kt:1— `wear/src/main/kotlin/io/homeassistant/companion/android/home/views/HomeView.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/views/ChooseEntityView.kt` change together 53% of the time (8 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `64a425ac` Use ViewState in some views of the watch to avoid concurrent issues (…; `d00c8236` Faster entity selection Wear OS (#2804) (at that commit the files were still `wear/src/main/java/io/homeassistant/companion/android/home/views/HomeView.kt` and `wear/src/main/java/io/homeassistant/companion/android/views/ChooseEntityView.kt`); `131296ad` Show names on shortcuts tile (#2142) (at that commit the files were still `wear/src/main/java/io/homeassistant/companion/android/home/views/HomeView.kt` and `wear/src/main/java/io/homeassistant/companion/android/home/views/ChooseEntityView.kt`) — run `git show` on any of them.
Change coupling: HomeActivity.kt ↔ HomePresenterImpl.kt wear/src/main/kotlin/io/homeassistant/companion/android/home/HomeActivity.kt:1— `wear/src/main/kotlin/io/homeassistant/companion/android/home/HomeActivity.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/home/HomePresenterImpl.kt` change together 50% of the time (12 of the 24 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 12 shared commits counted here, the most recent 3 are `6a21a1c2` Add missing catch when interacting with network (#6264); `a8a73633` Implement support for multiple Shortcut Tiles on Wear OS (#3697) (at that commit the files were still `wear/src/main/java/io/homeassistant/companion/android/home/HomeActivity.kt` and `wear/src/main/java/io/homeassistant/companion/android/home/HomePresenterImpl.kt`); `047abe93` Add new option to only show favorites on home screen (#3276) (at that commit the files were still `wear/src/main/java/io/homeassistant/companion/android/home/HomeActivity.kt` and `wear/src/main/java/io/homeassistant/companion/android/home/HomePresenterImpl.kt`) — run `git show` on any of them.
Change coupling: MainViewModel.kt ↔ SetFavoriteView.kt wear/src/main/kotlin/io/homeassistant/companion/android/home/MainViewModel.kt:1— `wear/src/main/kotlin/io/homeassistant/companion/android/home/MainViewModel.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SetFavoriteView.kt` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `64a425ac` Use ViewState in some views of the watch to avoid concurrent issues (…; `dbb1e8bf` Use suspend and transactions for Favorites dao (#2398) (at that commit the files were still `wear/src/main/java/io/homeassistant/companion/android/home/MainViewModel.kt` and `wear/src/main/java/io/homeassistant/companion/android/home/views/SetFavoriteView.kt`); `47962841` Add areas to entity list on Wear (#2118) (at that commit the files were still `wear/src/main/java/io/homeassistant/companion/android/home/MainViewModel.kt` and `wear/src/main/java/io/homeassistant/companion/android/home/views/SetFavoriteView.kt`) — run `git show` on any of them.
ClassTooLong: HealthConnectSensorManager app/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthConnectSensorManager.kt:85— ClassTooLong — 1062 significant lines (blank, comment-only and punctuation-only lines excluded), 51 methods. The bar is 400 significant lines; this is 662 over it, 2.66× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: WebSocketCoreImpl common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/impl/WebSocketCoreImpl.kt:142— ClassTooLong — 611 significant lines (blank, comment-only and punctuation-only lines excluded), 40 methods. The bar is 400 significant lines; this is 211 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: FrontendViewModel app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendViewModel.kt:115— ClassTooLong — 586 significant lines (blank, comment-only and punctuation-only lines excluded), 53 methods. The bar is 400 significant lines; this is 186 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: MediaPlayerControlsWidget app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:42— ClassTooLong — 527 significant lines (blank, comment-only and punctuation-only lines excluded), 14 methods. The bar is 400 significant lines; this is 127 over it, 1.32× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: NetworkSensorManager common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/NetworkSensorManager.kt:52— ClassTooLong — 440 significant lines (blank, comment-only and punctuation-only lines excluded), 20 methods. The bar is 400 significant lines; this is 40 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: IntegrationRepositoryImpl common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/impl/IntegrationRepositoryImpl.kt:72— ClassTooLong — 439 significant lines (blank, comment-only and punctuation-only lines excluded), 55 methods. The bar is 400 significant lines; this is 39 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: CarSensorManager app/src/main/kotlin/io/homeassistant/companion/android/sensors/CarSensorManager.kt:44— ClassTooLong — 426 significant lines (blank, comment-only and punctuation-only lines excluded), 19 methods. The bar is 400 significant lines; this is 26 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
X2 · Cancellation propagation· Suspend function with a blocking request · ×5
Suspend function with a blocking request: tls common/src/main/kotlin/io/homeassistant/companion/android/common/data/connectivity/DefaultConnectivityChecker.kt:119— `tls` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`.
Suspend function with a blocking request: homeAssistant common/src/main/kotlin/io/homeassistant/companion/android/common/data/connectivity/DefaultConnectivityChecker.kt:146— `homeAssistant` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`.
Suspend function with a blocking request: getImageBitmap app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1400— `getImageBitmap` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`.
Suspend function with a blocking request: saveTempAnimatedImage app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1426— `saveTempAnimatedImage` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`.
Suspend function with a blocking request: getVideoFrames app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1511— `getVideoFrames` suspends, but makes its request with `newCall(…).execute()`, which blocks: its caller's cancellation cannot reach the request, so it runs to its end after whatever wanted it has given up — `withContext(Dispatchers.IO)` moves it off the caller's thread and does not change that. Make the request with a call that suspends: Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` over `enqueue` that cancels the `Call` in `invokeOnCancellation`.
Duplicated block (10 lines × 2) app/src/full/kotlin/io/homeassistant/companion/android/notifications/FirebaseCloudMessagingService.kt:43— app/src/full/kotlin/io/homeassistant/companion/android/notifications/FirebaseCloudMessagingService.kt:43-52 | wear/src/main/kotlin/io/homeassistant/companion/android/notifications/FirebaseCloudMessagingService.kt:43-53 — before extracting anything, compare `app/src/full/kotlin/io/homeassistant/companion/android/notifications/FirebaseCloudMessagingService.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/notifications/FirebaseCloudMessagingService.kt` as WHOLE FILES: 95% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/full/kotlin/io/homeassistant/companion/android/notifications/FirebaseCloudMessagingService.kt:43` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/onboarding/manualserver/ManualServerScreen.kt:113— app/src/main/kotlin/io/homeassistant/companion/android/onboarding/manualserver/ManualServerScreen.kt:113-123 | app/src/main/kotlin/io/homeassistant/companion/android/onboarding/nameyourdevice/NameYourDeviceScreen.kt:106-115 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/onboarding/manualserver/ManualServerScreen.kt:113` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) wear/src/main/kotlin/io/homeassistant/companion/android/home/views/DetailsPanelView.kt:219— wear/src/main/kotlin/io/homeassistant/companion/android/home/views/DetailsPanelView.kt:219-228 | wear/src/main/kotlin/io/homeassistant/companion/android/home/views/DetailsPanelView.kt:273-282 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `wear/src/main/kotlin/io/homeassistant/companion/android/home/views/DetailsPanelView.kt:219` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:613— common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:613-622 | common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:635-644 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:613` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Swallowed exception (caught, then discarded) app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:514— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:612— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) app/src/main/kotlin/io/homeassistant/companion/android/settings/notification/views/NotificationDetailView.kt:72— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) app/src/main/kotlin/io/homeassistant/companion/android/frontend/session/ServerSessionManager.kt:66— `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Duplicated block (8 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:2155— app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:2155-2162 | app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:2201-2208 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:2155` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/widgets/BaseWidgetProvider.kt:81— app/src/main/kotlin/io/homeassistant/companion/android/widgets/BaseWidgetProvider.kt:81-88 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidget.kt:101-108 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/BaseWidgetProvider.kt:81` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidget.kt:79— app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidget.kt:79-86 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidget.kt:232-239 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidget.kt:79` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:429— app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:429-435 | wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt:287-293 — before extracting anything, compare `app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: `AssistMessage` names `io.homeassistant.companion.android.assist.ui.AssistMessage` in one and `io.homeassistant.companion.android.conversation.views.AssistMessage` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidgetConfigureViewModel.kt:311— app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidgetConfigureViewModel.kt:311-317 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/todo/TodoWidgetConfigureViewModel.kt:225-231 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidgetConfigureViewModel.kt:311` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) wear/src/main/kotlin/io/homeassistant/companion/android/tiles/CameraTile.kt:77— wear/src/main/kotlin/io/homeassistant/companion/android/tiles/CameraTile.kt:77-83 | wear/src/main/kotlin/io/homeassistant/companion/android/tiles/ThermostatTile.kt:74-81 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `wear/src/main/kotlin/io/homeassistant/companion/android/tiles/CameraTile.kt:77` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×2
Members sharing a duplicated core (4 members, 50+ identical tokens) app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt:973— app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt:973-995 | app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt:999-1026 | app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt:1030-1053 | app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt:1057-1078 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:131— app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:131-187 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidgetConfigureScreen.kt:127-184 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidgetConfigureScreen.kt:111-163 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/todo/TodoWidgetConfigureScreen.kt:109-159 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Duplicated block (31 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:514— app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:514-544 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:612-642 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:514` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (31 lines × 2) wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SelectCameraTileView.kt:21— wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SelectCameraTileView.kt:21-51 | wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SelectThermostatTileView.kt:21-51 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `tiles` to `List<CameraTile>` in one and `List<ThermostatTile>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (21 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:146— app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:146-166 | wear/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:56-76 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:146` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:169` calls `addAction` and `wear/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:79` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (21 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/sensors/NotificationListenerSensorManager.kt:161— app/src/main/kotlin/io/homeassistant/companion/android/sensors/NotificationListenerSensorManager.kt:161-181 | app/src/main/kotlin/io/homeassistant/companion/android/sensors/NotificationListenerSensorManager.kt:200-220 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/sensors/NotificationListenerSensorManager.kt:161` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:445— app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:445-463 | wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt:299-317 — before extracting anything, compare `app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:445` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:464` calls `restartInactivityTimer` and `wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt:318` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (19 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:379— app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:379-397 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidgetConfigureScreen.kt:264-282 — before extracting anything, compare `app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt` and `app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidgetConfigureScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidgetConfigureScreen.kt:264` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/NetworkSensorManager.kt:454— common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/NetworkSensorManager.kt:454-469 | common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/NetworkSensorManager.kt:538-553 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/NetworkSensorManager.kt:454` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:347— app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:347-364 | wear/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:70-85 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:347` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) app/src/debug/kotlin/io/homeassistant/companion/android/developer/catalog/HAUserInputScreen.kt:110— app/src/debug/kotlin/io/homeassistant/companion/android/developer/catalog/HAUserInputScreen.kt:110-123 | app/src/debug/kotlin/io/homeassistant/companion/android/developer/catalog/HAUserInputScreen.kt:158-171 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/debug/kotlin/io/homeassistant/companion/android/developer/catalog/HAUserInputScreen.kt:110` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (14 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:132— app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:132-145 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidgetConfigureScreen.kt:128-141 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:132` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidgetConfigureScreen.kt:143` calls `fillMaxSize` and `app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:147` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (13 lines × 2) common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/PhoneStateSensorManager.kt:285— common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/PhoneStateSensorManager.kt:285-297 | common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/PhoneStateSensorManager.kt:329-341 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/PhoneStateSensorManager.kt:285` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:500— app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:500-512 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:596-608 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:500` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:467— app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:467-478 | wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt:319-330 — before extracting anything, compare `app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:464` calls `restartInactivityTimer` and `wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt:317` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 2) app/src/full/kotlin/io/homeassistant/companion/android/FullApplicationModule.kt:25— app/src/full/kotlin/io/homeassistant/companion/android/FullApplicationModule.kt:25-36 | wear/src/main/kotlin/io/homeassistant/companion/android/ApplicationModule.kt:43-54 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `wear/src/main/kotlin/io/homeassistant/companion/android/ApplicationModule.kt:56` calls `OptIn` and `app/src/full/kotlin/io/homeassistant/companion/android/FullApplicationModule.kt:38` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Low cohesion: MainViewModel (LCOM4 6) wear/src/main/kotlin/io/homeassistant/companion/android/home/MainViewModel.kt:49— MainViewModel's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: DeveloperSettingsFragment (LCOM4 4) app/src/main/kotlin/io/homeassistant/companion/android/settings/developer/DeveloperSettingsFragment.kt:28— DeveloperSettingsFragment's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
EntityKt.getIcon (cyclomatic 169) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:981— EntityKt.getIcon has cyclomatic complexity 169 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing. This file is where this pass's cyclomatic complexity CONCENTRATES: common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt holds 4 of the 41 methods over the threshold — including the worst — and 252 of the 700 points over it (36%), 2.1× the next-largest file (app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt at 119). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
FriendlyStateKt.stateResource (cyclomatic 104) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/FriendlyState.kt:76— FriendlyStateKt.stateResource has cyclomatic complexity 104 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
MessagingManager.handleMessage (cyclomatic 72) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:304— MessagingManager.handleMessage has cyclomatic complexity 72 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EntityKt.sensorIcon (cyclomatic 63) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:1323— EntityKt.sensorIcon has cyclomatic complexity 63 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing. This file is where this pass's cyclomatic complexity CONCENTRATES: common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt holds 4 of the 41 methods over the threshold — including the worst — and 252 of the 700 points over it (36%), 2.1× the next-largest file (app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt at 119). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
MessagingManager.handleDeviceCommands (cyclomatic 56) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:673— MessagingManager.handleDeviceCommands has cyclomatic complexity 56 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EntityKt.binarySensorIcon (cyclomatic 51) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:1244— EntityKt.binarySensorIcon has cyclomatic complexity 51 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This file is where this pass's cyclomatic complexity CONCENTRATES: common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt holds 4 of the 41 methods over the threshold — including the worst — and 252 of the 700 points over it (36%), 2.1× the next-largest file (app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt at 119). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
Migration16to17.migrate (cyclomatic 49) common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt:243— Migration16to17.migrate has cyclomatic complexity 49 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
SensorUpdater.syncSensorsWithServer (cyclomatic 42) common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorUpdater.kt:177— SensorUpdater.syncSensorsWithServer has cyclomatic complexity 42 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
SensorDetailViewKt.SensorDetailView (cyclomatic 37) app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt:100— SensorDetailViewKt.SensorDetailView has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ManageShortcutsViewKt.CreateShortcutView (cyclomatic 32) app/src/main/kotlin/io/homeassistant/companion/android/settings/shortcuts/legacy/views/ManageShortcutsView.kt:94— ManageShortcutsViewKt.CreateShortcutView has cyclomatic complexity 32 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
MessagingManager.addExtrasToIntent (cyclomatic 30) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:933— MessagingManager.addExtrasToIntent has cyclomatic complexity 30 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
EntityKt.coverIcon (cyclomatic 29) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:1274— EntityKt.coverIcon has cyclomatic complexity 29 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing. This file is where this pass's cyclomatic complexity CONCENTRATES: common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt holds 4 of the 41 methods over the threshold — including the worst — and 252 of the 700 points over it (36%), 2.1× the next-largest file (app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt at 119). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
WebSocketCoreImpl.handleEvent (cyclomatic 27) common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/impl/WebSocketCoreImpl.kt:915— WebSocketCoreImpl.handleEvent has cyclomatic complexity 27 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
FrontendMessageHandler.handleMessage (cyclomatic 27) app/src/main/kotlin/io/homeassistant/companion/android/frontend/handler/FrontendMessageHandler.kt:155— FrontendMessageHandler.handleMessage has cyclomatic complexity 27 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
HealthConnectSensorManager.requestSensorUpdate (cyclomatic 27) app/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthConnectSensorManager.kt:584— HealthConnectSensorManager.requestSensorUpdate has cyclomatic complexity 27 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
MediaPlayerControlsWidget.getWidgetRemoteViews (cyclomatic 27) app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:66— MediaPlayerControlsWidget.getWidgetRemoteViews has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ThreadManagerImpl.fullSyncPreferredDataset (cyclomatic 26) app/src/full/kotlin/io/homeassistant/companion/android/thread/ThreadManagerImpl.kt:87— ThreadManagerImpl.fullSyncPreferredDataset has cyclomatic complexity 26 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
LocationSensorManager.shouldEnableHighAccuracyMode (cyclomatic 24) app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:541— LocationSensorManager.shouldEnableHighAccuracyMode has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MainViewKt.MainView (cyclomatic 23) wear/src/main/kotlin/io/homeassistant/companion/android/home/views/MainView.kt:52— MainViewKt.MainView has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DeviceCommandsKt.commandBleTransmitter (cyclomatic 23) common/src/main/kotlin/io/homeassistant/companion/android/common/notifications/DeviceCommands.kt:124— DeviceCommandsKt.commandBleTransmitter has cyclomatic complexity 23 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
SettingsFragment.onCreatePreferences (cyclomatic 23) app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt:92— SettingsFragment.onCreatePreferences has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
WearToggleChip.entityToggleChipBackgroundColors (cyclomatic 21) wear/src/main/kotlin/io/homeassistant/companion/android/util/WearToggleChip.kt:36— WearToggleChip.entityToggleChipBackgroundColors has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
WearToggleChipColors.equals (cyclomatic 20) wear/src/main/kotlin/io/homeassistant/companion/android/util/WearToggleChip.kt:364— WearToggleChipColors.equals has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
IntegrationRepositoryImpl.registerSensor (cyclomatic 20) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/impl/IntegrationRepositoryImpl.kt:579— IntegrationRepositoryImpl.registerSensor has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
HealthServicesSensorManager.updateHealthServices (cyclomatic 19) wear/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthServicesSensorManager.kt:231— HealthServicesSensorManager.updateHealthServices has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This is NOT this file's highest cyclomatic complexity: HealthServicesSensorManager.getActivityIcon (cyclomatic 49) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
SensorManager.onSensorUpdated (cyclomatic 19) common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorManager.kt:319— SensorManager.onSensorUpdated has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
OnSwipeListener.onTouch (cyclomatic 19) app/src/main/kotlin/io/homeassistant/companion/android/util/OnSwipeListener.kt:39— OnSwipeListener.onTouch has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessagingManager.createOpenUriPendingIntent (cyclomatic 18) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1717— MessagingManager.createOpenUriPendingIntent has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessagingManager.notifyMissingPermission (cyclomatic 18) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:2154— MessagingManager.notifyMissingPermission has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
SettingsActivity.onCreate (cyclomatic 18) app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsActivity.kt:85— SettingsActivity.onCreate has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
LocationTrackingViewKt.LocationTrackingHistoryRow (cyclomatic 18) app/src/main/kotlin/io/homeassistant/companion/android/settings/developer/location/views/LocationTrackingView.kt:149— LocationTrackingViewKt.LocationTrackingHistoryRow has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
WidgetDynamicFieldAdapter.onBindViewHolder (cyclomatic 18) app/src/main/kotlin/io/homeassistant/companion/android/widgets/common/WidgetDynamicFieldAdapter.kt:44— WidgetDynamicFieldAdapter.onBindViewHolder has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
LocationSensorManager.refreshLocationTrackingSetup (cyclomatic 17) app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:313— LocationSensorManager.refreshLocationTrackingSetup has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
LocationSensorManager.handleGeoUpdate (cyclomatic 17) app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:782— LocationSensorManager.handleGeoUpdate has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ThermostatTile.onTileRequest (cyclomatic 16) wear/src/main/kotlin/io/homeassistant/companion/android/tiles/ThermostatTile.kt:68— ThermostatTile.onTileRequest has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NotificationManagerExtensionsKt.cancelNotificationGroupIfNeeded (cyclomatic 16) common/src/main/kotlin/io/homeassistant/companion/android/common/util/NotificationManagerExtensions.kt:43— NotificationManagerExtensionsKt.cancelNotificationGroupIfNeeded has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LocationSensorManager.sendLocationUpdate (cyclomatic 16) app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:883— LocationSensorManager.sendLocationUpdate has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HomeAssistantApplication.onCreate (cyclomatic 16) app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:89— HomeAssistantApplication.onCreate has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AssistViewModel.runAssistPipeline (cyclomatic 16) app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:428— AssistViewModel.runAssistPipeline has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CarSensorManager.setListener (cyclomatic 16) app/src/main/kotlin/io/homeassistant/companion/android/sensors/CarSensorManager.kt:381— CarSensorManager.setListener has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SensorDetailFragment.onViewCreated (cyclomatic 16) app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/SensorDetailFragment.kt:95— SensorDetailFragment.onViewCreated has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
EntityKt.getIcon (cognitive 116) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:981— EntityKt.getIcon has cognitive complexity 116 (threshold 15). Drivers by points: if/else 43 (76 pts), match/switch 12 (40 pts) (nesting depth added 61). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessagingManager.handleMessage (cognitive 101) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:304— MessagingManager.handleMessage has cognitive complexity 101 (threshold 15). Drivers by points: if/else 38 (71 pts), boolean chains 21, match/switch 3 (6 pts), error handling 1 (3 pts) (nesting depth added 38). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FriendlyStateKt.stateResource (cognitive 84) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/FriendlyState.kt:76— FriendlyStateKt.stateResource has cognitive complexity 84 (threshold 15). Drivers by points: if/else 41 (79 pts), match/switch 3 (5 pts) (nesting depth added 40). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
MessagingManager.handleDeviceCommands (cognitive 73) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:673— MessagingManager.handleDeviceCommands has cognitive complexity 73 (threshold 15). Drivers by points: if/else 35 (54 pts), match/switch 6 (14 pts), boolean chains 3, error handling 1 (2 pts) (nesting depth added 28). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
EntityKt.binarySensorIcon (cognitive 71) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:1244— EntityKt.binarySensorIcon has cognitive complexity 71 (threshold 15). Drivers by points: if/else 47 (70 pts), match/switch 1 (nesting depth added 23). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
ThreadManagerImpl.fullSyncPreferredDataset (cognitive 71) app/src/full/kotlin/io/homeassistant/companion/android/thread/ThreadManagerImpl.kt:87— ThreadManagerImpl.fullSyncPreferredDataset has cognitive complexity 71 (threshold 15). Drivers by points: error handling 10 (36 pts), if/else 17 (30 pts), boolean chains 5 (nesting depth added 39). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SensorUpdater.syncSensorsWithServer (cognitive 64) common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorUpdater.kt:177— SensorUpdater.syncSensorsWithServer has cognitive complexity 64 (threshold 15). Drivers by points: if/else 18 (28 pts), boolean chains 18, error handling 10 (18 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ManageShortcutsViewKt.CreateShortcutView (cognitive 61) app/src/main/kotlin/io/homeassistant/companion/android/settings/shortcuts/legacy/views/ManageShortcutsView.kt:94— ManageShortcutsViewKt.CreateShortcutView has cognitive complexity 61 (threshold 15). Drivers by points: if/else 31 (41 pts), loops 3 (8 pts), boolean chains 7, match/switch 1 (5 pts) (nesting depth added 19). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MediaPlayerControlsWidget.getWidgetRemoteViews (cognitive 59) app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:66— MediaPlayerControlsWidget.getWidgetRemoteViews has cognitive complexity 59 (threshold 15). Drivers by points: if/else 25 (40 pts), error handling 4 (10 pts), boolean chains 6, match/switch 1 (3 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MainViewKt.MainView (cognitive 53) wear/src/main/kotlin/io/homeassistant/companion/android/home/views/MainView.kt:52— MainViewKt.MainView has cognitive complexity 53 (threshold 15). Drivers by points: if/else 17 (41 pts), loops 2 (7 pts), boolean chains 3, match/switch 1 (2 pts) (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Migration16to17.migrate (cognitive 48) common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt:243— Migration16to17.migrate has cognitive complexity 48 (threshold 15). Drivers by points: boolean chains 24, if/else 23, error handling 1. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
NotificationManagerExtensionsKt.cancelNotificationGroupIfNeeded (cognitive 45) common/src/main/kotlin/io/homeassistant/companion/android/common/util/NotificationManagerExtensions.kt:43— NotificationManagerExtensionsKt.cancelNotificationGroupIfNeeded has cognitive complexity 45 (threshold 15). Drivers by points: if/else 17 (40 pts), boolean chains 5 (nesting depth added 23). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
SensorDetailViewKt.SensorDetailView (cognitive 42) app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt:100— SensorDetailViewKt.SensorDetailView has cognitive complexity 42 (threshold 15). Drivers by points: if/else 16 (26 pts), match/switch 4 (11 pts), boolean chains 5 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ThermostatTile.onTileRequest (cognitive 37) wear/src/main/kotlin/io/homeassistant/companion/android/tiles/ThermostatTile.kt:68— ThermostatTile.onTileRequest has cognitive complexity 37 (threshold 15). Drivers by points: if/else 15 (27 pts), error handling 2 (6 pts), boolean chains 3, match/switch 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WearToggleChip.entityToggleChipBackgroundColors (cognitive 35) wear/src/main/kotlin/io/homeassistant/companion/android/util/WearToggleChip.kt:36— WearToggleChip.entityToggleChipBackgroundColors has cognitive complexity 35 (threshold 15). Drivers by points: if/else 17 (24 pts), match/switch 4 (8 pts), boolean chains 3 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SettingsFragment.onCreatePreferences (cognitive 35) app/src/main/kotlin/io/homeassistant/companion/android/settings/SettingsFragment.kt:92— SettingsFragment.onCreatePreferences has cognitive complexity 35 (threshold 15). Drivers by points: if/else 16 (24 pts), boolean chains 5, error handling 1 (4 pts), match/switch 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocationSensorManager.shouldEnableHighAccuracyMode (cognitive 34) app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:541— LocationSensorManager.shouldEnableHighAccuracyMode has cognitive complexity 34 (threshold 15). Drivers by points: if/else 13 (23 pts), boolean chains 10, match/switch 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WebSocketCoreImpl.handleEvent (cognitive 33) common/src/main/kotlin/io/homeassistant/companion/android/common/data/websocket/impl/WebSocketCoreImpl.kt:915— WebSocketCoreImpl.handleEvent has cognitive complexity 33 (threshold 15). Drivers by points: if/else 19 (25 pts), match/switch 2 (5 pts), error handling 2, boolean chains 1 (nesting depth added 9). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
LocationSensorManager.setupBackgroundLocation (cognitive 32) app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:374— LocationSensorManager.setupBackgroundLocation has cognitive complexity 32 (threshold 15). Drivers by points: if/else 13 (27 pts), boolean chains 5 (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
IntegrationRepositoryImpl.registerSensor (cognitive 31) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/impl/IntegrationRepositoryImpl.kt:579— IntegrationRepositoryImpl.registerSensor has cognitive complexity 31 (threshold 15). Drivers by points: if/else 22 (27 pts), boolean chains 3, match/switch 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
LocationSensorManager.handleGeoUpdate (cognitive 31) app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:782— LocationSensorManager.handleGeoUpdate has cognitive complexity 31 (threshold 15). Drivers by points: if/else 15 (23 pts), error handling 1 (3 pts), match/switch 2 (3 pts), loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OnSwipeListener.onTouch (cognitive 30) app/src/main/kotlin/io/homeassistant/companion/android/util/OnSwipeListener.kt:39— OnSwipeListener.onTouch has cognitive complexity 30 (threshold 15). Drivers by points: if/else 10 (23 pts), loops 2 (4 pts), boolean chains 2, match/switch 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WidgetDynamicFieldAdapter.onBindViewHolder (cognitive 30) app/src/main/kotlin/io/homeassistant/companion/android/widgets/common/WidgetDynamicFieldAdapter.kt:44— WidgetDynamicFieldAdapter.onBindViewHolder has cognitive complexity 30 (threshold 15). Drivers by points: if/else 16 (21 pts), boolean chains 5, error handling 2 (4 pts) (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
TileExtensions.setTileData (cognitive 29) app/src/main/kotlin/io/homeassistant/companion/android/qs/TileExtensions.kt:145— TileExtensions.setTileData has cognitive complexity 29 (threshold 15). Drivers by points: if/else 13 (19 pts), error handling 2 (4 pts), boolean chains 3, match/switch 1 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SensorReceiverBase.onReceive (cognitive 28) common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorReceiverBase.kt:73— SensorReceiverBase.onReceive has cognitive complexity 28 (threshold 15). Drivers by points: if/else 9 (16 pts), error handling 2 (8 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConversationViewModel.onCreate (cognitive 27) wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt:65— ConversationViewModel.onCreate has cognitive complexity 27 (threshold 15). Drivers by points: if/else 11 (14 pts), error handling 4 (12 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
LocationSensorManager.sendLocationUpdate (cognitive 27) app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:883— LocationSensorManager.sendLocationUpdate has cognitive complexity 27 (threshold 15). Drivers by points: if/else 16 (23 pts), boolean chains 3, error handling 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EntityGridVehicleScreen.createEntityGrid (cognitive 27) app/src/main/kotlin/io/homeassistant/companion/android/vehicle/EntityGridVehicleScreen.kt:139— EntityGridVehicleScreen.createEntityGrid has cognitive complexity 27 (threshold 15). Drivers by points: if/else 11 (14 pts), error handling 2 (8 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 11). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
EntityKt.coverIcon (cognitive 26) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:1274— EntityKt.coverIcon has cognitive complexity 26 (threshold 15). Drivers by points: if/else 11 (13 pts), match/switch 7 (13 pts) (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
HealthConnectSensorManager.requestSensorUpdate (cognitive 26) app/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthConnectSensorManager.kt:584— HealthConnectSensorManager.requestSensorUpdate has cognitive complexity 26 (threshold 15). Drivers by points: if/else 26. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ManageControlsViewKt.ManageControlsView (cognitive 26) app/src/main/kotlin/io/homeassistant/companion/android/settings/controls/views/ManageControlsView.kt:71— ManageControlsViewKt.ManageControlsView has cognitive complexity 26 (threshold 15). Drivers by points: if/else 11 (20 pts), boolean chains 6 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SensorDetailViewKt.SensorDetailTopPanel (cognitive 26) app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt:373— SensorDetailViewKt.SensorDetailTopPanel has cognitive complexity 26 (threshold 15). Drivers by points: if/else 19 (24 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
CameraWidget.getWidgetRemoteViews (cognitive 26) app/src/main/kotlin/io/homeassistant/companion/android/widgets/camera/CameraWidget.kt:107— CameraWidget.getWidgetRemoteViews has cognitive complexity 26 (threshold 15). Drivers by points: error handling 4 (12 pts), if/else 9 (12 pts), match/switch 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessagingManager.createOpenUriPendingIntent (cognitive 25) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1717— MessagingManager.createOpenUriPendingIntent has cognitive complexity 25 (threshold 15). Drivers by points: if/else 12 (17 pts), boolean chains 5, error handling 1 (2 pts), match/switch 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocationTrackingViewKt.LocationTrackingHistoryRow (cognitive 24) app/src/main/kotlin/io/homeassistant/companion/android/settings/developer/location/views/LocationTrackingView.kt:149— LocationTrackingViewKt.LocationTrackingHistoryRow has cognitive complexity 24 (threshold 15). Drivers by points: if/else 18, boolean chains 4, match/switch 2. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
EntityKt.sensorIcon (cognitive 23) common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/Entity.kt:1323— EntityKt.sensorIcon has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (12 pts), match/switch 3 (10 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConversationViewModel.setPipeline (cognitive 22) wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt:198— ConversationViewModel.setPipeline has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (11 pts), error handling 4 (8 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CameraTile.onTileResourcesRequest (cognitive 22) wear/src/main/kotlin/io/homeassistant/companion/android/tiles/CameraTile.kt:115— CameraTile.onTileResourcesRequest has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (18 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TileExtensions.tileClicked (cognitive 22) app/src/main/kotlin/io/homeassistant/companion/android/qs/TileExtensions.kt:211— TileExtensions.tileClicked has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (17 pts), boolean chains 3, error handling 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CarSensorManager.setListener (cognitive 22) app/src/main/kotlin/io/homeassistant/companion/android/sensors/CarSensorManager.kt:381— CarSensorManager.setListener has cognitive complexity 22 (threshold 15). Drivers by points: if/else 15 (21 pts), match/switch 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ButtonWidget.callConfiguredAction (cognitive 22) app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidget.kt:264— ButtonWidget.callConfiguredAction has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (16 pts), error handling 2 (4 pts), boolean chains 2 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
WebsocketManager.collectNotifications (cognitive 21) app/src/main/kotlin/io/homeassistant/companion/android/websocket/WebsocketManager.kt:204— WebsocketManager.collectNotifications has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 2 (7 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IBeaconMonitor.setBeacons (cognitive 20) common/src/main/kotlin/io/homeassistant/companion/android/common/bluetooth/ble/IBeaconMonitor.kt:43— IBeaconMonitor.setBeacons has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 3, boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessagingManager.handleActions (cognitive 20) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1617— MessagingManager.handleActions has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (15 pts), match/switch 1 (3 pts), boolean chains 1, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CarSensorManager.requestSensorUpdate (cognitive 20) app/src/main/kotlin/io/homeassistant/companion/android/sensors/CarSensorManager.kt:346— CarSensorManager.requestSensorUpdate has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (14 pts), match/switch 1 (5 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ButtonWidgetConfigureActivity.onCreate (cognitive 20) app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidgetConfigureActivity.kt:212— ButtonWidgetConfigureActivity.onCreate has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13 (15 pts), boolean chains 3, error handling 2 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
WearToggleChipColors.equals (cognitive 19) wear/src/main/kotlin/io/homeassistant/companion/android/util/WearToggleChip.kt:364— WearToggleChipColors.equals has cognitive complexity 19 (threshold 15). Drivers by points: if/else 19. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SensorDetailViewModel.setEnabled (cognitive 19) app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/SensorDetailViewModel.kt:227— SensorDetailViewModel.setEnabled has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 3, error handling 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CameraWidgetConfigureActivity.onCreate (cognitive 19) app/src/main/kotlin/io/homeassistant/companion/android/widgets/camera/CameraWidgetConfigureActivity.kt:62— CameraWidgetConfigureActivity.onCreate has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 3, error handling 2 (3 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
SensorUiKt.SensorUi (cognitive 18) wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SensorUi.kt:59— SensorUiKt.SensorUi has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (11 pts), boolean chains 7 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
HealthServicesSensorManager.updateHealthServices (cognitive 18) wear/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthServicesSensorManager.kt:231— HealthServicesSensorManager.updateHealthServices has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (14 pts), boolean chains 3, match/switch 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DeviceCommandsKt.commandBleTransmitter (cognitive 18) common/src/main/kotlin/io/homeassistant/companion/android/common/notifications/DeviceCommands.kt:124— DeviceCommandsKt.commandBleTransmitter has cognitive complexity 18 (threshold 15). Drivers by points: match/switch 4 (10 pts), if/else 8 (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
HomeAssistantApplication.onCreate (cognitive 18) app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:89— HomeAssistantApplication.onCreate has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 5, loops 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AssistActivity.onCreate (cognitive 18) app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistActivity.kt:83— AssistActivity.onCreate has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (17 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
NfcSetupActivity.onNewIntent (cognitive 18) app/src/main/kotlin/io/homeassistant/companion/android/nfc/NfcSetupActivity.kt:103— NfcSetupActivity.onNewIntent has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (12 pts), error handling 2 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SensorDetailFragment.onViewCreated (cognitive 18) app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/SensorDetailFragment.kt:95— SensorDetailFragment.onViewCreated has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 4, match/switch 2 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
PhoneStateSensorManager.updateSimSensor (cognitive 17) common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/PhoneStateSensorManager.kt:232— PhoneStateSensorManager.updateSimSensor has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (13 pts), error handling 1 (3 pts), match/switch 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivitySensorManager.requestSensorUpdate (cognitive 17) app/src/full/kotlin/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt:249— ActivitySensorManager.requestSensorUpdate has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (7 pts), boolean chains 4, error handling 2 (4 pts), match/switch 1 (2 pts) (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HaMediaSession.buildMediaButtonPreferences (cognitive 17) app/src/main/kotlin/io/homeassistant/companion/android/mediacontrols/HaMediaSession.kt:243— HaMediaSession.buildMediaButtonPreferences has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (11 pts), match/switch 3 (6 pts) (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
EntityWidget.resolveTextToShow (cognitive 17) app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidget.kt:148— EntityWidget.resolveTextToShow has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8, error handling 5 (7 pts), boolean chains 2 (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
BluetoothSensorManager.updateBLESensor (cognitive 16) common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/BluetoothSensorManager.kt:449— BluetoothSensorManager.updateBLESensor has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (11 pts), boolean chains 5 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
LocationSensorManager.refreshLocationTrackingSetup (cognitive 16) app/src/full/kotlin/io/homeassistant/companion/android/sensors/LocationSensorManager.kt:313— LocationSensorManager.refreshLocationTrackingSetup has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8, boolean chains 7, error handling 1. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
AssistSheetKt.SpeechBubble (cognitive 16) app/src/main/kotlin/io/homeassistant/companion/android/assist/ui/AssistSheet.kt:563— AssistSheetKt.SpeechBubble has cognitive complexity 16 (threshold 15). Drivers by points: if/else 14, match/switch 2. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
MessagingManager.notifyMissingPermission (cognitive 16) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:2154— MessagingManager.notifyMissingPermission has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (9 pts), match/switch 1 (5 pts), loops 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DeveloperSettingsPresenterImpl.runThreadDebug (cognitive 16) app/src/main/kotlin/io/homeassistant/companion/android/settings/developer/DeveloperSettingsPresenterImpl.kt:69— DeveloperSettingsPresenterImpl.runThreadDebug has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 2, error handling 1, match/switch 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SensorDetailViewModel.getSettingEntries (cognitive 16) app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/SensorDetailViewModel.kt:525— SensorDetailViewModel.getSettingEntries has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (11 pts), match/switch 2 (3 pts), boolean chains 2 (nesting depth added 5). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
SensorDetailViewKt.SensorDetailRow (cognitive 16) app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt:536— SensorDetailViewKt.SensorDetailRow has cognitive complexity 16 (threshold 15). Drivers by points: if/else 13 (16 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
SsidViewKt.SsidView (cognitive 16) app/src/main/kotlin/io/homeassistant/companion/android/settings/ssid/views/SsidView.kt:68— SsidViewKt.SsidView has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11, boolean chains 5. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D4 · Code Duplication· Near-duplicate member family (5 members, 28 shared lines) · ×1
Near-duplicate member family (5 members, 28 shared lines) app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:463— app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:463-496 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:559-592 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:657-690 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:692-725 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:727-760 — These 5 members are variants of one another: a block of 28 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
Near-duplicate member pair (38 shared lines) app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:428— app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:428-495 | wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt:286-337 — These two members are variants of one another: 38 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Duplicated block (49 lines × 2) wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SetCameraTileView.kt:42— wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SetCameraTileView.kt:42-90 | wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SetThermostatTileView.kt:47-95 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SetCameraTileView.kt:42` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: `DEFAULT_REFRESH_INTERVAL` names `io.homeassistant.companion.android.tiles.CameraTile.Companion.DEFAULT_REFRESH_INTERVAL` in one and `io.homeassistant.companion.android.tiles.ThermostatTile.Companion.DEFAULT_REFRESH_INTERVAL` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (45 lines × 2) wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/OnboardingPresenterImpl.kt:44— wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/OnboardingPresenterImpl.kt:44-88 | wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/manual/ManualSetupPresenterImpl.kt:36-80 — before extracting anything, compare `wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/OnboardingPresenterImpl.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/manual/ManualSetupPresenterImpl.kt` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/manual/ManualSetupPresenterImpl.kt:36` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (40 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:231— app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:231-270 | wear/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:88-127 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:231` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (26–27 lines × 3) app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureViewModel.kt:213— app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureViewModel.kt:213-238 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidgetConfigureViewModel.kt:169-195 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidgetConfigureViewModel.kt:152-177 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (24 lines × 3) app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:136— app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:136-159 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidgetConfigureScreen.kt:116-139 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/todo/TodoWidgetConfigureScreen.kt:114-137 — before extracting anything, compare `app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt` and `app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidgetConfigureScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:136` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (19–20 lines × 2) wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/OnboardingPresenterImpl.kt:124— wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/OnboardingPresenterImpl.kt:124-143 | wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/manual/ManualSetupPresenterImpl.kt:83-101 — before extracting anything, compare `wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/OnboardingPresenterImpl.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/manual/ManualSetupPresenterImpl.kt` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (17 lines × 4) app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt:979— app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt:979-995 | app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt:1010-1026 | app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt:1037-1053 | app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt:1062-1078 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt:979` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 5) app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:478— app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:478-493 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:574-589 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:672-687 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:707-722 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:742-757 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:478` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 3) app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureViewModel.kt:250— app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureViewModel.kt:250-265 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidgetConfigureViewModel.kt:189-204 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/todo/TodoWidgetConfigureViewModel.kt:175-191 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureViewModel.kt:250` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (15 lines × 2) app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearFavoritesView.kt:73— app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearFavoritesView.kt:73-87 | app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearLandingView.kt:54-68 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearFavoritesView.kt:73` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearFavoritesView.kt:72` calls `dismiss` and `app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearLandingView.kt:53` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14–15 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidget.kt:135— app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidget.kt:135-148 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/camera/CameraWidget.kt:226-240 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidget.kt:135` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (12–13 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:409— app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:409-421 | wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt:271-282 — before extracting anything, compare `app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt` and `wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:409` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `AssistMessage` names `io.homeassistant.companion.android.assist.ui.AssistMessage` in one and `io.homeassistant.companion.android.conversation.views.AssistMessage` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:423` calls `restartInactivityTimer` and `wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt:283` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1048— app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1048-1058 | wear/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:115-125 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1048` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1059` calls `isAtLeast` and `wear/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:126` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7–9 lines × 2) wear/src/main/kotlin/io/homeassistant/companion/android/tiles/TileViews.kt:82— wear/src/main/kotlin/io/homeassistant/companion/android/tiles/TileViews.kt:82-90 | wear/src/main/kotlin/io/homeassistant/companion/android/tiles/TileViews.kt:170-176 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidget.kt:68— app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidget.kt:68-76 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidget.kt:70-78 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (12 lines × 3) app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:249— app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:249-260 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidgetConfigureScreen.kt:171-182 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/todo/TodoWidgetConfigureScreen.kt:198-209 — before extracting anything, compare `app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt` and `app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidgetConfigureScreen.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureScreen.kt:249` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 2) common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt:124— common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt:124-141 | common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt:176-193 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt:124` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt:143` calls `execSQL` and `common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt:194` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 7) app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:464— app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:464-475 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:499-510 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:560-571 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:595-606 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:658-669 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:693-704 | app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt:728-739 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
P3 · Security & performance tooling· SAST runs, but gates no merge · ×1
SAST runs, but gates no merge — `REDACTED` run(s) a static-analysis scan, but no workflow that runs one is triggered by a pull request (or a merge queue, or an unfiltered push) — the scan fires on a schedule or a manual dispatch only. A vulnerable change therefore merges clean and is reported on the next scheduled run, by which time it is on the default branch and the only remedy is a follow-up fix. Add the pull-request trigger to the workflow that runs the scan so the finding arrives before the merge rather than after it.
Sync-over-async blocking wear/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthServicesSensorManager.kt:231— `updateHealthServices` is async and calls runBlocking — a blocking call inside async code stalls the coroutine's thread, and every coroutine dispatched to it for as long as it runs.
Swallowed exception (empty catch) common/src/main/kotlin/io/homeassistant/companion/android/common/data/HomeAssistantApis.kt:100— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Orphaned file wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SettingsView.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file app/src/main/kotlin/io/homeassistant/companion/android/widgets/common/WidgetDynamicFieldAdapter.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/SettingsWearActivity.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file common/src/main/kotlin/io/homeassistant/companion/android/common/bluetooth/ble/TransmitterManager.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file app/src/debug/kotlin/io/homeassistant/companion/android/developer/catalog/HATextAndBannersScreen.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file common/src/main/kotlin/io/homeassistant/companion/android/common/util/tts/TextToSpeechClient.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearLandingView.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearTemplateTile.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file app/src/main/kotlin/io/homeassistant/companion/android/util/ForegroundServiceLauncher.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearOnboardingView.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearTemplateTileList.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SelectShortcutsTileView.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file common/src/main/kotlin/io/homeassistant/companion/android/common/util/tts/AndroidTextToSpeechEngine.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file common/src/main/kotlin/io/homeassistant/companion/android/common/bluetooth/ble/IBeaconMonitor.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/manual/ManualSetupActivity.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file app/src/main/kotlin/io/homeassistant/companion/android/widgets/WidgetAppearanceDropdowns.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/integration/MobileAppIntegrationActivity.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file wear/src/main/kotlin/io/homeassistant/companion/android/theme/Color.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file wear/src/main/kotlin/io/homeassistant/companion/android/onboarding/ServerListAdapter.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file app/src/main/kotlin/io/homeassistant/companion/android/widgets/common/SingleItemArrayAdapter.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file common/src/main/kotlin/io/homeassistant/companion/android/common/bluetooth/BluetoothUtils.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file common/src/main/kotlin/io/homeassistant/companion/android/common/util/tts/TextToSpeech.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file wear/src/main/kotlin/io/homeassistant/companion/android/views/ExpandableListHeader.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SelectThermostatTileView.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SelectTemplateTileView.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Duplicated predicate app/src/full/kotlin/io/homeassistant/companion/android/matter/MatterManagerImpl.kt:34— `!serverManager.isRegistered() || serverManager.getServer(serverId)?.user?.isAdmin != true` appears character-identically in 2 files — app/src/full/kotlin/io/homeassistant/companion/android/matter/MatterManagerImpl.kt, app/src/full/kotlin/io/homeassistant/companion/android/thread/ThreadManagerImpl.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/full/kotlin/io/homeassistant/companion/android/matter/MatterManagerImpl.kt:30— `SdkVersion.isAtLeast(Build.VERSION_CODES.O_MR1) && !isAutomotive` appears character-identically in 2 files — app/src/full/kotlin/io/homeassistant/companion/android/matter/MatterManagerImpl.kt, app/src/full/kotlin/io/homeassistant/companion/android/thread/ThreadManagerImpl.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt:100— `SdkVersion.isAtLeast(Build.VERSION_CODES.S) && BuildConfig.DEBUG && !BuildConfig.NO_STRICT_MODE` appears character-identically in 2 files — app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt, wear/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidgetConfigureActivity.kt:238— `appWidgetId == AppWidgetManager.INVALID_APPWIDGET_ID && !requestLauncherSetup` appears character-identically in 2 files — app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidgetConfigureActivity.kt, app/src/main/kotlin/io/homeassistant/companion/android/widgets/camera/CameraWidgetConfigureActivity.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/assist/wakeword/WakeWordListener.kt:94— `cause != null && cause !is CancellationException` appears character-identically in 2 files — app/src/main/kotlin/io/homeassistant/companion/android/assist/wakeword/WakeWordListener.kt, app/src/main/kotlin/io/homeassistant/companion/android/mediacontrols/HaRemoteMediaPlayer.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate common/src/main/kotlin/io/homeassistant/companion/android/common/data/prefs/PrefsRepositoryImpl.kt:67— `currentVersion == null || currentVersion < 1` appears character-identically in 2 files — common/src/main/kotlin/io/homeassistant/companion/android/common/data/prefs/PrefsRepositoryImpl.kt, common/src/main/kotlin/io/homeassistant/companion/android/common/data/prefs/WearPrefsRepositoryImpl.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidgetConfigureActivity.kt:110— `hasFocus && view is AutoCompleteTextView` appears character-identically in 3 files — app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidgetConfigureActivity.kt, app/src/main/kotlin/io/homeassistant/companion/android/widgets/camera/CameraWidgetConfigureActivity.kt, app/src/main/kotlin/io/homeassistant/companion/android/widgets/common/WidgetDynamicFieldAdapter.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:401— `inputMode == AssistInputMode.VOICE_ACTIVE && proactive == false` appears character-identically in 2 files — app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt, wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt:460— `isError && inputMode == AssistInputMode.VOICE_ACTIVE` appears character-identically in 2 files — app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt, wear/src/main/kotlin/io/homeassistant/companion/android/conversation/ConversationViewModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/LightSensorManager.kt:81— `listenerLastRegistered + SensorManager.SENSOR_LISTENER_TIMEOUT < now && isListenerRegistered` appears character-identically in 4 files — common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/LightSensorManager.kt, common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/PressureSensorManager.kt, common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/ProximitySensorManager.kt, common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/StepsSensorManager.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/vehicle/DomainListScreen.kt:69— `newDomains.size != domains.size || newDomains != domains || !domainsAdded` appears character-identically in 2 files — app/src/main/kotlin/io/homeassistant/companion/android/vehicle/DomainListScreen.kt, app/src/main/kotlin/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt:1061— `notification != null && notification.isGroup` appears character-identically in 2 files — app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt, wear/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/vehicle/LoginScreen.kt:27— `serverManager.isRegistered() && serverManager.authenticationRepository() .getSessionState() == SessionState.CONNECTED` appears character-identically in 2 files — app/src/main/kotlin/io/homeassistant/companion/android/vehicle/LoginScreen.kt, app/src/main/kotlin/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchViewModel.kt:263— `serverManager.isRegistered() && serverManager.authenticationRepository().getSessionState() == SessionState.CONNECTED` appears character-identically in 2 files — app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchViewModel.kt, wear/src/main/kotlin/io/homeassistant/companion/android/home/HomePresenterImpl.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate wear/src/main/kotlin/io/homeassistant/companion/android/tiles/CameraTile.kt:80— `tileConfig?.refreshInterval != null && tileConfig.refreshInterval!! <= 1` appears character-identically in 2 files — wear/src/main/kotlin/io/homeassistant/companion/android/tiles/CameraTile.kt, wear/src/main/kotlin/io/homeassistant/companion/android/tiles/ThermostatTile.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidget.kt:186— `widget?.backgroundType == WidgetBackgroundType.DYNAMICCOLOR && DynamicColors.isDynamicColorAvailable()` appears character-identically in 4 files — app/src/main/kotlin/io/homeassistant/companion/android/widgets/button/ButtonWidget.kt, app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidget.kt, app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidget.kt, app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidget.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureViewModel.kt:271— `widgetId != AppWidgetManager.INVALID_APPWIDGET_ID && _state.value.selectedEntityId == null` appears character-identically in 2 files — app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureViewModel.kt, app/src/main/kotlin/io/homeassistant/companion/android/widgets/todo/TodoWidgetConfigureViewModel.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureActivity.kt:54— `widgetId == AppWidgetManager.INVALID_APPWIDGET_ID && !requestLauncherSetup` appears character-identically in 4 files — app/src/main/kotlin/io/homeassistant/companion/android/widgets/entity/EntityWidgetConfigureActivity.kt, app/src/main/kotlin/io/homeassistant/companion/android/widgets/mediaplayer/MediaPlayerControlsWidgetConfigureActivity.kt, app/src/main/kotlin/io/homeassistant/companion/android/widgets/template/TemplateWidgetConfigureActivity.kt, app/src/main/kotlin/io/homeassistant/companion/android/widgets/todo/TodoWidgetConfigureActivity.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
DM2 · Strongly-typed ids· Primitive id on a domain type · ×11
Primitive id on a domain type: LocationHistoryItem.serverId common/src/main/kotlin/io/homeassistant/companion/android/database/location/LocationHistoryItem.kt:34— `LocationHistoryItem.serverId` is a raw `Int` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int`, in whatever form your language spells that.
Primitive id on a domain type: MediaControlsConfig.serverId common/src/main/kotlin/io/homeassistant/companion/android/database/mediacontrol/MediaControlsConfig.kt:10— `MediaControlsConfig.serverId` is a raw `Int` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int`, in whatever form your language spells that.
Primitive id on a domain type: MediaControlsConfig.entityId common/src/main/kotlin/io/homeassistant/companion/android/database/mediacontrol/MediaControlsConfig.kt:12— `MediaControlsConfig.entityId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: NotificationItem.serverId common/src/main/kotlin/io/homeassistant/companion/android/database/notification/NotificationItem.kt:20— `NotificationItem.serverId` is a raw `Int` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int`, in whatever form your language spells that.
Primitive id on a domain type: Attribute.sensorId common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Attribute.kt:9— `Attribute.sensorId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: Sensor.serverId common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/Sensor.kt:11— `Sensor.serverId` is a raw `Int` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int`, in whatever form your language spells that.
Primitive id on a domain type: SensorSetting.sensorId common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/SensorSetting.kt:25— `SensorSetting.sensorId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: Server.deviceRegistryId common/src/main/kotlin/io/homeassistant/companion/android/database/server/Server.kt:24— `Server.deviceRegistryId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: CameraTile.entityId common/src/main/kotlin/io/homeassistant/companion/android/database/wear/CameraTile.kt:19— `CameraTile.entityId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: EntityStateComplications.entityId common/src/main/kotlin/io/homeassistant/companion/android/database/wear/EntityStateComplications.kt:16— `EntityStateComplications.entityId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: ThermostatTile.entityId common/src/main/kotlin/io/homeassistant/companion/android/database/wear/ThermostatTile.kt:19— `ThermostatTile.entityId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Silent fallback default on parse failure common/src/main/kotlin/io/homeassistant/companion/android/database/location/LocationHistoryItem.kt:61— `fromStringToList` answers `emptyList()` when `SerializationException` is thrown, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
Silent fallback default on parse failure common/src/main/kotlin/io/homeassistant/companion/android/database/location/LocationHistoryItem.kt:69— `fromListToString` answers `""` when `SerializationException` is thrown, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 108 significant file(s) lose their only recent owner: app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendViewModel.kt, app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt, common/src/main/kotlin/io/homeassistant/companion/android/database/migration/DatabaseMigration.kt, common/src/main/kotlin/io/homeassistant/companion/android/common/data/integration/display/EntitiesForDisplayManager.kt, app/src/main/kotlin/io/homeassistant/companion/android/onboarding/OnboardingNavigation.kt, common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorUpdater.kt, app/src/main/kotlin/io/homeassistant/companion/android/onboarding/serverdiscovery/ServerDiscoveryScreen.kt, app/src/main/kotlin/io/homeassistant/companion/android/settings/assist/AssistSettingsScreen.kt (+100 more). Pair on, review, or document these before any departure.
D16 · Bus Factor· Further sole-owners (lower concentration) · ×1
Further sole-owners (lower concentration) — 1 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (110 single-owned of 503 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 503 of the 957 production source files in this repository met that bar). They are anonymized user #2 (1 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: common/src/main/kotlin/io/homeassistant/companion/android/common/data/servers/ConnectionAvailabilityMonitor.kt.
Documentation: no build, run or usage example README.md:1— the repository holds project manifests and neither `README.md` nor the documents it links hold a code block or a command. Show the command that builds or runs it, or a usage snippet.
No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion — 3 of 9 project(s) overshoot their size bounds, lowering Project Cohesion to 3.3/10. The most over is `app` (67040 LoC, 1184 module-visible types across 149 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D34 · Knowledge Freshness· Orphaned files with no living knowledge · ×1
Orphaned files with no living knowledge — 25 of 503 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 503 of the 957 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — most significant first: wear/src/main/kotlin/io/homeassistant/companion/android/home/views/SettingsView.kt, app/src/main/kotlin/io/homeassistant/companion/android/widgets/common/WidgetDynamicFieldAdapter.kt, app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/SettingsWearActivity.kt, common/src/main/kotlin/io/homeassistant/companion/android/common/bluetooth/ble/TransmitterManager.kt, app/src/debug/kotlin/io/homeassistant/companion/android/developer/catalog/HATextAndBannersScreen.kt, common/src/main/kotlin/io/homeassistant/companion/android/common/util/tts/TextToSpeechClient.kt, app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearLandingView.kt, app/src/full/kotlin/io/homeassistant/companion/android/settings/wear/views/SettingsWearTemplateTile.kt (and 17 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
X2 · Cancellation propagation· Not all suspend functions that make a request accept the coroutine's cancellation · ×1
Not all suspend functions that make a request accept the coroutine's cancellation — Only 0/5 suspend functions that make a cancellable request (Ktor, OkHttp newCall, URL streams) accept the coroutine's cancellation or pass one on, so a request keeps running after whatever wanted it has given up — a screen navigated away from, a disposed widget, a superseded search. In a suspend function, make the request with a call that suspends — Ktor, OkHttp's `executeAsync()`, or a `suspendCancellableCoroutine` that cancels the `Call` — not a blocking `execute()`: `withContext(Dispatchers.IO)` moves the call off the caller's thread but does not make it cancellable; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
Outdated: fastlane — `fastlane` is resolved to 2.241.1 in the committed Gemfile.lock but 2.241.2 is the current release on rubygems.org, and Gemfile declares no version requirement for it, so nothing but the lockfile is holding it back. This build is therefore missing every fix published since, including any security fix. Run `bundle update fastlane` and commit the updated Gemfile.lock.
Off the main sequence: home-assistant-android:common — home-assistant-android:common: abstractness 0.15, instability 0.00, distance 0.85 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 38 file(s) — `app/src/main/kotlin/io/homeassistant/companion/android/assist/AssistViewModel.kt`, `app/src/main/kotlin/io/homeassistant/companion/android/assist/wakeword/WakeWordListener.kt`, `app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendScreen.kt`, `app/src/main/kotlin/io/homeassistant/companion/android/frontend/error/ErrorAction.kt`, `app/src/main/kotlin/io/homeassistant/companion/android/frontend/improv/BluetoothCapabilities.kt`, … (+33 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a17a03-8519-73d7-a540-52365ebe4451 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 44 · Warnings: 351 · Recommendations: 68 · Info: 2 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 26-10-2026 @ 21:00 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.