Public report of paradigmxyz/reth, published 27 October 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 27 October 2026, 23:03 UTC · Survey ID cd_2441bbaaaa8d4accb86f33dee8d000d3
paradigmxyz/reth
Measured 27 October 2026, 22:58 UTC, at code version f1cc50e
No regression since the last survey
A regression is a drop of 0.5 points or more in the score, or of 2.5 or more out of 10 in a dimension, since the last survey.
CAI scoreAt riskNo change since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A large codebase: 399,415 lines of product code in 116 projects, tests not counted · Estimated rebuild effort: about 2.9 person-years · Weakest lens: Production Readiness, 45
Findings by how serious they are
33 critical1012 serious130 minor
13 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
27 October 2026, 22:58 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that
implements it, and today Watchdog is the only one that does.
A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.
The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
71of 71 dimensions measured by tools.
1090of 1175 findings point to an exact file and line, so you can open each one in the code. The other 85 concern the repository as a whole, such as missing documentation.
71dimensions across 7 lenses, read from 399,415 lines of product code in 116 projects.
paradigmxyz/reth is rated At risk because critical security findings are open, most of them in its servers and containers. Its score is held back in part because it has packages under a licence on your banned list. It scores 61 out of 100, which the At risk rating leaves unchanged.
Production Readiness, at 45, is the weakest lens and counts most in the score. The best first step is replacing the five packages under a banned licence, worth about 14 points. Documenting the recovery plan comes next, worth about 7 points. Raising Production Readiness to 70 would lift the score to about 72.
Fifteen settings leave the servers or containers unsafe. Five pipeline steps run downloads nobody checks, and five packages carry licence risk. Correcting the unsafe settings, checking each download against a checksum and replacing or clearing the banned-licence packages would close these risks. Correcting the flagged pipeline settings would fix the three weaknesses in the build pipeline's configuration, and updating the vulnerable packages would deal with the package with a known security hole. The piece of product code that depends on test code needs its reference to the test project removed.
The product code is 399,415 lines, about €430,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Outbound HTTP resilience · Outbound HTTP without resilience crates/cli/commands/src/download/source.rs
Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 50 findings
These 50 critical or serious findings were in the previous survey, on 13 October 2026, and are gone from this one.
€140,000 to €710,000, for 2,369 to 7,517 hours of work, about 2.9 person-years for 1 to 6 engineers
Difficulty of the problem
Low, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.8 at a score of 61. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Large: 399,415 lines of product code
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 5 Banned license finding(s) in License Compliance.
Codify backups + geo-recovery in IaC and document RTO/RPO and the restore procedure — a persistence guard alone is not disaster recovery.
Raises the score by about 7 points · Medium effort · DR & Backup
3
Give every client a whole-request bound: `reqwest::Client::builder().timeout(Duration::from_secs(10))` (never `reqwest::get` or `Client::new()`, which have none), ureq's `timeout_global`, or wrap the call in `tokio::time::timeout`; add retry with back-off (`reqwest-retry`'s `RetryTransientMiddleware`, `backoff`) around dependencies that fail.
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €430,000 to build again, about 2.9 person-years of work. Its weakest lens is Production Readiness, at 45 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 5 Banned license finding(s) in License Compliance. Of all the actions in this report, it raises the score most for the work it takes: about 14 points for low effort, because it clears the 5 License Compliance findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
944 modules, with 2786 dependencies between them. 15 loops run through 269 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 904 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
reth_chain_state.in_memory uses reth_ipc.client, so a change to reth_ipc.client can break reth_chain_state.in_memory, while a change to reth_chain_state.in_memory can't break reth_ipc.client.
Position
Below the diagonal: reth_chain_state.in_memory uses a module listed above it, which is the healthy direction.
reth_chain_state.in_memory uses reth_trie_common.hashed_state, so a change to reth_trie_common.hashed_state can break reth_chain_state.in_memory, while a change to reth_chain_state.in_memory can't break reth_trie_common.hashed_state.
Position
Below the diagonal: reth_chain_state.in_memory uses a module listed above it, which is the healthy direction.
reth_chain_state.in_memory uses reth_trie_common.updates, so a change to reth_trie_common.updates can break reth_chain_state.in_memory, while a change to reth_chain_state.in_memory can't break reth_trie_common.updates.
Position
Below the diagonal: reth_chain_state.in_memory uses a module listed above it, which is the healthy direction.
reth_chainspec.spec uses reth_era.e2s.types, so a change to reth_era.e2s.types can break reth_chainspec.spec, while a change to reth_chainspec.spec can't break reth_era.e2s.types.
Position
Below the diagonal: reth_chainspec.spec uses a module listed above it, which is the healthy direction.
reth_chainspec.spec uses reth_network_peers.node_record, so a change to reth_network_peers.node_record can break reth_chainspec.spec, while a change to reth_chainspec.spec can't break reth_network_peers.node_record.
Position
Below the diagonal: reth_chainspec.spec uses a module listed above it, which is the healthy direction.
14→40 reth_db.implementation.mdbx uses reth_cli_commands.commonpart of a loop✕
Connections
1 pair of types, where a type in reth_db.implementation.mdbx uses a type in reth_cli_commands.common.
reth_db.implementation.mdbx uses reth_cli_commands.common, so a change to reth_cli_commands.common can break reth_db.implementation.mdbx, while a change to reth_db.implementation.mdbx can't break reth_cli_commands.common.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
reth_evm.execute uses reth_trie_common.bundle_state.bundle_state, so a change to reth_trie_common.bundle_state.bundle_state can break reth_evm.execute, while a change to reth_evm.execute can't break reth_trie_common.bundle_state.bundle_state.
Position
Below the diagonal: reth_evm.execute uses a module listed above it, which is the healthy direction.
reth_evm.execute uses reth_trie_common.hashed_state, so a change to reth_trie_common.hashed_state can break reth_evm.execute, while a change to reth_evm.execute can't break reth_trie_common.hashed_state.
Position
Below the diagonal: reth_evm.execute uses a module listed above it, which is the healthy direction.
reth_evm.execute uses reth_trie_common.updates, so a change to reth_trie_common.updates can break reth_evm.execute, while a change to reth_evm.execute can't break reth_trie_common.updates.
Position
Below the diagonal: reth_evm.execute uses a module listed above it, which is the healthy direction.
15→20 reth_evm.execute uses reth_engine_tree.tree.txpool_prewarmpart of a loop✕
Connections
2 pairs of types, where a type in reth_evm.execute uses a type in reth_engine_tree.tree.txpool_prewarm.
reth_evm.execute uses reth_engine_tree.tree.txpool_prewarm, so a change to reth_engine_tree.tree.txpool_prewarm can break reth_evm.execute, while a change to reth_evm.execute can't break reth_engine_tree.tree.txpool_prewarm.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
reth_prune_types.segment uses reth_db_api.table, so a change to reth_db_api.table can break reth_prune_types.segment, while a change to reth_prune_types.segment can't break reth_db_api.table.
Position
Below the diagonal: reth_prune_types.segment uses a module listed above it, which is the healthy direction.
reth_storage_overlay.provider uses reth_trie_common.bundle_state.bundle_state, so a change to reth_trie_common.bundle_state.bundle_state can break reth_storage_overlay.provider, while a change to reth_storage_overlay.provider can't break reth_trie_common.bundle_state.bundle_state.
Position
Below the diagonal: reth_storage_overlay.provider uses a module listed above it, which is the healthy direction.
reth_storage_overlay.provider uses reth_trie_common.hashed_state, so a change to reth_trie_common.hashed_state can break reth_storage_overlay.provider, while a change to reth_storage_overlay.provider can't break reth_trie_common.hashed_state.
Position
Below the diagonal: reth_storage_overlay.provider uses a module listed above it, which is the healthy direction.
18→20 reth_tasks.runtime uses reth_engine_tree.tree.txpool_prewarmpart of a loop✕
Connections
3 pairs of types, where a type in reth_tasks.runtime uses a type in reth_engine_tree.tree.txpool_prewarm.
reth_tasks.runtime uses reth_engine_tree.tree.txpool_prewarm, so a change to reth_engine_tree.tree.txpool_prewarm can break reth_tasks.runtime, while a change to reth_tasks.runtime can't break reth_engine_tree.tree.txpool_prewarm.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
reth_engine_tree.tree uses reth_ipc.client, so a change to reth_ipc.client can break reth_engine_tree.tree, while a change to reth_engine_tree.tree can't break reth_ipc.client.
Position
Below the diagonal: reth_engine_tree.tree uses a module listed above it, which is the healthy direction.
reth_engine_tree.tree uses reth_chain_state.in_memory, so a change to reth_chain_state.in_memory can break reth_engine_tree.tree, while a change to reth_engine_tree.tree can't break reth_chain_state.in_memory.
Position
Below the diagonal: reth_engine_tree.tree uses a module listed above it, which is the healthy direction.
reth_engine_tree.tree uses reth_tasks.runtime, so a change to reth_tasks.runtime can break reth_engine_tree.tree, while a change to reth_engine_tree.tree can't break reth_tasks.runtime.
Position
Below the diagonal: reth_engine_tree.tree uses a module listed above it, which is the healthy direction.
reth_engine_tree.tree.txpool_prewarm uses reth_evm.execute, so a change to reth_evm.execute can break reth_engine_tree.tree.txpool_prewarm, while a change to reth_engine_tree.tree.txpool_prewarm can't break reth_evm.execute.
Position
Below the diagonal: reth_engine_tree.tree.txpool_prewarm uses a module listed above it, which is the healthy direction.
reth_engine_tree.tree.txpool_prewarm uses reth_storage_overlay.provider, so a change to reth_storage_overlay.provider can break reth_engine_tree.tree.txpool_prewarm, while a change to reth_engine_tree.tree.txpool_prewarm can't break reth_storage_overlay.provider.
Position
Below the diagonal: reth_engine_tree.tree.txpool_prewarm uses a module listed above it, which is the healthy direction.
reth_engine_tree.tree.txpool_prewarm uses reth_tasks.runtime, so a change to reth_tasks.runtime can break reth_engine_tree.tree.txpool_prewarm, while a change to reth_engine_tree.tree.txpool_prewarm can't break reth_tasks.runtime.
Position
Below the diagonal: reth_engine_tree.tree.txpool_prewarm uses a module listed above it, which is the healthy direction.
reth_network.session uses reth_ipc.client, so a change to reth_ipc.client can break reth_network.session, while a change to reth_network.session can't break reth_ipc.client.
Position
Below the diagonal: reth_network.session uses a module listed above it, which is the healthy direction.
reth_network.session uses reth_tasks.runtime, so a change to reth_tasks.runtime can break reth_network.session, while a change to reth_network.session can't break reth_tasks.runtime.
Position
Below the diagonal: reth_network.session uses a module listed above it, which is the healthy direction.
reth_prune_types.mode uses reth_prune_types.segment, so a change to reth_prune_types.segment can break reth_prune_types.mode, while a change to reth_prune_types.mode can't break reth_prune_types.segment.
Position
Below the diagonal: reth_prune_types.mode uses a module listed above it, which is the healthy direction.
reth_storage_rpc_provider uses reth_ipc.client, so a change to reth_ipc.client can break reth_storage_rpc_provider, while a change to reth_storage_rpc_provider can't break reth_ipc.client.
Position
Below the diagonal: reth_storage_rpc_provider uses a module listed above it, which is the healthy direction.
reth_storage_rpc_provider uses reth_network.state, so a change to reth_network.state can break reth_storage_rpc_provider, while a change to reth_storage_rpc_provider can't break reth_network.state.
Position
Below the diagonal: reth_storage_rpc_provider uses a module listed above it, which is the healthy direction.
reth_storage_rpc_provider uses reth_stages_types.id, so a change to reth_stages_types.id can break reth_storage_rpc_provider, while a change to reth_storage_rpc_provider can't break reth_stages_types.id.
Position
Below the diagonal: reth_storage_rpc_provider uses a module listed above it, which is the healthy direction.
reth_storage_rpc_provider uses reth_trie_common.bundle_state.bundle_state, so a change to reth_trie_common.bundle_state.bundle_state can break reth_storage_rpc_provider, while a change to reth_storage_rpc_provider can't break reth_trie_common.bundle_state.bundle_state.
Position
Below the diagonal: reth_storage_rpc_provider uses a module listed above it, which is the healthy direction.
reth_storage_rpc_provider uses reth_trie_common.hashed_state, so a change to reth_trie_common.hashed_state can break reth_storage_rpc_provider, while a change to reth_storage_rpc_provider can't break reth_trie_common.hashed_state.
Position
Below the diagonal: reth_storage_rpc_provider uses a module listed above it, which is the healthy direction.
reth_storage_rpc_provider uses reth_chain_state.in_memory, so a change to reth_chain_state.in_memory can break reth_storage_rpc_provider, while a change to reth_storage_rpc_provider can't break reth_chain_state.in_memory.
Position
Below the diagonal: reth_storage_rpc_provider uses a module listed above it, which is the healthy direction.
reth_storage_rpc_provider uses reth_chainspec.spec, so a change to reth_chainspec.spec can break reth_storage_rpc_provider, while a change to reth_storage_rpc_provider can't break reth_chainspec.spec.
Position
Below the diagonal: reth_storage_rpc_provider uses a module listed above it, which is the healthy direction.
reth_storage_rpc_provider uses reth_prune_types.segment, so a change to reth_prune_types.segment can break reth_storage_rpc_provider, while a change to reth_storage_rpc_provider can't break reth_prune_types.segment.
Position
Below the diagonal: reth_storage_rpc_provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.static_file.manager uses reth_network.state, so a change to reth_network.state can break reth_provider.providers.static_file.manager, while a change to reth_provider.providers.static_file.manager can't break reth_network.state.
Position
Below the diagonal: reth_provider.providers.static_file.manager uses a module listed above it, which is the healthy direction.
reth_provider.providers.static_file.manager uses reth_prune_types.segment, so a change to reth_prune_types.segment can break reth_provider.providers.static_file.manager, while a change to reth_provider.providers.static_file.manager can't break reth_prune_types.segment.
Position
Below the diagonal: reth_provider.providers.static_file.manager uses a module listed above it, which is the healthy direction.
reth_provider.providers.static_file.manager uses reth_tasks.runtime, so a change to reth_tasks.runtime can break reth_provider.providers.static_file.manager, while a change to reth_provider.providers.static_file.manager can't break reth_tasks.runtime.
Position
Below the diagonal: reth_provider.providers.static_file.manager uses a module listed above it, which is the healthy direction.
reth_provider.providers.static_file.manager uses reth_prune_types.mode, so a change to reth_prune_types.mode can break reth_provider.providers.static_file.manager, while a change to reth_provider.providers.static_file.manager can't break reth_prune_types.mode.
Position
Below the diagonal: reth_provider.providers.static_file.manager uses a module listed above it, which is the healthy direction.
reth_transaction_pool.traits uses reth_ipc.client, so a change to reth_ipc.client can break reth_transaction_pool.traits, while a change to reth_transaction_pool.traits can't break reth_ipc.client.
Position
Below the diagonal: reth_transaction_pool.traits uses a module listed above it, which is the healthy direction.
reth_transaction_pool.traits uses reth_engine_tree.tree.txpool_prewarm, so a change to reth_engine_tree.tree.txpool_prewarm can break reth_transaction_pool.traits, while a change to reth_transaction_pool.traits can't break reth_engine_tree.tree.txpool_prewarm.
Position
Below the diagonal: reth_transaction_pool.traits uses a module listed above it, which is the healthy direction.
reth_provider.providers.database.provider uses reth_db_api.table, so a change to reth_db_api.table can break reth_provider.providers.database.provider, while a change to reth_provider.providers.database.provider can't break reth_db_api.table.
Position
Below the diagonal: reth_provider.providers.database.provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.database.provider uses reth_network.state, so a change to reth_network.state can break reth_provider.providers.database.provider, while a change to reth_provider.providers.database.provider can't break reth_network.state.
Position
Below the diagonal: reth_provider.providers.database.provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.database.provider uses reth_stages_types.id, so a change to reth_stages_types.id can break reth_provider.providers.database.provider, while a change to reth_provider.providers.database.provider can't break reth_stages_types.id.
Position
Below the diagonal: reth_provider.providers.database.provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.database.provider uses reth_trie_common.bundle_state.bundle_state, so a change to reth_trie_common.bundle_state.bundle_state can break reth_provider.providers.database.provider, while a change to reth_provider.providers.database.provider can't break reth_trie_common.bundle_state.bundle_state.
Position
Below the diagonal: reth_provider.providers.database.provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.database.provider uses reth_trie_common.hashed_state, so a change to reth_trie_common.hashed_state can break reth_provider.providers.database.provider, while a change to reth_provider.providers.database.provider can't break reth_trie_common.hashed_state.
Position
Below the diagonal: reth_provider.providers.database.provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.database.provider uses reth_trie_common.updates, so a change to reth_trie_common.updates can break reth_provider.providers.database.provider, while a change to reth_provider.providers.database.provider can't break reth_trie_common.updates.
Position
Below the diagonal: reth_provider.providers.database.provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.database.provider uses reth_chainspec.spec, so a change to reth_chainspec.spec can break reth_provider.providers.database.provider, while a change to reth_provider.providers.database.provider can't break reth_chainspec.spec.
Position
Below the diagonal: reth_provider.providers.database.provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.database.provider uses reth_prune_types.segment, so a change to reth_prune_types.segment can break reth_provider.providers.database.provider, while a change to reth_provider.providers.database.provider can't break reth_prune_types.segment.
Position
Below the diagonal: reth_provider.providers.database.provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.database.provider uses reth_tasks.runtime, so a change to reth_tasks.runtime can break reth_provider.providers.database.provider, while a change to reth_provider.providers.database.provider can't break reth_tasks.runtime.
Position
Below the diagonal: reth_provider.providers.database.provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.database.provider uses reth_provider.providers.static_file.manager, so a change to reth_provider.providers.static_file.manager can break reth_provider.providers.database.provider, while a change to reth_provider.providers.database.provider can't break reth_provider.providers.static_file.manager.
Position
Below the diagonal: reth_provider.providers.database.provider uses a module listed above it, which is the healthy direction.
reth_storage_api.noop uses reth_network.state, so a change to reth_network.state can break reth_storage_api.noop, while a change to reth_storage_api.noop can't break reth_network.state.
Position
Below the diagonal: reth_storage_api.noop uses a module listed above it, which is the healthy direction.
reth_storage_api.noop uses reth_stages_types.id, so a change to reth_stages_types.id can break reth_storage_api.noop, while a change to reth_storage_api.noop can't break reth_stages_types.id.
Position
Below the diagonal: reth_storage_api.noop uses a module listed above it, which is the healthy direction.
reth_storage_api.noop uses reth_trie_common.bundle_state.bundle_state, so a change to reth_trie_common.bundle_state.bundle_state can break reth_storage_api.noop, while a change to reth_storage_api.noop can't break reth_trie_common.bundle_state.bundle_state.
Position
Below the diagonal: reth_storage_api.noop uses a module listed above it, which is the healthy direction.
reth_storage_api.noop uses reth_trie_common.hashed_state, so a change to reth_trie_common.hashed_state can break reth_storage_api.noop, while a change to reth_storage_api.noop can't break reth_trie_common.hashed_state.
Position
Below the diagonal: reth_storage_api.noop uses a module listed above it, which is the healthy direction.
reth_storage_api.noop uses reth_chain_state.in_memory, so a change to reth_chain_state.in_memory can break reth_storage_api.noop, while a change to reth_storage_api.noop can't break reth_chain_state.in_memory.
Position
Below the diagonal: reth_storage_api.noop uses a module listed above it, which is the healthy direction.
reth_storage_api.noop uses reth_chainspec.spec, so a change to reth_chainspec.spec can break reth_storage_api.noop, while a change to reth_storage_api.noop can't break reth_chainspec.spec.
Position
Below the diagonal: reth_storage_api.noop uses a module listed above it, which is the healthy direction.
reth_storage_api.noop uses reth_prune_types.segment, so a change to reth_prune_types.segment can break reth_storage_api.noop, while a change to reth_storage_api.noop can't break reth_prune_types.segment.
Position
Below the diagonal: reth_storage_api.noop uses a module listed above it, which is the healthy direction.
reth_storage_api.noop uses reth_provider.providers.static_file.manager, so a change to reth_provider.providers.static_file.manager can break reth_storage_api.noop, while a change to reth_storage_api.noop can't break reth_provider.providers.static_file.manager.
Position
Below the diagonal: reth_storage_api.noop uses a module listed above it, which is the healthy direction.
reth_transaction_pool uses reth_ipc.client, so a change to reth_ipc.client can break reth_transaction_pool, while a change to reth_transaction_pool can't break reth_ipc.client.
Position
Below the diagonal: reth_transaction_pool uses a module listed above it, which is the healthy direction.
reth_transaction_pool uses reth_engine_tree.tree.txpool_prewarm, so a change to reth_engine_tree.tree.txpool_prewarm can break reth_transaction_pool, while a change to reth_transaction_pool can't break reth_engine_tree.tree.txpool_prewarm.
Position
Below the diagonal: reth_transaction_pool uses a module listed above it, which is the healthy direction.
reth_transaction_pool uses reth_transaction_pool.traits, so a change to reth_transaction_pool.traits can break reth_transaction_pool, while a change to reth_transaction_pool can't break reth_transaction_pool.traits.
Position
Below the diagonal: reth_transaction_pool uses a module listed above it, which is the healthy direction.
reth_network.transactions uses reth_ipc.client, so a change to reth_ipc.client can break reth_network.transactions, while a change to reth_network.transactions can't break reth_ipc.client.
Position
Below the diagonal: reth_network.transactions uses a module listed above it, which is the healthy direction.
reth_network.transactions uses reth_transaction_pool.traits, so a change to reth_transaction_pool.traits can break reth_network.transactions, while a change to reth_network.transactions can't break reth_transaction_pool.traits.
Position
Below the diagonal: reth_network.transactions uses a module listed above it, which is the healthy direction.
reth_network.transactions uses reth_transaction_pool, so a change to reth_transaction_pool can break reth_network.transactions, while a change to reth_network.transactions can't break reth_transaction_pool.
Position
Below the diagonal: reth_network.transactions uses a module listed above it, which is the healthy direction.
29→33 reth_network.transactions uses reth_network.networkpart of a loop✕
Connections
1 pair of types, where a type in reth_network.transactions uses a type in reth_network.network.
reth_network.transactions uses reth_network.network, so a change to reth_network.network can break reth_network.transactions, while a change to reth_network.transactions can't break reth_network.network.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
reth_node_core.node_config uses reth_config.config, so a change to reth_config.config can break reth_node_core.node_config, while a change to reth_node_core.node_config can't break reth_config.config.
Position
Below the diagonal: reth_node_core.node_config uses a module listed above it, which is the healthy direction.
reth_node_core.node_config uses reth_chainspec.spec, so a change to reth_chainspec.spec can break reth_node_core.node_config, while a change to reth_node_core.node_config can't break reth_chainspec.spec.
Position
Below the diagonal: reth_node_core.node_config uses a module listed above it, which is the healthy direction.
reth_node_core.node_config uses reth_transaction_pool, so a change to reth_transaction_pool can break reth_node_core.node_config, while a change to reth_node_core.node_config can't break reth_transaction_pool.
Position
Below the diagonal: reth_node_core.node_config uses a module listed above it, which is the healthy direction.
reth_provider.providers.database uses reth_network.state, so a change to reth_network.state can break reth_provider.providers.database, while a change to reth_provider.providers.database can't break reth_network.state.
Position
Below the diagonal: reth_provider.providers.database uses a module listed above it, which is the healthy direction.
reth_provider.providers.database uses reth_stages_types.id, so a change to reth_stages_types.id can break reth_provider.providers.database, while a change to reth_provider.providers.database can't break reth_stages_types.id.
Position
Below the diagonal: reth_provider.providers.database uses a module listed above it, which is the healthy direction.
reth_provider.providers.database uses reth_chainspec.spec, so a change to reth_chainspec.spec can break reth_provider.providers.database, while a change to reth_provider.providers.database can't break reth_chainspec.spec.
Position
Below the diagonal: reth_provider.providers.database uses a module listed above it, which is the healthy direction.
reth_provider.providers.database uses reth_db.implementation.mdbx, so a change to reth_db.implementation.mdbx can break reth_provider.providers.database, while a change to reth_provider.providers.database can't break reth_db.implementation.mdbx.
Position
Below the diagonal: reth_provider.providers.database uses a module listed above it, which is the healthy direction.
reth_provider.providers.database uses reth_prune_types.segment, so a change to reth_prune_types.segment can break reth_provider.providers.database, while a change to reth_provider.providers.database can't break reth_prune_types.segment.
Position
Below the diagonal: reth_provider.providers.database uses a module listed above it, which is the healthy direction.
reth_provider.providers.database uses reth_tasks.runtime, so a change to reth_tasks.runtime can break reth_provider.providers.database, while a change to reth_provider.providers.database can't break reth_tasks.runtime.
Position
Below the diagonal: reth_provider.providers.database uses a module listed above it, which is the healthy direction.
reth_provider.providers.database uses reth_provider.providers.static_file.manager, so a change to reth_provider.providers.static_file.manager can break reth_provider.providers.database, while a change to reth_provider.providers.database can't break reth_provider.providers.static_file.manager.
Position
Below the diagonal: reth_provider.providers.database uses a module listed above it, which is the healthy direction.
reth_provider.providers.database uses reth_provider.providers.database.provider, so a change to reth_provider.providers.database.provider can break reth_provider.providers.database, while a change to reth_provider.providers.database can't break reth_provider.providers.database.provider.
Position
Below the diagonal: reth_provider.providers.database uses a module listed above it, which is the healthy direction.
reth_rpc.eth.core uses reth_ipc.client, so a change to reth_ipc.client can break reth_rpc.eth.core, while a change to reth_rpc.eth.core can't break reth_ipc.client.
Position
Below the diagonal: reth_rpc.eth.core uses a module listed above it, which is the healthy direction.
reth_rpc.eth.core uses reth_evm.execute, so a change to reth_evm.execute can break reth_rpc.eth.core, while a change to reth_rpc.eth.core can't break reth_evm.execute.
Position
Below the diagonal: reth_rpc.eth.core uses a module listed above it, which is the healthy direction.
reth_rpc.eth.core uses reth_tasks.runtime, so a change to reth_tasks.runtime can break reth_rpc.eth.core, while a change to reth_rpc.eth.core can't break reth_tasks.runtime.
Position
Below the diagonal: reth_rpc.eth.core uses a module listed above it, which is the healthy direction.
reth_rpc.eth.core uses reth_engine_tree.tree.txpool_prewarm, so a change to reth_engine_tree.tree.txpool_prewarm can break reth_rpc.eth.core, while a change to reth_rpc.eth.core can't break reth_engine_tree.tree.txpool_prewarm.
Position
Below the diagonal: reth_rpc.eth.core uses a module listed above it, which is the healthy direction.
reth_rpc.eth.core uses reth_transaction_pool.traits, so a change to reth_transaction_pool.traits can break reth_rpc.eth.core, while a change to reth_rpc.eth.core can't break reth_transaction_pool.traits.
Position
Below the diagonal: reth_rpc.eth.core uses a module listed above it, which is the healthy direction.
reth_rpc.eth.core uses reth_transaction_pool, so a change to reth_transaction_pool can break reth_rpc.eth.core, while a change to reth_rpc.eth.core can't break reth_transaction_pool.
Position
Below the diagonal: reth_rpc.eth.core uses a module listed above it, which is the healthy direction.
32→35 reth_rpc.eth.core uses reth_node_builder.rpcpart of a loop✕
Connections
1 pair of types, where a type in reth_rpc.eth.core uses a type in reth_node_builder.rpc.
reth_rpc.eth.core uses reth_node_builder.rpc, so a change to reth_node_builder.rpc can break reth_rpc.eth.core, while a change to reth_rpc.eth.core can't break reth_node_builder.rpc.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
reth_network.network uses reth_network_peers.node_record, so a change to reth_network_peers.node_record can break reth_network.network, while a change to reth_network.network can't break reth_network_peers.node_record.
Position
Below the diagonal: reth_network.network uses a module listed above it, which is the healthy direction.
reth_network.network uses reth_network.transactions, so a change to reth_network.transactions can break reth_network.network, while a change to reth_network.network can't break reth_network.transactions.
Position
Below the diagonal: reth_network.network uses a module listed above it, which is the healthy direction.
reth_node_builder.launch.common uses reth_config.config, so a change to reth_config.config can break reth_node_builder.launch.common, while a change to reth_node_builder.launch.common can't break reth_config.config.
Position
Below the diagonal: reth_node_builder.launch.common uses a module listed above it, which is the healthy direction.
reth_node_builder.launch.common uses reth_chainspec.spec, so a change to reth_chainspec.spec can break reth_node_builder.launch.common, while a change to reth_node_builder.launch.common can't break reth_chainspec.spec.
Position
Below the diagonal: reth_node_builder.launch.common uses a module listed above it, which is the healthy direction.
reth_node_builder.launch.common uses reth_provider.providers.static_file.manager, so a change to reth_provider.providers.static_file.manager can break reth_node_builder.launch.common, while a change to reth_node_builder.launch.common can't break reth_provider.providers.static_file.manager.
Position
Below the diagonal: reth_node_builder.launch.common uses a module listed above it, which is the healthy direction.
reth_node_builder.launch.common uses reth_transaction_pool, so a change to reth_transaction_pool can break reth_node_builder.launch.common, while a change to reth_node_builder.launch.common can't break reth_transaction_pool.
Position
Below the diagonal: reth_node_builder.launch.common uses a module listed above it, which is the healthy direction.
reth_node_builder.launch.common uses reth_node_core.node_config, so a change to reth_node_core.node_config can break reth_node_builder.launch.common, while a change to reth_node_builder.launch.common can't break reth_node_core.node_config.
Position
Below the diagonal: reth_node_builder.launch.common uses a module listed above it, which is the healthy direction.
reth_node_builder.launch.common uses reth_provider.providers.database, so a change to reth_provider.providers.database can break reth_node_builder.launch.common, while a change to reth_node_builder.launch.common can't break reth_provider.providers.database.
Position
Below the diagonal: reth_node_builder.launch.common uses a module listed above it, which is the healthy direction.
reth_node_builder.rpc uses reth_ipc.client, so a change to reth_ipc.client can break reth_node_builder.rpc, while a change to reth_node_builder.rpc can't break reth_ipc.client.
Position
Below the diagonal: reth_node_builder.rpc uses a module listed above it, which is the healthy direction.
reth_node_builder.rpc uses reth_engine_tree.tree.txpool_prewarm, so a change to reth_engine_tree.tree.txpool_prewarm can break reth_node_builder.rpc, while a change to reth_node_builder.rpc can't break reth_engine_tree.tree.txpool_prewarm.
Position
Below the diagonal: reth_node_builder.rpc uses a module listed above it, which is the healthy direction.
reth_node_builder.rpc uses reth_transaction_pool, so a change to reth_transaction_pool can break reth_node_builder.rpc, while a change to reth_node_builder.rpc can't break reth_transaction_pool.
Position
Below the diagonal: reth_node_builder.rpc uses a module listed above it, which is the healthy direction.
reth_node_builder.rpc uses reth_node_core.node_config, so a change to reth_node_core.node_config can break reth_node_builder.rpc, while a change to reth_node_builder.rpc can't break reth_node_core.node_config.
Position
Below the diagonal: reth_node_builder.rpc uses a module listed above it, which is the healthy direction.
reth_node_builder.rpc uses reth_rpc.eth.core, so a change to reth_rpc.eth.core can break reth_node_builder.rpc, while a change to reth_node_builder.rpc can't break reth_rpc.eth.core.
Position
Below the diagonal: reth_node_builder.rpc uses a module listed above it, which is the healthy direction.
35→38 reth_node_builder.rpc uses reth_rpc_builderpart of a loop✕
Connections
8 pairs of types, where a type in reth_node_builder.rpc uses a type in reth_rpc_builder.
reth_node_builder.rpc uses reth_rpc_builder, so a change to reth_rpc_builder can break reth_node_builder.rpc, while a change to reth_node_builder.rpc can't break reth_rpc_builder.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
35→39 reth_node_builder.rpc uses reth_node_builder.nodepart of a loop✕
Connections
2 pairs of types, where a type in reth_node_builder.rpc uses a type in reth_node_builder.node.
reth_node_builder.rpc uses reth_node_builder.node, so a change to reth_node_builder.node can break reth_node_builder.rpc, while a change to reth_node_builder.rpc can't break reth_node_builder.node.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
reth_provider.providers.blockchain_provider uses reth_network.state, so a change to reth_network.state can break reth_provider.providers.blockchain_provider, while a change to reth_provider.providers.blockchain_provider can't break reth_network.state.
Position
Below the diagonal: reth_provider.providers.blockchain_provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.blockchain_provider uses reth_stages_types.id, so a change to reth_stages_types.id can break reth_provider.providers.blockchain_provider, while a change to reth_provider.providers.blockchain_provider can't break reth_stages_types.id.
Position
Below the diagonal: reth_provider.providers.blockchain_provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.blockchain_provider uses reth_chain_state.in_memory, so a change to reth_chain_state.in_memory can break reth_provider.providers.blockchain_provider, while a change to reth_provider.providers.blockchain_provider can't break reth_chain_state.in_memory.
Position
Below the diagonal: reth_provider.providers.blockchain_provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.blockchain_provider uses reth_chainspec.spec, so a change to reth_chainspec.spec can break reth_provider.providers.blockchain_provider, while a change to reth_provider.providers.blockchain_provider can't break reth_chainspec.spec.
Position
Below the diagonal: reth_provider.providers.blockchain_provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.blockchain_provider uses reth_prune_types.segment, so a change to reth_prune_types.segment can break reth_provider.providers.blockchain_provider, while a change to reth_provider.providers.blockchain_provider can't break reth_prune_types.segment.
Position
Below the diagonal: reth_provider.providers.blockchain_provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.blockchain_provider uses reth_provider.providers.static_file.manager, so a change to reth_provider.providers.static_file.manager can break reth_provider.providers.blockchain_provider, while a change to reth_provider.providers.blockchain_provider can't break reth_provider.providers.static_file.manager.
Position
Below the diagonal: reth_provider.providers.blockchain_provider uses a module listed above it, which is the healthy direction.
reth_provider.providers.blockchain_provider uses reth_provider.providers.database, so a change to reth_provider.providers.database can break reth_provider.providers.blockchain_provider, while a change to reth_provider.providers.blockchain_provider can't break reth_provider.providers.database.
Position
Below the diagonal: reth_provider.providers.blockchain_provider uses a module listed above it, which is the healthy direction.
reth_node_builder.builder uses reth_chainspec.spec, so a change to reth_chainspec.spec can break reth_node_builder.builder, while a change to reth_node_builder.builder can't break reth_chainspec.spec.
Position
Below the diagonal: reth_node_builder.builder uses a module listed above it, which is the healthy direction.
reth_node_builder.builder uses reth_transaction_pool, so a change to reth_transaction_pool can break reth_node_builder.builder, while a change to reth_node_builder.builder can't break reth_transaction_pool.
Position
Below the diagonal: reth_node_builder.builder uses a module listed above it, which is the healthy direction.
reth_node_builder.builder uses reth_node_core.node_config, so a change to reth_node_core.node_config can break reth_node_builder.builder, while a change to reth_node_builder.builder can't break reth_node_core.node_config.
Position
Below the diagonal: reth_node_builder.builder uses a module listed above it, which is the healthy direction.
reth_node_builder.builder uses reth_network.network, so a change to reth_network.network can break reth_node_builder.builder, while a change to reth_node_builder.builder can't break reth_network.network.
Position
Below the diagonal: reth_node_builder.builder uses a module listed above it, which is the healthy direction.
reth_node_builder.builder uses reth_node_builder.launch.common, so a change to reth_node_builder.launch.common can break reth_node_builder.builder, while a change to reth_node_builder.builder can't break reth_node_builder.launch.common.
Position
Below the diagonal: reth_node_builder.builder uses a module listed above it, which is the healthy direction.
reth_rpc_builder uses reth_evm.execute, so a change to reth_evm.execute can break reth_rpc_builder, while a change to reth_rpc_builder can't break reth_evm.execute.
Position
Below the diagonal: reth_rpc_builder uses a module listed above it, which is the healthy direction.
reth_rpc_builder uses reth_tasks.runtime, so a change to reth_tasks.runtime can break reth_rpc_builder, while a change to reth_rpc_builder can't break reth_tasks.runtime.
Position
Below the diagonal: reth_rpc_builder uses a module listed above it, which is the healthy direction.
reth_rpc_builder uses reth_engine_tree.tree.txpool_prewarm, so a change to reth_engine_tree.tree.txpool_prewarm can break reth_rpc_builder, while a change to reth_rpc_builder can't break reth_engine_tree.tree.txpool_prewarm.
Position
Below the diagonal: reth_rpc_builder uses a module listed above it, which is the healthy direction.
reth_rpc_builder uses reth_transaction_pool, so a change to reth_transaction_pool can break reth_rpc_builder, while a change to reth_rpc_builder can't break reth_transaction_pool.
Position
Below the diagonal: reth_rpc_builder uses a module listed above it, which is the healthy direction.
reth_rpc_builder uses reth_rpc.eth.core, so a change to reth_rpc.eth.core can break reth_rpc_builder, while a change to reth_rpc_builder can't break reth_rpc.eth.core.
Position
Below the diagonal: reth_rpc_builder uses a module listed above it, which is the healthy direction.
reth_rpc_builder uses reth_node_builder.rpc, so a change to reth_node_builder.rpc can break reth_rpc_builder, while a change to reth_rpc_builder can't break reth_node_builder.rpc.
Position
Below the diagonal: reth_rpc_builder uses a module listed above it, which is the healthy direction.
reth_node_builder.node uses reth_chainspec.spec, so a change to reth_chainspec.spec can break reth_node_builder.node, while a change to reth_node_builder.node can't break reth_chainspec.spec.
Position
Below the diagonal: reth_node_builder.node uses a module listed above it, which is the healthy direction.
reth_node_builder.node uses reth_evm.execute, so a change to reth_evm.execute can break reth_node_builder.node, while a change to reth_node_builder.node can't break reth_evm.execute.
Position
Below the diagonal: reth_node_builder.node uses a module listed above it, which is the healthy direction.
reth_node_builder.node uses reth_engine_tree.tree.txpool_prewarm, so a change to reth_engine_tree.tree.txpool_prewarm can break reth_node_builder.node, while a change to reth_node_builder.node can't break reth_engine_tree.tree.txpool_prewarm.
Position
Below the diagonal: reth_node_builder.node uses a module listed above it, which is the healthy direction.
reth_node_builder.node uses reth_transaction_pool, so a change to reth_transaction_pool can break reth_node_builder.node, while a change to reth_node_builder.node can't break reth_transaction_pool.
Position
Below the diagonal: reth_node_builder.node uses a module listed above it, which is the healthy direction.
reth_node_builder.node uses reth_node_core.node_config, so a change to reth_node_core.node_config can break reth_node_builder.node, while a change to reth_node_builder.node can't break reth_node_core.node_config.
Position
Below the diagonal: reth_node_builder.node uses a module listed above it, which is the healthy direction.
reth_node_builder.node uses reth_rpc_builder, so a change to reth_rpc_builder can break reth_node_builder.node, while a change to reth_node_builder.node can't break reth_rpc_builder.
Position
Below the diagonal: reth_node_builder.node uses a module listed above it, which is the healthy direction.
reth_cli_commands.common uses reth_chainspec.spec, so a change to reth_chainspec.spec can break reth_cli_commands.common, while a change to reth_cli_commands.common can't break reth_chainspec.spec.
Position
Below the diagonal: reth_cli_commands.common uses a module listed above it, which is the healthy direction.
reth_cli_commands.common uses reth_db.implementation.mdbx, so a change to reth_db.implementation.mdbx can break reth_cli_commands.common, while a change to reth_cli_commands.common can't break reth_db.implementation.mdbx.
Position
Below the diagonal: reth_cli_commands.common uses a module listed above it, which is the healthy direction.
reth_cli_commands.common uses reth_tasks.runtime, so a change to reth_tasks.runtime can break reth_cli_commands.common, while a change to reth_cli_commands.common can't break reth_tasks.runtime.
Position
Below the diagonal: reth_cli_commands.common uses a module listed above it, which is the healthy direction.
reth_cli_commands.common uses reth_provider.providers.static_file.manager, so a change to reth_provider.providers.static_file.manager can break reth_cli_commands.common, while a change to reth_cli_commands.common can't break reth_provider.providers.static_file.manager.
Position
Below the diagonal: reth_cli_commands.common uses a module listed above it, which is the healthy direction.
reth_cli_commands.common uses reth_provider.providers.database, so a change to reth_provider.providers.database can break reth_cli_commands.common, while a change to reth_cli_commands.common can't break reth_provider.providers.database.
Position
Below the diagonal: reth_cli_commands.common uses a module listed above it, which is the healthy direction.
reth_cli_commands.common uses reth_node_builder.node, so a change to reth_node_builder.node can break reth_cli_commands.common, while a change to reth_cli_commands.common can't break reth_node_builder.node.
Position
Below the diagonal: reth_cli_commands.common uses a module listed above it, which is the healthy direction.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A02:2025 — Security Misconfiguration
27
High / Critical
A05:2025 — Injection
12
High / Critical
A03:2025 — Software Supply Chain Failures
12
High / Critical
Roadmap
First, resolve the five banned license findings to ensure full compliance. Next, codify backups and geo-recovery in infrastructure-as-code while documenting RTO and RPO, as current persistence guards do not constitute disaster recovery. Then, enforce request timeouts on all HTTP clients and add retry logic with back-off for transient failures to improve resilience. Finally, secure the server by enabling TLS and sending Strict-Transport-Security headers, and maintain a changelog to track release history.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 5 Banned license finding(s) in License Compliance.
Give every client a whole-request bound: `reqwest::Client::builder().timeout(Duration::from_secs(10))` (never `reqwest::get` or `Client::new()`, which have none), ureq's `timeout_global`, or wrap the call in `tokio::time::timeout`; add retry with back-off (`reqwest-retry`'s `RetryTransientMiddleware`, `backoff`) around dependencies that fail.
Secure the server's transport: serve TLS itself (`HttpServer::bind_rustls_0_23(addr, config)` in actix-web, `axum_server::bind_rustls(addr, RustlsConfig::from_pem_file(…))`, tonic's `Server::builder().tls_config(ServerTlsConfig::new().identity(…))`, Rocket's `[default.tls]`), or run it behind a TLS-terminating proxy and check `X-Forwarded-Proto`; send `Strict-Transport-Security` once it is HTTPS-only.
Name the access rules — roles and permissions declared once (an enum Role/Permission, actix-web-grants #[protect(…)], axum-login's permission_required!, a casbin or oso policy) and consulted where access is checked, so the rule set is reviewable and testable on its own.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 33
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 1012
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 130
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 13
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 71 of 71 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); none rely on LLM judgement. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 71 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1090 of 1175 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.rs) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (lcov — `cargo install cargo-llvm-cov`, then `cargo llvm-cov --lcov --output-path lcov.info`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures. You can widen what we reach: optional: produce a coverage report in a standard format (lcov — `cargo install cargo-llvm-cov`, then `cargo llvm-cov --lcov --output-path lcov.info`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then the real number is read on the next scan.
D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.rs) and this repository declares a Cargo test suite (repository root, 568 test files), but it was not re-run: no test result was produced. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D19 Documentation Quality — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
D21 Naming Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D21's deterministic naming rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. Until then its declarations carry no naming verdict this run — this says nothing about whether its names are consistent.
D22 Internal API Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22's deterministic call-shape rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. This says nothing about whether that surface is consistent.
D24 Comment Value — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
D27 Navigability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Navigability is taken over call sites whose callee resolved. For C# that population includes calls into referenced assemblies; for this language only calls declared inside the repository count, so the abstention threshold reads the repository's use of its standard library as a resolution failure. That is a limit of this analyzer, not a build problem in this repository.
AXR1 Runtime accessibility — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via DockerCompose (REDACTED). compose up failed (exit 18 — an image could not be pulled) — loki Pulling promtail Pulling grafana Pulling reth Pulling prometheus Pulling loki Error Get "https://registry-1.docker.io/v2/": Forbidden promtail Error context canceled reth Error context canceled prometheus Error context canceled grafana Error context canceled Error response from daemon: Get "https://registry-1.docker.io/v2/": Forbidden; the earlier `compose pull` step reported: promtail Pulling reth Pulling prometheus Pulling loki Pulling grafana Pulling prometheus Error Get "https://registry-1.docker.io/v2/": Forbidden grafana Error Get "https://registry-1.docker.io/v2/": Forbidden promtail Error context canceled loki Error context canceled reth Error context canceled Error response from daemon: Get "https://registry-1.docker.io/v2/": Forbidden; the runtime sandbox reaches registries only through the in-fence pull-through mirror, so an image the mirror does not carry cannot be fetched — this is a limit of our sandbox, not of your stack; runtime evidence skipped.
C1 Data Protection — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'rocksdb' is imported (crates/storage/provider/src/bal.rs:11), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
C3 Audit Trail — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'rocksdb' is imported (crates/storage/provider/src/bal.rs:11), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
C4 Data Retention — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'rocksdb' is imported (crates/storage/provider/src/bal.rs:11), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
C5 Data-Subject Rights — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'rocksdb' is imported (crates/storage/provider/src/bal.rs:11), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
GD1 Unfinished & placeholder code — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and this repository's Python, Rust is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
IC1 Incompleteness & stubs — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and this repository's Python, Rust is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
M4 Documentation accuracy — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9). Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
X4 Structured logging — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 139 further occurrence(s) are not listed individually; the score already reflects all 179.
Repo exclusion declarations: 3 pattern(s) declared (.gitattributes linguist-generated/vendored, .editorconfig generated_code) excluded 0 source file(s) from code-quality scoring. Declarations are the repo's own visible statement that a tree is machine-written or vendored — auditable in any diff, honored by GitHub the same way.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a REDACTED (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
AX9 CQS / query purity: Handlers are found by interface/name convention — a query handler using neither is not seen. Mutation is a resolved write/publish invocation (SaveChanges/repository/bus), so a write hidden behind a hand-rolled wrapper, reflection, or a string-keyed service locator resolves to a non-persistence type and isn't flagged; it detects that a query writes state, not whether the write is a legitimate read-side cache update. Clean means "no resolved write/publish in a query body", not a proof of CQS purity.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
98 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was reth_trie_dst::run at 60. A further 13 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being Error::to_err_code at 33 — they are counted neither in the figure above nor in this dimension's score. 6 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold functions was excluded, so the exclusion is disclosed nowhere in the file itself: crates/storage/libmdbx-rs/src/error.rs (Error::to_err_code at 33), crates/transaction-pool/src/error.rs (InvalidPoolTransactionError::is_bad_transaction at 26), crates/ethereum/cli/src/app.rs (reth_ethereum_cli::app::run_commands_with at 19), crates/rpc/rpc-eth-types/src/error/mod.rs (RpcInvalidTransactionError::from at 18), crates/stages/types/src/id.rs (StageId::as_str at 18), and 1 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 72 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 16 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with reth_trie_dst::run (cyclomatic 60), ActiveSession::on_incoming_message (cyclomatic 60), controller.main (cyclomatic 51). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 16 together lifts Cyclomatic Complexity from 6.5 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 143 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 1 body over 120 down to 120 or less in Cognitive Complexity — start with reth_trie_dst::run (cognitive 150). — Refactoring it lifts Cognitive Complexity from 5.6 to about 5.8/10.
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes8.7 / 10Strong✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
+ 1 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 72 FileTooLong finding(s) in God Classes — start with mod.rs (11), lib.rs (4), provider.rs (3). — One of this dimension's main actionable groups (72 warning-level).
Resolve the 37 ClassTooLong finding(s) in God Classes — start with mod.rs (6), provider.rs (4), manager.rs (3). — One of this dimension's main actionable groups (37 warning-level).
Resolve the 36 MethodTooLong finding(s) in God Classes — start with mod.rs (8), manager.rs (2), provider.rs (2). — One of this dimension's main actionable groups (36 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
242 duplicated block group(s) detected. A further 11 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted. 9 of the 253 are in trees this repository does not ship — vendored, example/demo, project-template, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.
+ 71 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 24 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with utils.rs (2), provider.rs (2), copy.rs. — One of this dimension's main actionable groups (24 warning-level).
Resolve the 19 Duplicated block (11 lines × 2) finding(s) in Code Duplication — start with engine_api.rs (2), manager.rs (2), account_history.rs (2). — One of this dimension's main actionable groups (19 warning-level).
Resolve the 17 Duplicated block (6 lines × 2) finding(s) in Code Duplication — start with hashed_state.rs (2), prune_checkpoints.rs (2), bench-reth-charts.py (2). — One of this dimension's main actionable groups (17 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling7.4 / 10Strong✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
116 production modules (Cargo+npm), 0 dependency cycle(s), 12 unstable depended-on module(s). Read from the build's own module declarations; 26 module(s) off the main sequence, with abstractness counted on 107 of the 116 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).
Off the main sequence: reth-db-models · ×23
Unstable project reth-cli-commands
Unstable project reth-engine-tree
Unstable project reth-engine-util
Unstable project reth-ethereum-cli
+ 9 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 23 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (23 warning-level).
Resolve the 1 Unstable project reth-cli-commands finding(s) in Coupling. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Unstable project reth-engine-tree finding(s) in Coupling. — One of this dimension's main actionable groups (1 warning-level).
Enforce Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 11 Low cohesion finding(s) in Cohesion (LCOM4) — start with lib.rs (2), config.rs, trace.rs. — One of this dimension's main actionable groups (11 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D9 · Test Distribution9.7 / 10Exemplary✓ Tool-verified
What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.
Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.
4254 test methods: 3757 unit, 387 integration, 0 BDD, 110 e2e. The Rust suite contributes 4254 `#[test]` function(s) across 568 file(s) declaring at least one; its unit/integration split is Cargo's own — 68 of those file(s) are integration-test targets under a crate's tests/ directory, and the rest are #[test] functions compiled into the crate they test.
What it measures: Whether dependencies are current, secure, and not bloated.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.
24 outdated, 0 yanked direct Cargo dependencies. 183 of 190 direct crates were graded against crates.io (0 not published there, 7 not resolved by a committed REDACTED). Only DIRECT edges are graded: a transitive crate cannot be moved past what its parent's requirement admits, so reporting one would be advice its owner cannot take. A newer release is reported only where this repository's OWN requirement already admits it, so the remedy is `cargo update` and never a manifest edit — which means a release outside the declared range is deliberately NOT charged, because a written-down constraint is a decision rather than a defect. Note that a bare requirement is a CARET, and for a 0.x crate its ceiling is the minor. Whether any crate is UNMAINTAINED is not graded — crates.io publishes no maintenance status, and release age does not stand in for one. Known CVEs in this dependency graph are D30's question, read from REDACTED there.
Outdated: alloy-rlp · ×24
What to do
Enforce Dependency Hygiene in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
5 of 972 shipped crate(s) use a banned license. Licences were resolved from crates.io over the crates a consumer compiles — this repository's REDACTED closed over its manifests' `[dependencies]` and `[build-dependencies]`. Crates it asks for ONLY under `[dev-dependencies]` are excluded: they are not compiled by anything that depends on this repository. A further 20 crate(s) in the closure resolve from git, a path or a private registry and publish no licence this pass can read; they are outside this verdict. This repository publishes itself under MIT OR Apache-2.0, which is its own choice and is not judged here.
Banned license: test-fuzz · ×5
What to do
Resolve the 5 Banned license finding(s) in License Compliance. — One of this dimension's main actionable groups (5 issue-level).
Enforce License Compliance in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d14_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Top hotspots: crates/engine/tree/src/tree/mod.rs (40×21=840); crates/storage/provider/src/providers/database/provider.rs (34×23=782); crates/engine/tree/src/tree/payload_validator.rs (29×23=667) Repeated repair below the complexity floor: crates/cli/commands/src/common.rs (7 of 11 changes were fixes); crates/storage/provider/src/bal/rocksdb.rs (6 of 10 changes were fixes); crates/storage/provider/src/providers/rocksdb/metrics.rs (5 of 7 changes were fixes)
Resolve the 44 Hotspot finding(s) in Churn × Complexity Hotspots — start with mod.rs (7), manager.rs (2), lib.rs (2). — One of this dimension's main actionable groups (44 warning-level).
Resolve the 14 Repeated repair finding(s) in Churn × Complexity Hotspots — start with error.rs (5), common.rs, rocksdb.rs. — One of this dimension's main actionable groups (14 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor9.8 / 10Exemplary✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
18 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is crates/net/eth-wire/src/eth_snap.rs. Counted over 825 of the 1128 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Off-boarding risk: anonymized user #1 · ×2
Further sole-owners (lower concentration)
✓ On the Gold path — maintain.
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
76 deducted task-comment markers across 399415 LoC (0.0/KLoC) → score 10.0. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
Resolve the 74 TodoComment finding(s) in Explicit Debt — start with main.rs (5), generators.rs (4), mod.rs (4). — One of this dimension's main actionable groups (74 warning-level).
Resolve the 1 FixmeComment finding(s) in Explicit Debt — start with mod.rs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 HackComment finding(s) in Explicit Debt — start with engine.rs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
1 of 1 documentation facets pass in full. 160 document(s) read across 1 unit(s).
✓ On the Gold path — maintain.
Detailed fixes: d19_recommendation.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
12 finding(s): 0 critical, 10 high, 2 medium, 0 low. semgrep hit a parse error in 52 file(s) — `.github/scripts/bench-benchmarkoor-run.sh`, `.github/scripts/bench-state-test.sh`, `.github/scripts/bench-state.sh` (line 10), `.github/scripts/bench-txgen-extract.sh`, `.github/scripts/bench-txgen-run.sh`, … (+47 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 15 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 2 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 issue-level).
Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 issue-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.
Resolve the 1 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 5 Medium advisory (unmaintained) finding(s) in Dependency Vulnerabilities — start with REDACTED (5). — One of this dimension's main actionable groups (5 warning-level).
Resolve the 2 Medium vulnerability finding(s) in Dependency Vulnerabilities — start with REDACTED (2). — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
Resolve the 15 High IaC finding(s) in IaC & Container Security — start with REDACTED (7), REDACTED (3), REDACTED (2). — One of this dimension's main actionable groups (15 issue-level).
Resolve the 8 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (4), REDACTED (2), REDACTED (2). — One of this dimension's main actionable groups (8 warning-level).
Resolve the 4 Low IaC finding(s) in IaC & Container Security — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (4 recommendation-level).
Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
33 of 825 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is crates/rpc/rpc-e2e-tests/src/rpc_compat.rs. Counted over 825 of the 1128 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 24 Change coupling finding(s) in Change Coupling — start with mem.rs (2), db.rs (2), lib.rs (2). — One of this dimension's main actionable groups (24 warning-level).
Resolve the 3 Change-coupling hub finding(s) in Change Coupling — start with mod.rs, common.rs, trie.rs. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 1 Change coupling clique finding(s) in Change Coupling — start with noop.rs. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.
Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 1 platform declaration(s) and 3 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
What to do
The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Do you agree with this assessment?
AX8 · Test isolation7.5 / 10Strong✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
`reth-rpc-e2e-tests` (production) references the test project `reth-e2e-test-utils`. Production must never depend on test code — it pulls a unit-test framework and test fixtures into the shipped product and inverts the only correct direction (tests depend on production, never the reverse). Move any shared helper into a production support library, or invert the reference.
What to do
Remove every production → test project reference: extract any shared test helper into a production support library (which the tests reference), or invert the dependency so the test project depends on production — not the reverse.
Other · Architecture — Whether read (query) handlers stay side-effect-free — a query that writes persistent state or raises events breaks CQS and makes reads unsafe to retry, cache, or route to a read replica.
Method: Roslyn scan: CQRS handlers classified query-vs-command by interface (IQueryHandler/ICommandHandler/IRequestHandler<TQuery,TResult>) and name convention (*Query/Get*/Find* vs *Command); each query handler's body checked for persistent-state writes (SaveChanges/repository Add-Update) or event publishes by resolved invocation. Deterministic, type-level, exhaustive over the detected handlers.
Coverage: Population: CQRS handlers identified by IQueryHandler/ICommandHandler/IRequestHandler interface + *Query/Get*/Find*/*Command NAME convention; query purity then checked exhaustively within that set — a query handler using neither convention is invisible, and mutation is a resolved persistence/publish CALL, not full dataflow.
`RpcBlockchainStateProvider.get_account` is a read-named query yet it performs a durable write on the read path (a persist to a store/repository). A query must stay side-effect-free so reads are safe to retry, cache, and route to a read replica; move the write into a command. — crates/storage/rpc-provider/src/lib.rs:1036
What to do
Keep query handlers read-only — move the writes/event-publishes into a command handler so reads stay safe to retry, cache, and route to a read replica.
Do you agree with this assessment?
C2 · Access Controls7.0 / 10Strong✓ Tool-verified
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
Authorization IS enforced here (by route guards, auth middleware or checks that refuse a caller) — this is NOT a claim that endpoints are unprotected. What's missing is a NAMED rule set: who may do what is encoded inline where it is checked, so the rules can't be listed, reviewed or tested apart from the code that applies them. Recommendation, not a defect.
What to do
Name the access rules — roles and permissions declared once (an enum Role/Permission, actix-web-grants #[protect(…)], axum-login's permission_required!, a casbin or oso policy) and consulted where access is checked, so the rule set is reviewable and testable on its own.
Other · Event Sourcing — Whether the recovery-replay fold is deterministic — state derived purely from each event's own fields, no clock/random/IO on the replay path.
Method: Roslyn syntax scan (event-sourcing gated): Apply/When folds checked for forbidden tokens (DateTime.Now, Guid.NewGuid, Random, IO), stripped of comments/strings. Deterministic, hard fact per fold.
Other · Event Sourcing — Whether domain events stay immutable (private fields, set once) rather than carrying mutable state.
Method: Roslyn scan (event-sourcing gated): persisted events checked for public setters; immutability verified per property/field. Deterministic, hard fact.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Add a README to the 133 of 147 project(s) that lack one — worth up to 1.8 pts.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
Do you agree with this assessment?
P10 · Library API & versioning10.0 / 10Exemplary○ Nothing flagged
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.
Only 72/75 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `.`, `.`, `contrib/trie-dst/crates/reth-trie-dst`.
What to do
Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
What to do
Dependabot is configured but does not watch `npm`, `cargo`, `pip` — add those `package-ecosystem` entries to .github/dependabot.yml so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Do you agree with this assessment?
P5 · DR & Backup0.0 / 10Critical✓ Tool-verified
Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.
Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.
A persistence guard (data volume / purge-protection) was found, but no backup, geo-recovery or RTO/RPO controls were evidenced — a volume that survives a container recreate is not a tested restore from catastrophic loss.
What to do
Codify backups + geo-recovery in IaC and document RTO/RPO and the restore procedure — a persistence guard alone is not disaster recovery.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.
Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.
`Client::new()` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×6) — crates/cli/commands/src/download/manifest.rs:583, crates/cli/commands/src/download/source.rs:91, crates/cli/commands/src/download/source.rs:143, …
`Client::builder()` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. — crates/node/metrics/src/server.rs:254
What to do
Give every client a whole-request bound: `reqwest::Client::builder().timeout(Duration::from_secs(10))` (never `reqwest::get` or `Client::new()`, which have none), ureq's `timeout_global`, or wrap the call in `tokio::time::timeout`; add retry with back-off (`reqwest-retry`'s `RetryTransientMiddleware`, `backoff`) around dependencies that fail.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
Other · Security — Read from this repository's Rust source: cryptographic hygiene (weak hash or cipher, key material fixed in the source) and outbound TLS (certificate validation, protocol version) — facts about code that hold whether or not it serves anything itself. This repository serves HTTP itself (`Server::builder()` (docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:69)), so its Rust source was also read for the server controls: TLS served or HSTS set, security response headers, cookie flags and inbound validation — each credited where its Rust spelling appears in production source, not proven on every route. A Rocket 0.5 application is credited the headers Rocket's default `Shield` sends unless it attaches its own, and its cookie jar's SameSite=Strict default; a session middleware its default cookie flags.
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
This repository starts an HTTP server and nothing in its Rust source or committed `Rocket.toml` secures the transport: no TLS served (actix-web `bind_rustls`/`bind_openssl`, axum-server `bind_rustls` with a `RustlsConfig`, tonic `ServerTlsConfig`, a `TlsAcceptor`, Rocket's `[default.tls]`), no `Strict-Transport-Security` header, no `X-Forwarded-Proto` read from a TLS-terminating proxy — so its traffic may cross the network in clear text. (−2.0 on this card.) The server: `Server::builder()` (docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:69).
None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is set on a response this repository's Rust server sends — defense in depth, even when a proxy could set them. (−2.0 on this card.) The server: `Server::builder()` (docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:69).
What to do
Secure the server's transport: serve TLS itself (`HttpServer::bind_rustls_0_23(addr, config)` in actix-web, `axum_server::bind_rustls(addr, RustlsConfig::from_pem_file(…))`, tonic's `Server::builder().tls_config(ServerTlsConfig::new().identity(…))`, Rocket's `[default.tls]`), or run it behind a TLS-terminating proxy and check `X-Forwarded-Proto`; send `Strict-Transport-Security` once it is HTTPS-only.
Set security response headers on what the server sends — actix-web's `DefaultHeaders::new().add((header::X_CONTENT_TYPE_OPTIONS, "nosniff"))`, tower-http's `SetResponseHeaderLayer::overriding(…)` on an axum router, or keep Rocket's default `Shield` — with `Content-Security-Policy`, `X-Content-Type-Options` and a frame policy on every response.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader2.2 / 10Critical✓ Tool-verified
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
`key_length` is read from the bytes being parsed at line 268 (`usize::from_be_bytes`), then used to size a `vec![…; n]` at line 270 — and nowhere in its scope is `key_length` compared to anything, clamped, or bounded against the input that remains. Whoever wrote those bytes therefore chooses the allocation directly: it reserves the whole length before a single byte of the payload is known to exist, so a 32-bit length asks for up to 4 GiB, and an allocation the allocator refuses aborts the process with `memory allocation of … bytes failed` — an abort, not a panic, so no `catch_unwind` intercepts it and the whole process dies; a 64-bit length past `isize::MAX` panics with `capacity overflow` instead, out of a parser whose failure path was written for malformed input, not for hostile input. Bound `key_length` against the bytes actually remaining and a maximum the format allows before allocating. — crates/etl/src/lib.rs:270
`value_length` is read from the bytes being parsed at line 269 (`usize::from_be_bytes`), then used to size a `vec![…; n]` at line 271 — and nowhere in its scope is `value_length` compared to anything, clamped, or bounded against the input that remains. Whoever wrote those bytes therefore chooses the allocation directly: it reserves the whole length before a single byte of the payload is known to exist, so a 32-bit length asks for up to 4 GiB, and an allocation the allocator refuses aborts the process with `memory allocation of … bytes failed` — an abort, not a panic, so no `catch_unwind` intercepts it and the whole process dies; a 64-bit length past `isize::MAX` panics with `capacity overflow` instead, out of a parser whose failure path was written for malformed input, not for hostile input. Bound `value_length` against the bytes actually remaining and a maximum the format allows before allocating. — crates/etl/src/lib.rs:271
`count` is read from the bytes being parsed at line 208 (`i64::from_le_bytes`), then used to size a `Vec::with_capacity` at line 231 — and nowhere in its scope is `count` compared to anything, clamped, or bounded against the input that remains. Whoever wrote those bytes therefore chooses the allocation directly: it reserves the whole length before a single byte of the payload is known to exist, so a 32-bit length asks for up to 4 GiB, and an allocation the allocator refuses aborts the process with `memory allocation of … bytes failed` — an abort, not a panic, so no `catch_unwind` intercepts it and the whole process dies; a 64-bit length past `isize::MAX` panics with `capacity overflow` instead, out of a parser whose failure path was written for malformed input, not for hostile input. Bound `count` against the bytes actually remaining and a maximum the format allows before allocating. — crates/era/src/e2s/types.rs:231
What to do
Each finding names the read that takes the length from the input and the site that spends it, and states that the value is never compared in between. Confirm from the two, then bound the length against the remaining stream before using it.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `for` loop leaves the `RefCell` it is walking alone — safe Rust rejects a body that changes the collection its loop borrows at compile time, except through interior mutability: a `RefCell` borrowed in the loop's header stays borrowed until the loop ends, so a `borrow_mut()` of it inside the body panics with `already borrowed: BorrowMutError` and the remaining elements are never seen. Whether a `for` loop leaves the `dict`, `set` or `deque` it is walking alone — CPython's iterators over those check that the collection has not changed size since the loop began, so a body that removes from (or empties) the very collection the loop is walking makes the next step raise `RuntimeError: dictionary changed size during iteration` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
`error!` at line 1285 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/trie/trie/src/proof_v2/calculator.rs:1285
`debug!` at line 367 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/maintain.rs:367
`error!` at line 843 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/maintain.rs:843
`debug!` at line 219 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/pool/best.rs:219
`debug!` at line 293 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/pool/listener.rs:293
`debug!` at line 335 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/pool/listener.rs:335
`debug!` at line 758 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/pool/mod.rs:758
`debug!` at line 861 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/pool/mod.rs:861
`debug!` at line 1353 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/pool/mod.rs:1353
`warn!` at line 1355 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/pool/mod.rs:1355
`trace!` at line 1306 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `trace!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/pool/txpool.rs:1306
`trace!` at line 1318 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `trace!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/pool/txpool.rs:1318
`trace!` at line 690 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `trace!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/transaction-pool/src/blobstore/disk.rs:690
`warn!` at line 38 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/tokio-util/src/event_stream.rs:38
`error!` at line 691 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/tasks/src/runtime.rs:691
`error!` at line 760 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/tasks/src/runtime.rs:760
`error!` at line 829 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/tasks/src/runtime.rs:829
`debug!` at line 1073 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/tasks/src/runtime.rs:1073
`debug!` at line 466 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/storage/provider/src/providers/static_file/writer.rs:466
`debug!` at line 481 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/storage/provider/src/providers/static_file/writer.rs:481
`info!` at line 141 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/storage/db-common/src/db_tool/mod.rs:141
`info!` at line 145 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/storage/db-common/src/db_tool/mod.rs:145
`info!` at line 151 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/storage/db-common/src/db_tool/mod.rs:151
`warn!` at line 79 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/storage/db/src/lockfile.rs:79
`warn!` at line 505 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/storage/db/src/implementation/mdbx/mod.rs:505
`info!` at line 322 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/stages/stages/src/stages/hashing_account.rs:322
`info!` at line 263 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/stages/stages/src/stages/hashing_storage.rs:263
`error!` at line 690 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/stages/api/src/pipeline/mod.rs:690
`error!` at line 715 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/stages/api/src/pipeline/mod.rs:715
`error!` at line 745 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/stages/api/src/pipeline/mod.rs:745
`warn!` at line 750 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/stages/api/src/pipeline/mod.rs:750
`error!` at line 29 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/rpc/rpc-layer/src/jwt_validator.rs:29
`error!` at line 36 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/rpc/rpc-layer/src/jwt_validator.rs:36
`debug!` at line 223 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/rpc/rpc-eth-api/src/helpers/pending_block.rs:223
`trace!` at line 197 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `trace!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/rpc/rpc/src/eth/filter.rs:197
`trace!` at line 499 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `trace!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/rpc/rpc/src/eth/sim_bundle.rs:499
`warn!` at line 112 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/rpc/ipc/src/server/connection.rs:112
`debug!` at line 159 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/rpc/ipc/src/server/connection.rs:159
`trace!` at line 194 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `trace!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/rpc/ipc/src/server/mod.rs:194
`debug!` at line 55 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`. — crates/prune/types/src/pruner.rs:55
Other · Code Health — Whether strict null checking is enabled and not undermined by heavy `!` assertion — TypeScript's `strictNullChecks` (which `strict` turns on) is what makes `string` exclude `null` and `undefined`, and the postfix `!` is the operator that silences it.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 2 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
X10 Duplicated predicate — 11 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 3 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C3 Audit Trail — Not assessed: this repository stores data through 'rocksdb' (crates/storage/provider/src/bal.rs:11) but declares no persisted model this check reads (Diesel table! columns, SeaORM entity / Diesel model / sqlx FromRow struct fields, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations and SQL string literals). Personal data may be written through raw SQL or a hosted backend, so whether its changes need an audit trail could not be established, and the trail's absence is not scored.
C4 Data Retention — Not assessed: this repository stores data through 'rocksdb' (crates/storage/provider/src/bal.rs:11) but declares no persisted model this check reads (Diesel table! columns, SeaORM entity / Diesel model / sqlx FromRow struct fields, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations and SQL string literals). Personal data may be written through raw SQL or a hosted backend, so whether a retention limit applies here could not be established, and its absence is not scored.
C5 Data-Subject Rights — Not assessed: this repository stores data through 'rocksdb' (crates/storage/provider/src/bal.rs:11) but declares no persisted model this check reads (Diesel table! columns, SeaORM entity / Diesel model / sqlx FromRow struct fields, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations and SQL string literals). Personal data may be written through raw SQL or a hosted backend, so whether data-subject rights apply here could not be established, and their absence is not scored.
Not included — 46 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — Frontend below the scale floor (12 DOM element(s) < 25) — too little surface to assess accessibility.
AC2 Forms & labels — Frontend below the scale floor (12 DOM element(s) < 25) — too little surface to assess accessibility.
AC3 Page structure — Frontend below the scale floor (12 DOM element(s) < 25) — too little surface to assess accessibility.
AC4 Keyboard semantics — Frontend below the scale floor (12 DOM element(s) < 25) — too little surface to assess accessibility.
AC5 ARIA correctness — Frontend below the scale floor (12 DOM element(s) < 25) — too little surface to assess accessibility.
AC6 Visual & motion safety — Frontend below the scale floor (12 DOM element(s) < 25) — too little surface to assess accessibility.
AC7 A11y enforcement — Frontend below the scale floor (12 DOM element(s) < 25) — too little surface to assess accessibility.
AX1 Captive dependencies — Not applicable: this repository's Python imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; Rust with no dependency-injection crate has no container to hand one lifetime's instance to another — every value is owned by the code that builds it, and the borrow checker rejects a longer-lived value keeping a borrow of a shorter-lived one.
AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No function in this Python code is served by a threaded web framework (a Flask, Bottle or FastAPI route, a Django or Pyramid view), so no module is shared between request threads. Rust's compiler refuses unsynchronised shared mutation — a value shared across threads must be Sync — so the race this check looks for cannot be written. TypeScript/JavaScript runs each process's requests on one event loop, so no two requests write a shared object at the same instant (interleaving across an await is a different defect).
AX4 Dependency direction — not applicable to a transaction-script/CRUD architecture (the inward-dependency rule is for layered/clean styles)
AX6 Interface segregation — no exported interface declares behaviour
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — compose up failed (exit 18 — an image could not be pulled) — loki Pulling promtail Pulling grafana Pulling reth Pulling prometheus Pulling loki Error Get "https://registry-1.docker.io/v2/": Forbidden promtail Error context canceled reth Error context canceled prometheus Error context canceled grafana Error context canceled Error response from daemon: Get "https://registry-1.docker.io/v2/": Forbidden; the earlier `compose pull` step reported: promtail Pulling reth Pulling prometheus Pulling loki Pulling grafana Pulling prometheus Error Get "https://registry-1.docker.io/v2/": Forbidden grafana Error Get "https://registry-1.docker.io/v2/": Forbidden promtail Error context canceled loki Error context canceled reth Error context canceled Error response from daemon: Get "https://registry-1.docker.io/v2/": Forbidden; the runtime sandbox reaches registries only through the in-fence pull-through mirror, so an image the mirror does not carry cannot be fetched — this is a limit of our sandbox, not of your stack; runtime evidence skipped This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
C1 Data Protection — Not assessed: this repository stores data through 'rocksdb' (crates/storage/provider/src/bal.rs:11) but declares no persisted model this check reads (Diesel table! columns, SeaORM entity / Diesel model / sqlx FromRow struct fields, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations and SQL string literals). Personal data may be written through raw SQL or a hosted backend, so the absence of a personal-data field here is not evidence that none is stored, and encryption at rest is not scored over a subject that could not be established.
D10 Test Quality — ~35586 lines of test source are present (.rs) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
D11 Test Reliability — Test reliability not included — the .rs suite was found but not re-run
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D21 Naming Consistency — Naming consistency is measured on C# only; Python, Rust, TypeScript, html not measured.
D22 Internal API Consistency — API consistency is measured on C# only; the exposed Rust surface was not measured.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ projects each declaring an entity of their own. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D24 Comment Value — D24 reads C# and Visual Basic comments only — this repository's production source is .py, .rs, .ts, .tsx, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D25 ADR Conformance — no ADRs to check
D27 Navigability — D27 counts a call into the standard library or a dependency as unresolved for this repository's language (.rs), so too few call sites counted as resolved to assess navigability. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage not included — suite not readable by the collector
DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 193 value object(s); 17 domain event(s); its domain events are published by services or handlers — no domain entity raises one
ED2 Event/command shape — not scored — deciding whether a command has more than one competing handler requires resolving the call graph, and a call made through an inferred or generic receiver has no resolvable owner in the source. Reported as guidance rather than measured
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (lcov — `cargo install cargo-llvm-cov`, then `cargo llvm-cov --lcov --output-path lcov.info`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
PF2 Allocation hygiene — Not applicable: Rust spells out every heap allocation and makes borrowed slices (&[T], &str) its ordinary parameter types, so the allocation-aware style this card rewards elsewhere is the language's baseline rather than a rung to climb.
SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X2 Cancellation propagation — no C# was loaded; this repository's Python and Rust were read, and no request in it can be cancelled by a caller — a Python request takes no token: asyncio cancels the task and trio or anyio the scope that made it, from outside the call, and requests, httpx, aiohttp and gRPC take a timeout, not a cancellation; a Rust request takes no token: a future is cancelled by dropping it, from outside the call (select!, a timeout, an aborted task), and reqwest, hyper and tonic take none
X20 Mistyped argument guard — This check asks whether an argument guard reports an EMPTY value as a NULL one, which needs a language that throws a null-specific argument exception — .NET's ArgumentNullException, the JVM's NullPointerException, Dart's ArgumentError.notNull. This repository contains none of those languages: the ones it is written in have a single exception for a bad argument, so there is no pair of exceptions to confuse and nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
Banned license: test-fuzz — `test-fuzz` 7.3.0 is published on crates.io under `AGPL-3.0 WITH mif-exception`, which this policy bans, and it is in the SHIPPED closure of this repository's REDACTED — so it is compiled by everything that builds this repository, not just by its test harness. The expression was read as SPDX, not as text: an `OR` is a choice and is only charged when every branch is banned, while an `AND` binds you to both operands and is charged when either is. Replace the crate, or record an accepted exception.
Banned license: gmp-mpfr-sys — `gmp-mpfr-sys` 1.7.1 is published on crates.io under `LGPL-3.0+`, which this policy bans, and it is in the SHIPPED closure of this repository's REDACTED — so it is compiled by everything that builds this repository, not just by its test harness. The expression was read as SPDX, not as text: an `OR` is a choice and is only charged when every branch is banned, while an `AND` binds you to both operands and is charged when either is. Replace the crate, or record an accepted exception.
Banned license: test-fuzz-internal — `test-fuzz-internal` 7.3.0 is published on crates.io under `AGPL-3.0 WITH mif-exception`, which this policy bans, and it is in the SHIPPED closure of this repository's REDACTED — so it is compiled by everything that builds this repository, not just by its test harness. The expression was read as SPDX, not as text: an `OR` is a choice and is only charged when every branch is banned, while an `AND` binds you to both operands and is charged when either is. Replace the crate, or record an accepted exception.
Banned license: test-fuzz-macro — `test-fuzz-macro` 7.3.0 is published on crates.io under `AGPL-3.0 WITH mif-exception`, which this policy bans, and it is in the SHIPPED closure of this repository's REDACTED — so it is compiled by everything that builds this repository, not just by its test harness. The expression was read as SPDX, not as text: an `OR` is a choice and is only charged when every branch is banned, while an `AND` binds you to both operands and is charged when either is. Replace the crate, or record an accepted exception.
Banned license: test-fuzz-runtime — `test-fuzz-runtime` 7.3.0 is published on crates.io under `AGPL-3.0 WITH mif-exception`, which this policy bans, and it is in the SHIPPED closure of this repository's REDACTED — so it is compiled by everything that builds this repository, not just by its test harness. The expression was read as SPDX, not as text: an `OR` is a choice and is only charged when every branch is banned, while an `AND` binds you to both operands and is charged when either is. Replace the crate, or record an accepted exception.
AX8 · Test isolation· Production project references a test project · ×1
Production project references a test project: reth-rpc-e2e-tests → reth-e2e-test-utils — `reth-rpc-e2e-tests` (production) references the test project `reth-e2e-test-utils`. Production must never depend on test code — it pulls a unit-test framework and test fixtures into the shipped product and inverts the only correct direction (tests depend on production, never the reverse). Move any shared helper into a production support library, or invert the reference.
AX9 · CQS / query purity· Query writes persistent state on the read path · ×1
Query writes persistent state on the read path: RpcBlockchainStateProvider.get_account crates/storage/rpc-provider/src/lib.rs:1036— `RpcBlockchainStateProvider.get_account` is a read-named query yet it performs a durable write on the read path (a persist to a store/repository). A query must stay side-effect-free so reads are safe to retry, cache, and route to a read replica; move the write into a command.
TodoComment testing/testing-utils/src/generators.rs:3— // TODO(rand): update ::random calls after rand_09 migration — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment testing/testing-utils/src/generators.rs:164— // TODO: rand08 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment testing/testing-utils/src/generators.rs:186— // TODO: rand08 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment testing/testing-utils/src/generators.rs:245— // TODO(onbjerg): Proper EIP-7685 request support
TodoComment examples/bsc-p2p/src/upgrade_status.rs:54— // TODO: support disable_peer_tx_broadcast flag — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/trie/sparse/src/state.rs:1147— // TODO(alexey): assert against real state root calculation updates — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/transaction-pool/src/traits.rs:1657— // TODO: Initialize this with the actual mask once sparse sidecars are supported. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/transaction-pool/src/blobstore/mod.rs:115— // TODO: Initialize this with the actual mask once sparse sidecars are supported. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/transaction-pool/src/pool/blob.rs:411— // TODO: this could be u64: — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/transaction-pool/src/pool/txpool.rs:53— // TODO: Inlined diagram due to a bug in aquamarine library, should become an include when it's — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/net/network/src/manager.rs:75— // TODO: Inlined diagram due to a bug in aquamarine library, should become an include when it's — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/tasks/src/runtime.rs:217— // TODO: reserved_cpu_cores is currently ignored because subtracting from thread pool — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/node/builder/src/launch/common.rs:236— // TODO: reserved_cpu_cores is currently ignored because subtracting from thread pool — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/storage/storage-api/src/chain.rs:156— // TODO: Ideally storage should hold its own copy of chain spec — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/storage/provider/src/either_writer.rs:196— // TODO: support writing receipts to static files with log filter pruning enabled — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/storage/provider/src/providers/blockchain_provider.rs:2608— // todo(joshie) add canonical_hashes_range below after changing its interface into range — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/storage/provider/src/providers/blockchain_provider.rs:2962— // TODO: withdrawals, requests, ommers — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/storage/provider/src/providers/consistent.rs:1031— // TODO: should we only apply this for the RPCs that are listed in EIP-1898?
TodoComment crates/storage/provider/src/providers/static_file/manager.rs:1003— /// [`StaticFileJarProvider`]. TODO(joshie): we should check the size and pop N if there's too — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/storage/provider/src/providers/static_file/manager.rs:1826— // TODO(joshie): is_block_meta — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/storage/provider/src/providers/database/provider.rs:2719— // TODO(mediocregopher): This could be rewritten in a way which doesn't — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/storage/provider/src/providers/database/provider.rs:3067— // TODO: add a `take` method that removes and returns the items instead of doing this — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/storage/provider/src/providers/database/provider.rs:3817— /// TODO(joshie): this fn should be moved to `UnifiedStorageWriter` eventually — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/storage/nippy-jar/src/consistency.rs:77— // TODO: ideally we could truncate until the last offset of the last column of the — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment crates/storage/nippy-jar/src/lib.rs:256— // TODO(joshie): ensure consistency on unexpected shutdown — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FileTooLong: database/provider.rs crates/storage/provider/src/providers/database/provider.rs— FileTooLong — 2530 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 95% of them inside a single declaration: DatabaseProvider (54 blocks, 164-4086). The bar is 500 significant lines; this is 2030 over it, 5.06× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: tree/mod.rs crates/engine/tree/src/tree/mod.rs— FileTooLong — 1988 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 1488 over it, 3.98× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: static_file/manager.rs crates/storage/provider/src/providers/static_file/manager.rs— FileTooLong — 1779 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 89% of them inside a single declaration: StaticFileProvider (18 blocks, 124-3155). The bar is 500 significant lines; this is 1279 over it, 3.56× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: scripts/bench-reth-summary.py .github/scripts/bench-reth-summary.py— FileTooLong — 1767 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1267 over it, 3.53× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: arena/mod.rs crates/trie/sparse/src/arena/mod.rs— FileTooLong — 1697 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 81% of them inside a single declaration: ArenaParallelSparseTrie (6 blocks, 607-2890). The bar is 500 significant lines; this is 1197 over it, 3.39× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: rocksdb/provider.rs crates/storage/provider/src/providers/rocksdb/provider.rs— FileTooLong — 1692 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 1192 over it, 3.38× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/lib.rs crates/net/discv4/src/lib.rs— FileTooLong — 1365 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 61% of them inside a single declaration: Discv4Service (4 blocks, 498-2066). The bar is 500 significant lines; this is 865 over it, 2.73× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/lib.rs crates/rpc/rpc-builder/src/lib.rs— FileTooLong — 1364 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 864 over it, 2.73× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: tree/payload_validator.rs crates/engine/tree/src/tree/payload_validator.rs— FileTooLong — 1300 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 800 over it, 2.60× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: pool/txpool.rs crates/transaction-pool/src/pool/txpool.rs— FileTooLong — 1271 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 771 over it, 2.54× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/lib.rs crates/storage/rpc-provider/src/lib.rs— FileTooLong — 1264 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 764 over it, 2.53× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: transactions/mod.rs crates/net/network/src/transactions/mod.rs— FileTooLong — 1171 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 62% of them inside a single declaration: TransactionsManager (6 blocks, 321-1732). The bar is 500 significant lines; this is 671 over it, 2.34× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/rpc.rs crates/node/builder/src/rpc.rs— FileTooLong — 1130 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 630 over it, 2.26× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: src/engine_api.rs crates/rpc/rpc-engine-api/src/engine_api.rs— FileTooLong — 1111 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 95% of them inside a single declaration: EngineApi (8 blocks, 66-1798). The bar is 500 significant lines; this is 611 over it, 2.22× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/debug.rs crates/rpc/rpc/src/debug.rs— FileTooLong — 1052 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 87% of them inside a single declaration: DebugApi (6 blocks, 65-1439). The bar is 500 significant lines; this is 552 over it, 2.10× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: static_file/writer.rs crates/storage/provider/src/providers/static_file/writer.rs— FileTooLong — 1004 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 84% of them inside a single declaration: StaticFileProviderRW (2 blocks, 234-1790). The bar is 500 significant lines; this is 504 over it, 2.01× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/execute.rs crates/evm/evm/src/execute.rs— FileTooLong — 973 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 473 over it, 1.95× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: proof_v2/calculator.rs crates/trie/trie/src/proof_v2/calculator.rs— FileTooLong — 910 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 85% of them inside a single declaration: ProofCalculator (3 blocks, 42-1572). The bar is 500 significant lines; this is 410 over it, 1.82× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: pool/mod.rs crates/transaction-pool/src/pool/mod.rs— FileTooLong — 899 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 77% of them inside a single declaration: PoolInner (3 blocks, 140-1403). The bar is 500 significant lines; this is 399 over it, 1.80× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: src/init.rs crates/storage/db-common/src/init.rs— FileTooLong — 889 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 389 over it, 1.78× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: providers/consistent.rs crates/storage/provider/src/providers/consistent.rs— FileTooLong — 879 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 96% of them inside a single declaration: ConsistentProvider (19 blocks, 45-1410). The bar is 500 significant lines; this is 379 over it, 1.76× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: session/mod.rs crates/net/network/src/session/mod.rs— FileTooLong — 875 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 375 over it, 1.75× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: state_root_strategy/sparse_trie.rs crates/engine/tree/src/tree/state_root_strategy/sparse_trie.rs— FileTooLong — 864 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), about 74% of them inside a single declaration: SparseTrieCacheTask (2 blocks, 119-1231). The bar is 500 significant lines; this is 364 over it, 1.73× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: scripts/bench-call-summary.py .github/scripts/bench-call-summary.py— FileTooLong — 855 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 355 over it, 1.71× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: state_root_strategy/mod.rs crates/engine/tree/src/tree/state_root_strategy/mod.rs— FileTooLong — 852 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted). The bar is 500 significant lines; this is 352 over it, 1.70× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
Hotspot: crates/engine/tree/src/tree/mod.rs crates/engine/tree/src/tree/mod.rs:1581— crates/engine/tree/src/tree/mod.rs changed 40 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in EngineApiTreeHandler::on_engine_message at line 1581. 18 of those changes were fix/bug commits, and the other 22 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/engine/tree/src/tree/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/storage/provider/src/providers/database/provider.rs crates/storage/provider/src/providers/database/provider.rs:569— crates/storage/provider/src/providers/database/provider.rs changed 34 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in DatabaseProvider::save_blocks_inner at line 569. 7 of those changes were fix/bug commits, and the other 27 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/storage/provider/src/providers/database/provider.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/engine/tree/src/tree/payload_validator.rs crates/engine/tree/src/tree/payload_validator.rs:470— crates/engine/tree/src/tree/payload_validator.rs changed 29 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in BasicEngineValidator::validate_block_with_state at line 470. 9 of those changes were fix/bug commits, and the other 20 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/engine/tree/src/tree/payload_validator.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/transaction-pool/src/validate/eth.rs crates/transaction-pool/src/validate/eth.rs:457— crates/transaction-pool/src/validate/eth.rs changed 13 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 35 in EthTransactionValidator::validate_stateless at line 457. 6 of those changes were fix/bug commits, and the other 7 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/transaction-pool/src/validate/eth.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/rpc/rpc-eth-api/src/helpers/call.rs crates/rpc/rpc-eth-api/src/helpers/call.rs:65— crates/rpc/rpc-eth-api/src/helpers/call.rs changed 21 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in EthCall::simulate_v1 at line 65. 10 of those changes were fix/bug commits, and the other 11 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/rpc/rpc-eth-api/src/helpers/call.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/engine/tree/src/tree/payload_processor/prewarm.rs crates/engine/tree/src/tree/payload_processor/prewarm.rs:325— crates/engine/tree/src/tree/payload_processor/prewarm.rs changed 23 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in PrewarmCacheTask::transact_worker at line 325. 6 of those changes were fix/bug commits, and the other 17 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/engine/tree/src/tree/payload_processor/prewarm.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/ethereum/node/src/engine_ssz_proxy.rs crates/ethereum/node/src/engine_ssz_proxy.rs:578— crates/ethereum/node/src/engine_ssz_proxy.rs changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 37 in reth_node_ethereum::engine_ssz_proxy::handle_engine_ssz_request at line 578. 1 of those changes was a fix/bug commit, and the other 10 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/ethereum/node/src/engine_ssz_proxy.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/rpc/rpc/src/debug.rs crates/rpc/rpc/src/debug.rs:978— crates/rpc/rpc/src/debug.rs changed 21 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in DebugApi::debug_subscribe at line 978. 4 of those changes were fix/bug commits, and the other 17 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/rpc/rpc/src/debug.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/rpc/rpc-eth-types/src/cache/mod.rs crates/rpc/rpc-eth-types/src/cache/mod.rs:553— crates/rpc/rpc-eth-types/src/cache/mod.rs changed 12 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 31 in EthStateCacheService::poll at line 553. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/rpc/rpc-eth-types/src/cache/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/storage/storage-overlay/src/manager.rs crates/storage/storage-overlay/src/manager.rs:491— crates/storage/storage-overlay/src/manager.rs changed 23 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in OverlayManager::get_or_compute_overlay at line 491. 7 of those changes were fix/bug commits, and the other 16 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/storage/storage-overlay/src/manager.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/trie/sparse/src/arena/mod.rs crates/trie/sparse/src/arena/mod.rs:2600— crates/trie/sparse/src/arena/mod.rs changed 12 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 30 in ArenaParallelSparseTrie::update_leaves at line 2600. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/trie/sparse/src/arena/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/stages/stages/src/stages/execution/mod.rs crates/stages/stages/src/stages/execution/mod.rs:293— crates/stages/stages/src/stages/execution/mod.rs changed 13 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in ExecutionStage::execute at line 293. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/stages/stages/src/stages/execution/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/rpc/rpc/src/eth/filter.rs crates/rpc/rpc/src/eth/filter.rs:481— crates/rpc/rpc/src/eth/filter.rs changed 16 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in EthFilterInner::logs_for_filter at line 481. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/rpc/rpc/src/eth/filter.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/transaction-pool/src/pool/txpool.rs crates/transaction-pool/src/pool/txpool.rs:2113— crates/transaction-pool/src/pool/txpool.rs changed 16 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in AllTransactions::insert_tx at line 2113. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/transaction-pool/src/pool/txpool.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/node/builder/src/launch/common.rs crates/node/builder/src/launch/common.rs:498— crates/node/builder/src/launch/common.rs changed 15 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in LaunchContextWith::create_provider_factory_with_recovery at line 498. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/node/builder/src/launch/common.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/cli/commands/src/download/mod.rs crates/cli/commands/src/download/mod.rs:715— crates/cli/commands/src/download/mod.rs changed 12 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in DownloadCommand::resolve_components at line 715. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/cli/commands/src/download/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/snap-sync/src/bootstrap.rs crates/snap-sync/src/bootstrap.rs:127— crates/snap-sync/src/bootstrap.rs changed 13 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in SnapBootstrap::run at line 127. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/snap-sync/src/bootstrap.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/net/network/src/transactions/mod.rs crates/net/network/src/transactions/mod.rs:1327— crates/net/network/src/transactions/mod.rs changed 10 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in TransactionsManager::import_transactions at line 1327. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/net/network/src/transactions/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/trie/common/src/proofs.rs crates/trie/common/src/proofs.rs:522— crates/trie/common/src/proofs.rs changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in DecodedMultiProofV2::from_witness at line 522. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/trie/common/src/proofs.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/rpc/rpc/src/validation.rs crates/rpc/rpc/src/validation.rs:160— crates/rpc/rpc/src/validation.rs changed 14 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in ValidationApi::validate_message_against_block at line 160. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/rpc/rpc/src/validation.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: contrib/trie-dst/crates/reth-trie-dst/src/main.rs contrib/trie-dst/crates/reth-trie-dst/src/main.rs:209— contrib/trie-dst/crates/reth-trie-dst/src/main.rs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 60 in reth_trie_dst::run at line 209. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- contrib/trie-dst/crates/reth-trie-dst/src/main.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/storage/provider/src/providers/static_file/manager.rs crates/storage/provider/src/providers/static_file/manager.rs:1735— crates/storage/provider/src/providers/static_file/manager.rs changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in StaticFileProvider::ensure_invariants at line 1735. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/storage/provider/src/providers/static_file/manager.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/trie/trie/src/witness.rs crates/trie/trie/src/witness.rs:88— crates/trie/trie/src/witness.rs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 27 in TrieWitness::compute at line 88. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/trie/trie/src/witness.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/cli/commands/src/re_execute.rs crates/cli/commands/src/re_execute.rs:78— crates/cli/commands/src/re_execute.rs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 32 in Command::execute at line 78. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/cli/commands/src/re_execute.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: crates/ethereum/payload/src/lib.rs crates/ethereum/payload/src/lib.rs:148— crates/ethereum/payload/src/lib.rs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 32 in reth_ethereum_payload_builder::default_ethereum_payload at line 148. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/ethereum/payload/src/lib.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
ClassTooLong: DatabaseProvider crates/storage/provider/src/providers/database/provider.rs:193— ClassTooLong — 2391 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 40 methods, 54 blocks, lines 164-4086. The bar is 400 significant lines; this is 1991 over it, 5.98× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: StaticFileProvider crates/storage/provider/src/providers/static_file/manager.rs:122— ClassTooLong — 1580 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 57 methods, 18 blocks, lines 124-3155. The bar is 400 significant lines; this is 1180 over it, 3.95× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ArenaParallelSparseTrie crates/trie/sparse/src/arena/mod.rs:607— ClassTooLong — 1370 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 30 methods, 6 blocks, lines 607-2890. The bar is 400 significant lines; this is 970 over it, 3.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: EngineApi crates/rpc/rpc-engine-api/src/engine_api.rs:66— ClassTooLong — 1058 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 73 methods, 8 blocks, lines 66-1798. The bar is 400 significant lines; this is 658 over it, 2.65× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: DebugApi crates/rpc/rpc/src/debug.rs:65— ClassTooLong — 916 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 23 methods, 6 blocks, lines 65-1439. The bar is 400 significant lines; this is 516 over it, 2.29× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: StaticFileProviderRW crates/storage/provider/src/providers/static_file/writer.rs:234— ClassTooLong — 848 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 56 methods, 2 blocks, lines 234-1790. The bar is 400 significant lines; this is 448 over it, 2.12× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ConsistentProvider crates/storage/provider/src/providers/consistent.rs:45— ClassTooLong — 847 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 7 methods, 19 blocks, lines 45-1410. The bar is 400 significant lines; this is 447 over it, 2.12× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Discv4Service crates/net/discv4/src/lib.rs:498— ClassTooLong — 827 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 57 methods, 4 blocks, lines 498-2066. The bar is 400 significant lines; this is 427 over it, 2.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ProofCalculator crates/trie/trie/src/proof_v2/calculator.rs:42— ClassTooLong — 769 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 26 methods, 3 blocks, lines 42-1572. The bar is 400 significant lines; this is 369 over it, 1.92× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: TransactionsManager crates/net/network/src/transactions/mod.rs:321— ClassTooLong — 728 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 30 methods, 6 blocks, lines 321-1732. The bar is 400 significant lines; this is 328 over it, 1.82× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: TxPool crates/transaction-pool/src/pool/txpool.rs:94— ClassTooLong — 723 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 57 methods, 5 blocks, lines 94-1429. The bar is 400 significant lines; this is 323 over it, 1.81× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: PeersManager crates/net/network/src/peers.rs:58— ClassTooLong — 707 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 56 methods, 3 blocks, lines 58-1390. The bar is 400 significant lines; this is 307 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: RpcBlockchainStateProvider crates/storage/rpc-provider/src/lib.rs:921— ClassTooLong — 696 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 7 methods, 31 blocks, lines 921-1983. The bar is 400 significant lines; this is 296 over it, 1.74× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: PoolInner crates/transaction-pool/src/pool/mod.rs:140— ClassTooLong — 694 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 86 methods, 3 blocks, lines 140-1403. The bar is 400 significant lines; this is 294 over it, 1.74× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: OverlayStateProvider crates/storage/storage-overlay/src/provider.rs:161— ClassTooLong — 667 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 11 methods, 18 blocks, lines 161-1057. The bar is 400 significant lines; this is 267 over it, 1.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: NetworkManager crates/net/network/src/manager.rs:108— ClassTooLong — 653 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 36 methods, 4 blocks, lines 108-1207. The bar is 400 significant lines; this is 253 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: SparseTrieCacheTask crates/engine/tree/src/tree/state_root_strategy/sparse_trie.rs:119— ClassTooLong — 641 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 30 methods, 2 blocks, lines 119-1231. The bar is 400 significant lines; this is 241 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: LaunchContextWith crates/node/builder/src/launch/common.rs:261— ClassTooLong — 621 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 60 methods, 10 blocks, lines 261-1346. The bar is 400 significant lines; this is 221 over it, 1.55× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: RpcAddOns crates/node/builder/src/rpc.rs:531— ClassTooLong — 603 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 22 methods, 8 blocks, lines 531-1463. The bar is 400 significant lines; this is 203 over it, 1.51× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ProviderFactory crates/storage/provider/src/providers/database/mod.rs:75— ClassTooLong — 559 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 21 methods, 26 blocks, lines 75-1007. The bar is 400 significant lines; this is 159 over it, 1.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: BlockchainProvider crates/storage/provider/src/providers/blockchain_provider.rs:66— ClassTooLong — 527 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 8 methods, 30 blocks, lines 66-1050. The bar is 400 significant lines; this is 127 over it, 1.32× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: TransactionFetcher crates/net/network/src/transactions/fetcher.rs:94— ClassTooLong — 520 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 25 methods, 4 blocks, lines 94-1147. The bar is 400 significant lines; this is 120 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: EthTransactionValidator crates/transaction-pool/src/validate/eth.rs:80— ClassTooLong — 501 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 39 methods, 6 blocks, lines 80-1524. The bar is 400 significant lines; this is 101 over it, 1.25× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: TraceApi crates/rpc/rpc/src/trace.rs:50— ClassTooLong — 501 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 19 methods, 8 blocks, lines 50-840. The bar is 400 significant lines; this is 101 over it, 1.25× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: RpcBlockchainProvider crates/storage/rpc-provider/src/lib.rs:133— ClassTooLong — 499 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted), 8 methods, 21 blocks, lines 133-915. The bar is 400 significant lines; this is 99 over it, 1.25× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
MethodTooLong: SessionManager.poll crates/net/network/src/session/mod.rs:505— MethodTooLong — poll runs 206 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 106 over it, 2.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Input.mutate_at contrib/trie-dst/crates/reth-trie-dst/src/input.rs:243— MethodTooLong — mutate_at runs 185 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 85 over it, 1.85× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: NetworkManager.on_swarm_event crates/net/network/src/manager.rs:814— MethodTooLong — on_swarm_event runs 178 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 78 over it, 1.78× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: EngineApiTreeHandler.on_engine_message crates/engine/tree/src/tree/mod.rs:1581— MethodTooLong — on_engine_message runs 176 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 76 over it, 1.76× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ArenaParallelSparseTrie.update_leaves crates/trie/sparse/src/arena/mod.rs:2600— MethodTooLong — update_leaves runs 165 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 65 over it, 1.65× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: EthBundle.call_bundle crates/rpc/rpc/src/eth/bundle.rs:51— MethodTooLong — call_bundle runs 162 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 62 over it, 1.62× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DatabaseProvider.save_blocks_inner crates/storage/provider/src/providers/database/provider.rs:569— MethodTooLong — save_blocks_inner runs 160 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 60 over it, 1.60× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: StateRoot.calculate crates/trie/trie/src/trie.rs:174— MethodTooLong — calculate runs 157 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 57 over it, 1.57× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: RpcServerConfig.start crates/rpc/rpc-builder/src/lib.rs:1409— MethodTooLong — start runs 154 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 54 over it, 1.54× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DefaultStateRootStrategy.spawn_sparse_trie_task crates/engine/tree/src/tree/state_root_strategy/mod.rs:616— MethodTooLong — spawn_sparse_trie_task runs 151 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 51 over it, 1.51× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: BundleAccount.update_and_create_revert crates/trie/common/src/bundle_state/bundle_account.rs:138— MethodTooLong — update_and_create_revert runs 146 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 46 over it, 1.46× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Discovery.new crates/net/network/src/discovery.rs:90— MethodTooLong — new runs 145 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 45 over it, 1.45× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ExecutionStage.execute crates/stages/stages/src/stages/execution/mod.rs:293— MethodTooLong — execute runs 145 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 45 over it, 1.45× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Command.static_files_stats_table crates/cli/commands/src/db/stats.rs:223— MethodTooLong — static_files_stats_table runs 143 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 43 over it, 1.43× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ActiveSession.poll crates/net/network/src/session/active.rs:771— MethodTooLong — poll runs 138 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 38 over it, 1.38× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ChangesetCache.get_or_compute_range crates/storage/storage-overlay/src/changeset_cache.rs:267— MethodTooLong — get_or_compute_range runs 136 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 36 over it, 1.36× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: RuntimeBuilder.build crates/tasks/src/runtime.rs:947— MethodTooLong — build runs 136 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 36 over it, 1.36× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: EthSimBundle.sim_bundle_inner crates/rpc/rpc/src/eth/sim_bundle.rs:279— MethodTooLong — sim_bundle_inner runs 134 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 34 over it, 1.34× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: OverlayBuilder.build_state_trie_overlay_at_frontiers crates/storage/storage-overlay/src/builder.rs:407— MethodTooLong — build_state_trie_overlay_at_frontiers runs 134 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 34 over it, 1.34× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ArenaParallelSparseTrie.update_cached_rlp crates/trie/sparse/src/arena/mod.rs:959— MethodTooLong — update_cached_rlp runs 134 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 34 over it, 1.34× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: TestingApi.build_payload_v1 crates/rpc/rpc/src/testing.rs:119— MethodTooLong — build_payload_v1 runs 127 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 27 over it, 1.27× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DatabaseProvider.take_state_above crates/storage/provider/src/providers/database/provider.rs:3025— MethodTooLong — take_state_above runs 127 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 27 over it, 1.27× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: MerkleStage.execute crates/stages/stages/src/stages/merkle.rs:192— MethodTooLong — execute runs 124 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 24 over it, 1.24× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ProofCalculator.next_uncached_key_range crates/trie/trie/src/proof_v2/calculator.rs:971— MethodTooLong — next_uncached_key_range runs 122 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 22 over it, 1.22× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Command.execute crates/cli/commands/src/db/get.rs:133— MethodTooLong — execute runs 120 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 20 over it, 1.20× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
TooManyMethods: EngineApiTreeHandler crates/engine/tree/src/tree/mod.rs:267— TooManyMethods — 89 methods. The bar is 30 methods; this is 59 over it, 2.97× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PoolInner crates/transaction-pool/src/pool/mod.rs:140— TooManyMethods — 86 methods. The bar is 30 methods; this is 56 over it, 2.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: TreeConfig crates/engine/primitives/src/config.rs:117— TooManyMethods — 75 methods. The bar is 30 methods; this is 45 over it, 2.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: EngineApi crates/rpc/rpc-engine-api/src/engine_api.rs:66— TooManyMethods — 73 methods. The bar is 30 methods; this is 43 over it, 2.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LaunchContextWith crates/node/builder/src/launch/common.rs:261— TooManyMethods — 60 methods. The bar is 30 methods; this is 30 over it, 2.00× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Discv4Service crates/net/discv4/src/lib.rs:498— TooManyMethods — 57 methods. The bar is 30 methods; this is 27 over it, 1.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: StaticFileProvider crates/storage/provider/src/providers/static_file/manager.rs:122— TooManyMethods — 57 methods. The bar is 30 methods; this is 27 over it, 1.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: TxPool crates/transaction-pool/src/pool/txpool.rs:94— TooManyMethods — 57 methods. The bar is 30 methods; this is 27 over it, 1.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PeersManager crates/net/network/src/peers.rs:58— TooManyMethods — 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: StaticFileProviderRW crates/storage/provider/src/providers/static_file/writer.rs:234— TooManyMethods — 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: NetworkConfigBuilder crates/net/network/src/config.rs:191— TooManyMethods — 52 methods. The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DefaultRpcServerArgs crates/node/core/src/args/rpc_server.rs:55— TooManyMethods — 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: RocksDBProvider crates/storage/provider/src/providers/rocksdb/provider.rs:519— TooManyMethods — 48 methods, declared across 2 files: rocksdb/provider.rs (43), rocksdb/invariants.rs (5). The bar is 30 methods; this is 18 over it, 1.60× the bar. That list is where to read them, not a suggestion to split the file: the members belong to the type wherever they are declared, so moving them between files leaves the count unchanged. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: EthApiBuilder crates/rpc/rpc/src/eth/builder.rs:31— TooManyMethods — 47 methods. The bar is 30 methods; this is 17 over it, 1.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: CanonicalInMemoryState crates/chain-state/src/in_memory.rs:174— TooManyMethods — 43 methods. The bar is 30 methods; this is 13 over it, 1.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DatabaseProvider crates/storage/provider/src/providers/database/provider.rs:193— TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Runtime crates/tasks/src/runtime.rs:365— TooManyMethods — 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: EthTransactionValidator crates/transaction-pool/src/validate/eth.rs:80— TooManyMethods — 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Chain crates/evm/execution-types/src/chain.rs:30— TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: NodeConfig crates/node/core/src/node_config.rs:91— TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SparseStateTrie crates/trie/sparse/src/state.rs:29— TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Cursor crates/storage/libmdbx-rs/src/cursor.rs:17— TooManyMethods — 37 methods. The bar is 30 methods; this is 7 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: NetworkManager crates/net/network/src/manager.rs:108— TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ExecutionOutcome crates/evm/execution-types/src/execution_outcome.rs:49— TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DefaultEngineValues crates/node/core/src/args/engine.rs:28— TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Change coupling: disk.rs ↔ noop.rs crates/transaction-pool/src/blobstore/disk.rs:1— `crates/transaction-pool/src/blobstore/disk.rs` and `crates/transaction-pool/src/blobstore/noop.rs` change together 100% of the time (11 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module — a sibling reference still needs an import — so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `ea10653e` fix(net): decode wire bitvectors into typed blob cell masks (#27089); `71e5cc84` feat(txpool): track blob cell availability (#25463); `d769d96f` feat(engine): add has blobs rpc (#25589) — run `git show` on any of them.
Change coupling: mem.rs ↔ noop.rs crates/transaction-pool/src/blobstore/mem.rs:1— `crates/transaction-pool/src/blobstore/mem.rs` and `crates/transaction-pool/src/blobstore/noop.rs` change together 100% of the time (11 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module — a sibling reference still needs an import — so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `ea10653e` fix(net): decode wire bitvectors into typed blob cell masks (#27089); `71e5cc84` feat(txpool): track blob cell availability (#25463); `d769d96f` feat(engine): add has blobs rpc (#25589) — run `git show` on any of them.
Change coupling: execution.rs ↔ merkle.rs crates/cli/commands/src/stage/dump/execution.rs:1— `crates/cli/commands/src/stage/dump/execution.rs` and `crates/cli/commands/src/stage/dump/merkle.rs` change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module — a sibling reference still needs an import — so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `dc22ece4` fix(cli): use HeaderTy for stage dump headers (#23274); `370a548f` refactor(db): derive Clone for DatabaseEnv (#21641); `412f39e2` chore(consensus): Remove associated type `Consensus::Error` (#20843) — run `git show` on any of them.
Change coupling: rocksdb.rs ↔ metrics.rs crates/storage/provider/src/bal/rocksdb.rs:1— `crates/storage/provider/src/bal/rocksdb.rs` and `crates/storage/provider/src/providers/rocksdb/metrics.rs` change together 70% of the time (7 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `f5060248` revert: "fix(storage): revert BAL store activation" (#27472); `7e31e83e` fix(storage): revert BAL store activation (#27470); `8ff32376` revert: restore RocksDB BAL storage (#26789) — run `git show` on any of them.
Change coupling: common.rs ↔ metrics.rs crates/cli/commands/src/common.rs:1— `crates/cli/commands/src/common.rs` and `crates/storage/provider/src/providers/rocksdb/metrics.rs` change together 70% of the time (7 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `f5060248` revert: "fix(storage): revert BAL store activation" (#27472); `7e31e83e` fix(storage): revert BAL store activation (#27470); `8ff32376` revert: restore RocksDB BAL storage (#26789) — run `git show` on any of them.
Change coupling: rpc_state_cache.rs ↔ config.rs crates/node/core/src/args/rpc_state_cache.rs:1— `crates/node/core/src/args/rpc_state_cache.rs` and `crates/rpc/rpc-eth-types/src/cache/config.rs` change together 70% of the time (7 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `fa167700` feat(rpc): add cache byte limits and idle eviction (#27351); `18e6014a` feat(rpc): prewarm BAL cache from local replay (#24097); `b77a6bfd` refactor(rpc): remove dead header cache (#26836) — run `git show` on any of them.
Change coupling: mock.rs ↔ noop.rs crates/storage/provider/src/test_utils/mock.rs:1— `crates/storage/provider/src/test_utils/mock.rs` and `crates/storage/provider/src/test_utils/noop.rs` change together 67% of the time (26 of the 39 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module — a sibling reference still needs an import — so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 26 shared commits counted here, the most recent 3 are `7764b9a0` chore: add `OmmersProvider` trait (#13331); `62e2cbfe` chore: remove unused evm env provider fns (#13272); `c9c6eb5a` chore: rm unused evm provider fn (#13184) — run `git show` on any of them.
Change coupling: either.rs ↔ noop.rs crates/evm/evm/src/either.rs:1— `crates/evm/evm/src/either.rs` and `crates/evm/evm/src/noop.rs` change together 67% of the time (8 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module — a sibling reference still needs an import — so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `4f73e1a4` chore: remove `BatchExecutor` (#14453) (at that commit the files were still `crates/evm/src/either.rs` and `crates/evm/src/noop.rs`); `5fcefcea` refactor: remove `PruneModes` from batch executor (#14025) (at that commit the files were still `crates/evm/src/either.rs` and `crates/evm/src/noop.rs`); `af1eb610` feat(perf): integrate OnStateHook in executor (#11345) (at that commit the files were still `crates/evm/src/either.rs` and `crates/evm/src/noop.rs`) — run `git show` on any of them.
Change coupling: db.rs ↔ mock.rs crates/rpc/rpc-eth-types/src/cache/db.rs:1— `crates/rpc/rpc-eth-types/src/cache/db.rs` and `crates/storage/provider/src/test_utils/mock.rs` change together 65% of the time (20 of the 31 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 20 shared commits counted here, the most recent 3 are `a05960ab` feat(stateless): make witness generation conform to the draft specs (…; `21cf573d` fix: move `bytecode_by_hash` from `StateProvider` to a dedicated `Byt…; `fc7a3e5b` chore: use shorter map names (#14445) — run `git show` on any of them.
Change coupling: db.rs ↔ historical.rs crates/rpc/rpc-eth-types/src/cache/db.rs:1— `crates/rpc/rpc-eth-types/src/cache/db.rs` and `crates/storage/provider/src/providers/state/historical.rs` change together 65% of the time (20 of the 31 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 20 shared commits counted here, the most recent 3 are `a05960ab` feat(stateless): make witness generation conform to the draft specs (…; `21cf573d` fix: move `bytecode_by_hash` from `StateProvider` to a dedicated `Byt…; `fc7a3e5b` chore: use shorter map names (#14445) — run `git show` on any of them.
Change coupling: index_storage_history.rs ↔ provider.rs crates/stages/stages/src/stages/index_storage_history.rs:1— `crates/stages/stages/src/stages/index_storage_history.rs` and `crates/storage/provider/src/providers/database/provider.rs` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `7744d20c` test(storage): remove redundant tests (#27829); `effa0ab4` fix(provider): read changesets from static files during unwind (#21528); `ab418642` fix(stages): commit RocksDB batches before flush and configure immedi… — run `git show` on any of them.
Change coupling: cache.rs ↔ storage.rs crates/exex/exex/src/wal/cache.rs:1— `crates/exex/exex/src/wal/cache.rs` and `crates/exex/exex/src/wal/storage.rs` change together 58% of the time (7 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module — a sibling reference still needs an import — so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `e882d00f` feat(exex): WAL metrics (#11431); `9c041d25` fix(exex): set next file ID when creating WAL storage (#11372); `bf679b43` feat(exex): finalize WAL below the given block (#11324) — run `git show` on any of them.
Change coupling: lib.rs ↔ lib.rs crates/ethereum/payload/src/lib.rs:1— `crates/ethereum/payload/src/lib.rs` and `crates/payload/builder/src/lib.rs` change together 57% of the time (8 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `559b0b9f` refactor(payload): store recovered block in built payload (#24403); `044db3ec` feat: implement try into v6 (#23497); `ddc9375a` chore: remove executed_block from EthBuiltPayload (#14017) — run `git show` on any of them.
Change coupling: blockchain_provider.rs ↔ noop.rs crates/storage/provider/src/providers/blockchain_provider.rs:1— `crates/storage/provider/src/providers/blockchain_provider.rs` and `crates/storage/storage-api/src/noop.rs` change together 56% of the time (25 of the 45 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 25 shared commits counted here, the most recent 3 are `eb1214b5` perf: share pending block and receipts (#27427); `6165a999` refactor(provider): remove historical state conversion (#26904); `2125dc6b` refactor(storage): move OverlayStateProvider and let it use a Provide… — run `git show` on any of them.
Change coupling: import_era.rs ↔ lib.rs crates/cli/commands/src/import_era.rs:1— `crates/cli/commands/src/import_era.rs` and `crates/era-utils/src/lib.rs` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `e2563b7a` feat: add -`-with-receipts` to `import-era` to store receipts (#26436); `535bf429` feat(era): extend import to era file (#25404); `256ceb66` feat(cli): support ERE (.erae) files in import-era (#25122) — run `git show` on any of them.
Change coupling: lib.rs ↔ test_utils.rs crates/ethereum/payload/src/lib.rs:1— `crates/ethereum/payload/src/lib.rs` and `crates/payload/builder/src/test_utils.rs` change together 53% of the time (9 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `559b0b9f` refactor(payload): store recovered block in built payload (#24403); `044db3ec` feat: implement try into v6 (#23497); `ddc9375a` chore: remove executed_block from EthBuiltPayload (#14017) — run `git show` on any of them.
Change coupling: mem.rs ↔ noop.rs crates/transaction-pool/src/blobstore/mem.rs:1— `crates/transaction-pool/src/blobstore/mem.rs` and `crates/transaction-pool/src/noop.rs` change together 50% of the time (10 of the 20 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `ea10653e` fix(net): decode wire bitvectors into typed blob cell masks (#27089); `71e5cc84` feat(txpool): track blob cell availability (#25463); `d769d96f` feat(engine): add has blobs rpc (#25589) — run `git show` on any of them.
Change coupling: merkle.rs ↔ unwind.rs crates/cli/commands/src/stage/dump/merkle.rs:1— `crates/cli/commands/src/stage/dump/merkle.rs` and `crates/cli/commands/src/stage/unwind.rs` change together 50% of the time (8 of the 16 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `370a548f` refactor(db): derive Clone for DatabaseEnv (#21641); `1ba12aee` chore: remove `NoopBlockExecutorProvider` (#16060); `5fcefcea` refactor: remove `PruneModes` from batch executor (#14025) — run `git show` on any of them.
Change coupling: chain_info.rs ↔ mod.rs crates/chain-state/src/chain_info.rs:1— `crates/chain-state/src/chain_info.rs` and `crates/storage/provider/src/providers/mod.rs` change together 50% of the time (8 of the 16 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `caac226c` chore: make CanonicalInMemoryState generic over sealed header and blo…; `1ba631ba` feat: store safe block num as well (#11648); `d9936a96` Use more appropriate names for forkchoice subscriptions (#10401) — run `git show` on any of them.
Change coupling: mod.rs ↔ sidebar-cli-reth.ts crates/cli/commands/src/db/mod.rs:1— `crates/cli/commands/src/db/mod.rs` and `docs/vocs/sidebar-cli-reth.ts` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) and are written in DIFFERENT LANGUAGES, so no import can join them and they cannot be co-located into one unit — they compile and ship as separate artifacts. What binds them is a CONTRACT across that boundary — an event or message name, a route, a serialised shape — that each side currently spells out on its own, which is exactly why a change to one drags the other. Declare that contract once where both sides read it (a shared schema, a generated constants file, an interface-definition file) so a change on one side fails the other's build instead of drifting silently; where the surface is too small to be worth that, name the counterpart in a comment on both sides so the next reader finds it. There is nothing here to merge. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `03a308da` feat(cli): add `reth db migrate-v2` for v1→v2 storage migration (#23422); `ce2a194f` feat(cli): add db stage-checkpoints command (#22579); `56bbb3ce` feat(cli): add `reth db prune-checkpoints` command (#22288) — run `git show` on any of them.
Change coupling: in_memory.rs ↔ input.rs crates/chain-state/src/in_memory.rs:1— `crates/chain-state/src/in_memory.rs` and `crates/trie/common/src/input.rs` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `e58aa09f` perf(engine): return sorted data from compute_trie_input (#19340); `5106f64f` fix(engine): recompute trie updates for forked blocks (#16568); `6c855977` revert: fix(engine): recompute trie updates for forked blocks (#16500… — run `git show` on any of them.
Change coupling: manager.rs ↔ cache.rs crates/exex/exex/src/manager.rs:1— `crates/exex/exex/src/manager.rs` and `crates/exex/exex/src/wal/cache.rs` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `565fd4d1` chore(exex): emit warn log when WAL grows beyond a certain number of …; `e882d00f` feat(exex): WAL metrics (#11431); `bf679b43` feat(exex): finalize WAL below the given block (#11324) — run `git show` on any of them.
Change coupling: test_utils.rs ↔ lib.rs crates/ethereum/evm/src/test_utils.rs:1— `crates/ethereum/evm/src/test_utils.rs` and `crates/evm/evm/src/lib.rs` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `0df9791b` chore: bump alloy-evm to 0.28.0 (#22636); `6a50aa3e` feat: make more EVM and RPC conversions fallible (#18685); `f5c2502f` feat: delay block -> payload conversions (#17681) — run `git show` on any of them.
Change coupling: blockchain_provider.rs ↔ changeset_cache.rs crates/storage/provider/src/providers/blockchain_provider.rs:1— `crates/storage/provider/src/providers/blockchain_provider.rs` and `crates/storage/storage-overlay/src/changeset_cache.rs` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `7744d20c` test(storage): remove redundant tests (#27829); `835e4286` perf(trie): skip historical trie changesets with complete overlays (#…; `f0166c32` feat(overlay): Use OverlayStateProvider for most StateProviders in ho… — run `git show` on any of them.
Duplicated block (9 lines × 2) crates/cli/commands/src/db/copy.rs:48— crates/cli/commands/src/db/copy.rs:48-56 | crates/cli/commands/src/db/migrate_v2.rs:414-422 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (9 lines × 2) crates/engine/tree/src/tree/mod.rs:1704— crates/engine/tree/src/tree/mod.rs:1704-1712 | crates/engine/tree/src/tree/mod.rs:1785-1793 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/ethereum/evm/src/executor.rs:328— crates/ethereum/evm/src/executor.rs:328-336 | crates/ethereum/evm/src/executor.rs:372-380 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/rpc/rpc-engine-api/src/engine_api.rs:877— crates/rpc/rpc-engine-api/src/engine_api.rs:877-885 | crates/rpc/rpc-engine-api/src/engine_api.rs:973-981 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/rpc/rpc-eth-api/src/helpers/state.rs:166— crates/rpc/rpc-eth-api/src/helpers/state.rs:166-174 | crates/rpc/rpc-eth-api/src/helpers/state.rs:200-208 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/rpc/rpc-eth-types/src/gas_oracle.rs:136— crates/rpc/rpc-eth-types/src/gas_oracle.rs:136-144 | crates/rpc/rpc-eth-types/src/gas_oracle.rs:288-296 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/rpc/rpc/src/otterscan.rs:192— crates/rpc/rpc/src/otterscan.rs:192-200 | crates/rpc/rpc/src/otterscan.rs:208-216 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/rpc/rpc/src/trace.rs:608— crates/rpc/rpc/src/trace.rs:608-616 | crates/rpc/rpc/src/trace.rs:644-652 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/stages/stages/src/stages/utils.rs:346— crates/stages/stages/src/stages/utils.rs:346-354 | crates/stages/stages/src/stages/utils.rs:389-397 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/stages/stages/src/stages/utils.rs:568— crates/stages/stages/src/stages/utils.rs:568-576 | crates/stages/stages/src/stages/utils.rs:613-621 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/storage/nippy-jar/src/consistency.rs:67— crates/storage/nippy-jar/src/consistency.rs:67-81 | crates/storage/nippy-jar/src/consistency.rs:105-113 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/storage/provider/src/providers/database/provider.rs:3328— crates/storage/provider/src/providers/database/provider.rs:3328-3337 | crates/storage/provider/src/providers/database/provider.rs:3354-3362 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/storage/rpc-provider/src/lib.rs:594— crates/storage/rpc-provider/src/lib.rs:594-602 | crates/storage/rpc-provider/src/lib.rs:677-686 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/storage/storage-overlay/src/provider.rs:739— crates/storage/storage-overlay/src/provider.rs:739-747 | crates/storage/storage-overlay/src/provider.rs:757-765 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/transaction-pool/src/blobstore/disk.rs:393— crates/transaction-pool/src/blobstore/disk.rs:393-401 | crates/transaction-pool/src/blobstore/mem.rs:229-237 — before extracting anything, compare `crates/transaction-pool/src/blobstore/disk.rs` and `crates/transaction-pool/src/blobstore/mem.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) crates/trie/common/src/hashed_state.rs:565— crates/trie/common/src/hashed_state.rs:565-573 | crates/trie/common/src/updates.rs:654-662 — before extracting anything, compare `crates/trie/common/src/hashed_state.rs` and `crates/trie/common/src/updates.rs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) crates/trie/common/src/proofs.rs:243— crates/trie/common/src/proofs.rs:243-251 | crates/trie/common/src/proofs.rs:724-732 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/trie/common/src/target_v2.rs:237— crates/trie/common/src/target_v2.rs:237-245 | crates/trie/common/src/target_v2.rs:269-277 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/trie/trie/src/hashed_cursor/post_state.rs:198— crates/trie/trie/src/hashed_cursor/post_state.rs:198-206 | crates/trie/trie/src/trie_cursor/in_memory.rs:147-155 — before extracting anything, compare `crates/trie/trie/src/hashed_cursor/post_state.rs` and `crates/trie/trie/src/trie_cursor/in_memory.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 98 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) crates/era/src/era/file.rs:220— crates/era/src/era/file.rs:220-228 | crates/era/src/era1/file.rs:283-291 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) crates/stages/stages/src/stages/hashing_account.rs:219— crates/stages/stages/src/stages/hashing_account.rs:219-228 | crates/stages/stages/src/stages/hashing_storage.rs:154-162 — before extracting anything, compare `crates/stages/stages/src/stages/hashing_account.rs` and `crates/stages/stages/src/stages/hashing_storage.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) crates/engine/tree/src/tree/trie_updates.rs:41— crates/engine/tree/src/tree/trie_updates.rs:41-49 | crates/engine/tree/src/tree/trie_updates.rs:76-84 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/era/src/era/types/consensus.rs:99— crates/era/src/era/types/consensus.rs:99-107 | crates/era/src/era/types/consensus.rs:215-223 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) crates/storage/provider/src/test_utils/blocks.rs:299— crates/storage/provider/src/test_utils/blocks.rs:299-307 | crates/storage/provider/src/test_utils/blocks.rs:440-449 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Off the main sequence: reth-db-models — reth-db-models: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
Off the main sequence: reth-ipc — reth-ipc: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
Off the main sequence: reth-metrics — reth-metrics: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 28 project(s), so it's rigid to change.
Off the main sequence: reth-net-banlist — reth-net-banlist: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 4 project(s), so it's rigid to change.
Off the main sequence: reth-net-nat — reth-net-nat: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 4 project(s), so it's rigid to change.
Off the main sequence: reth-network-peers — reth-network-peers: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 17 project(s), so it's rigid to change.
Off the main sequence: reth-prune-types — reth-prune-types: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 17 project(s), so it's rigid to change.
Off the main sequence: reth-tokio-util — reth-tokio-util: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 9 project(s), so it's rigid to change.
Off the main sequence: reth-tracing-otlp — reth-tracing-otlp: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
Off the main sequence: reth-stages-types — reth-stages-types: abstractness 0.00, instability 0.06, distance 0.94 — zone of pain — concrete and depended on by 17 project(s), so it's rigid to change.
Off the main sequence: reth-tasks — reth-tasks: abstractness 0.03, instability 0.03, distance 0.94 — zone of pain — concrete and depended on by 28 project(s), so it's rigid to change.
Off the main sequence: reth-rpc-layer — reth-rpc-layer: abstractness 0.08, instability 0.00, distance 0.92 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
Off the main sequence: reth-static-file-types — reth-static-file-types: abstractness 0.00, instability 0.08, distance 0.92 — zone of pain — concrete and depended on by 11 project(s), so it's rigid to change.
Off the main sequence: reth-storage-errors — reth-storage-errors: abstractness 0.00, instability 0.11, distance 0.89 — zone of pain — concrete and depended on by 17 project(s), so it's rigid to change.
Off the main sequence: reth-execution-types — reth-execution-types: abstractness 0.05, instability 0.09, distance 0.86 — zone of pain — concrete and depended on by 20 project(s), so it's rigid to change.
Off the main sequence: reth-era — reth-era: abstractness 0.15, instability 0.00, distance 0.85 — zone of pain — concrete and depended on by 4 project(s), so it's rigid to change.
Off the main sequence: reth-cli-runner — reth-cli-runner: abstractness 0.00, instability 0.20, distance 0.80 — zone of pain — concrete and depended on by 4 project(s), so it's rigid to change.
Off the main sequence: reth-etl — reth-etl: abstractness 0.00, instability 0.20, distance 0.80 — zone of pain — concrete and depended on by 4 project(s), so it's rigid to change.
Off the main sequence: reth-ecies — reth-ecies: abstractness 0.00, instability 0.25, distance 0.75 — zone of pain — concrete and depended on by 3 project(s), so it's rigid to change.
Off the main sequence: reth-ethereum-forks — reth-ethereum-forks: abstractness 0.25, instability 0.00, distance 0.75 — zone of pain — concrete and depended on by 10 project(s), so it's rigid to change.
Off the main sequence: reth-cli-util — reth-cli-util: abstractness 0.00, instability 0.29, distance 0.71 — zone of pain — concrete and depended on by 5 project(s), so it's rigid to change.
Off the main sequence: reth-network-types — reth-network-types: abstractness 0.00, instability 0.29, distance 0.71 — zone of pain — concrete and depended on by 5 project(s), so it's rigid to change.
Off the main sequence: reth-tracing — reth-tracing: abstractness 0.13, instability 0.17, distance 0.71 — zone of pain — concrete and depended on by 5 project(s), so it's rigid to change.
Duplicated block (11 lines × 2) crates/cli/commands/src/download/manifest.rs:289— crates/cli/commands/src/download/manifest.rs:289-299 | crates/cli/commands/src/download/manifest.rs:319-329 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/era/src/era1/types/execution.rs:420— crates/era/src/era1/types/execution.rs:420-430 | crates/era/src/ere/types/execution.rs:488-498 — before extracting anything, compare `crates/era/src/era1/types/execution.rs` and `crates/era/src/ere/types/execution.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 2) crates/net/discv4/src/lib.rs:1636— crates/net/discv4/src/lib.rs:1636-1646 | crates/net/discv4/src/lib.rs:1648-1658 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/net/ecies/src/codec.rs:67— crates/net/ecies/src/codec.rs:67-77 | crates/net/ecies/src/codec.rs:86-96 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/net/network/src/error.rs:251— crates/net/network/src/error.rs:251-261 | crates/net/network/src/error.rs:272-282 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/rpc/rpc-engine-api/src/engine_api.rs:1134— crates/rpc/rpc-engine-api/src/engine_api.rs:1134-1144 | crates/rpc/rpc-engine-api/src/engine_api.rs:1178-1188 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/rpc/rpc-engine-api/src/engine_api.rs:1398— crates/rpc/rpc-engine-api/src/engine_api.rs:1398-1408 | crates/rpc/rpc-engine-api/src/engine_api.rs:1427-1437 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/stages/stages/src/stages/hashing_account.rs:234— crates/stages/stages/src/stages/hashing_account.rs:234-244 | crates/stages/stages/src/stages/hashing_storage.rs:174-184 — before extracting anything, compare `crates/stages/stages/src/stages/hashing_account.rs` and `crates/stages/stages/src/stages/hashing_storage.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 2) crates/storage/db-common/src/init.rs:694— crates/storage/db-common/src/init.rs:694-704 | crates/storage/db-common/src/init.rs:766-776 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/storage/nippy-jar/src/cursor.rs:94— crates/storage/nippy-jar/src/cursor.rs:94-104 | crates/storage/nippy-jar/src/cursor.rs:135-145 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/storage/provider/src/providers/static_file/writer.rs:1318— crates/storage/provider/src/providers/static_file/writer.rs:1318-1328 | crates/storage/provider/src/providers/static_file/writer.rs:1381-1391 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/storage/storage-overlay/src/manager.rs:865— crates/storage/storage-overlay/src/manager.rs:865-875 | crates/storage/storage-overlay/src/manager.rs:976-986 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/storage/storage-overlay/src/manager.rs:894— crates/storage/storage-overlay/src/manager.rs:894-904 | crates/storage/storage-overlay/src/manager.rs:998-1008 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/trie/trie/src/hashed_cursor/post_state.rs:310— crates/trie/trie/src/hashed_cursor/post_state.rs:310-322 | crates/trie/trie/src/trie_cursor/in_memory.rs:297-307 — before extracting anything, compare `crates/trie/trie/src/hashed_cursor/post_state.rs` and `crates/trie/trie/src/trie_cursor/in_memory.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 98 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 2) crates/prune/prune/src/segments/user/account_history.rs:294— crates/prune/prune/src/segments/user/account_history.rs:294-304 | crates/prune/prune/src/segments/user/storage_history.rs:297-308 — before extracting anything, compare `crates/prune/prune/src/segments/user/account_history.rs` and `crates/prune/prune/src/segments/user/storage_history.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 116 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 2) crates/cli/commands/src/db/account_storage.rs:48— crates/cli/commands/src/db/account_storage.rs:48-58 | crates/cli/commands/src/db/account_storage.rs:81-92 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/engine/tree/src/tree/mod.rs:3476— crates/engine/tree/src/tree/mod.rs:3476-3486 | crates/engine/tree/src/tree/mod.rs:3508-3518 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/net/network/src/peers.rs:940— crates/net/network/src/peers.rs:940-950 | crates/net/network/src/peers.rs:1073-1083 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) crates/prune/prune/src/segments/user/account_history.rs:69— crates/prune/prune/src/segments/user/account_history.rs:69-79 | crates/prune/prune/src/segments/user/storage_history.rs:70-80 — before extracting anything, compare `crates/prune/prune/src/segments/user/account_history.rs` and `crates/prune/prune/src/segments/user/storage_history.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 116 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) crates/rpc/rpc-eth-api/src/helpers/transaction.rs:557— crates/rpc/rpc-eth-api/src/helpers/transaction.rs:557-562 | crates/rpc/rpc-eth-api/src/helpers/transaction.rs:633-638 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) crates/stages/stages/src/stages/index_account_history.rs:150— crates/stages/stages/src/stages/index_account_history.rs:150-155 | crates/stages/stages/src/stages/index_storage_history.rs:154-159 — before extracting anything, compare `crates/stages/stages/src/stages/index_account_history.rs` and `crates/stages/stages/src/stages/index_storage_history.rs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) crates/storage/libmdbx-rs/src/cursor.rs:566— crates/storage/libmdbx-rs/src/cursor.rs:566-571 | crates/storage/libmdbx-rs/src/cursor.rs:661-666 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) crates/storage/provider/src/either_writer.rs:490— crates/storage/provider/src/either_writer.rs:490-495 | crates/storage/provider/src/either_writer.rs:530-535 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) crates/trie/common/src/hashed_state.rs:520— crates/trie/common/src/hashed_state.rs:520-525 | crates/trie/common/src/updates.rs:601-606 — before extracting anything, compare `crates/trie/common/src/hashed_state.rs` and `crates/trie/common/src/updates.rs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) crates/cli/commands/src/db/prune_checkpoints.rs:20— crates/cli/commands/src/db/prune_checkpoints.rs:20-25 | crates/cli/commands/src/db/stage_checkpoints.rs:22-27 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) crates/cli/commands/src/db/prune_checkpoints.rs:112— crates/cli/commands/src/db/prune_checkpoints.rs:112-117 | crates/cli/commands/src/db/stage_checkpoints.rs:30-35 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) crates/era/src/era1/types/execution.rs:499— crates/era/src/era1/types/execution.rs:499-504 | crates/era/src/ere/types/execution.rs:601-606 — before extracting anything, compare `crates/era/src/era1/types/execution.rs` and `crates/era/src/ere/types/execution.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) crates/storage/storage-api/src/block_hash.rs:18— crates/storage/storage-api/src/block_hash.rs:18-23 | crates/storage/storage-api/src/block_id.rs:41-46 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) crates/transaction-pool/src/blobstore/noop.rs:53— crates/transaction-pool/src/blobstore/noop.rs:53-58 | crates/transaction-pool/src/noop.rs:370-375 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (6 lines × 2) crates/transaction-pool/src/pool/blob.rs:81— crates/transaction-pool/src/pool/blob.rs:81-86 | crates/transaction-pool/src/pool/parked.rs:159-164 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) crates/stages/stages/src/stages/hashing_account.rs:348— crates/stages/stages/src/stages/hashing_account.rs:348-353 | crates/stages/stages/src/stages/hashing_storage.rs:268-273 — before extracting anything, compare `crates/stages/stages/src/stages/hashing_account.rs` and `crates/stages/stages/src/stages/hashing_storage.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) crates/trie/common/src/hashed_state.rs:699— crates/trie/common/src/hashed_state.rs:699-704 | crates/trie/common/src/updates.rs:816-821 — before extracting anything, compare `crates/trie/common/src/hashed_state.rs` and `crates/trie/common/src/updates.rs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) crates/storage/db/src/mdbx.rs:38— crates/storage/db/src/mdbx.rs:38-43 | crates/storage/db/src/mdbx.rs:56-61 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) .github/scripts/bench-reth-charts.py:62— .github/scripts/bench-reth-charts.py:62-67 | .github/scripts/bench-reth-charts.py:70-75 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) .github/scripts/bench-reth-charts.py:81— .github/scripts/bench-reth-charts.py:81-86 | .github/scripts/bench-reth-charts.py:88-93 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) crates/net/p2p/src/test_utils/bodies.rs:53— crates/net/p2p/src/test_utils/bodies.rs:53-58 | crates/net/p2p/src/test_utils/receipts.rs:43-48 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (10 lines × 2) crates/cli/commands/src/db/repair_trie.rs:154— crates/cli/commands/src/db/repair_trie.rs:154-163 | crates/cli/commands/src/db/repair_trie.rs:273-282 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) crates/cli/commands/src/download/extract.rs:478— crates/cli/commands/src/download/extract.rs:478-487 | crates/cli/commands/src/download/fetch.rs:427-436 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (10 lines × 2) crates/ethereum/node/src/engine_ssz_proxy.rs:607— crates/ethereum/node/src/engine_ssz_proxy.rs:607-616 | crates/ethereum/node/src/engine_ssz_proxy.rs:651-660 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) crates/net/eth-wire-types/src/broadcast.rs:744— crates/net/eth-wire-types/src/broadcast.rs:744-753 | crates/net/eth-wire-types/src/broadcast.rs:940-949 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) crates/net/network/src/session/active.rs:607— crates/net/network/src/session/active.rs:607-616 | crates/net/network/src/session/active.rs:633-642 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) crates/rpc/rpc-eth-api/src/helpers/blocking_task.rs:204— crates/rpc/rpc-eth-api/src/helpers/blocking_task.rs:204-213 | crates/rpc/rpc/src/eth/filter.rs:692-701 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (10 lines × 2) crates/storage/provider/src/providers/static_file/writer.rs:141— crates/storage/provider/src/providers/static_file/writer.rs:141-150 | crates/storage/provider/src/providers/static_file/writer.rs:191-200 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) crates/transaction-pool/src/blobstore/disk.rs:308— crates/transaction-pool/src/blobstore/disk.rs:308-317 | crates/transaction-pool/src/blobstore/mem.rs:183-192 — before extracting anything, compare `crates/transaction-pool/src/blobstore/disk.rs` and `crates/transaction-pool/src/blobstore/mem.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 2) crates/trie/common/src/prefix_set.rs:282— crates/trie/common/src/prefix_set.rs:282-291 | crates/trie/common/src/prefix_set.rs:340-349 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) crates/trie/common/src/updates.rs:754— crates/trie/common/src/updates.rs:754-763 | crates/trie/common/src/updates.rs:838-847 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) crates/trie/db/src/state.rs:231— crates/trie/db/src/state.rs:231-240 | crates/trie/db/src/state.rs:249-258 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) docs/vocs/docs/snippets/sources/exex/hello-world/src/bin/2.rs:11— docs/vocs/docs/snippets/sources/exex/hello-world/src/bin/2.rs:11-20 | docs/vocs/docs/snippets/sources/exex/hello-world/src/bin/3.rs:37-46 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (10 lines × 2) docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:53— docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:53-62 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_4.rs:55-64 — before extracting anything, compare `docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs` and `docs/vocs/docs/snippets/sources/exex/remote/src/exex_4.rs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 2) crates/config/src/config.rs:296— crates/config/src/config.rs:296-305 | crates/stages/types/src/execution.rs:20-29 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (10 lines × 2) crates/trie/trie/src/hashed_cursor/metrics.rs:53— crates/trie/trie/src/hashed_cursor/metrics.rs:53-62 | crates/trie/trie/src/trie_cursor/metrics.rs:53-62 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (10 lines × 2) crates/cli/commands/src/download/fetch.rs:258— crates/cli/commands/src/download/fetch.rs:258-267 | crates/cli/commands/src/download/fetch.rs:342-351 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) crates/net/downloaders/src/file_client.rs:258— crates/net/downloaders/src/file_client.rs:258-265 | crates/net/downloaders/src/receipt_file_client.rs:90-97 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) crates/node/builder/src/builder/mod.rs:274— crates/node/builder/src/builder/mod.rs:274-281 | crates/node/builder/src/builder/mod.rs:298-305 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) crates/storage/provider/src/providers/blockchain_provider.rs:264— crates/storage/provider/src/providers/blockchain_provider.rs:264-271 | crates/storage/provider/src/providers/blockchain_provider.rs:320-327 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) crates/storage/provider/src/providers/database/provider.rs:1417— crates/storage/provider/src/providers/database/provider.rs:1417-1424 | crates/storage/provider/src/providers/rocksdb/provider.rs:1661-1669 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) crates/storage/provider/src/providers/static_file/writer.rs:102— crates/storage/provider/src/providers/static_file/writer.rs:102-109 | crates/storage/provider/src/providers/static_file/writer.rs:120-127 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) crates/storage/provider/src/providers/static_file/writer.rs:553— crates/storage/provider/src/providers/static_file/writer.rs:553-560 | crates/storage/provider/src/providers/static_file/writer.rs:635-642 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) crates/tasks/src/pool.rs:271— crates/tasks/src/pool.rs:271-278 | crates/tasks/src/pool.rs:288-295 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) crates/tracing-otlp/src/otlp.rs:38— crates/tracing-otlp/src/otlp.rs:38-45 | crates/tracing-otlp/src/otlp.rs:87-94 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) crates/transaction-pool/src/pool/state.rs:106— crates/transaction-pool/src/pool/state.rs:106-113 | crates/transaction-pool/src/pool/state.rs:122-129 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) crates/stages/stages/src/stages/index_account_history.rs:167— crates/stages/stages/src/stages/index_account_history.rs:167-175 | crates/stages/stages/src/stages/index_storage_history.rs:171-178 — before extracting anything, compare `crates/stages/stages/src/stages/index_account_history.rs` and `crates/stages/stages/src/stages/index_storage_history.rs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) crates/node/builder/src/launch/debug.rs:227— crates/node/builder/src/launch/debug.rs:227-237 | crates/node/builder/src/launch/debug.rs:254-261 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) crates/stages/stages/src/stages/hashing_account.rs:318— crates/stages/stages/src/stages/hashing_account.rs:318-325 | crates/stages/stages/src/stages/hashing_storage.rs:259-266 — before extracting anything, compare `crates/stages/stages/src/stages/hashing_account.rs` and `crates/stages/stages/src/stages/hashing_storage.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) crates/cli/commands/src/download/manifest.rs:708— crates/cli/commands/src/download/manifest.rs:708-715 | crates/cli/commands/src/download/manifest.rs:723-730 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) crates/trie/common/src/hashed_state.rs:1816— crates/trie/common/src/hashed_state.rs:1816-1823 | crates/trie/common/src/updates.rs:1534-1541 — before extracting anything, compare `crates/trie/common/src/hashed_state.rs` and `crates/trie/common/src/updates.rs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) crates/storage/provider/src/test_utils/blocks.rs:220— crates/storage/provider/src/test_utils/blocks.rs:220-227 | crates/storage/provider/src/test_utils/blocks.rs:276-284 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) crates/cli/commands/src/test_vectors/compact.rs:150— crates/cli/commands/src/test_vectors/compact.rs:150-157 | crates/cli/commands/src/test_vectors/tables.rs:27-34 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Repeated repair: crates/cli/commands/src/common.rs crates/cli/commands/src/common.rs:98— crates/cli/commands/src/common.rs changed 11 times in last 90 days and 7 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is EnvironmentArgs::init at line 98), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(stages): resume interrupted pipeline unwinds (#28067)”; “fix(cli): error on unloadable config and missing enode key (#27982)”; “revert: "fix(storage): revert BAL store activation" (#27472)”; “fix(storage): revert BAL store activation (#27470)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/cli/commands/src/common.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/storage/provider/src/bal/rocksdb.rs crates/storage/provider/src/bal/rocksdb.rs:103— crates/storage/provider/src/bal/rocksdb.rs changed 10 times in last 90 days and 6 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 5 (its worst body is RocksDBBalStore::read_one_by_hash at line 103), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “revert: "fix(storage): revert BAL store activation" (#27472)”; “fix(storage): open legacy BAL databases read-only (#27471)”; “fix(storage): revert BAL store activation (#27470)”; “revert: restore RocksDB BAL storage (#26789)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/storage/provider/src/bal/rocksdb.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/storage/provider/src/providers/rocksdb/metrics.rs crates/storage/provider/src/providers/rocksdb/metrics.rs:79— crates/storage/provider/src/providers/rocksdb/metrics.rs changed 7 times in last 90 days and 5 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is RocksDBOperation::as_str at line 79), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “revert: "fix(storage): revert BAL store activation" (#27472)”; “fix(storage): revert BAL store activation (#27470)”; “revert: restore RocksDB BAL storage (#26789)”; “revert: "feat(storage): re-enable RocksDB BAL storage" (#26788)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/storage/provider/src/providers/rocksdb/metrics.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/cli/commands/src/download/manifest.rs crates/cli/commands/src/download/manifest.rs:593— crates/cli/commands/src/download/manifest.rs changed 6 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 9 (its worst body is reth_cli_commands::download::manifest::generate_manifest at line 593), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: align snapshot block counts and downloads (#28058)”; “fix(cli): validate manifest input and fail closed on symlink check (#27983)”; “fix(cli): use configured minimal download defaults (#26934)”; “fix(cli): download enough history when the final snapshot chunk is partial (#26607)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/cli/commands/src/download/manifest.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/rpc/ipc/src/server/mod.rs crates/rpc/ipc/src/server/mod.rs:125— crates/rpc/ipc/src/server/mod.rs changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 11 (its worst body is IpcServer::start_inner at line 125), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: avoid Etherscan and IPC payload dumps (#27990)”; “fix(ipc): stop buffering oversized requests (#27864)”; “fix(ipc): abort in-flight calls when the connection closes (#27458)”; “fix(ipc): enforce max subscriptions per connection (#27459)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/rpc/ipc/src/server/mod.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/consensus/consensus/src/lib.rs crates/consensus/consensus/src/lib.rs:174— crates/consensus/consensus/src/lib.rs changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 3 (its worst body is HeaderValidator::validate_header_range at line 174), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(consensus): reject pre-Shanghai body withdrawals (#27715)”; “fix(engine): classify invalid BAL input as malformed (#26844)”; “fix(engine): separate malformed input from fatal errors (#26829)”; “fix(engine): reject undecodable block access list bytes as invalid params (#26694)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/consensus/consensus/src/lib.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/engine/primitives/src/error.rs crates/engine/primitives/src/error.rs:114— crates/engine/primitives/src/error.rs changed 4 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 6 (its worst body is InsertBlockErrorKind::ensure_validation_error at line 114), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(engine): report payload job start errors (#28015)”; “fix(engine): return invalid for undecodable block access lists (#26889)”; “fix(engine): separate malformed input from fatal errors (#26829)”; “fix(engine): reject undecodable block access list bytes as invalid params (#26694)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/engine/primitives/src/error.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/transaction-pool/src/validate/task.rs crates/transaction-pool/src/validate/task.rs:59— crates/transaction-pool/src/validate/task.rs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 3 (its worst body is ValidationTask::run at line 59), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(txpool): remove validation producer mutex (#27361)”; “fix(txpool): scale validation channel capacity with worker count (#27362)”; “fix(transaction-pool): release receiver lock before validating (#27015)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/transaction-pool/src/validate/task.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/engine/primitives/src/message.rs crates/engine/primitives/src/message.rs:302— crates/engine/primitives/src/message.rs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 3 (its worst body is BeaconEngineMessage::fmt at line 302), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(engine): report payload job start errors (#28015)”; “fix(tracing): preserve context across engine and worker tasks (#27529)”; “fix(engine): avoid cache handoff misses and locked drops (#27230)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/engine/primitives/src/message.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/rpc/rpc-engine-api/src/error.rs crates/rpc/rpc-engine-api/src/error.rs:94— crates/rpc/rpc-engine-api/src/error.rs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is EngineApiError::other at line 94), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(engine): report payload job start errors (#28015)”; “fix(engine): return invalid for undecodable block access lists (#26889)”; “fix(engine): reject undecodable block access list bytes as invalid params (#26694)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/rpc/rpc-engine-api/src/error.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/node/core/src/args/txpool.rs crates/node/core/src/args/txpool.rs:65— crates/node/core/src/args/txpool.rs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is DefaultTxPoolValues::try_init at line 65), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(txpool): apply min priority fee to legacy txs (#27720)”; “fix(txpool): reject transactions below tracked nonce (#26981)”; “fix(txpool): reject zero transaction batch size (#26806)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/node/core/src/args/txpool.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/net/network/src/error.rs crates/net/network/src/error.rs:183— crates/net/network/src/error.rs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is EthStreamError::should_backoff at line 183), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(network): pace pings. (#26702)”; “fix(network): better checking of ping / pong (#26698)”; “fix(network): do check the ECIES id in hello (#26639)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/net/network/src/error.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/trie/parallel/src/error.rs crates/trie/parallel/src/error.rs:26— crates/trie/parallel/src/error.rs changed 3 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is StateRootTaskError::from at line 26), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(trie): preserve worker error sources (#27790)”; “fix(trie): unify proof error conversion (#27788)”; “fix(trie): propagate proof worker startup failures (#26545)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/trie/parallel/src/error.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: crates/engine/tree/src/tree/error.rs crates/engine/tree/src/tree/error.rs:115— crates/engine/tree/src/tree/error.rs changed 3 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 5 (its worst body is InsertBlockErrorKind::from at line 115), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(engine): flush state before backfill sync (#26911)”; “fix(engine): classify invalid BAL input as malformed (#26844)”; “fix(engine): separate malformed input from fatal errors (#26829)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-29..2026-10-27, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-29 20:43:07 +00:00' --until='2026-10-27 20:43:07 +00:00' --full-history --no-merges -- crates/engine/tree/src/tree/error.rs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Duplicated block (13 lines × 2) crates/chain-state/src/in_memory.rs:282— crates/chain-state/src/in_memory.rs:282-294 | crates/chain-state/src/in_memory.rs:361-373 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) crates/era/src/era1/types/execution.rs:407— crates/era/src/era1/types/execution.rs:407-419 | crates/era/src/ere/types/execution.rs:475-487 — before extracting anything, compare `crates/era/src/era1/types/execution.rs` and `crates/era/src/ere/types/execution.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) crates/payload/primitives/src/lib.rs:314— crates/payload/primitives/src/lib.rs:314-326 | crates/payload/primitives/src/lib.rs:333-345 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) crates/stages/stages/src/stages/hashing_account.rs:162— crates/stages/stages/src/stages/hashing_account.rs:162-174 | crates/stages/stages/src/stages/hashing_storage.rs:92-104 — before extracting anything, compare `crates/stages/stages/src/stages/hashing_account.rs` and `crates/stages/stages/src/stages/hashing_storage.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) crates/storage/db-common/src/init.rs:1024— crates/storage/db-common/src/init.rs:1024-1036 | crates/storage/db-common/src/init.rs:1129-1141 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) crates/transaction-pool/src/blobstore/disk.rs:432— crates/transaction-pool/src/blobstore/disk.rs:432-444 | crates/transaction-pool/src/blobstore/mem.rs:249-261 — before extracting anything, compare `crates/transaction-pool/src/blobstore/disk.rs` and `crates/transaction-pool/src/blobstore/mem.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) crates/transaction-pool/src/pool/mod.rs:885— crates/transaction-pool/src/pool/mod.rs:885-897 | crates/transaction-pool/src/pool/mod.rs:950-962 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) crates/transaction-pool/src/pool/pending.rs:200— crates/transaction-pool/src/pool/pending.rs:200-212 | crates/transaction-pool/src/pool/pending.rs:253-265 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) crates/trie/common/src/proofs.rs:215— crates/trie/common/src/proofs.rs:215-227 | crates/trie/common/src/proofs.rs:341-353 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) crates/trie/common/src/proofs.rs:235— crates/trie/common/src/proofs.rs:235-247 | crates/trie/common/src/proofs.rs:361-373 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) crates/trie/common/src/proofs.rs:716— crates/trie/common/src/proofs.rs:716-728 | crates/trie/common/src/proofs.rs:766-778 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) crates/trie/trie/src/hashed_cursor/post_state.rs:213— crates/trie/trie/src/hashed_cursor/post_state.rs:213-225 | crates/trie/trie/src/trie_cursor/in_memory.rs:162-174 — before extracting anything, compare `crates/trie/trie/src/hashed_cursor/post_state.rs` and `crates/trie/trie/src/trie_cursor/in_memory.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 98 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) crates/prune/prune/src/segments/user/account_history.rs:318— crates/prune/prune/src/segments/user/account_history.rs:318-330 | crates/prune/prune/src/segments/user/storage_history.rs:324-337 — before extracting anything, compare `crates/prune/prune/src/segments/user/account_history.rs` and `crates/prune/prune/src/segments/user/storage_history.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 116 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (12 lines × 2) crates/era/src/era1/types/execution.rs:382— crates/era/src/era1/types/execution.rs:382-393 | crates/era/src/ere/types/execution.rs:450-461 — before extracting anything, compare `crates/era/src/era1/types/execution.rs` and `crates/era/src/ere/types/execution.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (12 lines × 2) crates/net/eth-wire-types/src/broadcast.rs:611— crates/net/eth-wire-types/src/broadcast.rs:611-622 | crates/net/eth-wire-types/src/broadcast.rs:794-805 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) crates/net/eth-wire-types/src/broadcast.rs:701— crates/net/eth-wire-types/src/broadcast.rs:701-712 | crates/net/eth-wire-types/src/broadcast.rs:717-728 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) crates/rpc/rpc/src/debug.rs:995— crates/rpc/rpc/src/debug.rs:995-1006 | crates/rpc/rpc/src/debug.rs:1007-1018 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) crates/stages/stages/src/stages/utils.rs:376— crates/stages/stages/src/stages/utils.rs:376-387 | crates/stages/stages/src/stages/utils.rs:600-611 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) crates/storage/provider/src/providers/consistent.rs:1269— crates/storage/provider/src/providers/consistent.rs:1269-1280 | crates/storage/provider/src/providers/consistent.rs:1313-1325 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) crates/storage/provider/src/providers/rocksdb/provider.rs:2263— crates/storage/provider/src/providers/rocksdb/provider.rs:2263-2274 | crates/storage/provider/src/providers/rocksdb/provider.rs:2720-2731 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) crates/transaction-pool/src/pool/pending.rs:188— crates/transaction-pool/src/pool/pending.rs:188-199 | crates/transaction-pool/src/pool/pending.rs:238-249 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) crates/transaction-pool/src/pool/txpool.rs:443— crates/transaction-pool/src/pool/txpool.rs:443-454 | crates/transaction-pool/src/pool/txpool.rs:467-478 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) crates/trie/trie/src/proof/mod.rs:181— crates/trie/trie/src/proof/mod.rs:181-192 | crates/trie/trie/src/proof/mod.rs:325-336 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) crates/trie/trie/src/hashed_cursor/post_state.rs:161— crates/trie/trie/src/hashed_cursor/post_state.rs:161-172 | crates/trie/trie/src/trie_cursor/in_memory.rs:116-127 — before extracting anything, compare `crates/trie/trie/src/hashed_cursor/post_state.rs` and `crates/trie/trie/src/trie_cursor/in_memory.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 98 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (12 lines × 2) crates/storage/provider/src/providers/rocksdb/provider.rs:2393— crates/storage/provider/src/providers/rocksdb/provider.rs:2393-2404 | crates/storage/provider/src/providers/rocksdb/provider.rs:2549-2560 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) crates/era-utils/src/history.rs:652— crates/era-utils/src/history.rs:652-656 | crates/storage/provider/src/providers/static_file/manager.rs:2074-2078 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) crates/era-utils/src/history.rs:813— crates/era-utils/src/history.rs:813-817 | crates/stages/stages/src/stages/headers.rs:146-150 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) crates/stages/stages/src/stages/utils.rs:262— crates/stages/stages/src/stages/utils.rs:262-266 | crates/stages/stages/src/stages/utils.rs:470-474 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) crates/storage/provider/src/providers/rocksdb/provider.rs:2460— crates/storage/provider/src/providers/rocksdb/provider.rs:2460-2464 | crates/storage/provider/src/providers/rocksdb/provider.rs:2616-2620 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) crates/era/src/era1/types/execution.rs:285— crates/era/src/era1/types/execution.rs:285-289 | crates/era/src/ere/types/execution.rs:210-214 — before extracting anything, compare `crates/era/src/era1/types/execution.rs` and `crates/era/src/ere/types/execution.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) crates/net/p2p/src/bodies/client.rs:80— crates/net/p2p/src/bodies/client.rs:80-84 | crates/net/p2p/src/headers/client.rs:111-115 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) docs/vocs/docs/snippets/sources/exex/remote/src/exex_1.rs:19— docs/vocs/docs/snippets/sources/exex/remote/src/exex_1.rs:19-23 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_2.rs:24-28 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (5 lines × 2) crates/net/discv4/src/lib.rs:836— crates/net/discv4/src/lib.rs:836-840 | crates/net/dns/src/lib.rs:195-199 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) crates/trie/trie/src/hashed_cursor/post_state.rs:44— crates/trie/trie/src/hashed_cursor/post_state.rs:44-48 | crates/trie/trie/src/trie_cursor/in_memory.rs:46-50 — before extracting anything, compare `crates/trie/trie/src/hashed_cursor/post_state.rs` and `crates/trie/trie/src/trie_cursor/in_memory.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 98 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) crates/era/src/era/file.rs:158— crates/era/src/era/file.rs:158-162 | crates/era/src/era1/file.rs:206-210 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) crates/era-downloader/src/client.rs:136— crates/era-downloader/src/client.rs:136-140 | crates/era-downloader/src/client.rs:155-159 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) .github/scripts/bench-call-summary.py:367— .github/scripts/bench-call-summary.py:367-371 | .github/scripts/bench-reth-summary.py:972-982 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
reth_cli_commands::db::get::get_rocksdb_storage_history (cognitive 29) crates/cli/commands/src/db/get.rs:424— reth_cli_commands::db::get::get_rocksdb_storage_history has cognitive complexity 29 (threshold 15). Drivers by points: if/else 7 (19 pts), match/switch 2 (4 pts), boolean chains 3, loops 1 (3 pts) (nesting depth added 16). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
reth_cli_commands::db::get::get_rocksdb_account_history (cognitive 27) crates/cli/commands/src/db/get.rs:355— reth_cli_commands::db::get::get_rocksdb_account_history has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (19 pts), match/switch 2 (4 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 16). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
reth_cli_commands::download::extract::streaming_download_and_extract (cognitive 26) crates/cli/commands/src/download/extract.rs:369— reth_cli_commands::download::extract::streaming_download_and_extract has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (20 pts), match/switch 2 (4 pts), boolean chains 1, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_cli_commands::import_core::import_blocks_from_file (cognitive 23) crates/cli/commands/src/import_core.rs:84— reth_cli_commands::import_core::import_blocks_from_file has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (13 pts), match/switch 3 (9 pts), loops 1 (nesting depth added 8). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
reth_cli_commands::db::repair_trie::do_verify_and_repair (cognitive 21) crates/cli/commands/src/db/repair_trie.rs:235— reth_cli_commands::db::repair_trie::do_verify_and_repair has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (15 pts), match/switch 2 (5 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_cli_commands::re_execute::verify_bundle_against_changesets (cognitive 20) crates/cli/commands/src/re_execute.rs:404— reth_cli_commands::re_execute::verify_bundle_against_changesets has cognitive complexity 20 (threshold 15). Drivers by points: loops 4 (8 pts), match/switch 2 (7 pts), if/else 2 (5 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_cli_commands::db::checksum::checksum_change_based_segment (cognitive 18) crates/cli/commands/src/db/checksum/mod.rs:382— reth_cli_commands::db::checksum::checksum_change_based_segment has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_cli_commands::db::tui::handle_event (cognitive 18) crates/cli/commands/src/db/tui.rs:198— reth_cli_commands::db::tui::handle_event has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (10 pts), match/switch 4 (8 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_cli_commands::db::checksum::checksum_static_file (cognitive 17) crates/cli/commands/src/db/checksum/mod.rs:118— reth_cli_commands::db::checksum::checksum_static_file has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_cli_commands::init_state::without_evm::append_dummy_chain (cognitive 17) crates/cli/commands/src/init_state/without_evm.rs:113— reth_cli_commands::init_state::without_evm::append_dummy_chain has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (8 pts), loops 6 (7 pts), match/switch 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_cli_commands::download::manifest::generate_manifest (cognitive 16) crates/cli/commands/src/download/manifest.rs:593— reth_cli_commands::download::manifest::generate_manifest has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Duplicated block (7 lines × 2) crates/cli/commands/src/download/tui.rs:229— crates/cli/commands/src/download/tui.rs:229-235 | crates/cli/commands/src/download/tui.rs:242-248 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) crates/net/eth-wire-types/src/broadcast.rs:736— crates/net/eth-wire-types/src/broadcast.rs:736-742 | crates/net/eth-wire-types/src/broadcast.rs:920-926 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) crates/rpc/rpc/src/eth/helpers/signer.rs:30— crates/rpc/rpc/src/eth/helpers/signer.rs:30-36 | crates/rpc/rpc/src/eth/helpers/signer.rs:55-62 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) crates/stages/stages/src/stages/utils.rs:254— crates/stages/stages/src/stages/utils.rs:254-260 | crates/stages/stages/src/stages/utils.rs:462-468 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) crates/storage/provider/src/providers/database/provider.rs:2153— crates/storage/provider/src/providers/database/provider.rs:2153-2159 | crates/storage/provider/src/providers/database/provider.rs:2236-2242 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) crates/storage/provider/src/providers/rocksdb/provider.rs:1279— crates/storage/provider/src/providers/rocksdb/provider.rs:1279-1285 | crates/storage/provider/src/providers/rocksdb/provider.rs:1329-1335 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) crates/transaction-pool/src/traits.rs:201— crates/transaction-pool/src/traits.rs:201-207 | crates/transaction-pool/src/traits.rs:219-225 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) crates/trie/common/src/hashed_state.rs:591— crates/trie/common/src/hashed_state.rs:591-597 | crates/trie/common/src/updates.rs:680-686 — before extracting anything, compare `crates/trie/common/src/hashed_state.rs` and `crates/trie/common/src/updates.rs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (7 lines × 2) crates/era-utils/src/export/era1.rs:85— crates/era-utils/src/export/era1.rs:85-91 | crates/era-utils/src/export/ere.rs:110-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (7 lines × 2) crates/trie/trie/src/hashed_cursor/metrics.rs:94— crates/trie/trie/src/hashed_cursor/metrics.rs:94-100 | crates/trie/trie/src/trie_cursor/metrics.rs:104-110 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) crates/trie/trie/src/hashed_cursor/metrics.rs:102— crates/trie/trie/src/hashed_cursor/metrics.rs:102-108 | crates/trie/trie/src/trie_cursor/metrics.rs:112-118 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Low cohesion: PeersConfig (LCOM4 14) crates/net/network-types/src/peers/config.rs:128— PeersConfig's methods fall into 14 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 14 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: DefaultTraceValues (LCOM4 10) crates/node/core/src/args/trace.rs:18— DefaultTraceValues's methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: RayonConfig (LCOM4 9) crates/tasks/src/runtime.rs:101— RayonConfig's methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: StreamBackfillJob (LCOM4 5) crates/exex/exex/src/backfill/stream.rs:54— StreamBackfillJob's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: RpcBlockchainProvider (LCOM4 5) crates/storage/rpc-provider/src/lib.rs:133— RpcBlockchainProvider's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: EthEvmConfig (LCOM4 4) crates/ethereum/evm/src/lib.rs:263— EthEvmConfig's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: P2PStream (LCOM4 4) crates/net/eth-wire/src/p2pstream.rs:262— P2PStream's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: ValidationApi (LCOM4 4) crates/rpc/rpc/src/validation.rs:57— ValidationApi's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: EthStateCacheService (LCOM4 4) crates/rpc/rpc-eth-types/src/cache/mod.rs:317— EthStateCacheService's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: TestStage (LCOM4 4) crates/stages/api/src/test_utils.rs:16— TestStage's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: Zstd (LCOM4 4) crates/storage/nippy-jar/src/compression/zstd.rs:28— Zstd's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
TooManyFields: RpcServerArgs crates/node/core/src/args/rpc_server.rs:449— TooManyFields — 50 stored fields beside 16 methods. The bar is 30 stored fields; this is 20 over it, 1.67× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: DefaultRpcServerArgs crates/node/core/src/args/rpc_server.rs:55— TooManyFields — 46 stored fields beside 48 methods. The bar is 30 stored fields; this is 16 over it, 1.53× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: EngineArgs crates/node/core/src/args/engine.rs:318— TooManyFields — 41 stored fields beside 5 methods. The bar is 30 stored fields; this is 11 over it, 1.37× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: DatabaseProviderMetrics crates/storage/provider/src/providers/database/metrics.rs:51— TooManyFields — 38 stored fields beside 3 methods. The bar is 30 stored fields; this is 8 over it, 1.27× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: TreeConfig crates/engine/primitives/src/config.rs:117— TooManyFields — 36 stored fields beside 75 methods. The bar is 30 stored fields; this is 6 over it, 1.20× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: NetworkArgs crates/node/core/src/args/network.rs:239— TooManyFields — 35 stored fields beside 16 methods. The bar is 30 stored fields; this is 5 over it, 1.17× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: JitMetrics crates/ethereum/evm/src/factory.rs:521— TooManyFields — 34 stored fields beside 2 methods. The bar is 30 stored fields; this is 4 over it, 1.13× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: DefaultEngineValues crates/node/core/src/args/engine.rs:28— TooManyFields — 32 stored fields beside 34 methods. The bar is 30 stored fields; this is 2 over it, 1.07× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: SparseTrieCacheTask crates/engine/tree/src/tree/state_root_strategy/sparse_trie.rs:119— TooManyFields — 31 stored fields beside 30 methods. The bar is 30 stored fields; this is 1 over it, 1.03× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
TooManyFields: ExecutionTimingStats crates/chain-state/src/execution_stats.rs:17— TooManyFields — 31 stored fields. The bar is 30 stored fields; this is 1 over it, 1.03× the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member — each reader then names only the group it uses.
Command::execute (cognitive 102) crates/cli/commands/src/re_execute.rs:78— Command::execute has cognitive complexity 102 (threshold 15). Drivers by points: if/else 24 (80 pts), loops 5 (12 pts), match/switch 3 (9 pts), boolean chains 1 (nesting depth added 69). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
Command::execute (cognitive 29) crates/cli/commands/src/db/get.rs:133— Command::execute has cognitive complexity 29 (threshold 15). Drivers by points: if/else 10 (23 pts), match/switch 4 (6 pts) (nesting depth added 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
Command::execute (cognitive 26) crates/cli/commands/src/p2p/bootnode.rs:64— Command::execute has cognitive complexity 26 (threshold 15). Drivers by points: if/else 8 (12 pts), match/switch 4 (11 pts), loops 2 (3 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Command::static_files_stats_table (cognitive 25) crates/cli/commands/src/db/stats.rs:223— Command::static_files_stats_table has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (21 pts), loops 3 (4 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Command::execute_current (cognitive 24) crates/cli/commands/src/db/state.rs:59— Command::execute_current has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (20 pts), loops 2 (4 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Command::execute (cognitive 23) crates/cli/commands/src/db/account_storage.rs:24— Command::execute has cognitive complexity 23 (threshold 15). Drivers by points: if/else 12 (19 pts), loops 2 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Command::execute (cognitive 20) crates/cli/commands/src/stage/drop.rs:40— Command::execute has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (14 pts), match/switch 3 (5 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Command::execute (cognitive 20) crates/cli/commands/src/stage/run.rs:110— Command::execute has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 2 (3 pts), boolean chains 1, match/switch 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Command::execute (cognitive 17) crates/cli/commands/src/db/mod.rs:88— Command::execute has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), match/switch 2 (3 pts) (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
ArenaParallelSparseTrie::update_leaves (cognitive 63) crates/trie/sparse/src/arena/mod.rs:2600— ArenaParallelSparseTrie::update_leaves has cognitive complexity 63 (threshold 15). Drivers by points: if/else 11 (25 pts), match/switch 6 (18 pts), loops 7 (16 pts), boolean chains 4 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ArenaParallelSparseTrie::update_cached_rlp (cognitive 48) crates/trie/sparse/src/arena/mod.rs:959— ArenaParallelSparseTrie::update_cached_rlp has cognitive complexity 48 (threshold 15). Drivers by points: if/else 11 (27 pts), match/switch 6 (17 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ArenaParallelSparseTrie::prune (cognitive 41) crates/trie/sparse/src/arena/mod.rs:2466— ArenaParallelSparseTrie::prune has cognitive complexity 41 (threshold 15). Drivers by points: if/else 15 (36 pts), loops 2 (3 pts), match/switch 1 (2 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ArenaParallelSparseTrie::reveal_nodes (cognitive 35) crates/trie/sparse/src/arena/mod.rs:2164— ArenaParallelSparseTrie::reveal_nodes has cognitive complexity 35 (threshold 15). Drivers by points: if/else 13 (24 pts), loops 4 (8 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ArenaParallelSparseTrie::update_subtrie_hashes (cognitive 25) crates/trie/sparse/src/arena/mod.rs:2329— ArenaParallelSparseTrie::update_subtrie_hashes has cognitive complexity 25 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 3 (5 pts), match/switch 2 (4 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ArenaParallelSparseTrie::find_leaf_in_arena (cognitive 22) crates/trie/sparse/src/arena/mod.rs:1204— ArenaParallelSparseTrie::find_leaf_in_arena has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (15 pts), match/switch 2 (5 pts), boolean chains 1, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ArenaParallelSparseTrie::maybe_collapse_or_remove_branch (cognitive 21) crates/trie/sparse/src/arena/mod.rs:781— ArenaParallelSparseTrie::maybe_collapse_or_remove_branch has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (20 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseProvider::take_state_above (cognitive 57) crates/storage/provider/src/providers/database/provider.rs:3025— DatabaseProvider::take_state_above has cognitive complexity 57 (threshold 15). Drivers by points: if/else 18 (42 pts), loops 6 (13 pts), boolean chains 2 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseProvider::remove_state_above (cognitive 49) crates/storage/provider/src/providers/database/provider.rs:2887— DatabaseProvider::remove_state_above has cognitive complexity 49 (threshold 15). Drivers by points: if/else 17 (39 pts), loops 4 (10 pts) (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseProvider::save_blocks_inner (cognitive 30) crates/storage/provider/src/providers/database/provider.rs:569— DatabaseProvider::save_blocks_inner has cognitive complexity 30 (threshold 15). Drivers by points: if/else 14 (17 pts), loops 4 (8 pts), boolean chains 3, match/switch 1 (2 pts) (nesting depth added 8). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
DatabaseProvider::write_state_reverts (cognitive 27) crates/storage/provider/src/providers/database/provider.rs:2687— DatabaseProvider::write_state_reverts has cognitive complexity 27 (threshold 15). Drivers by points: loops 5 (16 pts), if/else 4 (11 pts) (nesting depth added 18). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
DatabaseProvider::write_state_changes (cognitive 25) crates/storage/provider/src/providers/database/provider.rs:2766— DatabaseProvider::write_state_changes has cognitive complexity 25 (threshold 15). Drivers by points: if/else 6 (16 pts), loops 3 (7 pts), boolean chains 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseProvider::write_state (cognitive 19) crates/storage/provider/src/providers/database/provider.rs:2569— DatabaseProvider::write_state has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (10 pts), boolean chains 5, loops 3 (4 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseProvider::append_blocks_with_state (cognitive 16) crates/storage/provider/src/providers/database/provider.rs:3818— DatabaseProvider::append_blocks_with_state has cognitive complexity 16 (threshold 15). Drivers by points: loops 6 (11 pts), if/else 5 (nesting depth added 5). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
Outbound HTTP without resilience crates/cli/commands/src/download/manifest.rs:583— `Client::new()` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience crates/cli/commands/src/download/source.rs:91— `Client::new()` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience crates/cli/commands/src/download/source.rs:143— `Client::new()` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience crates/cli/commands/src/import_era.rs:184— `Client::new()` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience crates/consensus/debug-client/src/providers/etherscan.rs:36— `Client::new()` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience crates/node/metrics/src/server.rs:254— `Client::builder()` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
Outbound HTTP without resilience crates/stages/stages/src/stages/era.rs:91— `Client::new()` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
EngineApiTreeHandler::on_engine_message (cognitive 56) crates/engine/tree/src/tree/mod.rs:1581— EngineApiTreeHandler::on_engine_message has cognitive complexity 56 (threshold 15). Drivers by points: if/else 14 (45 pts), match/switch 5 (11 pts) (nesting depth added 37). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
EngineApiTreeHandler::insert_block_or_payload (cognitive 21) crates/engine/tree/src/tree/mod.rs:3171— EngineApiTreeHandler::insert_block_or_payload has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (17 pts), match/switch 2 (4 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EngineApiTreeHandler::run_until_exit (cognitive 19) crates/engine/tree/src/tree/mod.rs:525— EngineApiTreeHandler::run_until_exit has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (11 pts), match/switch 3 (7 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EngineApiTreeHandler::apply_chain_update (cognitive 19) crates/engine/tree/src/tree/mod.rs:1299— EngineApiTreeHandler::apply_chain_update has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (16 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EngineApiTreeHandler::on_backfill_sync_finished (cognitive 18) crates/engine/tree/src/tree/mod.rs:1845— EngineApiTreeHandler::on_backfill_sync_finished has cognitive complexity 18 (threshold 15). Drivers by points: if/else 15 (17 pts), boolean chains 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
EngineApiTreeHandler::get_save_blocks_input (cognitive 16) crates/engine/tree/src/tree/mod.rs:2234— EngineApiTreeHandler::get_save_blocks_input has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), boolean chains 3, loops 1, match/switch 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FunctionTooLong: reth_trie_dst::run contrib/trie-dst/crates/reth-trie-dst/src/main.rs:209— FunctionTooLong — reth_trie_dst::run runs 446 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 346 over it, 4.46× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: reth_trie_dst::main contrib/trie-dst/crates/reth-trie-dst/src/main.rs:770— FunctionTooLong — reth_trie_dst::main runs 161 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 61 over it, 1.61× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: reth_cli_commands::import_core::import_blocks_from_file crates/cli/commands/src/import_core.rs:84— FunctionTooLong — reth_cli_commands::import_core::import_blocks_from_file runs 136 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 36 over it, 1.36× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: reth_network::session::authenticate_stream crates/net/network/src/session/mod.rs:1185— FunctionTooLong — reth_network::session::authenticate_stream runs 129 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 29 over it, 1.29× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: reth_cli_commands::download::manifest::generate_manifest crates/cli/commands/src/download/manifest.rs:593— FunctionTooLong — reth_cli_commands::download::manifest::generate_manifest runs 117 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code — #[cfg(test)] modules and bare #[test] functions — not counted) in one body. The bar is 100 significant lines; this is 17 over it, 1.17× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: inject-cargo-docs.injectCargoDocs docs/vocs/scripts/inject-cargo-docs.ts:9— FunctionTooLong — injectCargoDocs runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Duplicated block (14 lines × 2) crates/storage/provider/src/providers/static_file/writer.rs:1213— crates/storage/provider/src/providers/static_file/writer.rs:1213-1226 | crates/storage/provider/src/providers/static_file/writer.rs:1244-1257 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (14 lines × 2) crates/trie/common/src/updates.rs:186— crates/trie/common/src/updates.rs:186-199 | crates/trie/common/src/updates.rs:349-362 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (14 lines × 2) crates/trie/trie/src/hashed_cursor/post_state.rs:366— crates/trie/trie/src/hashed_cursor/post_state.rs:366-379 | crates/trie/trie/src/trie_cursor/in_memory.rs:345-358 — before extracting anything, compare `crates/trie/trie/src/hashed_cursor/post_state.rs` and `crates/trie/trie/src/trie_cursor/in_memory.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 98 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (14 lines × 2) docs/vocs/docs/snippets/sources/exex/hello-world/src/bin/3.rs:11— docs/vocs/docs/snippets/sources/exex/hello-world/src/bin/3.rs:11-24 | docs/vocs/docs/snippets/sources/exex/tracking-state/src/bin/1.rs:26-39 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (14 lines × 2) crates/prune/prune/src/segments/user/account_history.rs:221— crates/prune/prune/src/segments/user/account_history.rs:221-234 | crates/prune/prune/src/segments/user/storage_history.rs:223-236 — before extracting anything, compare `crates/prune/prune/src/segments/user/account_history.rs` and `crates/prune/prune/src/segments/user/storage_history.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 116 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (14 lines × 2) crates/cli/commands/src/download/extract.rs:408— crates/cli/commands/src/download/extract.rs:408-421 | crates/cli/commands/src/download/extract.rs:453-466 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Command::execute (cyclomatic 32) crates/cli/commands/src/re_execute.rs:78— Command::execute has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Command::execute (cyclomatic 26) crates/cli/commands/src/stage/drop.rs:40— Command::execute has cyclomatic complexity 26 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Command::execute (cyclomatic 25) crates/cli/commands/src/db/mod.rs:88— Command::execute has cyclomatic complexity 25 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
Command::execute (cyclomatic 22) crates/cli/commands/src/stage/run.rs:110— Command::execute has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Command::execute (cyclomatic 21) crates/cli/commands/src/db/get.rs:133— Command::execute has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ArenaParallelSparseTrie::update_leaves (cyclomatic 30) crates/trie/sparse/src/arena/mod.rs:2600— ArenaParallelSparseTrie::update_leaves has cyclomatic complexity 30 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
ArenaParallelSparseTrie::update_cached_rlp (cyclomatic 26) crates/trie/sparse/src/arena/mod.rs:959— ArenaParallelSparseTrie::update_cached_rlp has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ArenaParallelSparseTrie::reveal_nodes (cyclomatic 19) crates/trie/sparse/src/arena/mod.rs:2164— ArenaParallelSparseTrie::reveal_nodes has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ArenaParallelSparseTrie::update_subtrie_hashes (cyclomatic 18) crates/trie/sparse/src/arena/mod.rs:2329— ArenaParallelSparseTrie::update_subtrie_hashes has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ArenaParallelSparseTrie::prune (cyclomatic 18) crates/trie/sparse/src/arena/mod.rs:2466— ArenaParallelSparseTrie::prune has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TransactionFetcher::on_announcement (cognitive 46) crates/net/network/src/transactions/fetcher.rs:193— TransactionFetcher::on_announcement has cognitive complexity 46 (threshold 15). Drivers by points: if/else 19 (38 pts), boolean chains 3, loops 2 (3 pts), match/switch 1 (2 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionFetcher::evict_pending (cognitive 22) crates/net/network/src/transactions/fetcher.rs:566— TransactionFetcher::evict_pending has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (16 pts), boolean chains 3, loops 2 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionFetcher::dispatch (cognitive 21) crates/net/network/src/transactions/fetcher.rs:352— TransactionFetcher::dispatch has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (14 pts), match/switch 2 (5 pts), loops 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionFetcher::on_delivery (cognitive 20) crates/net/network/src/transactions/fetcher.rs:865— TransactionFetcher::on_delivery has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (15 pts), boolean chains 3, loops 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionFetcher::pack_request (cognitive 16) crates/net/network/src/transactions/fetcher.rs:697— TransactionFetcher::pack_request has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (14 pts), boolean chains 1, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_rpc_eth_types::cache::db::apply_state_overrides_with_state (cognitive 31) crates/rpc/rpc-eth-types/src/cache/db.rs:83— reth_rpc_eth_types::cache::db::apply_state_overrides_with_state has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (23 pts), loops 2 (4 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_rpc_eth_types::simulate::execute_transactions (cognitive 28) crates/rpc/rpc-eth-types/src/simulate.rs:312— reth_rpc_eth_types::simulate::execute_transactions has cognitive complexity 28 (threshold 15). Drivers by points: if/else 13 (26 pts), boolean chains 1, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_rpc_eth_types::simulate::resolve_transaction_with_account (cognitive 25) crates/rpc/rpc-eth-types/src/simulate.rs:472— reth_rpc_eth_types::simulate::resolve_transaction_with_account has cognitive complexity 25 (threshold 15). Drivers by points: if/else 14 (21 pts), boolean chains 4 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_rpc_eth_types::logs_utils::append_matching_block_logs (cognitive 22) crates/rpc/rpc-eth-types/src/logs_utils.rs:83— reth_rpc_eth_types::logs_utils::append_matching_block_logs has cognitive complexity 22 (threshold 15). Drivers by points: match/switch 2 (11 pts), if/else 3 (8 pts), loops 2 (3 pts) (nesting depth added 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
reth_rpc_eth_types::simulate::sanitize_chain (cognitive 19) crates/rpc/rpc-eth-types/src/simulate.rs:169— reth_rpc_eth_types::simulate::sanitize_chain has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 2 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D30 · Dependency Vulnerabilities· Medium advisory (unmaintained) · ×5
Duplicated block (17 lines × 2) crates/cli/commands/src/db/get.rs:392— crates/cli/commands/src/db/get.rs:392-408 | crates/cli/commands/src/db/get.rs:466-482 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (17 lines × 2) crates/rpc/rpc-engine-api/src/engine_api.rs:1200— crates/rpc/rpc-engine-api/src/engine_api.rs:1200-1216 | crates/rpc/rpc-engine-api/src/engine_api.rs:1231-1247 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (17 lines × 2) crates/storage/libmdbx-rs/src/cursor.rs:577— crates/storage/libmdbx-rs/src/cursor.rs:577-593 | crates/storage/libmdbx-rs/src/cursor.rs:672-688 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (17 lines × 2) crates/tasks/src/worker_map.rs:63— crates/tasks/src/worker_map.rs:63-79 | crates/tasks/src/worker_map.rs:94-110 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (17 lines × 2) crates/trie/trie/src/hashed_cursor/post_state.rs:267— crates/trie/trie/src/hashed_cursor/post_state.rs:267-283 | crates/trie/trie/src/trie_cursor/in_memory.rs:217-233 — before extracting anything, compare `crates/trie/trie/src/hashed_cursor/post_state.rs` and `crates/trie/trie/src/trie_cursor/in_memory.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 98 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
DiskFileBlobStore::get_by_versioned_hashes_eip7594 (cognitive 34) crates/transaction-pool/src/blobstore/disk.rs:73— DiskFileBlobStore::get_by_versioned_hashes_eip7594 has cognitive complexity 34 (threshold 15). Drivers by points: if/else 8 (22 pts), loops 5 (11 pts), boolean chains 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiskFileBlobStore::get_by_versioned_hashes_cells_eip7594 (cognitive 32) crates/transaction-pool/src/blobstore/disk.rs:143— DiskFileBlobStore::get_by_versioned_hashes_cells_eip7594 has cognitive complexity 32 (threshold 15). Drivers by points: if/else 7 (19 pts), loops 5 (11 pts), boolean chains 2 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiskFileBlobStore::get_by_versioned_hashes_v1 (cognitive 27) crates/transaction-pool/src/blobstore/disk.rs:299— DiskFileBlobStore::get_by_versioned_hashes_v1 has cognitive complexity 27 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 5 (11 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiskFileBlobStore::has_versioned_hashes (cognitive 20) crates/transaction-pool/src/blobstore/disk.rs:390— DiskFileBlobStore::has_versioned_hashes has cognitive complexity 20 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 5 (8 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×4
Members sharing a duplicated core (4 members, 50+ identical tokens) crates/cli/commands/src/stage/dump/execution.rs:34— crates/cli/commands/src/stage/dump/execution.rs:34-58 | crates/cli/commands/src/stage/dump/hashing_account.rs:22-51 | crates/cli/commands/src/stage/dump/hashing_storage.rs:21-41 | crates/cli/commands/src/stage/dump/merkle.rs:41-77 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) crates/rpc/rpc-engine-api/src/engine_api.rs:1129— crates/rpc/rpc-engine-api/src/engine_api.rs:1129-1147 | crates/rpc/rpc-engine-api/src/engine_api.rs:1173-1191 | crates/rpc/rpc-engine-api/src/engine_api.rs:1196-1220 | crates/rpc/rpc-engine-api/src/engine_api.rs:1226-1251 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:65— docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:65-87 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_2.rs:31-49 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_3.rs:47-65 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_4.rs:67-85 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) docs/vocs/docs/snippets/sources/exex/remote/src/exex_1.rs:26— docs/vocs/docs/snippets/sources/exex/remote/src/exex_1.rs:26-40 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_2.rs:31-49 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_3.rs:47-65 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_4.rs:67-85 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Duplicated block (19–20 lines × 2) crates/storage/provider/src/providers/consistent.rs:1283— crates/storage/provider/src/providers/consistent.rs:1283-1302 | crates/storage/provider/src/providers/consistent.rs:1328-1346 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (19–20 lines × 2) crates/storage/provider/src/providers/rocksdb/provider.rs:1292— crates/storage/provider/src/providers/rocksdb/provider.rs:1292-1311 | crates/storage/provider/src/providers/rocksdb/provider.rs:1340-1358 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (19–20 lines × 2) crates/storage/provider/src/providers/static_file/manager.rs:2500— crates/storage/provider/src/providers/static_file/manager.rs:2500-2519 | crates/storage/provider/src/providers/static_file/manager.rs:2605-2623 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (19–20 lines × 2) crates/tasks/src/runtime.rs:683— crates/tasks/src/runtime.rs:683-702 | crates/tasks/src/runtime.rs:753-771 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13–14 lines × 2) crates/cli/commands/src/stage/dump/execution.rs:145— crates/cli/commands/src/stage/dump/execution.rs:145-157 | crates/cli/commands/src/stage/dump/hashing_storage.rs:54-67 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (13–14 lines × 2) crates/cli/runner/src/lib.rs:110— crates/cli/runner/src/lib.rs:110-123 | crates/cli/runner/src/lib.rs:170-182 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13–14 lines × 2) crates/storage/provider/src/providers/static_file/manager.rs:2468— crates/storage/provider/src/providers/static_file/manager.rs:2468-2481 | crates/storage/provider/src/providers/static_file/manager.rs:2572-2584 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13–14 lines × 2) crates/transaction-pool/src/pool/txpool.rs:241— crates/transaction-pool/src/pool/txpool.rs:241-254 | crates/transaction-pool/src/pool/txpool.rs:261-273 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8–9 lines × 2) crates/cli/commands/src/stage/dump/execution.rs:76— crates/cli/commands/src/stage/dump/execution.rs:76-83 | crates/cli/commands/src/stage/dump/merkle.rs:44-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8–9 lines × 2) crates/storage/provider/src/providers/rocksdb/provider.rs:1748— crates/storage/provider/src/providers/rocksdb/provider.rs:1748-1756 | crates/storage/provider/src/providers/rocksdb/provider.rs:2811-2818 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8–9 lines × 2) crates/storage/provider/src/providers/rocksdb/provider.rs:2241— crates/storage/provider/src/providers/rocksdb/provider.rs:2241-2248 | crates/storage/provider/src/providers/rocksdb/provider.rs:2275-2283 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8–9 lines × 2) crates/storage/provider/src/providers/rocksdb/provider.rs:2698— crates/storage/provider/src/providers/rocksdb/provider.rs:2698-2705 | crates/storage/provider/src/providers/rocksdb/provider.rs:2732-2740 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 3) crates/cli/commands/src/prune.rs:44— crates/cli/commands/src/prune.rs:44-50 | crates/cli/commands/src/stage/run.rs:138-144 | crates/node/builder/src/launch/common.rs:813-819 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (7 lines × 3) crates/storage/provider/src/providers/database/provider.rs:1417— crates/storage/provider/src/providers/database/provider.rs:1417-1424 | crates/storage/provider/src/providers/rocksdb/provider.rs:1661-1667 | crates/storage/provider/src/providers/rocksdb/provider.rs:2171-2177 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart.
Duplicated block (7 lines × 3) crates/tasks/src/runtime.rs:687— crates/tasks/src/runtime.rs:687-693 | crates/tasks/src/runtime.rs:756-762 | crates/tasks/src/runtime.rs:825-831 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (7 lines × 3) docs/vocs/docs/snippets/sources/exex/hello-world/src/bin/3.rs:15— docs/vocs/docs/snippets/sources/exex/hello-world/src/bin/3.rs:15-21 | docs/vocs/docs/snippets/sources/exex/remote/src/consumer.rs:22-28 | docs/vocs/docs/snippets/sources/exex/tracking-state/src/bin/1.rs:30-36 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Discv4Service::poll (cyclomatic 35) crates/net/discv4/src/lib.rs:1876— Discv4Service::poll has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Discv4Service::on_neighbours (cyclomatic 18) crates/net/discv4/src/lib.rs:1531— Discv4Service::on_neighbours has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Discv4Service::on_ping (cyclomatic 17) crates/net/discv4/src/lib.rs:1198— Discv4Service::on_ping has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TransactionsManager::import_transactions (cyclomatic 24) crates/net/network/src/transactions/mod.rs:1327— TransactionsManager::import_transactions has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TransactionsManager::on_new_pooled_transaction_hashes (cyclomatic 18) crates/net/network/src/transactions/mod.rs:656— TransactionsManager::on_new_pooled_transaction_hashes has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
TransactionsManager::propagate_transactions (cyclomatic 16) crates/net/network/src/transactions/mod.rs:975— TransactionsManager::propagate_transactions has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DatabaseProvider::take_state_above (cyclomatic 24) crates/storage/provider/src/providers/database/provider.rs:3025— DatabaseProvider::take_state_above has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DatabaseProvider::save_blocks_inner (cyclomatic 23) crates/storage/provider/src/providers/database/provider.rs:569— DatabaseProvider::save_blocks_inner has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DatabaseProvider::remove_state_above (cyclomatic 19) crates/storage/provider/src/providers/database/provider.rs:2887— DatabaseProvider::remove_state_above has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Input::mutation_sites (cognitive 81) contrib/trie-dst/crates/reth-trie-dst/src/input.rs:142— Input::mutation_sites has cognitive complexity 81 (threshold 15). Drivers by points: if/else 9 (36 pts), loops 8 (30 pts), match/switch 3 (13 pts), boolean chains 2 (nesting depth added 59). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Input::mutate_at (cognitive 76) contrib/trie-dst/crates/reth-trie-dst/src/input.rs:243— Input::mutate_at has cognitive complexity 76 (threshold 15). Drivers by points: if/else 19 (44 pts), match/switch 8 (23 pts), loops 2 (8 pts), boolean chains 1 (nesting depth added 46). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Input::generate (cognitive 26) contrib/trie-dst/crates/reth-trie-dst/src/input.rs:38— Input::generate has cognitive complexity 26 (threshold 15). Drivers by points: loops 4 (9 pts), if/else 4 (7 pts), match/switch 2 (7 pts), boolean chains 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AllTransactions::update_txs (cognitive 59) crates/transaction-pool/src/pool/txpool.rs:1640— AllTransactions::update_txs has cognitive complexity 59 (threshold 15). Drivers by points: if/else 18 (47 pts), loops 5 (12 pts) (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AllTransactions::insert_tx (cognitive 29) crates/transaction-pool/src/pool/txpool.rs:2113— AllTransactions::insert_tx has cognitive complexity 29 (threshold 15). Drivers by points: if/else 17 (25 pts), loops 2 (3 pts), match/switch 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AllTransactions::ensure_valid_blob_transaction (cognitive 19) crates/transaction-pool/src/pool/txpool.rs:2027— AllTransactions::ensure_valid_blob_transaction has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Discv4Service::poll (cognitive 54) crates/net/discv4/src/lib.rs:1876— Discv4Service::poll has cognitive complexity 54 (threshold 15). Drivers by points: if/else 11 (30 pts), loops 7 (14 pts), match/switch 3 (10 pts) (nesting depth added 33). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Discv4Service::on_neighbours (cognitive 35) crates/net/discv4/src/lib.rs:1531— Discv4Service::on_neighbours has cognitive complexity 35 (threshold 15). Drivers by points: if/else 13 (27 pts), match/switch 3 (6 pts), loops 2 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Discv4Service::on_ping (cognitive 22) crates/net/discv4/src/lib.rs:1198— Discv4Service::on_ping has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (16 pts), match/switch 3 (5 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionsManager::propagate_transactions (cognitive 39) crates/net/network/src/transactions/mod.rs:975— TransactionsManager::propagate_transactions has cognitive complexity 39 (threshold 15). Drivers by points: if/else 11 (22 pts), loops 6 (17 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionsManager::import_transactions (cognitive 30) crates/net/network/src/transactions/mod.rs:1327— TransactionsManager::import_transactions has cognitive complexity 30 (threshold 15). Drivers by points: if/else 18 (24 pts), loops 2 (3 pts), match/switch 2, boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionsManager::on_new_pooled_transaction_hashes (cognitive 17) crates/net/network/src/transactions/mod.rs:656— TransactionsManager::on_new_pooled_transaction_hashes has cognitive complexity 17 (threshold 15). Drivers by points: if/else 13 (14 pts), match/switch 2, boolean chains 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PeersManager::on_connection_failure (cognitive 36) crates/net/network/src/peers.rs:779— PeersManager::on_connection_failure has cognitive complexity 36 (threshold 15). Drivers by points: if/else 15 (34 pts), boolean chains 2 (nesting depth added 19). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
PeersManager::poll (cognitive 35) crates/net/network/src/peers.rs:1306— PeersManager::poll has cognitive complexity 35 (threshold 15). Drivers by points: if/else 9 (24 pts), loops 4 (8 pts), match/switch 1 (3 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PeersManager::apply_reputation_change (cognitive 22) crates/net/network/src/peers.rs:575— PeersManager::apply_reputation_change has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (20 pts), boolean chains 1, match/switch 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthRequestHandler::get_headers_response (cognitive 33) crates/net/network/src/eth_requests.rs:144— EthRequestHandler::get_headers_response has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (27 pts), match/switch 2 (4 pts), boolean chains 1, loops 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthRequestHandler::on_receipts70_request (cognitive 24) crates/net/network/src/eth_requests.rs:310— EthRequestHandler::on_receipts70_request has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (19 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthRequestHandler::get_storage_ranges_response (cognitive 16) crates/net/network/src/eth_requests.rs:632— EthRequestHandler::get_storage_ranges_response has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (10 pts), match/switch 1 (3 pts), boolean chains 2, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pipeline::unwind_stages (cognitive 32) crates/stages/api/src/pipeline/mod.rs:374— Pipeline::unwind_stages has cognitive complexity 32 (threshold 15). Drivers by points: if/else 7 (21 pts), loops 4 (5 pts), boolean chains 3, match/switch 1 (3 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pipeline::execute_stage_to_completion (cognitive 24) crates/stages/api/src/pipeline/mod.rs:537— Pipeline::execute_stage_to_completion has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (18 pts), match/switch 2 (5 pts), loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pipeline::on_stage_error (cognitive 18) crates/stages/api/src/pipeline/mod.rs:655— Pipeline::on_stage_error has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (15 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_payload_primitives::validate_slot_number_presence (cognitive 31) crates/payload/primitives/src/lib.rs:295— reth_payload_primitives::validate_slot_number_presence has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (24 pts), boolean chains 6, match/switch 1 (nesting depth added 13). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
reth_payload_primitives::validate_block_access_list_presence (cognitive 20) crates/payload/primitives/src/lib.rs:242— reth_payload_primitives::validate_block_access_list_presence has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 4, match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
reth_payload_primitives::validate_payload_timestamp (cognitive 18) crates/payload/primitives/src/lib.rs:74— reth_payload_primitives::validate_payload_timestamp has cognitive complexity 18 (threshold 15). Drivers by points: boolean chains 9, if/else 9. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
RocksDBBatch::prune_account_history_batch (cognitive 29) crates/storage/provider/src/providers/rocksdb/provider.rs:2389— RocksDBBatch::prune_account_history_batch has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (24 pts), loops 2 (3 pts), match/switch 1 (2 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (RocksDBBatch::prune_storage_history_batch) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
RocksDBBatch::prune_storage_history_batch (cognitive 29) crates/storage/provider/src/providers/rocksdb/provider.rs:2545— RocksDBBatch::prune_storage_history_batch has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (24 pts), loops 2 (3 pts), match/switch 1 (2 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (RocksDBBatch::prune_account_history_batch) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
RocksDBBatch::prune_history_shards_inner (cognitive 16) crates/storage/provider/src/providers/rocksdb/provider.rs:2299— RocksDBBatch::prune_history_shards_inner has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 2, loops 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
StaticFileProvider::update_index (cognitive 26) crates/storage/provider/src/providers/static_file/manager.rs:1113— StaticFileProvider::update_index has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (24 pts), boolean chains 1, match/switch 1 (nesting depth added 14). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
StaticFileProvider::check_consistency (cognitive 26) crates/storage/provider/src/providers/static_file/manager.rs:1332— StaticFileProvider::check_consistency has cognitive complexity 26 (threshold 15). Drivers by points: if/else 7 (19 pts), loops 2 (4 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StaticFileProvider::ensure_invariants (cognitive 20) crates/storage/provider/src/providers/static_file/manager.rs:1735— StaticFileProvider::ensure_invariants has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (14 pts), match/switch 2 (4 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PrewarmCacheTask::refresh_results (cognitive 23) crates/engine/tree/src/tree/payload_processor/prewarm.rs:263— PrewarmCacheTask::refresh_results has cognitive complexity 23 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 4 (10 pts), boolean chains 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PrewarmCacheTask::transact_worker (cognitive 22) crates/engine/tree/src/tree/payload_processor/prewarm.rs:325— PrewarmCacheTask::transact_worker has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 4, match/switch 2 (3 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PrewarmCacheTask::spawn_txs_prewarm (cognitive 16) crates/engine/tree/src/tree/payload_processor/prewarm.rs:157— PrewarmCacheTask::spawn_txs_prewarm has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (13 pts), boolean chains 2, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Change-coupling hub: mod.rs → test_utils.rs, engine_store.rs, input.rs crates/engine/tree/src/tree/mod.rs— `crates/engine/tree/src/tree/mod.rs` changes together with 3 other files — `crates/engine/tree/src/test_utils.rs`, `crates/engine/util/src/engine_store.rs`, `crates/trie/common/src/input.rs` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
Change-coupling hub: common.rs → execution.rs, setup.rs, metrics.rs crates/node/builder/src/launch/common.rs— `crates/node/builder/src/launch/common.rs` changes together with 3 other files — `crates/cli/commands/src/stage/dump/execution.rs`, `crates/node/builder/src/setup.rs`, `crates/storage/provider/src/providers/rocksdb/metrics.rs` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
Change-coupling hub: trie.rs → in_memory.rs, db.rs, historical.rs, noop.rs crates/storage/storage-api/src/trie.rs— `crates/storage/storage-api/src/trie.rs` changes together with 4 other files — `crates/chain-state/src/in_memory.rs`, `crates/rpc/rpc-eth-types/src/cache/db.rs`, `crates/storage/provider/src/providers/state/historical.rs`, `crates/storage/provider/src/test_utils/noop.rs` — none of which declares a dependency on it: one file is the hub of 4 separate couplings, not 4 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 4.
D4 · Code Duplication· Members sharing a duplicated core (5 members, 50+ identical tokens) · ×3
Members sharing a duplicated core (5 members, 50+ identical tokens) crates/net/discv4/src/proto.rs:283— crates/net/discv4/src/proto.rs:283-309 | crates/net/discv4/src/proto.rs:325-351 | crates/net/discv4/src/proto.rs:368-394 | crates/net/discv4/src/proto.rs:485-519 | crates/net/discv4/src/proto.rs:572-603 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
Members sharing a duplicated core (5 members, 50+ identical tokens) crates/net/network/src/fetch/mod.rs:384— crates/net/network/src/fetch/mod.rs:384-413 | crates/net/network/src/fetch/mod.rs:420-435 | crates/net/network/src/fetch/mod.rs:442-456 | crates/net/network/src/fetch/mod.rs:466-480 | crates/net/network/src/fetch/mod.rs:487-516 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
Members sharing a duplicated core (5 members, 50+ identical tokens) crates/storage/provider/src/test_utils/blocks.rs:190— crates/storage/provider/src/test_utils/blocks.rs:190-233 | crates/storage/provider/src/test_utils/blocks.rs:240-291 | crates/storage/provider/src/test_utils/blocks.rs:298-349 | crates/storage/provider/src/test_utils/blocks.rs:356-432 | crates/storage/provider/src/test_utils/blocks.rs:439-512 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
Duplicated block (22 lines × 2) crates/cli/commands/src/stage/run.rs:167— crates/cli/commands/src/stage/run.rs:167-188 | crates/cli/commands/src/stage/run.rs:218-239 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (22 lines × 2) crates/prune/prune/src/segments/user/account_history.rs:186— crates/prune/prune/src/segments/user/account_history.rs:186-207 | crates/prune/prune/src/segments/user/storage_history.rs:188-209 — before extracting anything, compare `crates/prune/prune/src/segments/user/account_history.rs` and `crates/prune/prune/src/segments/user/storage_history.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 116 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (22 lines × 2) crates/trie/trie/src/trie.rs:218— crates/trie/trie/src/trie.rs:218-239 | crates/trie/trie/src/trie.rs:291-312 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (20 lines × 2) crates/stages/stages/src/stages/index_account_history.rs:96— crates/stages/stages/src/stages/index_account_history.rs:96-115 | crates/stages/stages/src/stages/index_storage_history.rs:100-119 — before extracting anything, compare `crates/stages/stages/src/stages/index_account_history.rs` and `crates/stages/stages/src/stages/index_storage_history.rs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (20 lines × 2) crates/storage/provider/src/changeset_walker.rs:39— crates/storage/provider/src/changeset_walker.rs:39-58 | crates/storage/provider/src/changeset_walker.rs:121-140 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (20 lines × 2) crates/trie/common/src/hashed_state.rs:533— crates/trie/common/src/hashed_state.rs:533-552 | crates/trie/common/src/updates.rs:614-633 — before extracting anything, compare `crates/trie/common/src/hashed_state.rs` and `crates/trie/common/src/updates.rs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (18 lines × 2) crates/cli/commands/src/stage/dump/hashing_account.rs:88— crates/cli/commands/src/stage/dump/hashing_account.rs:88-105 | crates/cli/commands/src/stage/dump/hashing_storage.rs:83-100 — before extracting anything, compare `crates/cli/commands/src/stage/dump/hashing_account.rs` and `crates/cli/commands/src/stage/dump/hashing_storage.rs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (18 lines × 2) crates/era/src/era1/types/execution.rs:432— crates/era/src/era1/types/execution.rs:432-449 | crates/era/src/ere/types/execution.rs:500-517 — before extracting anything, compare `crates/era/src/era1/types/execution.rs` and `crates/era/src/ere/types/execution.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (18 lines × 2) crates/prune/prune/src/segments/receipts.rs:61— crates/prune/prune/src/segments/receipts.rs:61-78 | crates/prune/prune/src/segments/user/sender_recovery.rs:112-129 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (16 lines × 2) crates/storage/provider/src/providers/consistent.rs:238— crates/storage/provider/src/providers/consistent.rs:238-253 | crates/storage/provider/src/providers/consistent.rs:335-350 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (16 lines × 2) crates/transaction-pool/src/blobstore/disk.rs:83— crates/transaction-pool/src/blobstore/disk.rs:83-98 | crates/transaction-pool/src/blobstore/mem.rs:31-46 — before extracting anything, compare `crates/transaction-pool/src/blobstore/disk.rs` and `crates/transaction-pool/src/blobstore/mem.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (16 lines × 2) crates/trie/common/src/proofs.rs:250— crates/trie/common/src/proofs.rs:250-265 | crates/trie/common/src/proofs.rs:375-390 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 3) crates/net/network/src/metrics.rs:398— crates/net/network/src/metrics.rs:398-403 | crates/net/network/src/metrics.rs:467-472 | crates/net/network/src/metrics.rs:536-541 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (6 lines × 3) crates/trie/common/src/hashed_state.rs:1637— crates/trie/common/src/hashed_state.rs:1637-1642 | crates/trie/common/src/hashed_state.rs:1747-1752 | crates/trie/common/src/updates.rs:1461-1466 — before extracting anything, compare `crates/trie/common/src/hashed_state.rs` and `crates/trie/common/src/updates.rs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 3) crates/trie/common/src/hashed_state.rs:1646— crates/trie/common/src/hashed_state.rs:1646-1651 | crates/trie/common/src/hashed_state.rs:1756-1761 | crates/trie/common/src/updates.rs:1470-1479 — before extracting anything, compare `crates/trie/common/src/hashed_state.rs` and `crates/trie/common/src/updates.rs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
X15 · Unvalidated length from an untrusted reader· Length read from the parsed input is spent without ever being bounded · ×3
Length read from the parsed input is spent without ever being bounded crates/etl/src/lib.rs:270— `key_length` is read from the bytes being parsed at line 268 (`usize::from_be_bytes`), then used to size a `vec![…; n]` at line 270 — and nowhere in its scope is `key_length` compared to anything, clamped, or bounded against the input that remains. Whoever wrote those bytes therefore chooses the allocation directly: it reserves the whole length before a single byte of the payload is known to exist, so a 32-bit length asks for up to 4 GiB, and an allocation the allocator refuses aborts the process with `memory allocation of … bytes failed` — an abort, not a panic, so no `catch_unwind` intercepts it and the whole process dies; a 64-bit length past `isize::MAX` panics with `capacity overflow` instead, out of a parser whose failure path was written for malformed input, not for hostile input. Bound `key_length` against the bytes actually remaining and a maximum the format allows before allocating.
Length read from the parsed input is spent without ever being bounded crates/etl/src/lib.rs:271— `value_length` is read from the bytes being parsed at line 269 (`usize::from_be_bytes`), then used to size a `vec![…; n]` at line 271 — and nowhere in its scope is `value_length` compared to anything, clamped, or bounded against the input that remains. Whoever wrote those bytes therefore chooses the allocation directly: it reserves the whole length before a single byte of the payload is known to exist, so a 32-bit length asks for up to 4 GiB, and an allocation the allocator refuses aborts the process with `memory allocation of … bytes failed` — an abort, not a panic, so no `catch_unwind` intercepts it and the whole process dies; a 64-bit length past `isize::MAX` panics with `capacity overflow` instead, out of a parser whose failure path was written for malformed input, not for hostile input. Bound `value_length` against the bytes actually remaining and a maximum the format allows before allocating.
Length read from the parsed input is spent without ever being bounded crates/era/src/e2s/types.rs:231— `count` is read from the bytes being parsed at line 208 (`i64::from_le_bytes`), then used to size a `Vec::with_capacity` at line 231 — and nowhere in its scope is `count` compared to anything, clamped, or bounded against the input that remains. Whoever wrote those bytes therefore chooses the allocation directly: it reserves the whole length before a single byte of the payload is known to exist, so a 32-bit length asks for up to 4 GiB, and an allocation the allocator refuses aborts the process with `memory allocation of … bytes failed` — an abort, not a panic, so no `catch_unwind` intercepts it and the whole process dies; a 64-bit length past `isize::MAX` panics with `capacity overflow` instead, out of a parser whose failure path was written for malformed input, not for hostile input. Bound `count` against the bytes actually remaining and a maximum the format allows before allocating.
reth_trie_dst::run (cyclomatic 60) contrib/trie-dst/crates/reth-trie-dst/src/main.rs:209— reth_trie_dst::run has cyclomatic complexity 60 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
reth_trie_dst::main (cyclomatic 28) contrib/trie-dst/crates/reth-trie-dst/src/main.rs:770— reth_trie_dst::main has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ActiveSession::on_incoming_message (cyclomatic 60) crates/net/network/src/session/active.rs:259— ActiveSession::on_incoming_message has cyclomatic complexity 60 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
ActiveSession::poll (cyclomatic 42) crates/net/network/src/session/active.rs:771— ActiveSession::poll has cyclomatic complexity 42 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Input::mutate_at (cyclomatic 39) contrib/trie-dst/crates/reth-trie-dst/src/input.rs:243— Input::mutate_at has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Input::mutation_sites (cyclomatic 29) contrib/trie-dst/crates/reth-trie-dst/src/input.rs:142— Input::mutation_sites has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NetworkManager::on_handle_message (cyclomatic 35) crates/net/network/src/manager.rs:694— NetworkManager::on_handle_message has cyclomatic complexity 35 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
NetworkManager::on_swarm_event (cyclomatic 23) crates/net/network/src/manager.rs:814— NetworkManager::on_swarm_event has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
reth_payload_primitives::validate_slot_number_presence (cyclomatic 21) crates/payload/primitives/src/lib.rs:295— reth_payload_primitives::validate_slot_number_presence has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
reth_payload_primitives::validate_payload_timestamp (cyclomatic 19) crates/payload/primitives/src/lib.rs:74— reth_payload_primitives::validate_payload_timestamp has cyclomatic complexity 19 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
reth_rpc_eth_types::cache::db::apply_state_overrides_with_state (cyclomatic 19) crates/rpc/rpc-eth-types/src/cache/db.rs:83— reth_rpc_eth_types::cache::db::apply_state_overrides_with_state has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
reth_rpc_eth_types::simulate::resolve_transaction_with_account (cyclomatic 17) crates/rpc/rpc-eth-types/src/simulate.rs:472— reth_rpc_eth_types::simulate::resolve_transaction_with_account has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AllTransactions::update_txs (cyclomatic 19) crates/transaction-pool/src/pool/txpool.rs:1640— AllTransactions::update_txs has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AllTransactions::insert_tx (cyclomatic 17) crates/transaction-pool/src/pool/txpool.rs:2113— AllTransactions::insert_tx has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
reth_trie_dst::run (cognitive 150) contrib/trie-dst/crates/reth-trie-dst/src/main.rs:209— reth_trie_dst::run has cognitive complexity 150 (threshold 15). Drivers by points: if/else 33 (75 pts), loops 16 (48 pts), match/switch 8 (21 pts), boolean chains 6 (nesting depth added 87). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
reth_trie_dst::main (cognitive 60) contrib/trie-dst/crates/reth-trie-dst/src/main.rs:770— reth_trie_dst::main has cognitive complexity 60 (threshold 15). Drivers by points: if/else 12 (31 pts), match/switch 7 (19 pts), loops 2 (8 pts), boolean chains 2 (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActiveSession::poll (cognitive 94) crates/net/network/src/session/active.rs:771— ActiveSession::poll has cognitive complexity 94 (threshold 15). Drivers by points: if/else 17 (40 pts), match/switch 11 (37 pts), loops 8 (15 pts), boolean chains 2 (nesting depth added 56). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActiveSession::on_incoming_message (cognitive 66) crates/net/network/src/session/active.rs:259— ActiveSession::on_incoming_message has cognitive complexity 66 (threshold 15). Drivers by points: if/else 25 (36 pts), match/switch 11 (30 pts) (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RlpxSatelliteStream::poll_next (cognitive 51) crates/net/eth-wire/src/multiplex.rs:792— RlpxSatelliteStream::poll_next has cognitive complexity 51 (threshold 15). Drivers by points: if/else 13 (37 pts), match/switch 4 (9 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RlpxSatelliteStream::poll_outbound_producers (cognitive 16) crates/net/eth-wire/src/multiplex.rs:732— RlpxSatelliteStream::poll_outbound_producers has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (9 pts), match/switch 2 (6 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthSimBundle::parse_and_flatten_bundle (cognitive 44) crates/rpc/rpc/src/eth/sim_bundle.rs:148— EthSimBundle::parse_and_flatten_bundle has cognitive complexity 44 (threshold 15). Drivers by points: if/else 9 (29 pts), loops 4 (11 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthSimBundle::sim_bundle_inner (cognitive 21) crates/rpc/rpc/src/eth/sim_bundle.rs:279— EthSimBundle::sim_bundle_inner has cognitive complexity 21 (threshold 15). Drivers by points: if/else 10 (17 pts), boolean chains 2, loops 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Discovery::new (cognitive 43) crates/net/network/src/discovery.rs:90— Discovery::new has cognitive complexity 43 (threshold 15). Drivers by points: if/else 18 (31 pts), match/switch 4 (7 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Discovery::poll (cognitive 23) crates/net/network/src/discovery.rs:421— Discovery::poll has cognitive complexity 23 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 5 (9 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthFilterInner::logs_for_filter (cognitive 41) crates/rpc/rpc/src/eth/filter.rs:481— EthFilterInner::logs_for_filter has cognitive complexity 41 (threshold 15). Drivers by points: if/else 14 (34 pts), match/switch 2 (4 pts), boolean chains 3 (nesting depth added 22). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
EthFilterInner::get_logs_in_block_range_inner (cognitive 20) crates/rpc/rpc/src/eth/filter.rs:714— EthFilterInner::get_logs_in_block_range_inner has cognitive complexity 20 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 3 (5 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthTransactionValidator::validate_stateless (cognitive 41) crates/transaction-pool/src/validate/eth.rs:457— EthTransactionValidator::validate_stateless has cognitive complexity 41 (threshold 15). Drivers by points: if/else 24 (33 pts), boolean chains 5, match/switch 2 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthTransactionValidator::validate_eip4844 (cognitive 29) crates/transaction-pool/src/validate/eth.rs:809— EthTransactionValidator::validate_eip4844 has cognitive complexity 29 (threshold 15). Drivers by points: if/else 10 (26 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
ProofCalculator::next_uncached_key_range (cognitive 36) crates/trie/trie/src/proof_v2/calculator.rs:971— ProofCalculator::next_uncached_key_range has cognitive complexity 36 (threshold 15). Drivers by points: if/else 11 (29 pts), boolean chains 4, match/switch 1 (2 pts), loops 1 (nesting depth added 19). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
ProofCalculator::proof_subtrie (cognitive 20) crates/trie/trie/src/proof_v2/calculator.rs:1209— ProofCalculator::proof_subtrie has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (17 pts), loops 2, boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthCall::simulate_v1 (cognitive 33) crates/rpc/rpc-eth-api/src/helpers/call.rs:65— EthCall::simulate_v1 has cognitive complexity 33 (threshold 15). Drivers by points: if/else 14 (26 pts), boolean chains 4, match/switch 1 (2 pts), loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthCall::call_many (cognitive 18) crates/rpc/rpc-eth-api/src/helpers/call.rs:292— EthCall::call_many has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (11 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BasicEngineValidator::validate_block_with_state (cognitive 31) crates/engine/tree/src/tree/payload_validator.rs:470— BasicEngineValidator::validate_block_with_state has cognitive complexity 31 (threshold 15). Drivers by points: if/else 20 (23 pts), match/switch 5 (7 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
BasicEngineValidator::execute_transactions (cognitive 16) crates/engine/tree/src/tree/payload_validator.rs:1206— BasicEngineValidator::execute_transactions has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (13 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ValidationApi::validate_message_against_block (cognitive 26) crates/rpc/rpc/src/validation.rs:160— ValidationApi::validate_message_against_block has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (21 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ValidationApi::ensure_payment (cognitive 16) crates/rpc/rpc/src/validation.rs:322— ValidationApi::ensure_payment has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (13 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SpawnedDownloader::poll (cognitive 25) crates/net/downloaders/src/bodies/task.rs:83— SpawnedDownloader::poll has cognitive complexity 25 (threshold 15). Drivers by points: if/else 5 (17 pts), match/switch 2 (5 pts), loops 2 (3 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SpawnedDownloader::poll (cognitive 19) crates/net/downloaders/src/headers/task.rs:95— SpawnedDownloader::poll has cognitive complexity 19 (threshold 15). Drivers by points: match/switch 4 (12 pts), if/else 1 (4 pts), loops 2 (3 pts) (nesting depth added 12). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
StaticFileProviderRW::heal_changeset_sidecar (cognitive 24) crates/storage/provider/src/providers/static_file/writer.rs:391— StaticFileProviderRW::heal_changeset_sidecar has cognitive complexity 24 (threshold 15). Drivers by points: if/else 13 (20 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StaticFileProviderRW::truncate (cognitive 20) crates/storage/provider/src/providers/static_file/writer.rs:1008— StaticFileProviderRW::truncate has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SparseTrieCacheTask::promote_pending_account_updates (cognitive 21) crates/engine/tree/src/tree/state_root_strategy/sparse_trie.rs:1029— SparseTrieCacheTask::promote_pending_account_updates has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (12 pts), match/switch 3 (7 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SparseTrieCacheTask::run_ready_storage_work (cognitive 16) crates/engine/tree/src/tree/state_root_strategy/sparse_trie.rs:812— SparseTrieCacheTask::run_ready_storage_work has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2, boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_engine_tree::tree::payload_processor::bal::worker::spawn_worker (cognitive 20) crates/engine/tree/src/tree/payload_processor/bal/worker.rs:66— reth_engine_tree::tree::payload_processor::bal::worker::spawn_worker has cognitive complexity 20 (threshold 15). Drivers by points: if/else 4 (11 pts), match/switch 2 (6 pts), loops 2 (3 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_engine_tree::tree::payload_processor::bal_prewarm_pool::prewarm_loop (cognitive 20) crates/engine/tree/src/tree/payload_processor/bal_prewarm_pool.rs:159— reth_engine_tree::tree::payload_processor::bal_prewarm_pool::prewarm_loop has cognitive complexity 20 (threshold 15). Drivers by points: loops 3 (9 pts), match/switch 3 (8 pts), if/else 1 (3 pts) (nesting depth added 13). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
ArenaCursor::next (cognitive 19) crates/trie/sparse/src/arena/cursor.rs:283— ArenaCursor::next has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (16 pts), loops 2 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ArenaCursor::seek (cognitive 18) crates/trie/sparse/src/arena/cursor.rs:347— ArenaCursor::seek has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (11 pts), boolean chains 3, loops 2, match/switch 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_era_utils::history::import (cognitive 16) crates/era-utils/src/history.rs:238— reth_era_utils::history::import has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (11 pts), boolean chains 2, loops 2, match/switch 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
reth_era_utils::history::process_iter (cognitive 16) crates/era-utils/src/history.rs:625— reth_era_utils::history::process_iter has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (12 pts), match/switch 2, boolean chains 1, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D30 · Dependency Vulnerabilities· Medium vulnerability · ×2
Duplicated block (34 lines × 2) crates/storage/provider/src/providers/database/provider.rs:2922— crates/storage/provider/src/providers/database/provider.rs:2922-2955 | crates/storage/provider/src/providers/database/provider.rs:3085-3118 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (34 lines × 2) crates/trie/common/src/hashed_state.rs:606— crates/trie/common/src/hashed_state.rs:606-639 | crates/trie/common/src/updates.rs:695-728 — before extracting anything, compare `crates/trie/common/src/hashed_state.rs` and `crates/trie/common/src/updates.rs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (31 lines × 2) crates/engine/tree/src/tree/state_root_strategy/sparse_trie.rs:395— crates/engine/tree/src/tree/state_root_strategy/sparse_trie.rs:395-425 | crates/engine/tree/src/tree/state_root_strategy/sparse_trie.rs:434-464 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (31 lines × 2) crates/storage/provider/src/providers/database/provider.rs:2966— crates/storage/provider/src/providers/database/provider.rs:2966-2996 | crates/storage/provider/src/providers/database/provider.rs:3131-3161 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (23 lines × 2) crates/storage/provider/src/test_utils/mock.rs:1255— crates/storage/provider/src/test_utils/mock.rs:1255-1277 | crates/storage/storage-api/src/noop.rs:631-653 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (23 lines × 2) crates/trie/common/src/proofs.rs:276— crates/trie/common/src/proofs.rs:276-298 | crates/trie/common/src/proofs.rs:401-423 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (19 lines × 2) crates/rpc/rpc-eth-api/src/helpers/transaction.rs:520— crates/rpc/rpc-eth-api/src/helpers/transaction.rs:520-538 | crates/rpc/rpc-eth-api/src/helpers/transaction.rs:598-616 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (19 lines × 2) crates/transaction-pool/src/pool/txpool.rs:275— crates/transaction-pool/src/pool/txpool.rs:275-293 | crates/transaction-pool/src/pool/txpool.rs:296-314 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (15–16 lines × 2) crates/engine/tree/src/tree/payload_validator.rs:809— crates/engine/tree/src/tree/payload_validator.rs:809-823 | crates/engine/tree/src/tree/payload_validator.rs:848-863 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (15–16 lines × 2) crates/prune/prune/src/segments/user/storage_history.rs:160— crates/prune/prune/src/segments/user/storage_history.rs:160-174 | crates/prune/prune/src/segments/user/storage_history.rs:233-248 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (15 lines × 2) crates/transaction-pool/src/blobstore/disk.rs:158— crates/transaction-pool/src/blobstore/disk.rs:158-172 | crates/transaction-pool/src/blobstore/mem.rs:63-77 — before extracting anything, compare `crates/transaction-pool/src/blobstore/disk.rs` and `crates/transaction-pool/src/blobstore/mem.rs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (15 lines × 2) crates/trie/trie/src/hashed_cursor/post_state.rs:325— crates/trie/trie/src/hashed_cursor/post_state.rs:325-339 | crates/trie/trie/src/trie_cursor/in_memory.rs:310-324 — before extracting anything, compare `crates/trie/trie/src/hashed_cursor/post_state.rs` and `crates/trie/trie/src/trie_cursor/in_memory.rs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 98 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (12–14 lines × 2) crates/prune/prune/src/segments/user/account_history.rs:102— crates/prune/prune/src/segments/user/account_history.rs:102-115 | crates/prune/prune/src/segments/user/account_history.rs:184-195 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12–14 lines × 2) crates/prune/prune/src/segments/user/storage_history.rs:103— crates/prune/prune/src/segments/user/storage_history.rs:103-116 | crates/prune/prune/src/segments/user/storage_history.rs:186-197 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11–12 lines × 2) crates/net/downloaders/src/bodies/task.rs:42— crates/net/downloaders/src/bodies/task.rs:42-53 | crates/net/downloaders/src/headers/task.rs:43-53 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (11–12 lines × 2) crates/stages/stages/src/stages/hashing_account.rs:187— crates/stages/stages/src/stages/hashing_account.rs:187-198 | crates/stages/stages/src/stages/hashing_storage.rs:117-127 — before extracting anything, compare `crates/stages/stages/src/stages/hashing_account.rs` and `crates/stages/stages/src/stages/hashing_storage.rs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6–8 lines × 2) crates/storage/db-common/src/init.rs:711— crates/storage/db-common/src/init.rs:711-716 | crates/storage/db-common/src/init.rs:805-812 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6–8 lines × 2) crates/trie/sparse/src/arena/mod.rs:728— crates/trie/sparse/src/arena/mod.rs:728-735 | crates/trie/sparse/src/arena/mod.rs:809-814 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 4) docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:66— docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:66-70 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_2.rs:32-36 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_3.rs:48-52 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_4.rs:68-72 — before extracting anything, compare `docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs` and `docs/vocs/docs/snippets/sources/exex/remote/src/exex_4.rs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 4) crates/era/src/era1/types/execution.rs:154— crates/era/src/era1/types/execution.rs:154-158 | crates/era/src/era1/types/execution.rs:223-227 | crates/era/src/ere/types/execution.rs:89-93 | crates/era/src/ere/types/execution.rs:152-156 — before extracting anything, compare `crates/era/src/era1/types/execution.rs` and `crates/era/src/ere/types/execution.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
controller.main (cyclomatic 51) contrib/trie-dst/workload/controller.py:383— controller.main has cyclomatic complexity 51 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
bench-benchmarkoor-summary.main (cyclomatic 47) .github/scripts/bench-benchmarkoor-summary.py:98— bench-benchmarkoor-summary.main has cyclomatic complexity 47 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
reth_transaction_pool::maintain::maintain_transaction_pool (cyclomatic 40) crates/transaction-pool/src/maintain.rs:125— reth_transaction_pool::maintain::maintain_transaction_pool has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
controller.worker (cyclomatic 40) contrib/trie-dst/workload/controller.py:240— controller.worker has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
reth_node_ethereum::engine_ssz_proxy::handle_engine_ssz_request (cyclomatic 37) crates/ethereum/node/src/engine_ssz_proxy.rs:578— reth_node_ethereum::engine_ssz_proxy::handle_engine_ssz_request has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EthTransactionValidator::validate_stateless (cyclomatic 35) crates/transaction-pool/src/validate/eth.rs:457— EthTransactionValidator::validate_stateless has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ProtocolMessage::decode_message_with_tx_memory_budget (cyclomatic 34) crates/net/eth-wire-types/src/message.rs:108— ProtocolMessage::decode_message_with_tx_memory_budget has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
reth_ethereum_payload_builder::default_ethereum_payload (cyclomatic 32) crates/ethereum/payload/src/lib.rs:148— reth_ethereum_payload_builder::default_ethereum_payload has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EthStateCacheService::poll (cyclomatic 31) crates/rpc/rpc-eth-types/src/cache/mod.rs:553— EthStateCacheService::poll has cyclomatic complexity 31 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
StreamCodec::decode (cyclomatic 29) crates/rpc/ipc/src/stream_codec.rs:146— StreamCodec::decode has cyclomatic complexity 29 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
TrieWitness::compute (cyclomatic 27) crates/trie/trie/src/witness.rs:88— TrieWitness::compute has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RlpxSatelliteStream::poll_next (cyclomatic 26) crates/net/eth-wire/src/multiplex.rs:792— RlpxSatelliteStream::poll_next has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EstimateCall::estimate_gas_with (cyclomatic 25) crates/rpc/rpc-eth-api/src/helpers/estimate.rs:44— EstimateCall::estimate_gas_with has cyclomatic complexity 25 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
BundleAccount::update_and_create_revert (cyclomatic 25) crates/trie/common/src/bundle_state/bundle_account.rs:138— BundleAccount::update_and_create_revert has cyclomatic complexity 25 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
bench-reth-summary.main (cyclomatic 25) .github/scripts/bench-reth-summary.py:2050— bench-reth-summary.main has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EthBeaconConsensus::validate_header (cyclomatic 24) crates/ethereum/consensus/src/lib.rs:175— EthBeaconConsensus::validate_header has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ExecutionStage::execute (cyclomatic 24) crates/stages/stages/src/stages/execution/mod.rs:293— ExecutionStage::execute has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
inject-cargo-docs.injectCargoDocs (cyclomatic 24) docs/vocs/scripts/inject-cargo-docs.ts:9— inject-cargo-docs.injectCargoDocs has cyclomatic complexity 24 (threshold 15). Of this number, 18 points are the body's own statements and 6 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BasicEngineValidator::validate_block_with_state (cyclomatic 23) crates/engine/tree/src/tree/payload_validator.rs:470— BasicEngineValidator::validate_block_with_state has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
TransactionFetcher::on_announcement (cyclomatic 23) crates/net/network/src/transactions/fetcher.rs:193— TransactionFetcher::on_announcement has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EthFees::fee_history (cyclomatic 23) crates/rpc/rpc-eth-api/src/helpers/fee.rs:66— EthFees::fee_history has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ArchiveFetcher::download_sequential (cyclomatic 22) crates/cli/commands/src/download/fetch.rs:203— ArchiveFetcher::download_sequential has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SessionManager::poll (cyclomatic 22) crates/net/network/src/session/mod.rs:505— SessionManager::poll has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
EthStatsService::run (cyclomatic 22) crates/node/ethstats/src/ethstats.rs:605— EthStatsService::run has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
bench-call-summary.build_summary (cyclomatic 22) .github/scripts/bench-call-summary.py:931— bench-call-summary.build_summary has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
bench-reth-summary.compute_target_metric_summary (cyclomatic 22) .github/scripts/bench-reth-summary.py:1517— bench-reth-summary.compute_target_metric_summary has cyclomatic complexity 22 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
DownloadCommand::resolve_components (cyclomatic 21) crates/cli/commands/src/download/mod.rs:715— DownloadCommand::resolve_components has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
reth_cli_commands::db::tui::handle_event (cyclomatic 21) crates/cli/commands/src/db/tui.rs:198— reth_cli_commands::db::tui::handle_event has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
EngineApiTreeHandler::on_engine_message (cyclomatic 21) crates/engine/tree/src/tree/mod.rs:1581— EngineApiTreeHandler::on_engine_message has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ReverseHeadersDownloader::poll_next (cyclomatic 21) crates/net/downloaders/src/headers/reverse_headers.rs:831— ReverseHeadersDownloader::poll_next has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
P2PStream::poll_next (cyclomatic 21) crates/net/eth-wire/src/p2pstream.rs:546— P2PStream::poll_next has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Discovery::new (cyclomatic 21) crates/net/network/src/discovery.rs:90— Discovery::new has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PeerResponse::poll (cyclomatic 21) crates/net/network/src/message.rs:211— PeerResponse::poll has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing. This shape REPEATS in the file: one other method here (PeerResponseResult::try_into_message) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
PeerResponseResult::try_into_message (cyclomatic 21) crates/net/network/src/message.rs:292— PeerResponseResult::try_into_message has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing. This shape REPEATS in the file: one other method here (PeerResponse::poll) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
EthPubSub::handle_accepted (cyclomatic 20) crates/rpc/rpc/src/eth/pubsub.rs:85— EthPubSub::handle_accepted has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
EthCall::simulate_v1 (cyclomatic 20) crates/rpc/rpc-eth-api/src/helpers/call.rs:65— EthCall::simulate_v1 has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DecodedMultiProofV2::from_witness (cyclomatic 20) crates/trie/common/src/proofs.rs:522— DecodedMultiProofV2::from_witness has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EngineNodeLauncher::launch_node (cyclomatic 19) crates/node/builder/src/launch/engine.rs:83— EngineNodeLauncher::launch_node has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
IpcConnDriver::poll (cyclomatic 19) crates/rpc/ipc/src/server/connection.rs:91— IpcConnDriver::poll has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DebugApi::debug_subscribe (cyclomatic 19) crates/rpc/rpc/src/debug.rs:978— DebugApi::debug_subscribe has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
SnapBootstrap::run (cyclomatic 19) crates/snap-sync/src/bootstrap.rs:127— SnapBootstrap::run has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
ProofCalculator::next_uncached_key_range (cyclomatic 19) crates/trie/trie/src/proof_v2/calculator.rs:971— ProofCalculator::next_uncached_key_range has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PrewarmCacheTask::transact_worker (cyclomatic 18) crates/engine/tree/src/tree/payload_processor/prewarm.rs:325— PrewarmCacheTask::transact_worker has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PeersManager::poll (cyclomatic 18) crates/net/network/src/peers.rs:1306— PeersManager::poll has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EthFilterInner::logs_for_filter (cyclomatic 18) crates/rpc/rpc/src/eth/filter.rs:481— EthFilterInner::logs_for_filter has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StorageHashingStage::execute (cyclomatic 18) crates/stages/stages/src/stages/hashing_storage.rs:90— StorageHashingStage::execute has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DatabaseEnv::open (cyclomatic 18) crates/storage/db/src/implementation/mdbx/mod.rs:443— DatabaseEnv::open has cyclomatic complexity 18 (threshold 15). Of this number, 15 points are the body's own statements and 3 belong to 2 function items inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StateRoot::calculate (cyclomatic 18) crates/trie/trie/src/trie.rs:174— StateRoot::calculate has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
bench-call-summary.run_stats (cyclomatic 18) .github/scripts/bench-call-summary.py:237— bench-call-summary.run_stats has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
bench-call-summary.generate_markdown (cyclomatic 18) .github/scripts/bench-call-summary.py:864— bench-call-summary.generate_markdown has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PrewarmedTx::validate (cyclomatic 17) crates/engine/tree/src/tree/payload_processor/reuse.rs:272— PrewarmedTx::validate has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LaunchContextWith::create_provider_factory_with_recovery (cyclomatic 17) crates/node/builder/src/launch/common.rs:498— LaunchContextWith::create_provider_factory_with_recovery has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EthBundle::call_bundle (cyclomatic 17) crates/rpc/rpc/src/eth/bundle.rs:51— EthBundle::call_bundle has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
EthSimBundle::parse_and_flatten_bundle (cyclomatic 17) crates/rpc/rpc/src/eth/sim_bundle.rs:148— EthSimBundle::parse_and_flatten_bundle has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AccountHashingStage::execute (cyclomatic 17) crates/stages/stages/src/stages/hashing_account.rs:161— AccountHashingStage::execute has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EnvironmentBuilder::open_with_permissions (cyclomatic 17) crates/storage/libmdbx-rs/src/environment.rs:642— EnvironmentBuilder::open_with_permissions has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
bench-reth-summary.compute_target_metric_change (cyclomatic 17) .github/scripts/bench-reth-summary.py:1005— bench-reth-summary.compute_target_metric_change has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
StartingStream::poll_next (cyclomatic 16) crates/era-downloader/src/stream.rs:260— StartingStream::poll_next has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DnsDiscoveryService::poll (cyclomatic 16) crates/net/dns/src/lib.rs:307— DnsDiscoveryService::poll has cyclomatic complexity 16 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PayloadBuilderService::poll (cyclomatic 16) crates/payload/builder/src/service.rs:406— PayloadBuilderService::poll has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LoadPendingBlock::build_block (cyclomatic 16) crates/rpc/rpc-eth-api/src/helpers/pending_block.rs:274— LoadPendingBlock::build_block has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Pipeline::unwind_stages (cyclomatic 16) crates/stages/api/src/pipeline/mod.rs:374— Pipeline::unwind_stages has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StaticFileProvider::ensure_invariants (cyclomatic 16) crates/storage/provider/src/providers/static_file/manager.rs:1735— StaticFileProvider::ensure_invariants has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
OverlayManager::get_or_compute_overlay (cyclomatic 16) crates/storage/storage-overlay/src/manager.rs:491— OverlayManager::get_or_compute_overlay has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
bench-reth-summary.generate_comparison_table (cyclomatic 16) .github/scripts/bench-reth-summary.py:1733— bench-reth-summary.generate_comparison_table has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
FixmeComment crates/stages/api/src/pipeline/mod.rs:698— // FIXME: When handling errors, we do not commit the database transaction. This — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
HackComment crates/evm/evm/src/engine.rs:130— /// HACK: for some reason, this duplicated AT is the only way to enforce the inner Recovered: — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
reth_transaction_pool::maintain::maintain_transaction_pool (cognitive 111) crates/transaction-pool/src/maintain.rs:125— reth_transaction_pool::maintain::maintain_transaction_pool has cognitive complexity 111 (threshold 15). Drivers by points: if/else 23 (79 pts), loops 5 (17 pts), match/switch 4 (9 pts), boolean chains 6 (nesting depth added 73). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
controller.worker (cognitive 96) contrib/trie-dst/workload/controller.py:240— controller.worker has cognitive complexity 96 (threshold 15). Drivers by points: if/else 25 (74 pts), boolean chains 8, error handling 3 (8 pts), loops 3 (6 pts) (nesting depth added 57). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
controller.main (cognitive 82) contrib/trie-dst/workload/controller.py:383— controller.main has cognitive complexity 82 (threshold 15). Drivers by points: if/else 24 (44 pts), ternaries 10 (18 pts), boolean chains 8, error handling 2 (8 pts), loops 2 (4 pts) (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
bench-benchmarkoor-summary.main (cognitive 64) .github/scripts/bench-benchmarkoor-summary.py:98— bench-benchmarkoor-summary.main has cognitive complexity 64 (threshold 15). Drivers by points: if/else 18 (25 pts), boolean chains 16, ternaries 5 (14 pts), loops 7 (9 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_ethereum_payload_builder::default_ethereum_payload (cognitive 62) crates/ethereum/payload/src/lib.rs:148— reth_ethereum_payload_builder::default_ethereum_payload has cognitive complexity 62 (threshold 15). Drivers by points: if/else 29 (51 pts), match/switch 3 (7 pts), boolean chains 3, loops 1 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StreamCodec::decode (cognitive 58) crates/rpc/ipc/src/stream_codec.rs:146— StreamCodec::decode has cognitive complexity 58 (threshold 15). Drivers by points: if/else 19 (41 pts), boolean chains 8, match/switch 2 (7 pts), loops 1 (2 pts) (nesting depth added 28). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
EthStateCacheService::poll (cognitive 57) crates/rpc/rpc-eth-types/src/cache/mod.rs:553— EthStateCacheService::poll has cognitive complexity 57 (threshold 15). Drivers by points: if/else 9 (29 pts), loops 7 (22 pts), match/switch 2 (5 pts), boolean chains 1 (nesting depth added 38). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DecodedMultiProofV2::from_witness (cognitive 52) crates/trie/common/src/proofs.rs:522— DecodedMultiProofV2::from_witness has cognitive complexity 52 (threshold 15). Drivers by points: if/else 15 (44 pts), loops 3 (5 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_node_ethereum::engine_ssz_proxy::handle_engine_ssz_request (cognitive 51) crates/ethereum/node/src/engine_ssz_proxy.rs:578— reth_node_ethereum::engine_ssz_proxy::handle_engine_ssz_request has cognitive complexity 51 (threshold 15). Drivers by points: if/else 20 (38 pts), match/switch 8 (13 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TrieWitness::compute (cognitive 51) crates/trie/trie/src/witness.rs:88— TrieWitness::compute has cognitive complexity 51 (threshold 15). Drivers by points: if/else 21 (34 pts), loops 8 (13 pts), boolean chains 4 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
bench-reth-summary.compute_target_metric_summary (cognitive 51) .github/scripts/bench-reth-summary.py:1517— bench-reth-summary.compute_target_metric_summary has cognitive complexity 51 (threshold 15). Drivers by points: loops 12 (32 pts), if/else 8 (18 pts), boolean chains 1 (nesting depth added 30). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
EthStatsService::run (cognitive 48) crates/node/ethstats/src/ethstats.rs:605— EthStatsService::run has cognitive complexity 48 (threshold 15). Drivers by points: if/else 11 (32 pts), match/switch 4 (13 pts), loops 3 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IpcConnDriver::poll (cognitive 46) crates/rpc/ipc/src/server/connection.rs:91— IpcConnDriver::poll has cognitive complexity 46 (threshold 15). Drivers by points: if/else 8 (22 pts), match/switch 5 (18 pts), loops 3 (5 pts), boolean chains 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ArchiveFetcher::download_sequential (cognitive 45) crates/cli/commands/src/download/fetch.rs:203— ArchiveFetcher::download_sequential has cognitive complexity 45 (threshold 15). Drivers by points: if/else 19 (38 pts), boolean chains 4, match/switch 1 (2 pts), loops 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NetworkState::poll (cognitive 42) crates/net/network/src/state.rs:521— NetworkState::poll has cognitive complexity 42 (threshold 15). Drivers by points: loops 8 (18 pts), if/else 6 (17 pts), match/switch 2 (7 pts) (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReverseHeadersDownloader::poll_next (cognitive 39) crates/net/downloaders/src/headers/reverse_headers.rs:831— ReverseHeadersDownloader::poll_next has cognitive complexity 39 (threshold 15). Drivers by points: if/else 10 (23 pts), match/switch 3 (8 pts), loops 4 (6 pts), boolean chains 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PayloadProcessor::spawn_tx_iterator (cognitive 38) crates/engine/tree/src/tree/payload_processor/mod.rs:263— PayloadProcessor::spawn_tx_iterator has cognitive complexity 38 (threshold 15). Drivers by points: if/else 12 (30 pts), loops 2 (7 pts), boolean chains 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthFees::fee_history (cognitive 38) crates/rpc/rpc-eth-api/src/helpers/fee.rs:66— EthFees::fee_history has cognitive complexity 38 (threshold 15). Drivers by points: if/else 18 (24 pts), loops 4 (11 pts), boolean chains 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LoadPendingBlock::build_block (cognitive 38) crates/rpc/rpc-eth-api/src/helpers/pending_block.rs:274— LoadPendingBlock::build_block has cognitive complexity 38 (threshold 15). Drivers by points: if/else 13 (32 pts), match/switch 1 (3 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExecutionStage::execute (cognitive 38) crates/stages/stages/src/stages/execution/mod.rs:293— ExecutionStage::execute has cognitive complexity 38 (threshold 15). Drivers by points: if/else 17 (31 pts), boolean chains 4, loops 2 (3 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StateRoot::calculate (cognitive 38) crates/trie/trie/src/trie.rs:174— StateRoot::calculate has cognitive complexity 38 (threshold 15). Drivers by points: if/else 12 (29 pts), match/switch 2 (4 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_rpc::reth::finalized_chain_notifications (cognitive 37) crates/rpc/rpc/src/reth.rs:336— reth_rpc::reth::finalized_chain_notifications has cognitive complexity 37 (threshold 15). Drivers by points: if/else 9 (28 pts), match/switch 3 (8 pts), loops 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PayloadBuilderService::poll (cognitive 35) crates/payload/builder/src/service.rs:406— PayloadBuilderService::poll has cognitive complexity 35 (threshold 15). Drivers by points: if/else 5 (17 pts), match/switch 3 (11 pts), loops 4 (7 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PrewarmedTx::validate (cognitive 34) crates/engine/tree/src/tree/payload_processor/reuse.rs:272— PrewarmedTx::validate has cognitive complexity 34 (threshold 15). Drivers by points: if/else 10 (28 pts), loops 3, match/switch 1 (2 pts), boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EngineNodeLauncher::launch_node (cognitive 34) crates/node/builder/src/launch/engine.rs:83— EngineNodeLauncher::launch_node has cognitive complexity 34 (threshold 15). Drivers by points: if/else 13 (28 pts), match/switch 2 (5 pts), loops 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StorageHashingStage::execute (cognitive 34) crates/stages/stages/src/stages/hashing_storage.rs:90— StorageHashingStage::execute has cognitive complexity 34 (threshold 15). Drivers by points: if/else 10 (20 pts), loops 4 (9 pts), boolean chains 5 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PendingPool::remove_to_limit (cognitive 34) crates/transaction-pool/src/pool/pending.rs:420— PendingPool::remove_to_limit has cognitive complexity 34 (threshold 15). Drivers by points: if/else 7 (22 pts), loops 4 (9 pts), boolean chains 3 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BundleAccount::update_and_create_revert (cognitive 34) crates/trie/common/src/bundle_state/bundle_account.rs:138— BundleAccount::update_and_create_revert has cognitive complexity 34 (threshold 15). Drivers by points: if/else 9 (15 pts), match/switch 6 (13 pts), loops 2 (6 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthBeaconConsensus::validate_header (cognitive 33) crates/ethereum/consensus/src/lib.rs:175— EthBeaconConsensus::validate_header has cognitive complexity 33 (threshold 15). Drivers by points: if/else 22 (30 pts), boolean chains 3 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
P2PStream::poll_next (cognitive 33) crates/net/eth-wire/src/p2pstream.rs:546— P2PStream::poll_next has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (24 pts), boolean chains 4, match/switch 2 (4 pts), loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FetchFullBlockFuture::poll (cognitive 33) crates/net/p2p/src/full_block.rs:276— FetchFullBlockFuture::poll has cognitive complexity 33 (threshold 15). Drivers by points: if/else 8 (24 pts), match/switch 3 (8 pts), loops 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthPubSub::handle_accepted (cognitive 32) crates/rpc/rpc/src/eth/pubsub.rs:85— EthPubSub::handle_accepted has cognitive complexity 32 (threshold 15). Drivers by points: if/else 5 (15 pts), match/switch 6 (15 pts), loops 1 (2 pts) (nesting depth added 20). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
DnsDiscoveryService::poll (cognitive 31) crates/net/dns/src/lib.rs:307— DnsDiscoveryService::poll has cognitive complexity 31 (threshold 15). Drivers by points: loops 8 (16 pts), match/switch 3 (10 pts), if/else 2 (4 pts), boolean chains 1 (nesting depth added 17). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
AccountHashingStage::execute (cognitive 30) crates/stages/stages/src/stages/hashing_account.rs:161— AccountHashingStage::execute has cognitive complexity 30 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 4 (9 pts), boolean chains 5 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_stages::stages::execution::slot_preimages::inject_plain_wipe_slots (cognitive 30) crates/stages/stages/src/stages/execution/slot_preimages.rs:132— reth_stages::stages::execution::slot_preimages::inject_plain_wipe_slots has cognitive complexity 30 (threshold 15). Drivers by points: loops 8 (16 pts), if/else 5 (14 pts) (nesting depth added 17). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
EstimateCall::estimate_gas_with (cognitive 29) crates/rpc/rpc-eth-api/src/helpers/estimate.rs:44— EstimateCall::estimate_gas_with has cognitive complexity 29 (threshold 15). Drivers by points: if/else 15 (18 pts), boolean chains 5, match/switch 3 (5 pts), loops 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
DownloadCommand::resolve_components (cognitive 28) crates/cli/commands/src/download/mod.rs:715— DownloadCommand::resolve_components has cognitive complexity 28 (threshold 15). Drivers by points: if/else 14 (22 pts), boolean chains 6 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RlpxProtocolMultiplexer::into_satellite_stream_with_tuple_handshake (cognitive 28) crates/net/eth-wire/src/multiplex.rs:160— RlpxProtocolMultiplexer::into_satellite_stream_with_tuple_handshake has cognitive complexity 28 (threshold 15). Drivers by points: if/else 8 (21 pts), match/switch 2 (5 pts), boolean chains 1, loops 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PoolInner::notify_on_transaction_updates (cognitive 28) crates/transaction-pool/src/pool/mod.rs:931— PoolInner::notify_on_transaction_updates has cognitive complexity 28 (threshold 15). Drivers by points: if/else 10 (20 pts), loops 4 (6 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NodeArena::sweep_blinded (cognitive 28) crates/trie/sparse/src/arena/node_arena.rs:166— NodeArena::sweep_blinded has cognitive complexity 28 (threshold 15). Drivers by points: loops 6 (14 pts), if/else 5 (12 pts), boolean chains 2 (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
bench-reth-summary.main (cognitive 28) .github/scripts/bench-reth-summary.py:2050— bench-reth-summary.main has cognitive complexity 28 (threshold 15). Drivers by points: if/else 12 (16 pts), boolean chains 9, loops 3 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ECIESCodec::decode (cognitive 27) crates/net/ecies/src/codec.rs:62— ECIESCodec::decode has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (24 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ProtocolMessage::decode_message_with_tx_memory_budget (cognitive 27) crates/net/eth-wire-types/src/message.rs:108— ProtocolMessage::decode_message_with_tx_memory_budget has cognitive complexity 27 (threshold 15). Drivers by points: if/else 14 (24 pts), match/switch 2 (3 pts) (nesting depth added 11). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
SessionManager::poll (cognitive 27) crates/net/network/src/session/mod.rs:505— SessionManager::poll has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (15 pts), match/switch 7 (11 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReadTransactions::start_monitor (cognitive 27) crates/storage/libmdbx-rs/src/txn_manager.rs:232— ReadTransactions::start_monitor has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (18 pts), loops 3 (5 pts), match/switch 1 (4 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReceiptFileClient::from_receipt_reader (cognitive 26) crates/net/downloaders/src/receipt_file_client.rs:60— ReceiptFileClient::from_receipt_reader has cognitive complexity 26 (threshold 15). Drivers by points: if/else 8 (18 pts), match/switch 3 (7 pts), loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NetworkManager::on_swarm_event (cognitive 26) crates/net/network/src/manager.rs:814— NetworkManager::on_swarm_event has cognitive complexity 26 (threshold 15). Drivers by points: if/else 13 (25 pts), match/switch 1 (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
FetchFullBlockRangeFuture::poll (cognitive 26) crates/net/p2p/src/full_block.rs:879— FetchFullBlockRangeFuture::poll has cognitive complexity 26 (threshold 15). Drivers by points: if/else 5 (16 pts), match/switch 3 (8 pts), boolean chains 1, loops 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RangeBlockMode::next (cognitive 26) crates/rpc/rpc/src/eth/filter.rs:1233— RangeBlockMode::next has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (23 pts), loops 2 (3 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExExNotificationsWithHead::poll_next (cognitive 25) crates/exex/exex/src/notifications.rs:483— ExExNotificationsWithHead::poll_next has cognitive complexity 25 (threshold 15). Drivers by points: if/else 11 (21 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LaunchContextWith::create_provider_factory_with_recovery (cognitive 25) crates/node/builder/src/launch/common.rs:498— LaunchContextWith::create_provider_factory_with_recovery has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (17 pts), boolean chains 3, match/switch 1 (3 pts), loops 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DebugApi::debug_subscribe (cognitive 25) crates/rpc/rpc/src/debug.rs:978— DebugApi::debug_subscribe has cognitive complexity 25 (threshold 15). Drivers by points: match/switch 7 (13 pts), if/else 6 (10 pts), boolean chains 1, loops 1 (nesting depth added 10). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
TraceApi::trace_filter (cognitive 25) crates/rpc/rpc/src/trace.rs:381— TraceApi::trace_filter has cognitive complexity 25 (threshold 15). Drivers by points: if/else 12 (21 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TrieNodeIter::try_next (cognitive 25) crates/trie/trie/src/node_iter.rs:201— TrieNodeIter::try_next has cognitive complexity 25 (threshold 15). Drivers by points: if/else 6 (17 pts), match/switch 2 (5 pts), boolean chains 2, loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
bench-call-summary.build_summary (cognitive 25) .github/scripts/bench-call-summary.py:931— bench-call-summary.build_summary has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 10, loops 1 (2 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
BlockState::commit_account (cognitive 24) crates/evm/execution-types/src/compat.rs:91— BlockState::commit_account has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (13 pts), match/switch 3 (6 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EnvironmentBuilder::open_with_permissions (cognitive 24) crates/storage/libmdbx-rs/src/environment.rs:642— EnvironmentBuilder::open_with_permissions has cognitive complexity 24 (threshold 15). Drivers by points: if/else 12 (19 pts), match/switch 2 (3 pts), loops 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ArenaSparseSubtrie::prune (cognitive 24) crates/trie/sparse/src/arena/mod.rs:180— ArenaSparseSubtrie::prune has cognitive complexity 24 (threshold 15). Drivers by points: if/else 13 (23 pts), loops 1 (nesting depth added 10). Of this number, 21 points are the body's own statements and 3 belong to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CachedPrecompileProvider::execute (cognitive 23) crates/evm/evm/src/precompile_cache.rs:210— CachedPrecompileProvider::execute has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (19 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EthBundle::call_bundle (cognitive 23) crates/rpc/rpc/src/eth/bundle.rs:51— EthBundle::call_bundle has cognitive complexity 23 (threshold 15). Drivers by points: if/else 16 (19 pts), match/switch 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
ChunkedMultiProofTargetsV2::next (cognitive 23) crates/trie/common/src/target_v2.rs:204— ChunkedMultiProofTargetsV2::next has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (19 pts), boolean chains 2, loops 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BasicBlockDownloader::poll (cognitive 22) crates/engine/tree/src/download.rs:239— BasicBlockDownloader::poll has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 4 (5 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EngineHandler::poll (cognitive 22) crates/engine/tree/src/engine.rs:81— EngineHandler::poll has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (12 pts), match/switch 2 (7 pts), loops 2 (3 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TestingApi::build_payload_v1 (cognitive 22) crates/rpc/rpc/src/testing.rs:119— TestingApi::build_payload_v1 has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (17 pts), boolean chains 2, match/switch 1 (2 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SnapBootstrap::run (cognitive 22) crates/snap-sync/src/bootstrap.rs:127— SnapBootstrap::run has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (14 pts), match/switch 3 (7 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BundleState::extend (cognitive 22) crates/trie/common/src/bundle_state/bundle_state.rs:704— BundleState::extend has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (16 pts), loops 2 (5 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
bench-call-summary.run_stats (cognitive 22) .github/scripts/bench-call-summary.py:237— bench-call-summary.run_stats has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (17 pts), boolean chains 5 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
bench-reth-charts.plot_latency_and_throughput (cognitive 22) .github/scripts/bench-reth-charts.py:54— bench-reth-charts.plot_latency_and_throughput has cognitive complexity 22 (threshold 15). Drivers by points: ternaries 4 (9 pts), if/else 4 (7 pts), loops 3 (5 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
inject-cargo-docs.injectCargoDocs (cognitive 22) docs/vocs/scripts/inject-cargo-docs.ts:9— inject-cargo-docs.injectCargoDocs has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (7 pts), boolean chains 6, ternaries 2 (4 pts), loops 3, error handling 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_evm_ethereum::execution::post_block_balance_state_changes (cognitive 21) crates/ethereum/evm/src/execution.rs:476— reth_evm_ethereum::execution::post_block_balance_state_changes has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 4 (6 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExExManager::poll (cognitive 21) crates/exex/exex/src/manager.rs:458— ExExManager::poll has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (7 pts), loops 5 (6 pts), match/switch 2 (6 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BodiesDownloader::poll_next (cognitive 21) crates/net/downloaders/src/bodies/bodies.rs:361— BodiesDownloader::poll_next has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (8 pts), loops 4 (7 pts), match/switch 2 (6 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionLookupStage::execute (cognitive 21) crates/stages/stages/src/stages/tx_lookup.rs:77— TransactionLookupStage::execute has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseEnv::open (cognitive 21) crates/storage/db/src/implementation/mdbx/mod.rs:443— DatabaseEnv::open has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (16 pts), match/switch 2 (4 pts), boolean chains 1 (nesting depth added 6). Of this number, 16 points are the body's own statements and 5 belong to 2 function items inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
bench-reth-charts.merge_csvs (cognitive 21) .github/scripts/bench-reth-charts.py:193— bench-reth-charts.merge_csvs has cognitive complexity 21 (threshold 15). Drivers by points: loops 5 (10 pts), if/else 3 (7 pts), ternaries 1 (4 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ArchiveProcessor::run (cognitive 20) crates/cli/commands/src/download/archive.rs:140— ArchiveProcessor::run has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (14 pts), match/switch 2 (5 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_ethereum_consensus::validation::validate_block_post_execution_with_bal_hashes (cognitive 20) crates/ethereum/consensus/src/validation.rs:43— reth_ethereum_consensus::validation::validate_block_post_execution_with_bal_hashes has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (16 pts), boolean chains 4 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_network::session::authenticate_stream (cognitive 20) crates/net/network/src/session/mod.rs:1185— reth_network::session::authenticate_stream has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (8 pts), match/switch 5 (8 pts), loops 2 (4 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReceiptsByLogs::prune (cognitive 20) crates/prune/prune/src/segments/user/receipts_by_logs.rs:51— ReceiptsByLogs::prune has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (14 pts), match/switch 2 (3 pts), loops 2, boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_prune::segments::user::history::prune_shard (cognitive 20) crates/prune/prune/src/segments/user/history.rs:144— reth_prune::segments::user::history::prune_shard has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (16 pts), match/switch 1 (4 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OverlayManager::get_or_compute_overlay (cognitive 20) crates/storage/storage-overlay/src/manager.rs:491— OverlayManager::get_or_compute_overlay has cognitive complexity 20 (threshold 15). Drivers by points: match/switch 7 (12 pts), if/else 4 (7 pts), boolean chains 1 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
Verifier::verify_empty_storages (cognitive 20) crates/trie/trie/src/verify.rs:350— Verifier::verify_empty_storages has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
bench-call-summary.generate_markdown (cognitive 20) .github/scripts/bench-call-summary.py:864— bench-call-summary.generate_markdown has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (11 pts), ternaries 4 (5 pts), boolean chains 3, loops 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
bench-reth-charts.plot_wait_breakdown (cognitive 20) .github/scripts/bench-reth-charts.py:119— bench-reth-charts.plot_wait_breakdown has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Worker::warm_one_batch (cognitive 19) crates/engine/tree/src/tree/txpool_prewarm/worker.rs:183— Worker::warm_one_batch has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (16 pts), boolean chains 1, loops 1, match/switch 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StateFetcher::poll (cognitive 19) crates/net/network/src/fetch/mod.rs:239— StateFetcher::poll has cognitive complexity 19 (threshold 15). Drivers by points: match/switch 3 (9 pts), if/else 2 (6 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
reth_node_builder::rpc::prewarm_new_block_bals_task (cognitive 19) crates/node/builder/src/rpc.rs:1727— reth_node_builder::rpc::prewarm_new_block_bals_task has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 2 (4 pts), match/switch 2 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pruner::prune_segments (cognitive 19) crates/prune/prune/src/pruner.rs:186— Pruner::prune_segments has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (17 pts), boolean chains 1, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SegmentHeader::prune (cognitive 19) crates/static-file/types/src/segment.rs:510— SegmentHeader::prune has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (19 pts) (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
bench-reth-summary.compute_target_metric_change (cognitive 19) .github/scripts/bench-reth-summary.py:1005— bench-reth-summary.compute_target_metric_change has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (13 pts), boolean chains 4, ternaries 2 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MiningMode::poll (cognitive 18) crates/engine/local/src/miner.rs:94— MiningMode::poll has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 1 (2 pts), match/switch 1 (nesting depth added 10). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
StartingStream::poll_next (cognitive 18) crates/era-downloader/src/stream.rs:260— StartingStream::poll_next has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (10 pts), boolean chains 5, match/switch 2 (3 pts) (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
BodiesRequestFuture::poll (cognitive 18) crates/net/downloaders/src/bodies/request.rs:219— BodiesRequestFuture::poll has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 2 (3 pts), match/switch 1 (3 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EventHandler::poll (cognitive 18) crates/node/events/src/node.rs:487— EventHandler::poll has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (11 pts), match/switch 2 (5 pts), loops 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_ipc::server::ipc::process_batch_request (cognitive 18) crates/rpc/ipc/src/server/ipc.rs:31— reth_ipc::server::ipc::process_batch_request has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (12 pts), match/switch 1 (3 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
reth_db_common::init::init_genesis_with_settings_and_validate (cognitive 18) crates/storage/db-common/src/init.rs:171— reth_db_common::init::init_genesis_with_settings_and_validate has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 1, match/switch 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OverlayBuilder::build_state_trie_overlay_at_frontiers (cognitive 18) crates/storage/storage-overlay/src/builder.rs:407— OverlayBuilder::build_state_trie_overlay_at_frontiers has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (17 pts), match/switch 1 (nesting depth added 5). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
bench-reth-summary.query_histogram_target_metric_run (cognitive 18) .github/scripts/bench-reth-summary.py:1204— bench-reth-summary.query_histogram_target_metric_run has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
fetch-grafana-dashboard.make_exportable (cognitive 18) .github/scripts/fetch-grafana-dashboard.py:89— fetch-grafana-dashboard.make_exportable has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 4 (7 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GetValueViewer::view_dupsort (cognitive 17) crates/cli/commands/src/db/get.rs:580— GetValueViewer::view_dupsort has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EngineReorg::poll_next (cognitive 17) crates/engine/util/src/reorg.rs:109— EngineReorg::poll_next has cognitive complexity 17 (threshold 15). Drivers by points: match/switch 4 (11 pts), if/else 2 (4 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
QueryPool::poll (cognitive 17) crates/net/dns/src/query.rs:81— QueryPool::poll has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 3 (5 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NodeState::handle_pipeline_event (cognitive 17) crates/node/events/src/node.rs:90— NodeState::handle_pipeline_event has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (13 pts), match/switch 2 (4 pts) (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
DbTool::list (cognitive 17) crates/storage/db-common/src/db_tool/mod.rs:36— DbTool::list has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (13 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConsistentProvider::get_in_memory_or_storage_by_tx (cognitive 17) crates/storage/provider/src/providers/consistent.rs:325— ConsistentProvider::get_in_memory_or_storage_by_tx has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BlobTransactions::satisfy_attributes (cognitive 17) crates/transaction-pool/src/pool/blob.rs:107— BlobTransactions::satisfy_attributes has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExecutionCache::insert_state (cognitive 16) crates/engine/execution-cache/src/cached_state.rs:1133— ExecutionCache::insert_state has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 3 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PredictedState::update (cognitive 16) crates/engine/tree/src/tree/payload_processor/reuse.rs:589— PredictedState::update has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (9 pts), boolean chains 4, loops 2 (3 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Swarm::poll_next (cognitive 16) crates/net/network/src/swarm.rs:324— Swarm::poll_next has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (9 pts), match/switch 2 (4 pts), loops 2 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HeaderStage::write_headers (cognitive 16) crates/stages/stages/src/stages/headers.rs:100— HeaderStage::write_headers has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (11 pts), boolean chains 3, loops 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
bench-reth-summary.load_target_metric_scrapes (cognitive 16) .github/scripts/bench-reth-summary.py:857— bench-reth-summary.load_target_metric_scrapes has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), error handling 1 (2 pts), loops 2, boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
bench-reth-summary.generate_comparison_table (cognitive 16) .github/scripts/bench-reth-summary.py:1733— bench-reth-summary.generate_comparison_table has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (7 pts), ternaries 7, boolean chains 1, loops 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
Change coupling clique: noop.rs, test_utils.rs, lib.rs crates/consensus/consensus/src/noop.rs— 3 files — `crates/consensus/consensus/src/noop.rs`, `crates/consensus/consensus/src/test_utils.rs`, `crates/ethereum/consensus/src/lib.rs` — all change together with no explicit dependency: a fully-connected co-change clique, not 3 separate couplings. They share one concern (thin parallel siblings over a common abstraction), so extract the shared part into ONE unit and the whole clique's coupling clears at once — you do not need to break each pair individually.
Near-duplicate member pair (91 shared lines) crates/storage/provider/src/providers/rocksdb/provider.rs:2392— crates/storage/provider/src/providers/rocksdb/provider.rs:2392-2510 | crates/storage/provider/src/providers/rocksdb/provider.rs:2548-2667 — These two members are variants of one another: 91 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Near-duplicate member pair (44 shared lines) crates/stages/stages/src/stages/hashing_account.rs:161— crates/stages/stages/src/stages/hashing_account.rs:161-282 | crates/stages/stages/src/stages/hashing_storage.rs:90-223 — These two members are variants of one another: 44 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Near-duplicate member pair (40 shared lines) crates/rpc/rpc-eth-api/src/helpers/transaction.rs:508— crates/rpc/rpc-eth-api/src/helpers/transaction.rs:508-583 | crates/rpc/rpc-eth-api/src/helpers/transaction.rs:592-668 — These two members are variants of one another: 40 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication· Edited copy of a member (31 corresponding lines) · ×1
Edited copy of a member (31 corresponding lines) crates/storage/libmdbx-rs/src/cursor.rs:561— crates/storage/libmdbx-rs/src/cursor.rs:561-596 | crates/storage/libmdbx-rs/src/cursor.rs:656-691 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (44 lines × 2) crates/storage/provider/src/providers/rocksdb/provider.rs:2413— crates/storage/provider/src/providers/rocksdb/provider.rs:2413-2456 | crates/storage/provider/src/providers/rocksdb/provider.rs:2569-2612 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (32–37 lines × 2) crates/prune/prune/src/segments/user/account_history.rs:111— crates/prune/prune/src/segments/user/account_history.rs:111-147 | crates/prune/prune/src/segments/user/account_history.rs:266-297 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (35 lines × 2) crates/rpc/rpc/src/eth/builder.rs:206— crates/rpc/rpc/src/eth/builder.rs:206-240 | crates/rpc/rpc/src/eth/builder.rs:263-297 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (31–32 lines × 2) crates/rpc/rpc/src/validation.rs:500— crates/rpc/rpc/src/validation.rs:500-531 | crates/rpc/rpc/src/validation.rs:549-579 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (30–31 lines × 2) crates/storage/provider/src/providers/rocksdb/provider.rs:2467— crates/storage/provider/src/providers/rocksdb/provider.rs:2467-2496 | crates/storage/provider/src/providers/rocksdb/provider.rs:2623-2653 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (25 lines × 2) crates/stages/stages/src/stages/utils.rs:321— crates/stages/stages/src/stages/utils.rs:321-345 | crates/stages/stages/src/stages/utils.rs:543-567 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (21–24 lines × 2) crates/prune/prune/src/segments/user/account_history.rs:104— crates/prune/prune/src/segments/user/account_history.rs:104-127 | crates/prune/prune/src/segments/user/storage_history.rs:105-125 — before extracting anything, compare `crates/prune/prune/src/segments/user/account_history.rs` and `crates/prune/prune/src/segments/user/storage_history.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 116 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (19–22 lines × 3) crates/transaction-pool/src/blobstore/disk.rs:105— crates/transaction-pool/src/blobstore/disk.rs:105-126 | crates/transaction-pool/src/blobstore/disk.rs:177-195 | crates/transaction-pool/src/blobstore/disk.rs:324-345 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (21–22 lines × 2) crates/net/peers/src/node_record.rs:187— crates/net/peers/src/node_record.rs:187-207 | crates/net/peers/src/trusted_peer.rs:142-163 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (19–22 lines × 2) crates/prune/prune/src/segments/user/storage_history.rs:124— crates/prune/prune/src/segments/user/storage_history.rs:124-142 | crates/prune/prune/src/segments/user/storage_history.rs:274-295 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (20–22 lines × 2) crates/trie/trie/src/trie.rs:241— crates/trie/trie/src/trie.rs:241-260 | crates/trie/trie/src/trie.rs:314-335 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (15–21 lines × 2) crates/rpc/rpc-eth-api/src/helpers/transaction.rs:541— crates/rpc/rpc-eth-api/src/helpers/transaction.rs:541-555 | crates/rpc/rpc-eth-api/src/helpers/transaction.rs:640-660 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (20–21 lines × 2) crates/stages/stages/src/stages/utils.rs:154— crates/stages/stages/src/stages/utils.rs:154-173 | crates/stages/stages/src/stages/utils.rs:209-229 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13–20 lines × 2) crates/storage/provider/src/providers/consistent.rs:1131— crates/storage/provider/src/providers/consistent.rs:1131-1150 | crates/storage/provider/src/providers/consistent.rs:1186-1198 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11–19 lines × 3) crates/prune/prune/src/segments/user/account_history.rs:110— crates/prune/prune/src/segments/user/account_history.rs:110-128 | crates/prune/prune/src/segments/user/account_history.rs:265-275 | crates/prune/prune/src/segments/user/storage_history.rs:111-126 — before extracting anything, compare `crates/prune/prune/src/segments/user/account_history.rs` and `crates/prune/prune/src/segments/user/storage_history.rs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 116 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (18 lines × 3) docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:28— docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:28-45 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_3.rs:26-43 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_4.rs:28-45 — before extracting anything, compare `docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs` and `docs/vocs/docs/snippets/sources/exex/remote/src/exex_4.rs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (15–18 lines × 2) crates/storage/provider/src/providers/consistent.rs:1208— crates/storage/provider/src/providers/consistent.rs:1208-1222 | crates/storage/provider/src/providers/consistent.rs:1357-1374 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12–17 lines × 2) crates/transaction-pool/src/pool/mod.rs:795— crates/transaction-pool/src/pool/mod.rs:795-811 | crates/transaction-pool/src/pool/mod.rs:880-891 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (16 lines × 3) crates/cli/commands/src/stage/dump/hashing_account.rs:36— crates/cli/commands/src/stage/dump/hashing_account.rs:36-51 | crates/cli/commands/src/stage/dump/hashing_storage.rs:26-41 | crates/cli/commands/src/stage/dump/merkle.rs:62-77 — before extracting anything, compare `crates/cli/commands/src/stage/dump/hashing_account.rs` and `crates/cli/commands/src/stage/dump/hashing_storage.rs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (13–16 lines × 2) crates/net/discv4/src/proto.rs:504— crates/net/discv4/src/proto.rs:504-516 | crates/net/discv4/src/proto.rs:584-599 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13–15 lines × 2) crates/cli/commands/src/db/repair_trie.rs:129— crates/cli/commands/src/db/repair_trie.rs:129-141 | crates/cli/commands/src/db/repair_trie.rs:251-265 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12–14 lines × 5) crates/net/discv4/src/proto.rs:296— crates/net/discv4/src/proto.rs:296-309 | crates/net/discv4/src/proto.rs:338-351 | crates/net/discv4/src/proto.rs:381-394 | crates/net/discv4/src/proto.rs:508-519 | crates/net/discv4/src/proto.rs:591-603 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (10–12 lines × 2) crates/trie/common/src/hashed_state.rs:103— crates/trie/common/src/hashed_state.rs:103-114 | crates/trie/common/src/hashed_state.rs:469-478 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 4) crates/cli/commands/src/stage/dump/execution.rs:41— crates/cli/commands/src/stage/dump/execution.rs:41-51 | crates/cli/commands/src/stage/dump/hashing_account.rs:36-46 | crates/cli/commands/src/stage/dump/hashing_storage.rs:26-36 | crates/cli/commands/src/stage/dump/merkle.rs:62-72 — before extracting anything, compare `crates/cli/commands/src/stage/dump/hashing_account.rs` and `crates/cli/commands/src/stage/dump/hashing_storage.rs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (3–11 lines × 4) crates/cli/commands/src/db/stats.rs:204— crates/cli/commands/src/db/stats.rs:204-206 | crates/cli/commands/src/db/stats.rs:305-312 | crates/cli/commands/src/db/stats.rs:368-378 | crates/cli/commands/src/db/stats.rs:396-403 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (11 lines × 3) crates/rpc/rpc-engine-api/src/engine_api.rs:1175— crates/rpc/rpc-engine-api/src/engine_api.rs:1175-1185 | crates/rpc/rpc-engine-api/src/engine_api.rs:1198-1208 | crates/rpc/rpc-engine-api/src/engine_api.rs:1229-1239 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (10–11 lines × 2) contrib/trie-dst/crates/reth-trie-dst/src/main.rs:371— contrib/trie-dst/crates/reth-trie-dst/src/main.rs:371-380 | contrib/trie-dst/crates/reth-trie-dst/src/main.rs:473-483 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9–11 lines × 2) crates/storage/rpc-provider/src/lib.rs:484— crates/storage/rpc-provider/src/lib.rs:484-494 | crates/storage/rpc-provider/src/lib.rs:699-707 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6–9 lines × 5) crates/net/network/src/fetch/mod.rs:395— crates/net/network/src/fetch/mod.rs:395-400 | crates/net/network/src/fetch/mod.rs:426-435 | crates/net/network/src/fetch/mod.rs:448-456 | crates/net/network/src/fetch/mod.rs:472-480 | crates/net/network/src/fetch/mod.rs:508-516 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (9 lines × 4) docs/vocs/docs/snippets/sources/exex/remote/src/exex_1.rs:32— docs/vocs/docs/snippets/sources/exex/remote/src/exex_1.rs:32-40 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_2.rs:41-49 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_3.rs:57-65 | docs/vocs/docs/snippets/sources/exex/remote/src/exex_4.rs:77-85 — before extracting anything, compare `docs/vocs/docs/snippets/sources/exex/remote/src/exex_3.rs` and `docs/vocs/docs/snippets/sources/exex/remote/src/exex_4.rs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8–9 lines × 3) crates/cli/commands/src/db/stats.rs:193— crates/cli/commands/src/db/stats.rs:193-200 | crates/cli/commands/src/db/stats.rs:382-389 | crates/cli/commands/src/db/stats.rs:431-439 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (9 lines × 3) crates/rpc/rpc-engine-api/src/engine_api.rs:1160— crates/rpc/rpc-engine-api/src/engine_api.rs:1160-1168 | crates/rpc/rpc-engine-api/src/engine_api.rs:1300-1308 | crates/rpc/rpc-engine-api/src/engine_api.rs:1322-1330 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (8 lines × 3) crates/storage/provider/src/either_writer.rs:467— crates/storage/provider/src/either_writer.rs:467-474 | crates/storage/provider/src/either_writer.rs:499-506 | crates/storage/provider/src/either_writer.rs:598-605 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (5 lines × 3) crates/net/network/src/metrics.rs:388— crates/net/network/src/metrics.rs:388-392 | crates/net/network/src/metrics.rs:457-461 | crates/net/network/src/metrics.rs:526-530 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (22 lines × 7) crates/node/builder/src/rpc.rs:651— crates/node/builder/src/rpc.rs:651-672 | crates/node/builder/src/rpc.rs:678-699 | crates/node/builder/src/rpc.rs:742-763 | crates/node/builder/src/rpc.rs:772-793 | crates/rpc/rpc-convert/src/transaction.rs:680-701 | crates/rpc/rpc-convert/src/transaction.rs:761-782 | crates/rpc/rpc-convert/src/transaction.rs:788-809 — there are 7 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 7 sites; resolving a subset leaves the remainder to drift apart.
Duplicated block (13 lines × 3) crates/cli/commands/src/stage/dump/hashing_account.rs:90— crates/cli/commands/src/stage/dump/hashing_account.rs:90-102 | crates/cli/commands/src/stage/dump/hashing_storage.rs:85-97 | crates/cli/commands/src/stage/dump/merkle.rs:173-185 — before extracting anything, compare `crates/cli/commands/src/stage/dump/hashing_account.rs` and `crates/cli/commands/src/stage/dump/hashing_storage.rs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 58 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (14 lines × 3) crates/storage/provider/src/test_utils/blocks.rs:329— crates/storage/provider/src/test_utils/blocks.rs:329-342 | crates/storage/provider/src/test_utils/blocks.rs:412-425 | crates/storage/provider/src/test_utils/blocks.rs:492-505 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (13 lines × 4) crates/storage/provider/src/test_utils/blocks.rs:263— crates/storage/provider/src/test_utils/blocks.rs:263-275 | crates/storage/provider/src/test_utils/blocks.rs:326-338 | crates/storage/provider/src/test_utils/blocks.rs:409-421 | crates/storage/provider/src/test_utils/blocks.rs:489-501 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (10–11 lines × 4) crates/storage/provider/src/test_utils/blocks.rs:281— crates/storage/provider/src/test_utils/blocks.rs:281-291 | crates/storage/provider/src/test_utils/blocks.rs:340-349 | crates/storage/provider/src/test_utils/blocks.rs:423-432 | crates/storage/provider/src/test_utils/blocks.rs:503-512 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (9 lines × 5) crates/storage/provider/src/test_utils/blocks.rs:209— crates/storage/provider/src/test_utils/blocks.rs:209-217 | crates/storage/provider/src/test_utils/blocks.rs:263-271 | crates/storage/provider/src/test_utils/blocks.rs:326-334 | crates/storage/provider/src/test_utils/blocks.rs:409-417 | crates/storage/provider/src/test_utils/blocks.rs:489-497 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
No DR/backup evidence — A persistence guard (data volume / purge-protection) was found, but no backup, geo-recovery or RTO/RPO controls were evidenced — a volume that survives a container recreate is not a tested restore from catastrophic loss.
Interpolated log message defeats structured logging crates/trie/trie/src/proof_v2/calculator.rs:1285— `error!` at line 1285 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/maintain.rs:367— `debug!` at line 367 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/maintain.rs:843— `error!` at line 843 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/pool/best.rs:219— `debug!` at line 219 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/pool/listener.rs:293— `debug!` at line 293 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/pool/listener.rs:335— `debug!` at line 335 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/pool/mod.rs:758— `debug!` at line 758 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/pool/mod.rs:861— `debug!` at line 861 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/pool/mod.rs:1353— `debug!` at line 1353 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/pool/mod.rs:1355— `warn!` at line 1355 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/pool/txpool.rs:1306— `trace!` at line 1306 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `trace!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/pool/txpool.rs:1318— `trace!` at line 1318 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `trace!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/transaction-pool/src/blobstore/disk.rs:690— `trace!` at line 690 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `trace!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/tokio-util/src/event_stream.rs:38— `warn!` at line 38 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/tasks/src/runtime.rs:691— `error!` at line 691 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/tasks/src/runtime.rs:760— `error!` at line 760 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/tasks/src/runtime.rs:829— `error!` at line 829 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `error!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/tasks/src/runtime.rs:1073— `debug!` at line 1073 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/storage/provider/src/providers/static_file/writer.rs:466— `debug!` at line 466 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/storage/provider/src/providers/static_file/writer.rs:481— `debug!` at line 481 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `debug!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/storage/db-common/src/db_tool/mod.rs:141— `info!` at line 141 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/storage/db-common/src/db_tool/mod.rs:145— `info!` at line 145 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/storage/db-common/src/db_tool/mod.rs:151— `info!` at line 151 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `info!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/storage/db/src/lockfile.rs:79— `warn!` at line 79 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Interpolated log message defeats structured logging crates/storage/db/src/implementation/mdbx/mod.rs:505— `warn!` at line 505 is handed a format string with `{…}` values in it, so tracing records one finished `message` field — the values in it cannot be queried, filtered or aggregated as fields, and every occurrence reads as a different message. Record the values as fields beside a constant message instead: `warn!(order_id = %order_id, status = ?status, "order status updated")` (`%` records a value by its `Display`, `?` by its `Debug`, a bare name as itself), which a JSON subscriber, OpenTelemetry or a log store keeps as queryable keys. An error goes in as a field too: `error = %err`.
Orphaned file crates/rpc/rpc-e2e-tests/src/rpc_compat.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/prune/prune/src/limiter.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/e2e-test-utils/src/testsuite/actions/node_ops.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/era-downloader/src/stream.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/e2e-test-utils/src/testsuite/actions/engine_api.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/node/ethstats/src/events.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/rpc/rpc-layer/src/auth_layer.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/rpc/rpc-api/src/anvil.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file testing/testing-utils/src/genesis_allocator.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/ethereum/hardforks/src/display.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/net/discv5/src/metrics.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/cli/util/src/parsers.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/rpc/ipc/src/server/rpc_service.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/rpc/ipc/src/client/mod.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/payload/validator/src/cancun.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/node/core/src/version.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/payload/util/src/transaction.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/tracing/src/log_handle.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/rpc/rpc-layer/src/jwt_validator.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/tokio-util/src/event_sender.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/rpc/rpc-builder/src/rate_limiter.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/rpc/rpc/src/eth/helpers/sync_listener.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/net/discv5/src/filter.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/net/discv5/src/enr.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file crates/rpc/rpc-api/src/hardhat.rs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Duplicated predicate .github/scripts/bench-call-summary.py:1064— `args.run_pairs is not None and args.run_pairs < 1` appears character-identically in 2 files — .github/scripts/bench-call-summary.py, .github/scripts/bench-reth-summary.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate .github/scripts/bench-reth-summary.py:146— `query.startswith("sum(") and query.endswith(")")` appears character-identically in 2 files — .github/scripts/bench-reth-summary.py, .github/scripts/bench-target-metric-sample-filter.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate crates/stages/stages/src/stages/hashing_account.rs:206— `!channels.is_empty() && channels.len().is_multiple_of(MAXIMUM_CHANNELS)` appears character-identically in 2 files — crates/stages/stages/src/stages/hashing_account.rs, crates/stages/stages/src/stages/hashing_storage.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate crates/stages/stages/src/stages/hashing_account.rs:258— `block_number != last_block && total_entries >= self.commit_entries` appears character-identically in 2 files — crates/stages/stages/src/stages/hashing_account.rs, crates/stages/stages/src/stages/hashing_storage.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate crates/trie/trie/src/hashed_cursor/post_state.rs:638— `control_first.is_none() && test_first.is_none()` appears character-identically in 2 files — crates/trie/trie/src/hashed_cursor/post_state.rs, crates/trie/trie/src/trie_cursor/in_memory.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate crates/trie/trie/src/hashed_cursor/post_state.rs:664— `control_result.is_none() && test_result.is_none()` appears character-identically in 2 files — crates/trie/trie/src/hashed_cursor/post_state.rs, crates/trie/trie/src/trie_cursor/in_memory.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate crates/stages/stages/src/stages/hashing_account.rs:219— `index > 0 && index.is_multiple_of(interval)` appears character-identically in 3 files — crates/stages/stages/src/stages/hashing_account.rs, crates/stages/stages/src/stages/hashing_storage.rs, crates/stages/stages/src/stages/tx_lookup.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate crates/cli/commands/src/db/get.rs:462— `k.address == address && k.sharded_key.key == storage_key` appears character-identically in 2 files — crates/cli/commands/src/db/get.rs, crates/storage/provider/src/providers/rocksdb/provider.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate crates/transaction-pool/src/blobstore/disk.rs:172— `missing_count == 0 && result.iter().all(Option::is_some)` appears character-identically in 2 files — crates/transaction-pool/src/blobstore/disk.rs, crates/transaction-pool/src/blobstore/mem.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate crates/net/downloaders/src/snap/mod.rs:272— `response.accounts.is_empty() && response.proof.is_empty()` appears character-identically in 2 files — crates/net/downloaders/src/snap/mod.rs, crates/net/network/src/fetch/mod.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate crates/stages/stages/src/stages/hashing_account.rs:176— `total_range > self.clean_threshold || from_block == 1` appears character-identically in 2 files — crates/stages/stages/src/stages/hashing_account.rs, crates/stages/stages/src/stages/hashing_storage.rs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 8 significant file(s) lose their only recent owner: crates/net/eth-wire/src/eth_snap.rs, crates/era-utils/src/export/mod.rs, crates/net/downloaders/src/snap/bytecode.rs, crates/snap-sync/src/session.rs, crates/era/src/era/file.rs, crates/net/downloaders/src/snap/request.rs, crates/cli/commands/src/export_era.rs, crates/net/downloaders/src/snap/test_utils.rs. Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 5 significant file(s) lose their only recent owner: crates/rpc/rpc/src/validation/blob_cache.rs, crates/e2e-test-utils/src/wait.rs, crates/rpc/rpc-api/src/trace.rs, crates/storage/db/src/static_file/cursor.rs, crates/e2e-test-utils/src/trie.rs. Pair on, review, or document these before any departure.
C2 · Access Controls· No named authorization policies · ×1
No named authorization policies — Authorization IS enforced here (by route guards, auth middleware or checks that refuse a caller) — this is NOT a claim that endpoints are unprotected. What's missing is a NAMED rule set: who may do what is encoded inline where it is checked, so the rules can't be listed, reviewed or tested apart from the code that applies them. Recommendation, not a defect.
D16 · Bus Factor· Further sole-owners (lower concentration) · ×1
Further sole-owners (lower concentration) — 3 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (18 single-owned of 825 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 825 of the 1128 production source files in this repository met that bar). They are anonymized user #3 (2 file(s)), anonymized user #4 (2 file(s)), anonymized user #5 (1 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: crates/trie/trie/src/proof_v2/node.rs, crates/storage/provider/src/providers/database/save_blocks.rs, crates/net/network-api/src/custody.rs, crates/payload/validator/src/amsterdam.rs, crates/era-downloader/src/stream.rs.
No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion — 1 of 115 project(s) overshoot their size bounds, lowering Project Cohesion to 9.8/10. The most over is `crates/transaction-pool` (24575 LoC, 129 module-visible types across 5 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D34 · Knowledge Freshness· Orphaned files with no living knowledge · ×1
Orphaned files with no living knowledge — 33 of 825 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 825 of the 1128 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — most significant first: crates/rpc/rpc-e2e-tests/src/rpc_compat.rs, crates/prune/prune/src/limiter.rs, crates/e2e-test-utils/src/testsuite/actions/node_ops.rs, crates/era-downloader/src/stream.rs, crates/e2e-test-utils/src/testsuite/actions/engine_api.rs, crates/node/ethstats/src/events.rs, crates/rpc/rpc-layer/src/auth_layer.rs, crates/rpc/rpc-api/src/anvil.rs (and 25 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
Logging is not universal — Only 72/75 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `.`, `.`, `contrib/trie-dst/crates/reth-trie-dst`.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
No app-layer HTTPS enforcement detected — This repository starts an HTTP server and nothing in its Rust source or committed `Rocket.toml` secures the transport: no TLS served (actix-web `bind_rustls`/`bind_openssl`, axum-server `bind_rustls` with a `RustlsConfig`, tonic `ServerTlsConfig`, a `TlsAcceptor`, Rocket's `[default.tls]`), no `Strict-Transport-Security` header, no `X-Forwarded-Proto` read from a TLS-terminating proxy — so its traffic may cross the network in clear text. (−2.0 on this card.) The server: `Server::builder()` (docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:69).
No security response headers detected — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is set on a response this repository's Rust server sends — defense in depth, even when a proxy could set them. (−2.0 on this card.) The server: `Server::builder()` (docs/vocs/docs/snippets/sources/exex/remote/src/exex.rs:69).
Silent fallback default on Err crates/storage/provider/src/providers/rocksdb/provider.rs:692— `wal_size_bytes` turns every `Err` into `0` — a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with `?`. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing.
Outdated: alloy-rlp — `alloy-rlp` is locked at 0.3.16 but 0.3.17 is the current stable release on crates.io, and it already satisfies the `"0.3.16"` requirement declared in crates/e2e-test-utils/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p alloy-rlp` and commit the updated REDACTED.
Outdated: alloy-trie — `alloy-trie` is locked at 0.9.8 but 0.9.9 is the current stable release on crates.io, and it already satisfies the `"0.9.8"` requirement declared in crates/chainspec/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p alloy-trie` and commit the updated REDACTED.
Outdated: arbitrary — `arbitrary` is locked at 1.4.2 but 1.5.0 is the current stable release on crates.io, and it already satisfies the `"1.3"` requirement declared in crates/cli/commands/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p arbitrary` and commit the updated REDACTED.
Outdated: async-compression — `async-compression` is locked at 0.4.48 but 0.4.51 is the current stable release on crates.io, and it already satisfies the `"0.4"` requirement declared in crates/net/downloaders/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p async-compression` and commit the updated REDACTED.
Outdated: auto_impl — `auto_impl` is locked at 1.3.0 but 1.4.0 is the current stable release on crates.io, and it already satisfies the `"1"` requirement declared in crates/chainspec/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p auto_impl` and commit the updated REDACTED.
Outdated: cc — `cc` is locked at 1.5.1 but 1.10.0 is the current stable release on crates.io, and it already satisfies the `"1.2.62"` requirement declared in crates/storage/libmdbx-rs/mdbx-sys/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p cc` and commit the updated REDACTED.
Outdated: either — `either` is locked at 1.18.0 but 1.19.0 is the current stable release on crates.io, and it already satisfies the `"1.16.0"` requirement declared in crates/payload/primitives/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p either` and commit the updated REDACTED.
Outdated: fixed-cache — `fixed-cache` is locked at 0.1.10 but 0.1.11 is the current stable release on crates.io, and it already satisfies the `"0.1.10"` requirement declared in crates/engine/execution-cache/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p fixed-cache` and commit the updated REDACTED.
Outdated: fixed-map — `fixed-map` is locked at 0.9.5 but 0.9.6 is the current stable release on crates.io, and it already satisfies the `"0.9"` requirement declared in crates/static-file/types/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p fixed-map` and commit the updated REDACTED.
Outdated: interprocess — `interprocess` is locked at 2.4.4 but 2.4.7 is the current stable release on crates.io, and it already satisfies the `"2.4.2"` requirement declared in crates/rpc/ipc/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p interprocess` and commit the updated REDACTED.
Outdated: jsonrpsee — `jsonrpsee` is locked at 0.26.0 but 0.26.1 is the current stable release on crates.io, and it already satisfies the `"0.26.0"` requirement declared in bin/reth-bb/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p jsonrpsee` and commit the updated REDACTED.
Outdated: jsonrpsee-core — `jsonrpsee-core` is locked at 0.26.0 but 0.26.1 is the current stable release on crates.io, and it already satisfies the `"0.26.0"` requirement declared in crates/rpc/rpc-engine-api/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p jsonrpsee-core` and commit the updated REDACTED.
Outdated: jsonrpsee-http-client — `jsonrpsee-http-client` is locked at 0.26.0 but 0.26.1 is the current stable release on crates.io, and it already satisfies the `"0.26.0"` requirement declared in crates/rpc/rpc-layer/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p jsonrpsee-http-client` and commit the updated REDACTED.
Outdated: jsonrpsee-server — `jsonrpsee-server` is locked at 0.26.0 but 0.26.1 is the current stable release on crates.io, and it already satisfies the `"0.26.0"` requirement declared in crates/node/metrics/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p jsonrpsee-server` and commit the updated REDACTED.
Outdated: jsonrpsee-types — `jsonrpsee-types` is locked at 0.26.0 but 0.26.1 is the current stable release on crates.io, and it already satisfies the `"0.26.0"` requirement declared in crates/rpc/rpc-convert/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p jsonrpsee-types` and commit the updated REDACTED.
Outdated: libc — `libc` is locked at 0.2.189 but 0.2.191 is the current stable release on crates.io, and it already satisfies the `"0.2"` requirement declared in crates/metrics/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p libc` and commit the updated REDACTED.
Outdated: memmap2 — `memmap2` is locked at 0.9.11 but 0.9.12 is the current stable release on crates.io, and it already satisfies the `"0.9.11"` requirement declared in crates/storage/nippy-jar/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p memmap2` and commit the updated REDACTED.
Outdated: notify — `notify` is locked at 8.2.0 but 8.2.1 is the current stable release on crates.io, and it already satisfies the `"8.0.0"` requirement declared in crates/storage/provider/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p notify` and commit the updated REDACTED.
Outdated: nybbles — `nybbles` is locked at 0.4.8 but 0.4.9 is the current stable release on crates.io, and it already satisfies the `"0.4.8"` requirement declared in crates/evm/execution-errors/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p nybbles` and commit the updated REDACTED.
Outdated: proptest — `proptest` is locked at 1.11.0 but 1.12.0 is the current stable release on crates.io, and it already satisfies the `"1.7"` requirement declared in crates/transaction-pool/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p proptest` and commit the updated REDACTED.
Outdated: serde_json — `serde_json` is locked at 1.0.151 but 1.0.154 is the current stable release on crates.io, and it already satisfies the `"1.0"` requirement declared in crates/chainspec/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p serde_json` and commit the updated REDACTED.
Outdated: smallvec — `smallvec` is locked at 1.16.2 but 1.16.4 is the current stable release on crates.io, and it already satisfies the `"1"` requirement declared in crates/transaction-pool/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p smallvec` and commit the updated REDACTED.
Outdated: tokio — `tokio` is locked at 1.53.3 but 1.54.1 is the current stable release on crates.io, and it already satisfies the `"1.52.3"` requirement declared in crates/chain-state/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p tokio` and commit the updated REDACTED.
Outdated: tokio-util — `tokio-util` is locked at 0.7.19 but 0.7.20 is the current stable release on crates.io, and it already satisfies the `"0.7.11"` requirement declared in crates/metrics/Cargo.toml — so the lockfile is behind this repository's own declared range. Run `cargo update -p tokio-util` and commit the updated REDACTED.
Off the main sequence: reth-ethereum-primitives — reth-ethereum-primitives: abstractness 0.00, instability 0.00, distance 1.00 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: reth-trie-common — reth-trie-common: abstractness 0.03, instability 0.00, distance 0.97 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: reth-payload-builder-primitives — reth-payload-builder-primitives: abstractness 0.00, instability 0.14, distance 0.86 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a17f95-c59e-771a-9028-51e95d0c3a2e · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 33 · Warnings: 1012 · Recommendations: 103 · Info: 27 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 27-10-2026 @ 22:58 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.